Page MenuHomePhabricator

[AMDGPU] Implemented MCELFNoteDisassembler for PAL metadata note
Needs ReviewPublic

Authored by tpr on Oct 3 2018, 1:32 AM.

Details

Summary

Change-Id: I3749ab42309fd056f8cf5d58633891607b626820

Diff Detail

Event Timeline

tpr created this revision.Oct 3 2018, 1:32 AM
tpr added a reviewer: scott.linder.

Requires D52823. Currently no in-tree user of this code.

tpr added a reviewer: kzhuravl.Oct 3 2018, 1:59 AM
tpr added a subscriber: timcorringham.
arsenm added inline comments.Oct 3 2018, 2:08 AM
lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
986–988

We can't just not work on big endian hosts. Can't you just use the utilities in Endian.h to support this?

989–990

I'd prefer to just do if (BYTE_ORDER == LITTLE_ENDIAN) inside

lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h
184–185

No virtual