Page MenuHomePhabricator

[llvm-readobj][AMDGPU] Moved AMDGPU-specific note record dumping into target
Needs RevisionPublic

Authored by tpr on Oct 3 2018, 1:29 AM.

Details

Summary

Change-Id: Ic9133164a7c0746bfb6c79c4cb484eb132882c5b

Diff Detail

Event Timeline

tpr created this revision.Oct 3 2018, 1:29 AM
tpr added a reviewer: kzhuravl.Oct 3 2018, 1:58 AM
tpr added a subscriber: timcorringham.
abdulras requested changes to this revision.Nov 28 2018, 1:47 PM

I don't mind the separation, but, I don't see what makes this target specific still. I really think that we should have this be out-side of the target specific content, but having this in LLVM instead of the readobj tool makes sense. At the very least, I think that we need to fix the big endian case.

lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
951

You should be able to use ulittle_* to decode this even on a big endian host. I don't see why the content being in little endian should prevent the host tools from running on big endian.

This revision now requires changes to proceed.Nov 28 2018, 1:47 PM