This is an archive of the discontinued LLVM Phabricator instance.

Differential D52686

[clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto
ClosedPublic

Authored by JonasToth on Sep 29 2018, 6:33 AM.

Details

Reviewers
alexfh
aaron.ballman
hokein
Commits
rG240b8f39fea9: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto
rCTE343565: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto
rL343565: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto

Diff Detail

Repository
rL LLVM

Event Timeline

JonasToth created this revision.Sep 29 2018, 6:33 AM
Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. · View Herald TranscriptSep 29 2018, 6:33 AM
Harbormaster completed remote builds in B23273: Diff 167598.Sep 29 2018, 6:33 AM
JonasToth retitled this revision from [clang-tidy] use CHECK-NOTES in test for cppgoreguidelines-avoid-goto to [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto.Sep 29 2018, 6:33 AM
alexfh accepted this revision.Oct 1 2018, 5:06 AM

LG

This revision is now accepted and ready to land.Oct 1 2018, 5:06 AM
Closed by commit rL343565: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto (authored by JonasToth). · Explain WhyOct 2 2018, 2:41 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 2 2018, 2:41 AM

Revision Contents

PathSize
clang-tools-extra/
trunk/
test/
clang-tidy/
16 lines

Diff 167899

clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-avoid-goto.cpp

// RUN: %check_clang_tidy %s cppcoreguidelines-avoid-goto %t // RUN: %check_clang_tidy %s cppcoreguidelines-avoid-goto %t
void noop() {} void noop() {}
int main() { int main() {
noop(); noop();
goto jump_to_me; goto jump_to_me;
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: avoid using 'goto' for flow control // CHECK-NOTES: [[@LINE-1]]:3: warning: avoid using 'goto' for flow control
// CHECK-MESSAGES: [[@LINE+3]]:1: note: label defined here // CHECK-NOTES: [[@LINE+3]]:1: note: label defined here
noop(); noop();
jump_to_me:; jump_to_me:;
jump_backwards:; jump_backwards:;
noop(); noop();
goto jump_backwards; goto jump_backwards;
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: avoid using 'goto' for flow control // CHECK-NOTES: [[@LINE-1]]:3: warning: avoid using 'goto' for flow control
// CHECK-MESSAGES: [[@LINE-4]]:1: note: label defined here // CHECK-NOTES: [[@LINE-4]]:1: note: label defined here
goto jump_in_line; goto jump_in_line;
; ;
jump_in_line:; jump_in_line:;
// CHECK-MESSAGES: [[@LINE-3]]:3: warning: avoid using 'goto' for flow control // CHECK-NOTES: [[@LINE-3]]:3: warning: avoid using 'goto' for flow control
// CHECK-MESSAGES: [[@LINE-2]]:1: note: label defined here // CHECK-NOTES: [[@LINE-2]]:1: note: label defined here
// Test the GNU extension https://gcc.gnu.org/onlinedocs/gcc/Labels-as-Values.html // Test the GNU extension https://gcc.gnu.org/onlinedocs/gcc/Labels-as-Values.html
some_label:; some_label:;
void *dynamic_label = &&some_label; void *dynamic_label = &&some_label;
// FIXME: `IndirectGotoStmt` is not detected. // FIXME: `IndirectGotoStmt` is not detected.
goto *dynamic_label; goto *dynamic_label;
} }
▲ Show 20 Lines • Show All 94 Lines • ▼ Show 20 Lines
before_the_loop: before_the_loop:
noop(); noop();
for (int i = 0; i < 10; ++i) { for (int i = 0; i < 10; ++i) {
for (int j = 0; j < 10; ++j) { for (int j = 0; j < 10; ++j) {
if (i * j > 80) if (i * j > 80)
goto before_the_loop; goto before_the_loop;
// CHECK-MESSAGES: [[@LINE-1]]:9: warning: avoid using 'goto' for flow control // CHECK-NOTES: [[@LINE-1]]:9: warning: avoid using 'goto' for flow control
// CHECK-MESSAGES: [[@LINE-8]]:1: note: label defined here // CHECK-NOTES: [[@LINE-8]]:1: note: label defined here
} }
} }
} }