This is an archive of the discontinued LLVM Phabricator instance.

[ARM/AArch64][v8.5A] Add Armv8.5-A target
ClosedPublic

Authored by olista01 on Sep 25 2018, 7:16 AM.

Details

Summary

This patch allows targeting Armv8.5-A, adding the architecture to
tablegen and setting the options to be identical to Armv8.4-A for the
time being. Subsequent patches will add support for the different
features included in the Armv8.5-A Reference Manual.

Patch by Pablo Barrio!

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Sep 25 2018, 7:16 AM
dmgreen added inline comments.
lib/Target/ARM/ARM.td
456 ↗(On Diff #166886)

Is this intentionally diffferent to the 8.4 and aarch64 8.5 strings?

unittests/Support/TargetParserTest.cpp
29 ↗(On Diff #166886)

Should this not all include 8.4?

29 ↗(On Diff #166886)

Oh, that's a different patch. Ignore me.

olista01 updated this revision to Diff 167088.Sep 26 2018, 2:42 AM

Make description of feature consistent with others.

dmgreen accepted this revision.Sep 26 2018, 4:31 AM

LGTM

This revision is now accepted and ready to land.Sep 26 2018, 4:31 AM
This revision was automatically updated to reflect the committed changes.