Page MenuHomePhabricator

Add !thread.private metadata
Changes PlannedPublic

Authored by reames on Sep 17 2018, 2:30 PM.

Details

Reviewers
hfinkel
jfb
bollu
Summary

As recently proposed and discussed on LLVM dev: https://groups.google.com/forum/#!topic/llvm-dev/oYcAtJnwALY

Feedback on naming and specification is particularly welcome.

Note: The LangRef change may not build. I'll fix any warnings before submission. I generally don't build docs because it increases build time noticeable and enabling it requires a clean build, so I'll do that once at the end.

Diff Detail

Event Timeline

reames created this revision.Sep 17 2018, 2:30 PM
reames retitled this revision from Add !thread.private metdata to Add !thread.private metadata .Sep 17 2018, 2:30 PM

Just noting a couple of known gaps (to save reviewers time):

  • No verifier support (will add before submission)
  • Need to add references from each support instruction type in the docs (done to avoid rebase headache)

Follow on things which need to happen later:

  • Once we settle on naming, extra and rename existing logic in LICM and DSE into a utility file in Analysis.
  • Add a way to test that analysis in isolation. (print-thread-private or something)
docs/LangRef.rst
5430

FIXME: Change to thread.private.

aqjune added a subscriber: aqjune.Sep 26 2018, 5:47 AM
reames planned changes to this revision.Jan 25 2019, 10:08 AM
rkruppe removed a subscriber: rkruppe.Feb 4 2021, 9:01 AM