Page MenuHomePhabricator

[clangd] Implement FuzzyFindRequest JSON (de)serialization
ClosedPublic

Authored by kbobyrev on Sep 10 2018, 3:23 AM.

Details

Diff Detail

Event Timeline

kbobyrev created this revision.Sep 10 2018, 3:23 AM
sammccall accepted this revision.Sep 10 2018, 3:29 AM
sammccall added inline comments.
clang-tools-extra/clangd/CodeComplete.cpp
1384

{0:2} for prettyprinting

clang-tools-extra/clangd/index/Index.cpp
199

Can we explain this in simpler semantic terms?
e.g. // A huge limit means no limit, leave it out.

clang-tools-extra/clangd/index/Index.h
258

please fix your editor to only format changed lines

This revision is now accepted and ready to land.Sep 10 2018, 3:29 AM
kbobyrev updated this revision to Diff 164648.Sep 10 2018, 3:40 AM
kbobyrev marked 3 inline comments as done.

Revert unrelated formatting changes, simplify the comment.

This revision was automatically updated to reflect the committed changes.

Hi Kirill,

This commit broke ARMV8 buildbots, logs are available here:
http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6493/steps/build%20stage%201/logs/stdio

Thanks
Yvan

Hi! Apologies for inconvenience, https://reviews.llvm.org/rL341832 should solve the issue.