Page MenuHomePhabricator

yroux (Yvan Roux)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2014, 12:27 AM (382 w, 6 d)

Recent Activity

Wed, Jun 9

yroux committed rG6c78dbd4ca1f: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode. (authored by yroux).
[ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 9, 6:38 AM
yroux closed D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 9, 6:37 AM · Restricted Project
yroux added a comment to D103119: [scudo] Get rid of initLinkerInitialized.

This change introduced a regression on ARMv7 Thumb bots which wasn't noticed due to other issues.

Wed, Jun 9, 12:22 AM · Restricted Project

Mon, Jun 7

yroux added a comment to D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.

LGTM, just if you intend to reuse the summary as a commit message "... since MVE instructions are *not* outlined...".

Mon, Jun 7, 6:43 AM · Restricted Project
yroux added a comment to D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.

@efriedma, @chill is this patch ok for you ? (it'd be great to have the issue fixed into 12.0.1 release)

Mon, Jun 7, 6:03 AM · Restricted Project

Wed, Jun 2

yroux updated the diff for D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 2, 6:50 AM · Restricted Project
yroux added inline comments to D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 2, 6:47 AM · Restricted Project
yroux added inline comments to D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 2, 6:21 AM · Restricted Project

Wed, May 26

yroux requested review of D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, May 26, 7:20 AM · Restricted Project

Apr 26 2021

yroux added a comment to rG149d5a8c4793: [lsan] Temporarily disable new check broken on arm7.

Hi Vitaly,

Apr 26 2021, 1:07 AM

Apr 23 2021

yroux added a comment to D100704: [Thumb1][MachineOutliner] Add Machine Outliner support for Thumb1.

Hi and Thanks for working on this,

Apr 23 2021, 8:15 AM · Restricted Project

Apr 7 2021

yroux added a comment to D100036: [SystemZ][z/OS][TableGen] TableGen files should be text.

LGTM as well

Apr 7 2021, 8:16 AM · Restricted Project

Apr 6 2021

yroux added a comment to D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text.

I've committed this and it looks like the bot is back to green :) https://lab.llvm.org/buildbot/#/builders/65/builds/1400. Sorry for the delayed fix

Apr 6 2021, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
yroux added a comment to D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text.

Sorry I'm bit lost in the various patches proposed to fix the issue introduced by https://reviews.llvm.org/D97785
My understanding is that this is missing one to fix our Windows on ARM bots (broken for more than 2 weeks now)
So it'd be great to have it applied

Apr 6 2021, 2:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 25 2021

yroux updated subscribers of D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.

Hi Abhina,

Mar 25 2021, 9:51 AM · Restricted Project, Restricted Project

Mar 24 2021

yroux committed rG608ee3593c7a: [AArch64][ASAN] Re-enable fgets_fputs.cpp test. (authored by yroux).
[AArch64][ASAN] Re-enable fgets_fputs.cpp test.
Mar 24 2021, 2:09 AM

Mar 23 2021

yroux committed rG241032a20527: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling. (authored by yroux).
[llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling.
Mar 23 2021, 6:18 AM
yroux closed D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..
Mar 23 2021, 6:17 AM · Restricted Project
yroux updated the diff for D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..
Mar 23 2021, 2:34 AM · Restricted Project
yroux added inline comments to D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..
Mar 23 2021, 2:33 AM · Restricted Project

Mar 22 2021

yroux updated the diff for D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..
Mar 22 2021, 3:25 AM · Restricted Project

Mar 19 2021

yroux added a comment to D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..

Hmm, there is tools/llvm-nm/debug-syms.test which tests ARM --special-syms and --debug-syms, notice that with this change --special-syms is no more needed to dump mapping-symbols when --debug-syms is used, which is now in sync with gnu binutils nm. I don't see an AArch64 test though

Mar 19 2021, 2:53 AM · Restricted Project

Mar 18 2021

yroux updated the diff for D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..

This new version should just change llvm-nm behavior for ELF ARM and AArch64 targets to handle SF_FormatSpecific symbols and doesn't change the processing of COFF or debug symbols

Mar 18 2021, 8:44 AM · Restricted Project
yroux added a comment to D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..

Sure, because in dumpSymbolNamesFromObject line1815 these symbols are skipped if they are not debug ones, thus not printed even if --special-syms flag is used.

Mar 18 2021, 2:33 AM · Restricted Project
yroux planned changes to D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..

Thanks for the reviews,

Mar 18 2021, 2:18 AM · Restricted Project

Mar 17 2021

yroux updated the summary of D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..
Mar 17 2021, 12:04 PM · Restricted Project
yroux updated the summary of D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..
Mar 17 2021, 12:04 PM · Restricted Project
yroux requested review of D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling..
Mar 17 2021, 12:01 PM · Restricted Project

Mar 15 2021

yroux committed rGc0f224e63019: [AArch64][ASAN] Disable fgets_fputs.cpp test. (authored by yroux).
[AArch64][ASAN] Disable fgets_fputs.cpp test.
Mar 15 2021, 11:06 PM

Mar 10 2021

yroux added a comment to D71992: [ARM] Unrestrict Armv8 IT blocks.

I'm on a D05 box (Cortex-A72) and I should have a remote access to WoA surface laptop... I'll check

Mar 10 2021, 6:54 AM · Restricted Project
yroux added a comment to D71992: [ARM] Unrestrict Armv8 IT blocks.

Hi Sam,

Mar 10 2021, 3:57 AM · Restricted Project

Mar 9 2021

yroux added a comment to D94604: [CodeGen] Allow parallel uses of a resource.

I'm not experienced enough in the machine scheduler to approve it, but the description of the problem and the proposed solution make sense to me.

Mar 9 2021, 1:39 AM · Restricted Project

Mar 3 2021

yroux committed rZORGde437ff479d1: Don't run testsuite on Linaro quick bots. (authored by yroux).
Don't run testsuite on Linaro quick bots.
Mar 3 2021, 4:40 AM
yroux closed D96146: Don't run testsuite on Linaro quick bots..
Mar 3 2021, 4:40 AM

Mar 2 2021

yroux accepted D97686: [test-suite] Fix Unit Tests for Code Coverage.

It makes sense, thanks.

Mar 2 2021, 11:55 PM

Mar 1 2021

yroux added a comment to D97686: [test-suite] Fix Unit Tests for Code Coverage.

Hi Sam,

Mar 1 2021, 11:05 PM
yroux added a comment to D88931: [test-suite] Unit tests to improve code coverage.

@lenary it'd be great if you can commit your fix today, the bots are red for long time

Mar 1 2021, 12:31 AM

Feb 23 2021

yroux added a comment to D88931: [test-suite] Unit tests to improve code coverage.

this commit broke ARM bots, because their data model is ILP32, thus it is not safe to use a long format specifier to print a 64 bits type.

Feb 23 2021, 9:17 AM

Feb 22 2021

yroux updated subscribers of D96757: [InstrProfiling] Use ELF section groups for counters, data and values.

Hi Petr,

Feb 22 2021, 2:45 AM · Restricted Project, Restricted Project

Feb 5 2021

yroux requested review of D96146: Don't run testsuite on Linaro quick bots..
Feb 5 2021, 8:17 AM
yroux committed rG38f28f4621ed: [Test] Fix test case demonstrating oddities in behavior of LSR. (authored by yroux).
[Test] Fix test case demonstrating oddities in behavior of LSR.
Feb 5 2021, 7:03 AM

Jan 19 2021

yroux abandoned D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

All patches are now committed.

Jan 19 2021, 2:02 AM · Restricted Project, Restricted Project
yroux committed rG244ad228f343: [ARM][MachineOutliner] Add stack fixup feature (authored by yroux).
[ARM][MachineOutliner] Add stack fixup feature
Jan 19 2021, 1:59 AM
yroux closed D92934: [ARM][MachineOutliner] Add stack fixup feature..
Jan 19 2021, 1:59 AM · Restricted Project

Jan 18 2021

yroux added a comment to D92934: [ARM][MachineOutliner] Add stack fixup feature..

Hi Sam,

Jan 18 2021, 5:30 AM · Restricted Project

Jan 14 2021

yroux accepted D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided.

LGTM

Jan 14 2021, 11:41 PM · Restricted Project
yroux added a comment to D92934: [ARM][MachineOutliner] Add stack fixup feature..

ping

Jan 14 2021, 1:41 AM · Restricted Project

Jan 13 2021

yroux accepted D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.

Approved now that I've properly tested it.

Jan 13 2021, 6:57 AM · Restricted Project

Jan 11 2021

yroux added a comment to D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.

One small comment otherwise LGTM

Jan 11 2021, 8:12 AM · Restricted Project

Jan 6 2021

yroux committed rG0c41b1c9f93c: [Driver][MachineOutliner] Support outlining option with LTO (authored by yroux).
[Driver][MachineOutliner] Support outlining option with LTO
Jan 6 2021, 7:04 AM
yroux closed D93385: [Driver][MachineOutliner] Support outlining option with LTO.
Jan 6 2021, 7:04 AM · Restricted Project

Jan 4 2021

yroux added a comment to D92934: [ARM][MachineOutliner] Add stack fixup feature..

ping

Jan 4 2021, 11:33 PM · Restricted Project
yroux added a comment to D93385: [Driver][MachineOutliner] Support outlining option with LTO.

ping

Jan 4 2021, 11:33 PM · Restricted Project

Dec 17 2020

yroux committed rG923ca0b411f7: [ARM][MachineOutliner] Fix costs model. (authored by yroux).
[ARM][MachineOutliner] Fix costs model.
Dec 17 2020, 7:12 AM
yroux closed D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 7:12 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 5:27 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 5:16 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 4:16 AM · Restricted Project
yroux added a comment to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Hi Andrew, the new version LGTM

Dec 17 2020, 1:03 AM · Restricted Project

Dec 16 2020

yroux requested review of D93385: [Driver][MachineOutliner] Support outlining option with LTO.
Dec 16 2020, 2:26 AM · Restricted Project

Dec 14 2020

yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 14 2020, 1:08 AM · Restricted Project

Dec 10 2020

yroux retitled D92933: [ARM][MachineOutliner] Fix costs model. from [ARM][MachineOutliner] Handle stack usage. to [ARM][MachineOutliner] Fix costs model..
Dec 10 2020, 2:31 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 10 2020, 2:27 AM · Restricted Project

Dec 9 2020

yroux committed rG03a77d04b412: [LLD][ELF] Fix typo in relocation-model-pic.ll (authored by yroux).
[LLD][ELF] Fix typo in relocation-model-pic.ll
Dec 9 2020, 6:39 AM
yroux abandoned D90836: [ARM][MachineOutliner] Add stack fixup feature..

Hi Sam,

Dec 9 2020, 4:54 AM · Restricted Project
yroux requested review of D92934: [ARM][MachineOutliner] Add stack fixup feature..
Dec 9 2020, 4:46 AM · Restricted Project
yroux requested review of D92933: [ARM][MachineOutliner] Fix costs model..
Dec 9 2020, 4:42 AM · Restricted Project

Nov 27 2020

yroux added a comment to D90836: [ARM][MachineOutliner] Add stack fixup feature..

Ping

Nov 27 2020, 3:00 AM · Restricted Project

Nov 20 2020

yroux accepted D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

I think that the previous comments were addressed. LGTM

Nov 20 2020, 6:16 AM · Restricted Project

Nov 19 2020

yroux added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Nov 19 2020, 2:19 AM · Restricted Project

Nov 18 2020

yroux updated the diff for D90836: [ARM][MachineOutliner] Add stack fixup feature..
Nov 18 2020, 6:11 AM · Restricted Project

Nov 13 2020

yroux committed rGdee452da7a44: [UpdateTestChecks] Fix $ in function test for ARM. (authored by yroux).
[UpdateTestChecks] Fix $ in function test for ARM.
Nov 13 2020, 3:27 AM

Nov 9 2020

yroux accepted D89483: [ARM][MachineOutliner] Emit more CFI instructions.

Just a small comment, otherwise LGTM, thanks

Nov 9 2020, 1:01 AM · Restricted Project

Nov 6 2020

yroux added a comment to D82995: [UpdateTestChecks] Allow $ in function names.

Hi David,

Nov 6 2020, 1:33 AM · Restricted Project

Nov 5 2020

yroux requested review of D90836: [ARM][MachineOutliner] Add stack fixup feature..
Nov 5 2020, 3:24 AM · Restricted Project
yroux accepted D90627: [sanitizer] Assume getrandom might not be supported by the kernel.

LGTM

Nov 5 2020, 2:51 AM · Restricted Project

Nov 4 2020

yroux accepted D90628: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}.

LGTM, given it is needed to bring ARM bots back online

Nov 4 2020, 2:07 AM · Restricted Project
yroux added a comment to D90627: [sanitizer] Assume getrandom might not be supported by the kernel.

The change makes sense to me and will fix ARM broken bots, I'd say that it can be accepted if there is no objection within a day

Nov 4 2020, 2:06 AM · Restricted Project

Nov 3 2020

yroux accepted D89625: Add default value for MachineInstr::modifiesRegister. NFC..

LGTM

Nov 3 2020, 5:27 AM · Restricted Project

Nov 2 2020

yroux added a comment to D89625: Add default value for MachineInstr::modifiesRegister. NFC..

I'd check if there are some calls of modifiesRegister that pass nullptr, the patch LGTM otherwise

Nov 2 2020, 1:32 AM · Restricted Project
yroux accepted D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.

(Sorry for the delay, I took some vacations)

Nov 2 2020, 1:29 AM · Restricted Project

Oct 16 2020

yroux added inline comments to D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.
Oct 16 2020, 5:53 AM · Restricted Project

Oct 12 2020

yroux added a comment to D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.

Thanks for raising this issue, I've two inlined comments

Oct 12 2020, 6:05 AM · Restricted Project

Oct 1 2020

yroux updated subscribers of D68364: Implement C++20's P0784 (More constexpr containers).

Hi Louis,

Oct 1 2020, 4:38 AM · Restricted Project, Restricted Project

Sep 17 2020

yroux committed rGdeb8f8bcf315: [ARM][MachineOutliner] Add missing testcase for calls. (authored by yroux).
[ARM][MachineOutliner] Add missing testcase for calls.
Sep 17 2020, 6:21 AM

Sep 16 2020

yroux committed rG070b96962f51: [ARM][MachineOutliner] Add calls handling. (authored by yroux).
[ARM][MachineOutliner] Add calls handling.
Sep 16 2020, 1:00 AM
yroux closed D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 16 2020, 1:00 AM · Restricted Project

Sep 14 2020

yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 14 2020, 5:09 AM · Restricted Project
yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 14 2020, 4:15 AM · Restricted Project

Sep 10 2020

yroux updated the diff for D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 10 2020, 4:38 AM · Restricted Project

Sep 8 2020

yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 8 2020, 6:41 AM · Restricted Project
yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 8 2020, 6:35 AM · Restricted Project

Sep 4 2020

yroux requested review of D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 4 2020, 4:56 AM · Restricted Project

Sep 1 2020

yroux added a comment to D86869: [zorg] Add flang to clang-cmake-aarch64-full.

LGTM

Sep 1 2020, 7:15 AM
yroux abandoned D76068: [ARM][MachineOutliner] Add NoLRSave and Register modes..

Thsi was committed as D80125 and D80127

Sep 1 2020, 5:04 AM · Restricted Project
yroux abandoned D83313: [MachineOutliner] Fix liveness computing..

Issue fixed by D40061

Sep 1 2020, 5:01 AM · Restricted Project

Aug 26 2020

yroux accepted D82951: [ARM] Enable outliner at -Oz for M-class.

Hi Sam,

Aug 26 2020, 11:58 PM · Restricted Project
yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

My bad, I applied the previous version where a branch was inserted in those tests but your last version is fine.

Aug 26 2020, 6:51 AM · Restricted Project
yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

Hi Sam,

Aug 26 2020, 1:37 AM · Restricted Project

Aug 25 2020

yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

I think a few more testcases need to be updated:

Aug 25 2020, 8:34 AM · Restricted Project