Page MenuHomePhabricator

yroux (Yvan Roux)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2014, 12:27 AM (355 w, 1 d)

Recent Activity

Fri, Nov 27

yroux added a comment to D90836: [ARM][MachineOutliner] Add stack fixup feature..

Ping

Fri, Nov 27, 3:00 AM · Restricted Project

Fri, Nov 20

yroux accepted D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

I think that the previous comments were addressed. LGTM

Fri, Nov 20, 6:16 AM · Restricted Project

Thu, Nov 19

yroux added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Thu, Nov 19, 2:19 AM · Restricted Project

Wed, Nov 18

yroux updated the diff for D90836: [ARM][MachineOutliner] Add stack fixup feature..
Wed, Nov 18, 6:11 AM · Restricted Project

Fri, Nov 13

yroux committed rGdee452da7a44: [UpdateTestChecks] Fix $ in function test for ARM. (authored by yroux).
[UpdateTestChecks] Fix $ in function test for ARM.
Fri, Nov 13, 3:27 AM

Mon, Nov 9

yroux accepted D89483: [ARM][MachineOutliner] Emit more CFI instructions.

Just a small comment, otherwise LGTM, thanks

Mon, Nov 9, 1:01 AM · Restricted Project

Fri, Nov 6

yroux added a comment to D82995: [UpdateTestChecks] Allow $ in function names.

Hi David,

Fri, Nov 6, 1:33 AM · Restricted Project

Thu, Nov 5

yroux requested review of D90836: [ARM][MachineOutliner] Add stack fixup feature..
Thu, Nov 5, 3:24 AM · Restricted Project
yroux accepted D90627: [sanitizer] Assume getrandom might not be supported by the kernel.

LGTM

Thu, Nov 5, 2:51 AM · Restricted Project

Wed, Nov 4

yroux accepted D90628: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}.

LGTM, given it is needed to bring ARM bots back online

Wed, Nov 4, 2:07 AM · Restricted Project
yroux added a comment to D90627: [sanitizer] Assume getrandom might not be supported by the kernel.

The change makes sense to me and will fix ARM broken bots, I'd say that it can be accepted if there is no objection within a day

Wed, Nov 4, 2:06 AM · Restricted Project

Tue, Nov 3

yroux accepted D89625: Add default value for MachineInstr::modifiesRegister. NFC..

LGTM

Tue, Nov 3, 5:27 AM · Restricted Project

Nov 2 2020

yroux added a comment to D89625: Add default value for MachineInstr::modifiesRegister. NFC..

I'd check if there are some calls of modifiesRegister that pass nullptr, the patch LGTM otherwise

Nov 2 2020, 1:32 AM · Restricted Project
yroux accepted D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.

(Sorry for the delay, I took some vacations)

Nov 2 2020, 1:29 AM · Restricted Project

Oct 16 2020

yroux added inline comments to D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.
Oct 16 2020, 5:53 AM · Restricted Project

Oct 12 2020

yroux added a comment to D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.

Thanks for raising this issue, I've two inlined comments

Oct 12 2020, 6:05 AM · Restricted Project

Oct 1 2020

yroux updated subscribers of D68364: Implement C++20's P0784 (More constexpr containers).

Hi Louis,

Oct 1 2020, 4:38 AM · Restricted Project, Restricted Project

Sep 17 2020

yroux committed rGdeb8f8bcf315: [ARM][MachineOutliner] Add missing testcase for calls. (authored by yroux).
[ARM][MachineOutliner] Add missing testcase for calls.
Sep 17 2020, 6:21 AM

Sep 16 2020

yroux committed rG070b96962f51: [ARM][MachineOutliner] Add calls handling. (authored by yroux).
[ARM][MachineOutliner] Add calls handling.
Sep 16 2020, 1:00 AM
yroux closed D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 16 2020, 1:00 AM · Restricted Project

Sep 14 2020

yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 14 2020, 5:09 AM · Restricted Project
yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 14 2020, 4:15 AM · Restricted Project

Sep 10 2020

yroux updated the diff for D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 10 2020, 4:38 AM · Restricted Project

Sep 8 2020

yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 8 2020, 6:41 AM · Restricted Project
yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 8 2020, 6:35 AM · Restricted Project

Sep 4 2020

yroux requested review of D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 4 2020, 4:56 AM · Restricted Project

Sep 1 2020

yroux added a comment to D86869: [zorg] Add flang to clang-cmake-aarch64-full.

LGTM

Sep 1 2020, 7:15 AM
yroux abandoned D76068: [ARM][MachineOutliner] Add NoLRSave and Register modes..

Thsi was committed as D80125 and D80127

Sep 1 2020, 5:04 AM · Restricted Project
yroux abandoned D83313: [MachineOutliner] Fix liveness computing..

Issue fixed by D40061

Sep 1 2020, 5:01 AM · Restricted Project

Aug 26 2020

yroux accepted D82951: [ARM] Enable outliner at -Oz for M-class.

Hi Sam,

Aug 26 2020, 11:58 PM · Restricted Project
yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

My bad, I applied the previous version where a branch was inserted in those tests but your last version is fine.

Aug 26 2020, 6:51 AM · Restricted Project
yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

Hi Sam,

Aug 26 2020, 1:37 AM · Restricted Project

Aug 25 2020

yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

I think a few more testcases need to be updated:

Aug 25 2020, 8:34 AM · Restricted Project

Aug 20 2020

yroux committed rG0459f29e8b0f: [ARM][MachineOutliner] Add default mode. (authored by yroux).
[ARM][MachineOutliner] Add default mode.
Aug 20 2020, 12:31 AM
yroux closed D76069: [ARM][MachineOutliner] Add default mode..
Aug 20 2020, 12:31 AM · Restricted Project

Aug 19 2020

yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

I've tested the patch and it fixes the liveness issue seen with Machine Outliner enabled.

Aug 19 2020, 9:32 AM · Restricted Project

Jul 27 2020

yroux updated the diff for D76069: [ARM][MachineOutliner] Add default mode..

Removed uneeded LR addition to live-in set.

Jul 27 2020, 6:53 AM · Restricted Project

Jul 23 2020

yroux added inline comments to D76069: [ARM][MachineOutliner] Add default mode..
Jul 23 2020, 5:30 AM · Restricted Project

Jul 20 2020

yroux updated the diff for D76069: [ARM][MachineOutliner] Add default mode..

I've extracted parts which handle calls inside outlined frames (I'll submit that in the next patch) and enhanced the testcases.

Jul 20 2020, 7:42 AM · Restricted Project

Jul 9 2020

yroux added a comment to D83313: [MachineOutliner] Fix liveness computing..

I guess I just don't understand why the BX_RET wouldn't be marked with using the link register in the first place?

Jul 9 2020, 6:28 AM · Restricted Project
yroux added a comment to D83313: [MachineOutliner] Fix liveness computing..

I'm not really happy with this approach; if LiveRegUnits isn't producing correct results, we should fix it, not try to hack around it.

Maybe we should revive D40061...

Jul 9 2020, 6:14 AM · Restricted Project

Jul 7 2020

Herald added a project to D83313: [MachineOutliner] Fix liveness computing.: Restricted Project.
Jul 7 2020, 8:22 AM · Restricted Project

Jul 1 2020

yroux added a comment to D82951: [ARM] Enable outliner at -Oz for M-class.

Hi Sam,

Jul 1 2020, 7:00 AM · Restricted Project

Jun 15 2020

yroux committed rGffe8f6d33bcc: [ARM][MachineOutliner] Fix no-lr-save testcase. (authored by yroux).
[ARM][MachineOutliner] Fix no-lr-save testcase.
Jun 15 2020, 7:34 AM
yroux committed rG669066de650a: [ARM][MachineOutliner] Add LR RegSave mode. (authored by yroux).
[ARM][MachineOutliner] Add LR RegSave mode.
Jun 15 2020, 6:29 AM
yroux closed D80127: [ARM][MachineOutliner] Add LR RegSave mode..
Jun 15 2020, 6:29 AM · Restricted Project

Jun 11 2020

yroux added a comment to D80127: [ARM][MachineOutliner] Add LR RegSave mode..

No there is 3 more patches in the set, one for the default mode (save/restore of lr on the stack), one which will add the support of calls in the outlined regions and the most tricky one which will fixup the stack to handle load/store. In the end we should reach ~3% of size reduction in T32 and ~5% in ARM (this is what I observed on average for various benchs).

Jun 11 2020, 7:09 AM · Restricted Project
yroux committed rG6b8628a1f036: [ARM][MachineOutliner] Add NoLRSave mode. (authored by yroux).
[ARM][MachineOutliner] Add NoLRSave mode.
Jun 11 2020, 12:01 AM
yroux closed D80125: [ARM][MachineOutliner] Add NoLRSave mode..
Jun 11 2020, 12:01 AM · Restricted Project

Jun 9 2020

yroux updated the diff for D80125: [ARM][MachineOutliner] Add NoLRSave mode..

Updated testcase

Jun 9 2020, 2:42 AM · Restricted Project
yroux added inline comments to D80127: [ARM][MachineOutliner] Add LR RegSave mode..
Jun 9 2020, 2:42 AM · Restricted Project
yroux updated the diff for D80127: [ARM][MachineOutliner] Add LR RegSave mode..

Change register class to rGPR for both modes and updated testcase

Jun 9 2020, 2:42 AM · Restricted Project
yroux added inline comments to D80125: [ARM][MachineOutliner] Add NoLRSave mode..
Jun 9 2020, 2:42 AM · Restricted Project

Jun 4 2020

yroux committed rG6b9e10224363: [ARM][MachineOutliner] Remove unneeded dynamic allocation. (authored by yroux).
[ARM][MachineOutliner] Remove unneeded dynamic allocation.
Jun 4 2020, 4:18 AM

May 18 2020

yroux created D80127: [ARM][MachineOutliner] Add LR RegSave mode..
May 18 2020, 8:34 AM · Restricted Project
yroux added a comment to D80125: [ARM][MachineOutliner] Add NoLRSave mode..

This was splitted from D76068

May 18 2020, 8:34 AM · Restricted Project
yroux created D80125: [ARM][MachineOutliner] Add NoLRSave mode..
May 18 2020, 8:34 AM · Restricted Project

May 15 2020

yroux committed rG3648dde3ddd3: [ARM][MachineOutliner] Fix memory leak #2. (authored by yroux).
[ARM][MachineOutliner] Fix memory leak #2.
May 15 2020, 8:40 AM
yroux committed rG96c4460a0be6: [ARM][MachineOutliner] Fix memory leak. (authored by yroux).
[ARM][MachineOutliner] Fix memory leak.
May 15 2020, 7:35 AM
yroux committed rG0e4827aa4e4a: [ARM][MachineOutliner] Add Machine Outliner support for ARM. (authored by yroux).
[ARM][MachineOutliner] Add Machine Outliner support for ARM.
May 15 2020, 12:09 AM
yroux closed D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
May 15 2020, 12:08 AM · Restricted Project, Restricted Project

May 13 2020

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

I found a last issue when doing a full bootstrap with -moutline used to build clang, there was a case of thunk outlining where the original was call a BLX LR which was broken by the outlining call BL OUTLINE_FUNCTION_X I fixed this issue by checking the use of link register before handling calls and I've added a test case.

May 13 2020, 1:36 PM · Restricted Project, Restricted Project

May 6 2020

yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Ah, yes, good point. Then I have nothing else, but definitely worth waiting to see if Eli has further comments.

May 6 2020, 1:02 AM · Restricted Project, Restricted Project

May 5 2020

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
May 5 2020, 1:30 PM · Restricted Project, Restricted Project
yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Thanks for adding the MVE changes, but I also still don't see any DSP tests, i.e QADD, SADD16.

May 5 2020, 1:30 PM · Restricted Project, Restricted Project

Apr 30 2020

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

This update avoids outlining MVE instructions.

Apr 30 2020, 8:29 AM · Restricted Project, Restricted Project
yroux accepted D79161: Update parallelization settings on Linaro builders.

LGTM

Apr 30 2020, 3:01 AM
yroux added inline comments to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 30 2020, 2:44 AM · Restricted Project, Restricted Project

Apr 29 2020

yroux added inline comments to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 29 2020, 8:33 AM · Restricted Project, Restricted Project
yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 29 2020, 8:02 AM · Restricted Project, Restricted Project
yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Here is a new update of the patch.

Apr 29 2020, 8:00 AM · Restricted Project, Restricted Project

Apr 9 2020

yroux added inline comments to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 9 2020, 4:50 AM · Restricted Project, Restricted Project
yroux added a comment to D77648: [ARM][MVE] Tail predicate VML[A|S]LDAV.

Ok thanks, LGTM

Apr 9 2020, 4:50 AM · Restricted Project

Apr 8 2020

yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Hi Sam,

Apr 8 2020, 8:39 AM · Restricted Project, Restricted Project
yroux added inline comments to D77648: [ARM][MVE] Tail predicate VML[A|S]LDAV.
Apr 8 2020, 1:35 AM · Restricted Project

Apr 7 2020

yroux added a comment to D77590: [ARM] MVE saturating truncates.

I'm not that familiar with that part to approve it without the review from someone else, but it looks good to me.

Apr 7 2020, 9:44 AM · Restricted Project

Apr 6 2020

yroux added a comment to D76849: [ARM] unwinding .pad instructions missing in execute-only prologue.

I can't approve it, but it looks good to me.

Apr 6 2020, 3:45 AM · Restricted Project

Apr 3 2020

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Here is an update of the patch

Apr 3 2020, 9:08 AM · Restricted Project, Restricted Project

Mar 26 2020

yroux closed D53272: Add target requirement to profile remap test..

This was closed by commit r344593

Mar 26 2020, 1:35 AM

Mar 25 2020

yroux committed rGbd069ad39c9c: [ARM] Move ConstantIsland and LowOverheadLoops Passes. (authored by yroux).
[ARM] Move ConstantIsland and LowOverheadLoops Passes.
Mar 25 2020, 9:11 AM
yroux closed D76065: [ARM] Move ConstantIsland and LowOverheadLoops Passes..
Mar 25 2020, 9:10 AM · Restricted Project
yroux added a comment to D76069: [ARM][MachineOutliner] Add default mode..

Thanks for the review Jessica,

Mar 25 2020, 8:04 AM · Restricted Project
yroux added a comment to D76068: [ARM][MachineOutliner] Add NoLRSave and Register modes..

Thanks for the review Jessica and Sam,

Mar 25 2020, 7:32 AM · Restricted Project
yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Thanks for the review Sam,

Mar 25 2020, 7:32 AM · Restricted Project, Restricted Project

Mar 12 2020

yroux created D76069: [ARM][MachineOutliner] Add default mode..
Mar 12 2020, 8:08 AM · Restricted Project
yroux created D76068: [ARM][MachineOutliner] Add NoLRSave and Register modes..
Mar 12 2020, 8:08 AM · Restricted Project
yroux created D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Mar 12 2020, 8:08 AM · Restricted Project, Restricted Project
yroux created D76065: [ARM] Move ConstantIsland and LowOverheadLoops Passes..
Mar 12 2020, 8:08 AM · Restricted Project

Feb 17 2020

yroux added a comment to D72713: [ARM][LowOverheadLoops] Check loop liveouts.

Hi Sam,

Feb 17 2020, 7:40 AM · Restricted Project

Feb 13 2020

yroux added inline comments to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.
Feb 13 2020, 5:31 AM · Restricted Project, Restricted Project
yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Thanks for the comments Sam,

Feb 13 2020, 4:52 AM · Restricted Project, Restricted Project

Feb 12 2020

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Ping

Feb 12 2020, 3:28 AM · Restricted Project, Restricted Project

Jan 29 2020

yroux updated the diff for D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Here is a new version, which disables ARM Low Overhead Loops pass when the Machine Outliner is enabled.

Jan 29 2020, 9:21 AM · Restricted Project, Restricted Project

Jan 9 2020

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

! In D57054#1811740, @samparker wrote:
Hmm, would it be possible to pass a bool to the pass which will control whether liveness is updated? The other, suboptimal, option would be to not do outlining when we have the LOB extension.

Jan 9 2020, 6:37 AM · Restricted Project, Restricted Project
yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

This, and the fact that LowOverheadLoops is dependent upon block sizes and placement (I need to add a comment in the header on that pass....). So, ConstantIslands would have to guarantee not to change branch targets or change the distance between blocks around the low-overhead loop constructs. I think updating liveness information would be the easier option.

Jan 9 2020, 3:26 AM · Restricted Project, Restricted Project

Jan 8 2020

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Ah right, let's wait for Sam comments/advises and I'll prepare a proper patch for that.

Jan 8 2020, 10:53 PM · Restricted Project, Restricted Project
yroux updated the diff for D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

here is an update for the Machine Outliner support on ARM targets.
It addresses the comments received on the initial version and is rebased on current trunk.
Among the modifications needed by this rebase, this patch propose to move the ARM Low Overhead Loops pass before the Outliner and the Constant Island ones, because it requires the function to track the liveness (which is not the case of the outlined ones) and moving the Constant Island at the end seems more appropriate. If it is ok I'll split the patch and propose the move in a different review, but here is the whole thing such that you can test it.

Jan 8 2020, 9:24 AM · Restricted Project, Restricted Project

Nov 22 2019

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Sorry, for the delay, I'm finalizing some testcases and will send an update version, hopefully next week

Nov 22 2019, 2:24 AM · Restricted Project, Restricted Project

Nov 7 2019

yroux added a comment to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Same failures on ARM bots, logs are available here: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux/builds/1132

Nov 7 2019, 1:57 AM · Restricted Project

Aug 1 2019

yroux accepted D65563: [LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t.

looks good to me, Thanks Guillaume

Aug 1 2019, 2:15 AM · Restricted Project