Page MenuHomePhabricator

yroux (Yvan Roux)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2014, 12:27 AM (320 w, 6 d)

Recent Activity

Today

yroux added a comment to D76849: [ARM] unwinding .pad instructions missing in execute-only prologue.

I can't approve it, but it looks good to me.

Mon, Apr 6, 3:45 AM · Restricted Project

Fri, Apr 3

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Here is an update of the patch

Fri, Apr 3, 9:08 AM · Restricted Project, Restricted Project

Thu, Mar 26

yroux closed D53272: Add target requirement to profile remap test..

This was closed by commit r344593

Thu, Mar 26, 1:35 AM

Wed, Mar 25

yroux committed rGbd069ad39c9c: [ARM] Move ConstantIsland and LowOverheadLoops Passes. (authored by yroux).
[ARM] Move ConstantIsland and LowOverheadLoops Passes.
Wed, Mar 25, 9:11 AM
yroux closed D76065: [ARM] Move ConstantIsland and LowOverheadLoops Passes..
Wed, Mar 25, 9:10 AM · Restricted Project
yroux added a comment to D76069: [ARM][MachineOutliner] Add default mode..

Thanks for the review Jessica,

Wed, Mar 25, 8:04 AM · Restricted Project
yroux added a comment to D76068: [ARM][MachineOutliner] Add NoLRSave and Register modes..

Thanks for the review Jessica and Sam,

Wed, Mar 25, 7:32 AM · Restricted Project
yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Thanks for the review Sam,

Wed, Mar 25, 7:32 AM · Restricted Project, Restricted Project

Thu, Mar 12

yroux created D76069: [ARM][MachineOutliner] Add default mode..
Thu, Mar 12, 8:08 AM · Restricted Project
yroux created D76068: [ARM][MachineOutliner] Add NoLRSave and Register modes..
Thu, Mar 12, 8:08 AM · Restricted Project
yroux created D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Thu, Mar 12, 8:08 AM · Restricted Project, Restricted Project
yroux created D76065: [ARM] Move ConstantIsland and LowOverheadLoops Passes..
Thu, Mar 12, 8:08 AM · Restricted Project

Feb 17 2020

yroux added a comment to D72713: [ARM][LowOverheadLoops] Check loop liveouts.

Hi Sam,

Feb 17 2020, 7:40 AM · Restricted Project

Feb 13 2020

yroux added inline comments to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.
Feb 13 2020, 5:31 AM · Restricted Project, Restricted Project
yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Thanks for the comments Sam,

Feb 13 2020, 4:52 AM · Restricted Project, Restricted Project

Feb 12 2020

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Ping

Feb 12 2020, 3:28 AM · Restricted Project, Restricted Project

Jan 29 2020

yroux updated the diff for D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Here is a new version, which disables ARM Low Overhead Loops pass when the Machine Outliner is enabled.

Jan 29 2020, 9:21 AM · Restricted Project, Restricted Project

Jan 9 2020

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

! In D57054#1811740, @samparker wrote:
Hmm, would it be possible to pass a bool to the pass which will control whether liveness is updated? The other, suboptimal, option would be to not do outlining when we have the LOB extension.

Jan 9 2020, 6:37 AM · Restricted Project, Restricted Project
yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

This, and the fact that LowOverheadLoops is dependent upon block sizes and placement (I need to add a comment in the header on that pass....). So, ConstantIslands would have to guarantee not to change branch targets or change the distance between blocks around the low-overhead loop constructs. I think updating liveness information would be the easier option.

Jan 9 2020, 3:26 AM · Restricted Project, Restricted Project

Jan 8 2020

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Ah right, let's wait for Sam comments/advises and I'll prepare a proper patch for that.

Jan 8 2020, 10:53 PM · Restricted Project, Restricted Project
yroux updated the diff for D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

here is an update for the Machine Outliner support on ARM targets.
It addresses the comments received on the initial version and is rebased on current trunk.
Among the modifications needed by this rebase, this patch propose to move the ARM Low Overhead Loops pass before the Outliner and the Constant Island ones, because it requires the function to track the liveness (which is not the case of the outlined ones) and moving the Constant Island at the end seems more appropriate. If it is ok I'll split the patch and propose the move in a different review, but here is the whole thing such that you can test it.

Jan 8 2020, 9:24 AM · Restricted Project, Restricted Project

Nov 22 2019

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Sorry, for the delay, I'm finalizing some testcases and will send an update version, hopefully next week

Nov 22 2019, 2:24 AM · Restricted Project, Restricted Project

Nov 7 2019

yroux added a comment to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Same failures on ARM bots, logs are available here: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux/builds/1132

Nov 7 2019, 1:57 AM · Restricted Project

Aug 1 2019

yroux accepted D65563: [LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t.

looks good to me, Thanks Guillaume

Aug 1 2019, 2:15 AM · Restricted Project

May 20 2019

yroux committed rGbc07278e022b: [ELF] Fix tests from r361013 on ARM/AARch64 bots. (authored by yroux).
[ELF] Fix tests from r361013 on ARM/AARch64 bots.
May 20 2019, 1:50 AM
yroux committed rL361128: [ELF] Fix tests from r361013 on ARM/AARch64 bots..
[ELF] Fix tests from r361013 on ARM/AARch64 bots.
May 20 2019, 1:49 AM
yroux committed rLLD361128: [ELF] Fix tests from r361013 on ARM/AARch64 bots..
[ELF] Fix tests from r361013 on ARM/AARch64 bots.
May 20 2019, 1:49 AM

May 16 2019

yroux committed rG671fc5f3f449: [lld-link] Add missing "REQUIRES: x86" to COFF/lib-module-asm.ll test. (authored by yroux).
[lld-link] Add missing "REQUIRES: x86" to COFF/lib-module-asm.ll test.
May 16 2019, 4:27 AM
yroux committed rLLD360875: [lld-link] Add missing "REQUIRES: x86" to COFF/lib-module-asm.ll test..
[lld-link] Add missing "REQUIRES: x86" to COFF/lib-module-asm.ll test.
May 16 2019, 4:27 AM
yroux committed rL360875: [lld-link] Add missing "REQUIRES: x86" to COFF/lib-module-asm.ll test..
[lld-link] Add missing "REQUIRES: x86" to COFF/lib-module-asm.ll test.
May 16 2019, 4:26 AM
yroux committed rGeff622b23cc5: [crt] Mark dso_handle test as xfailing on ARM. (authored by yroux).
[crt] Mark dso_handle test as xfailing on ARM.
May 16 2019, 4:14 AM
yroux committed rCRT360873: [crt] Mark dso_handle test as xfailing on ARM..
[crt] Mark dso_handle test as xfailing on ARM.
May 16 2019, 4:14 AM
yroux committed rL360873: [crt] Mark dso_handle test as xfailing on ARM..
[crt] Mark dso_handle test as xfailing on ARM.
May 16 2019, 4:14 AM

Feb 13 2019

yroux added inline comments to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.
Feb 13 2019, 11:46 PM · Restricted Project, Restricted Project

Jan 28 2019

yroux added inline comments to D57254: [Outliner] Set nounwind for outlined functions.
Jan 28 2019, 8:13 AM
yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Thanks for the review David,

Jan 28 2019, 8:06 AM · Restricted Project, Restricted Project

Jan 25 2019

yroux accepted D57241: [scudo] Delay allocations in the RSS check test.

looks good to me, I'll keep an eye on the bots to check the fix. Thanks

Jan 25 2019, 9:15 AM

Jan 23 2019

yroux added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Thanks Tim, Jessica and Eli for the quick review!

Jan 23 2019, 7:10 AM · Restricted Project, Restricted Project

Jan 22 2019

yroux created D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.
Jan 22 2019, 6:39 AM · Restricted Project, Restricted Project

Nov 26 2018

yroux added a comment to D53942: IR Outliner Pass.

Ok, I don't think I'm allowed to share the bench sources, so I've creduced the problem and will send you the small obfuscated testcase and command lines.

Nov 26 2018, 4:51 AM · Restricted Project

Nov 21 2018

yroux added a comment to D53942: IR Outliner Pass.

Hi Tom,

Nov 21 2018, 8:42 AM · Restricted Project

Oct 17 2018

yroux updated subscribers of D52974: [XRay][compiler-rt] Generational Buffer Management.

Hi Dean,

Oct 17 2018, 5:57 AM

Oct 16 2018

yroux updated subscribers of D52840: Include Python binding tests in CMake rules.

Hi Michal,

Oct 16 2018, 7:03 AM
yroux committed rC344593: Add target requirement to profile remap test..
Add target requirement to profile remap test.
Oct 16 2018, 1:49 AM
yroux committed rL344593: Add target requirement to profile remap test..
Add target requirement to profile remap test.
Oct 16 2018, 1:49 AM

Oct 15 2018

yroux created D53272: Add target requirement to profile remap test..
Oct 15 2018, 1:57 AM

Oct 9 2018

yroux updated subscribers of D52881: [LV] Do not create SCEVs on broken IR in emitTransformedIndex. PR39160.

Hi Max,

Oct 9 2018, 6:23 AM

Sep 18 2018

yroux added a comment to D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed..

Seems that it was fixed earlier today.

Sep 18 2018, 1:59 PM
yroux updated subscribers of D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed..

Hi Sam,

Sep 18 2018, 10:34 AM

Sep 10 2018

yroux updated subscribers of D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization.

Hi Kirill,

Sep 10 2018, 7:15 AM · Restricted Project

Aug 28 2018

yroux updated subscribers of D50940: [sanitizer] Change Mmap*NoAccess to return nullptr on error.

Hi Kostya,

Aug 28 2018, 12:21 AM

Aug 16 2018

yroux committed rCXXA339865: [libcxxabi] Fix test_exception_address_alignment test for ARM.
[libcxxabi] Fix test_exception_address_alignment test for ARM
Aug 16 2018, 4:40 AM
yroux committed rL339865: [libcxxabi] Fix test_exception_address_alignment test for ARM.
[libcxxabi] Fix test_exception_address_alignment test for ARM
Aug 16 2018, 4:38 AM
yroux closed D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM.
Aug 16 2018, 4:38 AM
yroux updated subscribers of D50645: [clangd] Show non-instantiated decls in signatureHelp.

Hi Ilya,

Aug 16 2018, 4:31 AM

Aug 14 2018

yroux added a comment to D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3.

Notice that the affected bots run two times the test cases where one execution passes and one fails, as you can see in (search Analysis/plist-macros.cpp for instance):

Aug 14 2018, 3:17 AM

Aug 9 2018

yroux added a comment to D50460: [zorg] Increase parallelism for bots running on 96-core server..

LGTM

Aug 9 2018, 5:03 AM
yroux added a comment to D50458: [zorg] Update configuration of Linaro's AArch64 bots.

LGTM

Aug 9 2018, 5:03 AM

Aug 7 2018

yroux added a comment to D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM.

I dug a bit and can give more context. The usage of _LIBUNWIND_ARM_EHABI was introduced by D31178 but from what we are seeing with the release builds, libunwind headers are not picked up (at least in these configs) and since r309226 was committed, clang and libunwind unwind.h versions are close enough (and are the same w/r to alignment) to rely on libcxxabi macro _LIBCXXABI_ARM_EHABI to choose the alignment no matter which unwind header is used.

Aug 7 2018, 1:22 AM

Aug 2 2018

yroux updated the summary of D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM.
Aug 2 2018, 1:43 AM
yroux created D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM.
Aug 2 2018, 1:28 AM

Jul 7 2018

yroux committed rL336482: [MachineOutliner] Add missing liveness tracking info in MIR test..
[MachineOutliner] Add missing liveness tracking info in MIR test.
Jul 7 2018, 1:47 AM
yroux committed rL336481: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).
[MachineOutliner] Assert that Liveness tracking is accurate (NFC)
Jul 7 2018, 1:07 AM
yroux closed D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).
Jul 7 2018, 1:07 AM

Jul 6 2018

yroux updated the diff for D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).
Jul 6 2018, 12:16 PM
yroux added inline comments to D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).
Jul 6 2018, 12:05 PM
yroux added a comment to D48200: [CMake] Run libFuzzer tests with check-all..

Recommitted at r336449

Jul 6 2018, 10:34 AM
yroux committed rL336449: Recommit "[CMake] Run libFuzzer tests with check-all.".
Recommit "[CMake] Run libFuzzer tests with check-all."
Jul 6 2018, 10:27 AM
yroux committed rCRT336449: Recommit "[CMake] Run libFuzzer tests with check-all.".
Recommit "[CMake] Run libFuzzer tests with check-all."
Jul 6 2018, 10:27 AM
yroux committed rL336446: [libFuzzer] Disable hanging tests on AArch64.
[libFuzzer] Disable hanging tests on AArch64
Jul 6 2018, 10:11 AM
yroux committed rCRT336446: [libFuzzer] Disable hanging tests on AArch64.
[libFuzzer] Disable hanging tests on AArch64
Jul 6 2018, 10:11 AM
yroux closed D49011: [libFuzzer] Disable hanging tests on AArch64.
Jul 6 2018, 10:11 AM
yroux created D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).
Jul 6 2018, 7:31 AM
yroux created D49011: [libFuzzer] Disable hanging tests on AArch64.
Jul 6 2018, 1:56 AM

Jul 5 2018

yroux added a comment to D48200: [CMake] Run libFuzzer tests with check-all..

Sure, I'll do it today.

Jul 5 2018, 11:41 PM
yroux added a comment to D48349: [ADT] Add llvm::unique_function which is like std::function but supporting move-only closures..

ARM bots are back, Thanks Chandler.

Jul 5 2018, 11:37 PM
yroux committed rCRT336341: Revert "[CMake] Run libFuzzer tests with check-all.".
Revert "[CMake] Run libFuzzer tests with check-all."
Jul 5 2018, 5:25 AM
yroux committed rL336341: Revert "[CMake] Run libFuzzer tests with check-all.".
Revert "[CMake] Run libFuzzer tests with check-all."
Jul 5 2018, 5:24 AM
yroux added a comment to D48349: [ADT] Add llvm::unique_function which is like std::function but supporting move-only closures..

Hi Chandler,

Jul 5 2018, 4:38 AM
yroux added a comment to D48200: [CMake] Run libFuzzer tests with check-all..

This commit broke AArch64 bots, a bugzilla entry was created to track the issue:

Jul 5 2018, 4:23 AM

Jul 4 2018

yroux committed rL336285: [MachineOutliner] Fix typo in getOutliningCandidateInfo function name.
[MachineOutliner] Fix typo in getOutliningCandidateInfo function name
Jul 4 2018, 8:42 AM
yroux closed D48867: [MachineOutliner] Fix typo in getOutliningCandidateInfo function name.
Jul 4 2018, 8:42 AM

Jul 3 2018

yroux created D48867: [MachineOutliner] Fix typo in getOutliningCandidateInfo function name.
Jul 3 2018, 2:07 AM

Jul 2 2018

yroux added a comment to D48468: [SelectionDAG] Remove debug locations from ConstantSD(FP)Nodes.

Thanks for the fix Vedant.

Jul 2 2018, 1:08 AM

Jun 27 2018

yroux updated subscribers of D48468: [SelectionDAG] Remove debug locations from ConstantSD(FP)Nodes.

Hi Vedant,

Jun 27 2018, 2:30 AM

May 31 2018

yroux committed rCRT333729: [ASAN] Sanitize testsuite for ARM..
[ASAN] Sanitize testsuite for ARM.
May 31 2018, 11:28 PM
yroux committed rL333729: [ASAN] Sanitize testsuite for ARM..
[ASAN] Sanitize testsuite for ARM.
May 31 2018, 11:28 PM
yroux closed D47575: [ASAN] Sanitize testsuite for ARM..
May 31 2018, 11:27 PM
yroux added a comment to D47575: [ASAN] Sanitize testsuite for ARM..

Tested on ARMv7 and ARMv8 linux boxes.

May 31 2018, 1:39 AM
yroux created D47575: [ASAN] Sanitize testsuite for ARM..
May 31 2018, 1:38 AM

May 24 2018

yroux added a comment to D45916: Enable MachineOutliner by default under -Oz for AArch64.

Hi Jessica,

May 24 2018, 10:33 AM
yroux updated subscribers of D46964: Implement class deduction guides for `std::array`.

Hi Marshall,

May 24 2018, 7:16 AM

Apr 10 2018

yroux updated subscribers of D45199: AArch64: Allow offsets to be folded into addresses with ELF..

Hi Peter,

Apr 10 2018, 7:10 AM

Mar 22 2018

yroux updated subscribers of D44691: [CUDA] Disable LTO for device-side compilations..

Hi Artem,

Mar 22 2018, 12:02 AM

Feb 7 2018

yroux added a comment to D42900: [asan] Fix filename size on linux platforms..

Sorry for the delay Hans (I was off today) Hope it is not too late to include it in rc2.

Feb 7 2018, 10:33 AM
yroux committed rL324496: [asan] Fix filename size on linux platforms..
[asan] Fix filename size on linux platforms.
Feb 7 2018, 10:29 AM
yroux committed rCRT324496: [asan] Fix filename size on linux platforms..
[asan] Fix filename size on linux platforms.
Feb 7 2018, 10:29 AM
yroux closed D42900: [asan] Fix filename size on linux platforms..
Feb 7 2018, 10:29 AM

Feb 6 2018

yroux added a comment to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

@thebolt yes 2 stage build and regression testsuite passed on armv7 builder, thanks for the fix.

Feb 6 2018, 12:22 PM

Feb 5 2018

yroux updated the diff for D42900: [asan] Fix filename size on linux platforms..

Use PATH_MAX from <limits.h> instead of MAXPATHLEN.

Feb 5 2018, 11:10 PM