Page MenuHomePhabricator

[MIPS GlobalISel] Select bitwise instructions
ClosedPublic

Authored by Petar.Avramovic on Aug 2 2018, 6:09 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Petar.Avramovic created this revision.Aug 2 2018, 6:09 AM
atanasyan added inline comments.Aug 14 2018, 10:29 PM
test/CodeGen/Mips/GlobalISel/irtranslator/bitwise.ll
1 ↗(On Diff #158741)

Is this ll file really generated by update_mir_test_check.py?

test/CodeGen/Mips/GlobalISel/irtranslator/bitwise.ll
1 ↗(On Diff #158741)

Yes, partially. I wrote ll input and script generated this test file.

atanasyan added inline comments.Aug 15 2018, 10:20 PM
test/CodeGen/Mips/GlobalISel/irtranslator/bitwise.ll
1 ↗(On Diff #158741)

I mean why don’t you use update_llc_test_check.py?

test/CodeGen/Mips/GlobalISel/irtranslator/bitwise.ll
1 ↗(On Diff #158741)

When we stop after some function pass in llc update_mir_test_check.py is used to generate mir test. However when we let llc run until the end update_llc_test_check.py is used, such tests are located in Mips/GlobalISel/llvm-ir/. Remaining folders in Mips/GlobalISel/ contain mir tests for each Global ISel function pass.

This revision is now accepted and ready to land.Aug 20 2018, 4:21 AM
This revision was automatically updated to reflect the committed changes.