This is an archive of the discontinued LLVM Phabricator instance.

Add libcxxabi option back for sanitizer use.
ClosedPublic

Authored by srhines on Jul 10 2018, 3:05 PM.

Details

Summary

A prior refactoring accidentally dropped the case for using libc++abi as
the out-of-tree C++ runtime library for sanitizers. This patch restores
that functionality, which is used by Android, which can't depend on the
full libc++ for these libraries.

Diff Detail

Repository
rL LLVM

Event Timeline

srhines created this revision.Jul 10 2018, 3:05 PM
Herald added subscribers: Restricted Project, llvm-commits, delcypher, mgorny. · View Herald Transcript

https://reviews.llvm.org/D47100 is the commit where this got dropped.

phosek accepted this revision.Jul 10 2018, 3:50 PM

LGTM

CMakeLists.txt
356 ↗(On Diff #154892)

Should the name be libc++abi for consistency with libc++ above?

This revision is now accepted and ready to land.Jul 10 2018, 3:50 PM
srhines marked an inline comment as done.Jul 10 2018, 5:47 PM

Thanks for the quick review.

CMakeLists.txt
356 ↗(On Diff #154892)

The original naming was libcxxabi, so I am restoring that (in case anyone else is also using it).

This revision was automatically updated to reflect the committed changes.
srhines marked an inline comment as done.