- User Since
- Mar 16 2015, 4:30 PM (166 w, 2 d)
Tue, May 22
Only two minor suggestions. Everything looks fine. Thanks.
Fri, May 18
Mon, Apr 30
FYI, Android NDK has another use case in https://github.com/android-ndk/ndk/issues/680.
It would be nice to have clang-tidy recognize the response file.
Apr 18 2018
This change caused an assertion failure in ExprEngineCXX.cpp:
Apr 11 2018
Yes, calling __gcov_flush within .so files are different,
but it's a revert of https://reviews.llvm.org/D38124.
I think https://bugs.llvm.org/show_bug.cgi?id=27224
can be fixed by hiding only llvm_gcda_* functions,
without any change to __gcov_flush.
Apr 10 2018
If we use the unit test case, call __gcov_flush from the main function,
and dump static variables in GCDAProfiling.c, we can see that __gcov_flush
is resolved to the same copy for func.shared, func2.shared, and main.
However, when __gcov_flush is called from main and from f1_flush and f2_flush,
they use different copies of static variables defined in GCDAProfiling.c.
The "flush_fn_head" and its flush functions are different, so 3 calls of
__gcov_flush will flush to 3 different output files:
instrprof-dlopen-func.gcda instrprof-dlopen-func2.gcda instrprof-dlopen-dlclose-main.gcda
Apr 9 2018
Mar 26 2018
Mar 1 2018
Martin, thanks for finding this problem.
Please review/accept my new change if it passes your tests.
After this and D42999, the default emulated TLS mode should only be decided in
The clang driver will be fixed in https://reviews.llvm.org/D43965
I will upload a different fix soon.
We should set ExplicitEmulatedTLS only when -f[no-]emulated-tls flag is found at command line.
Any front-end should only pass the flag and let backend decide the default based on target.
Feb 28 2018
Feb 27 2018
This change produced a new error with LTO and AOSP ARM thumb code.
Please see a reduced test case at https://bugs.llvm.org/show_bug.cgi?id=36542
Feb 26 2018
Feb 13 2018
Feb 12 2018
Feb 7 2018
I don't think -fno-emulated-tls is used anywhere yet.
I should have not allowed that flag.
My original idea was to have only -femulated-tls for
targets like Android.
Feb 6 2018
Jan 31 2018
Jan 30 2018
Jan 29 2018
Jan 25 2018
Hi, I am trying to build Android with clang 7.0.
This change generates wrong inlined sprintf because Android bionic
used fortified version wrapper with attribute((always_inline)).
Oct 30 2017
Oct 11 2017
This change LGTM.
I added more comments in https://bugs.llvm.org/show_bug.cgi?id=34866.
Sep 26 2017
Sep 25 2017
Sep 21 2017
Sep 20 2017
Sep 18 2017
Please review https://reviews.llvm.org/D35743.
I uploaded there a new diff that should fix the spaces around & and && tokens.
Sep 15 2017
Thanks for this change.
Could you take a look of https://reviews.llvm.org/D35743 too?
Sep 6 2017
My original change in lib/Target/X86/X86ISelLowering.cpp
was part of https://reviews.llvm.org/D15134 to fix
calling convention bug of f128 type mentioned in
Sep 5 2017
Okay, I see the change in extract_store.ll now.
The checks were not reduced.
The test mode +mmx was changed to +sse,
and expected output of +sse2, +sse4.1, +avx were changed.
Sep 1 2017
I cannot get clang to crash with "clang -c -mno-mmx" and the given example.
Maybe I missed something?
Aug 16 2017
Aug 15 2017
Okay, 3 changes are combined into D36761.
Aug 14 2017
Daniel, Manuel, I will take over this CL since Yan has finished his internship at Google.,
Yan's latest patch to tryToParseLambda looks acceptable to me.
I think it should take care of new kw_auto in additional to kw_new, ke_delete, etc.
Jul 31 2017
Jul 28 2017
rsmith, srhines, akyrtzi, rtrieu, do you have any comment?
Jul 27 2017
Jul 26 2017
Jul 17 2017
If most code can be shared in a common base class like CloexecCheck,
maybe all 8 "Add a close-on-exec check" CLs can be combined into 1 or 2 CLs
to consolidate all review efforts.
I also prefer a separate check name for each function,
so users can enable/disable each check.