- User Since
- Mar 16 2015, 4:30 PM (153 w, 9 h)
Tue, Feb 13
Mon, Feb 12
Wed, Feb 7
I don't think -fno-emulated-tls is used anywhere yet.
I should have not allowed that flag.
My original idea was to have only -femulated-tls for
targets like Android.
Tue, Feb 6
Wed, Jan 31
Tue, Jan 30
Mon, Jan 29
Thu, Jan 25
Hi, I am trying to build Android with clang 7.0.
This change generates wrong inlined sprintf because Android bionic
used fortified version wrapper with attribute((always_inline)).
Oct 30 2017
Oct 11 2017
This change LGTM.
I added more comments in https://bugs.llvm.org/show_bug.cgi?id=34866.
Sep 26 2017
Sep 25 2017
Sep 21 2017
Sep 20 2017
Sep 18 2017
Please review https://reviews.llvm.org/D35743.
I uploaded there a new diff that should fix the spaces around & and && tokens.
Sep 15 2017
Thanks for this change.
Could you take a look of https://reviews.llvm.org/D35743 too?
Sep 6 2017
My original change in lib/Target/X86/X86ISelLowering.cpp
was part of https://reviews.llvm.org/D15134 to fix
calling convention bug of f128 type mentioned in
Sep 5 2017
Okay, I see the change in extract_store.ll now.
The checks were not reduced.
The test mode +mmx was changed to +sse,
and expected output of +sse2, +sse4.1, +avx were changed.
Sep 1 2017
I cannot get clang to crash with "clang -c -mno-mmx" and the given example.
Maybe I missed something?
Aug 16 2017
Aug 15 2017
Okay, 3 changes are combined into D36761.
Aug 14 2017
Daniel, Manuel, I will take over this CL since Yan has finished his internship at Google.,
Yan's latest patch to tryToParseLambda looks acceptable to me.
I think it should take care of new kw_auto in additional to kw_new, ke_delete, etc.
Jul 31 2017
Jul 28 2017
rsmith, srhines, akyrtzi, rtrieu, do you have any comment?
Jul 27 2017
Jul 26 2017
Jul 17 2017
If most code can be shared in a common base class like CloexecCheck,
maybe all 8 "Add a close-on-exec check" CLs can be combined into 1 or 2 CLs
to consolidate all review efforts.
I also prefer a separate check name for each function,
so users can enable/disable each check.
Jul 12 2017
Jul 11 2017
Jul 10 2017
See https://reviews.llvm.org/D35225 for a test case.
These tests should be added after https://bugs.llvm.org/show_bug.cgi?id=33734 is fixed.
Jul 6 2017
These warnings are triggered by -Wpadded -Wpacked
or clang-tidy's clang-diagnostic-packed check.
I agree that they should be ignored or suppressed in many cases.
What I am not sure is the amount of real positive cases.
Jun 30 2017
Except the unit test failure, I did not find error in building Android.
Please fix the unit test before submit.
I probably won't have time working on this before next Wednesday.
LGTM. If nobody needs this during the long weekend, it's better to submit after the long weekend.
Still running some Android tests.
This new diff looks good.
I only found one error in soft-fp-legal-in-HW-reg.ll so far.
Jun 29 2017
I think you also need to change docs/clang-tidy/checks/list.rst.
Summary should be updated. s/android-fopen-mode/android-cloexec-fopen/
Summary should be updated. s/android-creat-usage/android-cloexec-creat/
Please update the subject line and summary.
The new diff shows only the renaming of check name and file names.
Were the other changes for format and macro lost or are they
going to be in another change later?