chh (Chih-Hung Hsieh)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2015, 4:30 PM (166 w, 2 d)

Recent Activity

Tue, May 22

chh accepted D46978: Delay emutls deallocation for one round.

Only two minor suggestions. Everything looks fine. Thanks.

Tue, May 22, 10:01 AM

Fri, May 18

chh added inline comments to D46978: Delay emutls deallocation for one round.
Fri, May 18, 3:47 PM
chh added a reviewer for D46978: Delay emutls deallocation for one round: chh.
Fri, May 18, 3:44 PM

Mon, Apr 30

chh added a comment to D34440: [Clang] Expand response files before loading compilation database.

FYI, Android NDK has another use case in https://github.com/android-ndk/ndk/issues/680.
It would be nice to have clang-tidy recognize the response file.

Mon, Apr 30, 3:25 PM · Restricted Project

Apr 18 2018

chh added a comment to D43689: [analyzer] Disable constructor inlining when lifetime extension through fields occurs..

This change caused an assertion failure in ExprEngineCXX.cpp:
https://bugs.llvm.org/show_bug.cgi?id=37166

Apr 18 2018, 10:25 AM

Apr 11 2018

chh added a comment to D45454: Make __gcov_flush visible outside a shared library.

Yes, calling __gcov_flush within .so files are different,
but it's a revert of https://reviews.llvm.org/D38124.
I think https://bugs.llvm.org/show_bug.cgi?id=27224
can be fixed by hiding only llvm_gcda_* functions,
without any change to __gcov_flush.

Apr 11 2018, 11:31 AM

Apr 10 2018

chh added a comment to D45454: Make __gcov_flush visible outside a shared library.

If we use the unit test case, call __gcov_flush from the main function,
and dump static variables in GCDAProfiling.c, we can see that __gcov_flush
is resolved to the same copy for func.shared, func2.shared, and main.
However, when __gcov_flush is called from main and from f1_flush and f2_flush,
they use different copies of static variables defined in GCDAProfiling.c.
The "flush_fn_head" and its flush functions are different, so 3 calls of
__gcov_flush will flush to 3 different output files:

instrprof-dlopen-func.gcda
instrprof-dlopen-func2.gcda
instrprof-dlopen-dlclose-main.gcda
Apr 10 2018, 3:24 PM

Apr 9 2018

chh created D45454: Make __gcov_flush visible outside a shared library.
Apr 9 2018, 1:45 PM

Mar 26 2018

chh accepted D44852: [CodeGen] Mark fma as const for Android.
Mar 26 2018, 9:19 AM

Mar 1 2018

chh committed rC326499: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS.
[Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS
Mar 1 2018, 2:28 PM
chh committed rL326499: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS.
[Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS
Mar 1 2018, 2:28 PM
chh closed D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS.
Mar 1 2018, 2:28 PM
chh added a comment to D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS.

Martin, thanks for finding this problem.
Please review/accept my new change if it passes your tests.
After this and D42999, the default emulated TLS mode should only be decided in
llvm/trunk/include/llvm/ADT/Triple.h hasDefaultEmulatedTLS().

Mar 1 2018, 2:12 PM
chh added a comment to D42999: [TLS] use emulated TLS if the target supports only this mode.

The clang driver will be fixed in https://reviews.llvm.org/D43965

Mar 1 2018, 2:08 PM
chh updated subscribers of D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS.
Mar 1 2018, 2:08 PM
chh updated the diff for D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS.
Mar 1 2018, 2:03 PM
chh commandeered D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS.

I will upload a different fix soon.
We should set ExplicitEmulatedTLS only when -f[no-]emulated-tls flag is found at command line.
Any front-end should only pass the flag and let backend decide the default based on target.

Mar 1 2018, 1:41 PM

Feb 28 2018

chh committed rL326341: [TLS] use emulated TLS if the target supports only this mode.
[TLS] use emulated TLS if the target supports only this mode
Feb 28 2018, 10:53 AM
chh closed D42999: [TLS] use emulated TLS if the target supports only this mode.
Feb 28 2018, 10:53 AM

Feb 27 2018

chh added a comment to D41693: [ARM][NFC] Avoid recreating MCSubtargetInfo in ARMAsmBackend.

This change produced a new error with LTO and AOSP ARM thumb code.
Please see a reduced test case at https://bugs.llvm.org/show_bug.cgi?id=36542

Feb 27 2018, 12:17 PM

Feb 26 2018

chh added a comment to D42999: [TLS] use emulated TLS if the target supports only this mode.

ping.

Feb 26 2018, 9:25 AM

Feb 13 2018

chh updated the diff for D42999: [TLS] use emulated TLS if the target supports only this mode.
Feb 13 2018, 10:22 AM

Feb 12 2018

chh added a comment to D42999: [TLS] use emulated TLS if the target supports only this mode.

ping.

Feb 12 2018, 10:18 AM

Feb 7 2018

chh updated the diff for D42999: [TLS] use emulated TLS if the target supports only this mode.

I don't think -fno-emulated-tls is used anywhere yet.
I should have not allowed that flag.
My original idea was to have only -femulated-tls for
targets like Android.

Feb 7 2018, 2:43 PM

Feb 6 2018

chh added a reviewer for D42999: [TLS] use emulated TLS if the target supports only this mode: chapuni.
Feb 6 2018, 6:07 PM
chh updated subscribers of D42999: [TLS] use emulated TLS if the target supports only this mode.
Feb 6 2018, 6:04 PM
chh created D42999: [TLS] use emulated TLS if the target supports only this mode.
Feb 6 2018, 6:04 PM

Jan 31 2018

chh committed rL323898: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
[Analysis] Disable calls to *_finite and other glibc-only functions on Android.
Jan 31 2018, 11:15 AM
chh closed D42668: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
Jan 31 2018, 11:15 AM
chh updated the diff for D42668: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
Jan 31 2018, 10:29 AM

Jan 30 2018

chh added inline comments to D42668: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
Jan 30 2018, 6:42 PM
chh added inline comments to D42668: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
Jan 30 2018, 3:30 PM
chh updated the diff for D42668: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
Jan 30 2018, 3:29 PM

Jan 29 2018

chh created D42668: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
Jan 29 2018, 3:43 PM

Jan 25 2018

chh added a comment to D41335: [InlineFunction] Inline vararg functions that do not access varargs..

Hi, I am trying to build Android with clang 7.0.
This change generates wrong inlined sprintf because Android bionic
used fortified version wrapper with attribute((always_inline)).

Jan 25 2018, 12:40 PM

Oct 30 2017

chh added reviewers for D39313: Handle x86 feature specific alignment of __builtin_alloca.: srhines, danalbert.
Oct 30 2017, 10:09 AM · Restricted Project

Oct 11 2017

chh added a comment to D38771: [x86] avoid infinite loop from SoftenFloatOperand (PR34866).

This change LGTM.
I added more comments in https://bugs.llvm.org/show_bug.cgi?id=34866.

Oct 11 2017, 10:22 AM

Sep 26 2017

chh committed rL314264: [clang-format] Adjust space around &/&& of structured bindings.
[clang-format] Adjust space around &/&& of structured bindings
Sep 26 2017, 6:00 PM
chh closed D35743: [clang-format] Adjust space around &/&& of structured bindings by committing rL314264: [clang-format] Adjust space around &/&& of structured bindings.
Sep 26 2017, 6:00 PM · Restricted Project

Sep 25 2017

chh added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

ping.

Sep 25 2017, 11:46 AM · Restricted Project

Sep 21 2017

chh updated the summary of D35743: [clang-format] Adjust space around &/&& of structured bindings.
Sep 21 2017, 9:12 AM · Restricted Project
chh updated the diff for D35743: [clang-format] Adjust space around &/&& of structured bindings.
Sep 21 2017, 9:11 AM · Restricted Project

Sep 20 2017

chh updated the diff for D35743: [clang-format] Adjust space around &/&& of structured bindings.
Sep 20 2017, 3:23 PM · Restricted Project

Sep 18 2017

chh added a comment to D37132: [clang-format] Add support for C++17 structured bindings..

Please review https://reviews.llvm.org/D35743.
I uploaded there a new diff that should fix the spaces around & and && tokens.
Thanks.

Sep 18 2017, 4:02 PM
chh added a reviewer for D35743: [clang-format] Adjust space around &/&& of structured bindings: curdeius.
Sep 18 2017, 4:00 PM · Restricted Project
chh updated the diff for D35743: [clang-format] Adjust space around &/&& of structured bindings.
Sep 18 2017, 3:57 PM · Restricted Project
chh retitled D35743: [clang-format] Adjust space around &/&& of structured bindings from [clang-format] Handle Structured binding declaration in C++17 to [clang-format] Adjust space around &/&& of structured bindings.
Sep 18 2017, 3:56 PM · Restricted Project
chh commandeered D35743: [clang-format] Adjust space around &/&& of structured bindings.
Sep 18 2017, 3:53 PM · Restricted Project

Sep 15 2017

chh added a comment to D37132: [clang-format] Add support for C++17 structured bindings..

Thanks for this change.
Could you take a look of https://reviews.llvm.org/D35743 too?

Sep 15 2017, 2:36 PM
chh added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

ping.

Sep 15 2017, 9:44 AM · Restricted Project

Sep 6 2017

chh added a reviewer for D37365: [x86] Enable f128 as a legal type in 64-bit mode if SSE is enabled rather than if MMX is enabled.: chh.
Sep 6 2017, 12:00 PM
chh removed a reviewer for D37365: [x86] Enable f128 as a legal type in 64-bit mode if SSE is enabled rather than if MMX is enabled.: chh.
Sep 6 2017, 11:59 AM
chh resigned from D37365: [x86] Enable f128 as a legal type in 64-bit mode if SSE is enabled rather than if MMX is enabled..

My original change in lib/Target/X86/X86ISelLowering.cpp
was part of https://reviews.llvm.org/D15134 to fix
calling convention bug of f128 type mentioned in
https://bugs.llvm.org/show_bug.cgi?id=23897.

Sep 6 2017, 11:56 AM

Sep 5 2017

chh added a comment to D37365: [x86] Enable f128 as a legal type in 64-bit mode if SSE is enabled rather than if MMX is enabled..

Okay, I see the change in extract_store.ll now.
The checks were not reduced.
The test mode +mmx was changed to +sse,
and expected output of +sse2, +sse4.1, +avx were changed.

Sep 5 2017, 4:04 PM

Sep 1 2017

chh requested changes to D37365: [x86] Enable f128 as a legal type in 64-bit mode if SSE is enabled rather than if MMX is enabled..

I cannot get clang to crash with "clang -c -mno-mmx" and the given example.
Maybe I missed something?

Sep 1 2017, 6:33 PM

Aug 16 2017

chh committed rL311040: [clang-tidy] Remove unused static variable..
[clang-tidy] Remove unused static variable.
Aug 16 2017, 2:02 PM
chh committed rL311035: [clang-tidy] Use const char* to compile with VC cl.exe..
[clang-tidy] Use const char* to compile with VC cl.exe.
Aug 16 2017, 12:14 PM
chh added inline comments to D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Aug 16 2017, 11:04 AM · Restricted Project
chh committed rL311029: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
[clang-tidy] Add a close-on-exec check on epoll_create() in Android module.
Aug 16 2017, 11:03 AM
chh closed D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module. by committing rL311029: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module..
Aug 16 2017, 11:03 AM · Restricted Project
chh committed rL311028: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
[clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.
Aug 16 2017, 10:54 AM
chh closed D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module. by committing rL311028: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module..
Aug 16 2017, 10:54 AM · Restricted Project
chh committed rL311027: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
[clang-tidy] Add a close-on-exec check on accept4() in Android module.
Aug 16 2017, 10:47 AM
chh closed D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module. by committing rL311027: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
Aug 16 2017, 10:47 AM · Restricted Project
chh updated the summary of D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module..
Aug 16 2017, 10:21 AM · Restricted Project
chh committed rL311024: [clang-tidy] Add a close-on-exec check on accept() in Android module..
[clang-tidy] Add a close-on-exec check on accept() in Android module.
Aug 16 2017, 10:19 AM
chh closed D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module. by committing rL311024: [clang-tidy] Add a close-on-exec check on accept() in Android module..
Aug 16 2017, 10:19 AM · Restricted Project
chh updated the diff for D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module..
Aug 16 2017, 10:15 AM · Restricted Project
chh commandeered D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module..
Aug 16 2017, 10:14 AM · Restricted Project
chh committed rL311020: [clang-tidy] Use CloexecCheck as base class..
[clang-tidy] Use CloexecCheck as base class.
Aug 16 2017, 10:00 AM
chh closed D36761: [clang-tidy] Use CloexecCheck as base class. by committing rL311020: [clang-tidy] Use CloexecCheck as base class..
Aug 16 2017, 10:00 AM
chh updated the diff for D36761: [clang-tidy] Use CloexecCheck as base class..
Aug 16 2017, 9:57 AM

Aug 15 2017

chh updated the diff for D36761: [clang-tidy] Use CloexecCheck as base class..
Aug 15 2017, 1:42 PM
chh abandoned D36755: [clang-tidy] Use CloexecCheck as base class of CloexecCreatCheck..

Included in D36761.

Aug 15 2017, 1:34 PM
chh abandoned D36756: [clang-tidy] Use CloexecCheck as base class of CloexecSocketCheck..

Included in D36761.

Aug 15 2017, 1:33 PM
chh abandoned D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck..

Included in D36761.

Aug 15 2017, 1:32 PM
chh added a comment to D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck..

Okay, 3 changes are combined into D36761.

Aug 15 2017, 11:45 AM
chh created D36761: [clang-tidy] Use CloexecCheck as base class..
Aug 15 2017, 11:44 AM
chh added a comment to D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck..

Eugene, do you mean combining this one, D36756, and D36755 into one?
I don't mind either way.

Aug 15 2017, 11:30 AM
chh created D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck..
Aug 15 2017, 11:06 AM
chh created D36756: [clang-tidy] Use CloexecCheck as base class of CloexecSocketCheck..
Aug 15 2017, 10:43 AM
chh created D36755: [clang-tidy] Use CloexecCheck as base class of CloexecCreatCheck..
Aug 15 2017, 10:41 AM

Aug 14 2017

chh added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

Daniel, Manuel, I will take over this CL since Yan has finished his internship at Google.,
Yan's latest patch to tryToParseLambda looks acceptable to me.
I think it should take care of new kw_auto in additional to kw_new, ke_delete, etc.

Aug 14 2017, 12:04 PM · Restricted Project
chh committed rL310863: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
[clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.
Aug 14 2017, 10:47 AM
chh closed D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module. by committing rL310863: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..
Aug 14 2017, 10:47 AM · Restricted Project
chh committed rL310861: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
[clang-tidy] Add a close-on-exec check on inotify_init() in Android module.
Aug 14 2017, 10:26 AM
chh closed D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module. by committing rL310861: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module..
Aug 14 2017, 10:26 AM · Restricted Project
chh committed rL310858: [clang-tidy] Add a close-on-exec check on dup() in Android module..
[clang-tidy] Add a close-on-exec check on dup() in Android module.
Aug 14 2017, 10:06 AM
chh closed D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module. by committing rL310858: [clang-tidy] Add a close-on-exec check on dup() in Android module..
Aug 14 2017, 10:06 AM · Restricted Project

Jul 31 2017

chh accepted D34114: [clang] Change the condition of unnecessary packed warning.
Jul 31 2017, 3:27 PM

Jul 28 2017

chh added a comment to D34114: [clang] Change the condition of unnecessary packed warning.

LGTM.
rsmith, srhines, akyrtzi, rtrieu, do you have any comment?

Jul 28 2017, 10:33 AM
chh added inline comments to D34114: [clang] Change the condition of unnecessary packed warning.
Jul 28 2017, 9:45 AM

Jul 27 2017

chh added inline comments to D34114: [clang] Change the condition of unnecessary packed warning.
Jul 27 2017, 2:45 PM

Jul 26 2017

chh added inline comments to D34114: [clang] Change the condition of unnecessary packed warning.
Jul 26 2017, 4:24 PM

Jul 17 2017

chh added a comment to D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module..

If most code can be shared in a common base class like CloexecCheck,
maybe all 8 "Add a close-on-exec check" CLs can be combined into 1 or 2 CLs
to consolidate all review efforts.
I also prefer a separate check name for each function,
so users can enable/disable each check.

Jul 17 2017, 11:09 AM · Restricted Project

Jul 12 2017

chh committed rL307810: [clang-tidy] add regression test to performance-unnecessary-value-param.
[clang-tidy] add regression test to performance-unnecessary-value-param
Jul 12 2017, 9:27 AM
chh closed D35225: [clang-tidy] add regression test to performance-unnecessary-value-param by committing rL307810: [clang-tidy] add regression test to performance-unnecessary-value-param.
Jul 12 2017, 9:27 AM
chh committed rL307809: [clang] buildFixItInsertionLine should use Hints of the same FID and LineNo.
[clang] buildFixItInsertionLine should use Hints of the same FID and LineNo
Jul 12 2017, 9:26 AM
chh closed D35230: [clang] buildFixItInsertionLine should use Hints of the same FID and LineNo by committing rL307809: [clang] buildFixItInsertionLine should use Hints of the same FID and LineNo.
Jul 12 2017, 9:26 AM

Jul 11 2017

chh added inline comments to D35230: [clang] buildFixItInsertionLine should use Hints of the same FID and LineNo.
Jul 11 2017, 3:58 PM