Submitted in https://github.com/llvm/llvm-www/commit/bb31bb948a03102c5cfd0f335a2e22ec43387359

This looks good to me now, except maybe for the wording change suggested by jhenderson.

In D70743#1762664, @fhahn wrote:

In D70743#1762609, @fhahn wrote:

In D70743#1762558, @meikeb wrote:

Great addition! Could you add a "Contributing" section with a link to CONTRIBUTING.md to README.md for better visibility?

Yes that was one change I wanted to do as a follow up. But I can add it here as well!

I've added a reference to CONTRIBUTING.md to the README. I am undecided if it's better to link to CONTRIBUTING.md or Contributing.html directly. Given that CONTRIBUTING.md mostly just links to Contributing.html, should we link directly to that page? What do you think?

Great addition! Could you add a "Contributing" section with a link to CONTRIBUTING.md to README.md for better visibility?

I'll leave the long-form for now as I'm not sure long-term is what we want to imply. If someone comes up with better wording, we can always change it again.

Thank you for the feedback. I re-positioned Discord and named the new sections proposals.

I agree that it would make sense to add that to the dev resources section, but probably in a separate commit.

.

Rebase

Try to drop randomly uploaded commit.

Rebase to current commit.

Fix typos in commit message.

This is the same as D23820 besides that I added myself in the commit message as "Patch by". D23820 was reverted in D24579 because srhines' commit took authorship of this patch.

Thanks for reviewing my patch! It would be great if someone could submit this patch for me.

Correct assert position in offset sum helper function.

Try to improve offset sum helper function name and fix style issues.

I explained why I chose the names that you commented on. Feel free to add your thoughts if you still think another name would be more fitting.

Fix typos and add assert to sum up offset helper.

Thanks for taking the time and doing these great reviews! Really appreciated!

Fix mentioned issues.

Fix the mentioned issues.

Fix typo.