Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D47360

Implement <memory_resource> as a copy of <experimental/memory_resource>.
AbandonedPublic
Actions

Authored by • Quuxplusone on May 24 2018, 11:49 PM.

Details

Reviewers

EricWF
mclow.lists
serge-sans-paille

Summary

Depends on D46806 D47109 D47344 D47111 D47358

Even with all the above prep work to make <experimental/memory_resource> look just like <memory_resource>, this is still a huge diff.

Diff Detail

Repository: rCXX libc++

Event Timeline

• Quuxplusone created this revision.May 24 2018, 11:49 PM

Herald added subscribers: cfe-commits, christof. · View Herald TranscriptMay 24 2018, 11:49 PM

• Quuxplusone mentioned this in D47090: Implement C++17 <memory_resource>..May 24 2018, 11:50 PM

• Quuxplusone mentioned this in D46807: Rename test_memory_resource.hpp -> test_experimental_memory_resource.hpp. NFC..

• Quuxplusone added a reviewer: mclow.lists.May 26 2018, 9:48 PM

Once the dependencies (D47111 and D47358) are merged, I need to update the unit tests in this patch to reflect the unit tests that were committed. Right now, the unit tests in this patch reflect an old, out-of-date snapshot of what had been in those patches a couple weeks ago.

include/__memory_resource_base
54	This should be `#include <__tuple>`
include/memory_resource
48	This line should be gone.

Clean some minor cruft from src/experimental/memory_resource.cpp. (This part is a separate git commit which I could pull-request if you want it separately.)

I wonder if memory_resource needs a key function for its vtable; consider the precedent of D27387. But out-of-lining a trivial destructor just to avoid -Wweak-vtables feels kind of awful.

Experimental and std differ in their implementation of options() because the latter needs to be compileable as -std=c++11 whereas the former gets to use -std=c++14.

Herald added subscribers: ldionne, mgrang, mgorny. · View Herald TranscriptJul 3 2018, 2:33 AM

• Quuxplusone marked 2 inline comments as done.Jul 3 2018, 2:34 AM

@EricWF ping? (and D47344 D47111 D47358)

Herald added subscribers: libcxx-commits, jfb. · View Herald TranscriptNov 20 2018, 7:10 AM

Rebased on master. Added to <version> by updating and running the Python script.

Herald added a reviewer: serge-sans-paille. · View Herald TranscriptFeb 4 2019, 10:07 PM

Rebased on master.

The previous patch had replaced test/support/test_memory_resource.hpp with the two files test/support/test_experimental_memory_resource.hpp and test/support/test_memory_resource.hpp (and edited all the experimental tests to use the former).

This new patch replaces test/support/test_memory_resource.h with the two files test/support/test_memory_resource.h and test/support/test_std_memory_resource.h (which reduces the diff by leaving the experimental tests untouched in this patch).

Oops, fix one last include of an ".hpp" support file which was recently renamed to ".h".

• Quuxplusone mentioned this in D89057: Add the C++17 <memory_resource> header (mono-patch).Oct 8 2020, 10:21 AM

Superseded by D89057.

ldionne mentioned this in rG243da90ea535: [libc++] Add the C++17 <memory_resource> header (mono-patch).Oct 11 2022, 5:41 AM

Revision Contents
Changeset List

Path

Size

docs/

FeatureTestMacroTable.rst

2 lines

include/

2 lines

__memory_resource_base

315 lines

14 lines

14 lines

14 lines

17 lines

memory_resource

359 lines

module.modulemap

5 lines

19 lines

17 lines

19 lines

17 lines

17 lines

14 lines

2 lines

src/

1 line

memory_resource.cpp

567 lines

test/

libcxx/

double_include.sh.cpp

1 line

min_max_macros.sh.cpp

2 lines

utilities/

utility/

mem.res/

mem.poly.allocator.class/

mem.poly.allocator.mem/

construct_piecewise_pair.pass.cpp

173 lines

db_deallocate.pass.cpp

44 lines

mem.res.monotonic.buffer/

mem.res.monotonic.buffer.mem/

allocate_in_geometric_progression.pass.cpp

34 lines

mem.res.pool/

unsynchronized_buffer.pass.cpp

209 lines

std/

language.support/

support.limits/

support.limits.general/

memory_resource.version.pass.cpp

58 lines

version.version.pass.cpp

32 lines

utilities/

utility/

mem.res/

mem.poly.allocator.class/

mem.poly.allocator.ctor/

assign.pass.cpp

29 lines

48 lines

default.pass.cpp

50 lines

memory_resource_convert.pass.cpp

47 lines

other_alloc.pass.cpp

57 lines

mem.poly.allocator.eq/

135 lines

not_equal.pass.cpp

106 lines

mem.poly.allocator.mem/

allocate.pass.cpp

113 lines

construct_pair.pass.cpp

54 lines

construct_pair_const_lvalue_pair.pass.cpp

139 lines

construct_pair_rvalue.pass.cpp

134 lines

construct_pair_values.pass.cpp

140 lines

construct_piecewise_pair.pass.cpp

154 lines

construct_piecewise_pair_evil.pass.cpp

141 lines

construct_types.pass.cpp

190 lines

deallocate.pass.cpp

63 lines

destroy.pass.cpp

53 lines

resource.pass.cpp

58 lines

select_on_container_copy_construction.pass.cpp

54 lines

mem.res.aliases/

header_deque_synop.pass.cpp

35 lines

header_forward_list_synop.pass.cpp

35 lines

header_list_synop.pass.cpp

35 lines

header_list_synop2.pass.cpp

30 lines

header_map_synop.pass.cpp

67 lines

header_regex_synop.pass.cpp

55 lines

header_set_synop.pass.cpp

65 lines

header_string_synop.pass.cpp

73 lines

header_string_synop2.pass.cpp

36 lines

header_unordered_map_synop.pass.cpp

85 lines

header_unordered_set_synop.pass.cpp

83 lines

header_vector_synop.pass.cpp

35 lines

mem.res.global/

default_resource.pass.cpp

75 lines

new_delete_resource.pass.cpp

103 lines

null_memory_resource.pass.cpp

117 lines

mem.res.monotonic.buffer/

mem.res.monotonic.buffer.ctor/

copy_move.pass.cpp

28 lines

with_default_resource.pass.cpp

44 lines

without_buffer.pass.cpp

38 lines

mem.res.monotonic.buffer.mem/

allocate_deallocate.pass.cpp

56 lines

allocate_exception_safety.pass.cpp

75 lines

allocate_from_initial_buffer.pass.cpp

55 lines

allocate_from_underaligned_buffer.pass.cpp

56 lines

allocate_from_zero_sized_buffer.pass.cpp

45 lines

allocate_in_geometric_progression.pass.cpp

54 lines

allocate_overaligned_request.pass.cpp

48 lines

allocate_with_initial_size.pass.cpp

50 lines

equality.pass.cpp

61 lines

mem.res.pool/

mem.res.pool.ctor/

ctor_does_not_allocate.pass.cpp

46 lines

sync_with_default_resource.pass.cpp

40 lines

unsync_with_default_resource.pass.cpp

40 lines

mem.res.pool.mem/

equality.pass.cpp

70 lines

sync_allocate.pass.cpp

50 lines

sync_allocate_overaligned_request.pass.cpp

54 lines

sync_allocate_reuse_blocks.pass.cpp

53 lines

sync_deallocate_matches_allocate.pass.cpp

109 lines

unsync_allocate.pass.cpp

50 lines

unsync_allocate_overaligned_request.pass.cpp

54 lines

unsync_allocate_reuse_blocks.pass.cpp

53 lines

unsync_deallocate_matches_allocate.pass.cpp

109 lines

mem.res/

construct.fail.cpp

25 lines

mem.res.eq/

76 lines

not_equal.pass.cpp

75 lines

mem.res.private/

private_members.fail.cpp

27 lines

protected_members.fail.cpp

47 lines

mem.res.public/

allocate.pass.cpp

89 lines

deallocate.pass.cpp

74 lines

59 lines

is_equal.pass.cpp

93 lines

support/

test_std_memory_resource.h

162 lines

utils/

generate_feature_test_macro_components.py

1 line

Diff 219818

docs/FeatureTestMacroTable.rst

Loading...

include/CMakeLists.txt

Loading...

include/__memory_resource_base

Loading...

include/deque

Loading...

include/forward_list

Loading...

include/list

Loading...

include/map

Loading...

include/memory_resource

Loading...

include/module.modulemap

Loading...

include/regex

Loading...

include/set

Loading...

include/string

Loading...

include/unordered_map

Loading...

include/unordered_set

Loading...

include/vector

Loading...

include/version

Loading...

src/CMakeLists.txt

Loading...

src/memory_resource.cpp

Loading...

test/libcxx/double_include.sh.cpp

Loading...

test/libcxx/min_max_macros.sh.cpp

Loading...

test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp

Loading...

test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/db_deallocate.pass.cpp

Loading...

test/libcxx/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_in_geometric_progression.pass.cpp

Loading...

test/libcxx/utilities/utility/mem.res/mem.res.pool/unsynchronized_buffer.pass.cpp

Loading...

test/std/language.support/support.limits/support.limits.general/memory_resource.version.pass.cpp

Loading...

test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.ctor/assign.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.ctor/copy.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.ctor/default.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.ctor/memory_resource_convert.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.ctor/other_alloc.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.eq/equal.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.eq/not_equal.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/allocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_pair.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_pair_const_lvalue_pair.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_pair_rvalue.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_pair_values.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair_evil.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_types.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/deallocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/destroy.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/resource.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/select_on_container_copy_construction.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_deque_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_forward_list_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_list_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_list_synop2.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_map_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_regex_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_set_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_string_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_string_synop2.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_unordered_map_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_unordered_set_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.aliases/header_vector_synop.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.global/default_resource.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.global/new_delete_resource.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.global/null_memory_resource.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.ctor/copy_move.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.ctor/with_default_resource.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.ctor/without_buffer.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_deallocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_exception_safety.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_from_initial_buffer.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_from_underaligned_buffer.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_from_zero_sized_buffer.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_in_geometric_progression.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_overaligned_request.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/allocate_with_initial_size.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.monotonic.buffer/mem.res.monotonic.buffer.mem/equality.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.ctor/ctor_does_not_allocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.ctor/sync_with_default_resource.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.ctor/unsync_with_default_resource.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/equality.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/sync_allocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/sync_allocate_overaligned_request.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/sync_allocate_reuse_blocks.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/sync_deallocate_matches_allocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/unsync_allocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/unsync_allocate_overaligned_request.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/unsync_allocate_reuse_blocks.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/unsync_deallocate_matches_allocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/construct.fail.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.eq/equal.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.eq/not_equal.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.private/private_members.fail.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.private/protected_members.fail.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.public/allocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.public/deallocate.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.public/dtor.pass.cpp

Loading...

test/std/utilities/utility/mem.res/mem.res/mem.res.public/is_equal.pass.cpp

Loading...

test/support/test_std_memory_resource.h

Loading...

utils/generate_feature_test_macro_components.py

Loading...