Page MenuHomePhabricator

LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"
ClosedPublic

Authored by Quuxplusone on May 19 2018, 12:16 PM.

Details

Reviewers
EricWF
Summary

In the TS, uses_allocator construction for pair tried to use an allocator type of memory_resource*, which is incorrect because memory_resource* is not an allocator type. LWG 2969 fixed it to use polymorphic_allocator as the allocator type instead.
https://wg21.link/lwg2969

(D47090 included this in <memory_resource>; at Eric's request, I've split this out into its own patch applied to the existing <experimental/memory_resource> instead.)

Diff Detail

Repository
rCXX libc++

Event Timeline

Quuxplusone created this revision.May 19 2018, 12:16 PM

Fix two more tests hiding in test/libcxx/, and give -U999 context.

EricWF accepted this revision.May 19 2018, 12:33 PM

This LGTM. Let's land it and see if anybody complains.

This revision is now accepted and ready to land.May 19 2018, 12:33 PM

This LGTM. Let's land it and see if anybody complains.

Sounds good to me. I don't have commit privs so could you land it for me?
(Besides, I'm happy for you to get the blame if it *does* break someone's code, as I suspect it might. ;))

Sounds good to me. I don't have commit privs so could you land it for me?

@EricWF ping!

EricWF closed this revision.May 28 2018, 5:13 PM

Committed as r333384.

We also need to mark this off in the status. I can do that in D58879 or create a separate patch.

We also need to mark this off in the status. I can do that in D58879 or create a separate patch.

Good catch! Either is fine with me but I bet a separate patch would be more appropriate.