This is an archive of the discontinued LLVM Phabricator instance.

Add basic compiler-rt builtins support for hexagon
ClosedPublic

Authored by sidneym on May 2 2018, 12:48 PM.

Diff Detail

Event Timeline

sidneym created this revision.May 2 2018, 12:48 PM
Herald added subscribers: Restricted Project, aheejin, mgorny, dberris. · View Herald TranscriptMay 2 2018, 12:48 PM
bcain added a subscriber: bcain.May 3 2018, 7:39 AM
kparzysz added inline comments.May 3 2018, 11:52 AM
lib/builtins/hexagon/dfaddsub.S
405

This is always false. Please remove these checks.

sidneym added inline comments.May 3 2018, 12:48 PM
lib/builtins/hexagon/dfaddsub.S
405

I left them here in the event this library is ever used for a v61 target.

kparzysz requested changes to this revision.May 3 2018, 12:53 PM
kparzysz added inline comments.
lib/builtins/hexagon/dfaddsub.S
405

That will never happen.

This revision now requires changes to proceed.May 3 2018, 12:53 PM
sidneym updated this revision to Diff 145087.May 3 2018, 1:31 PM
kparzysz accepted this revision.May 3 2018, 1:36 PM

LGTM

This revision is now accepted and ready to land.May 3 2018, 1:36 PM
bcain accepted this revision.May 8 2018, 11:24 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.