Page MenuHomePhabricator

adasgupt (Anshu Dasgupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2014, 12:31 PM (272 w, 3 d)

Recent Activity

Mar 11 2015

adasgupt accepted D8204: [hexagon] Distinguish the 'o', 'v', and 'm' inline assembly memory constraints..
Mar 11 2015, 11:41 AM

Oct 14 2014

adasgupt accepted D5734: Enable the instruction printer in HexagonMCTargetDesc.
Oct 14 2014, 3:07 PM

Oct 3 2014

adasgupt accepted D5600: Fix build break on Hexagon.
Oct 3 2014, 7:03 AM

Sep 9 2014

adasgupt accepted D5255: Add missing HWEncoding to base register class..

LGTM. Discussed this with Sid offline and tests will be added as part of adding the encodings.

Sep 9 2014, 7:12 AM

Aug 25 2014

adasgupt accepted D5025: Minor spelling correction..
Aug 25 2014, 8:46 AM

May 19 2014

adasgupt accepted D3765: TableGen: allow non-leaf ComplexPatterns.

LGTM. Jyotsna looked at the patch and she is okay with the Hexagon changes as well.

May 19 2014, 10:48 AM
adasgupt accepted D3803: Hexagon: Add encoding bits for halfword signed/unsigned mulitply with add/subtract..
May 19 2014, 9:28 AM

May 16 2014

adasgupt added a comment to D3803: Hexagon: Add encoding bits for halfword signed/unsigned mulitply with add/subtract..

Line 137 - remove "Is Dwarf number correct comment" and on the following lines as well.

May 16 2014, 9:29 AM
adasgupt accepted D3802: Hexagon: Add encoding bits to mpy instructions..

Jyotsna - these patches look good. Go ahead and commit the remaining patches that add encoding bits to Hexagon after testing.

May 16 2014, 9:26 AM
adasgupt accepted D3804: Hexagon: Add encoding bits for vector multiply instructions..
May 16 2014, 9:24 AM
adasgupt accepted D3805: Hexagon: Add encoding for vector multiply instructions with accumulation..
May 16 2014, 9:19 AM

May 14 2014

adasgupt added a comment to D3765: TableGen: allow non-leaf ComplexPatterns.

Thanks for identifying the bug and providing a fix, Tim. We'll take a look at the Hexagon bugfix.

May 14 2014, 10:32 AM
adasgupt accepted D3516: [Hexagon] [Hexagon] Add New TSFlags to be used in the upcoming patches..
May 14 2014, 10:14 AM

May 2 2014

adasgupt accepted D3517: [Hexagon] Add new InstrItinClass to support timing classes..

Okay, please remember to add tests when you add v5 support. It need not be an elaborate set though that would be even better :)). We should have tests to ensure that the timing classes are actually consumed and used in codegen.

May 2 2014, 12:31 PM
adasgupt added a comment to D3516: [Hexagon] [Hexagon] Add New TSFlags to be used in the upcoming patches..

LGTM.

May 2 2014, 9:28 AM
adasgupt added a comment to D3517: [Hexagon] Add new InstrItinClass to support timing classes..

Test cases: Can you capture the change in timing classes as a scheduling change that can be tested?

May 2 2014, 9:27 AM