Page MenuHomePhabricator

azharudd (Azharuddin Mohammed)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2016, 11:11 AM (136 w, 6 d)

Recent Activity

Nov 1 2018

azharudd added a comment to D53912: [Headers] [MS] Add intrin0.h.
In D53912#1281584, @rnk wrote:

This sounds like it would defeat what I'm assuming is the intended purpose of intrin0.h, which is to reduce compile time. intrin.h is kind of enormous, and the compile time problems are well-documented. We should investigate what's up with intrin0.h and implement as many builtins as we need to support it.

Nov 1 2018, 4:30 PM

Oct 30 2018

azharudd created D53912: [Headers] [MS] Add intrin0.h.
Oct 30 2018, 4:50 PM

Oct 5 2018

azharudd added a comment to D51804: [CMake] Fix LTO option on Windows.

CMAKE_LINKER MATCHES "lld-link\.exe"

@aganea, can you please elaborate on the need for the backslash that you added?

Oct 5 2018, 6:17 PM

Sep 24 2018

azharudd added a reviewer for D52144: use __ARM_FP instead of __VFP_FP__: peter.smith.
Sep 24 2018, 12:01 PM

Sep 13 2018

azharudd committed rLLD342145: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Add missing REQUIRES x86 to test/COFF/icf-safe.s
Sep 13 2018, 8:43 AM
azharudd committed rL342145: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Add missing REQUIRES x86 to test/COFF/icf-safe.s
Sep 13 2018, 8:43 AM
azharudd closed D51764: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Sep 13 2018, 8:43 AM
azharudd committed rLLD342144: Fix typo in error message. NFC..
Fix typo in error message. NFC.
Sep 13 2018, 8:40 AM
azharudd added a comment to D51764: Add missing REQUIRES x86 to test/COFF/icf-safe.s.

Thanks for the review @ruiu.

Sep 13 2018, 8:39 AM
azharudd committed rL342144: Fix typo in error message. NFC..
Fix typo in error message. NFC.
Sep 13 2018, 8:38 AM
azharudd closed D51767: Fix typo in error message. NFC..
Sep 13 2018, 8:38 AM
azharudd added a comment to D51767: Fix typo in error message. NFC..

Thanks for the review @ruiu.

Sep 13 2018, 8:37 AM

Sep 6 2018

azharudd created D51767: Fix typo in error message. NFC..
Sep 6 2018, 5:51 PM
azharudd created D51764: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Sep 6 2018, 5:08 PM

Aug 8 2018

azharudd added a reviewer for D50431: generalize SKS key server in debian8 Dockerfile: ilya-biryukov.

Adding Ilya who is the original author of that file.

Aug 8 2018, 4:06 PM

Jul 30 2018

azharudd committed rCRT338284: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
[cmake] [ARM] Exclude any VFP builtins if VFP is not supported
Jul 30 2018, 11:20 AM
azharudd committed rL338284: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
[cmake] [ARM] Exclude any VFP builtins if VFP is not supported
Jul 30 2018, 11:19 AM
azharudd closed D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
Jul 30 2018, 11:19 AM
azharudd added a comment to D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

@peter.smith Thanks for the review.

Jul 30 2018, 11:17 AM

Jul 27 2018

azharudd added a comment to D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

Ping for review please.

Jul 27 2018, 9:53 AM

Jul 24 2018

azharudd committed rL337842: [docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value.
[docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value
Jul 24 2018, 11:34 AM
azharudd closed D49712: [docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value.
Jul 24 2018, 11:34 AM

Jul 23 2018

azharudd created D49712: [docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value.
Jul 23 2018, 6:35 PM
azharudd updated the diff for D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

Updated to check if VFP is enabled for armhf too.

Jul 23 2018, 6:01 PM
azharudd added a comment to D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

Can you elaborate on why the armhf buildbot failed and why you have excluded armhf from the MATCHES expression above. A simple test of a source file containing

__VFP_FP__

clang --target=arm-linux-gnueabihf -E vfp.c gives me

# 1 "vfp.c"
# 1 "<built-in>" 1
# 1 "<built-in>" 3
# 361 "<built-in>" 3
# 1 "<command line>" 1
# 1 "<built-in>" 2
# 1 "vfp.c" 2
1

Unless I'm missing something a target of arm-linux-gnueabihf would define the macro unless the fpu were disabled with -mfpu=none so it should come through the test with the right answer.

Jul 23 2018, 6:01 PM
azharudd added a comment to D49397: Pass CMAKE_C_FLAGS to the custom libc++ build too.

What about C++ flags? libc++ is a C++ library so those are likely going to be important as well. Rather than lumping both C and C++ flags together into a single variable, we should probably consider adding two new keyword arguments to add_custom_libcxx, CMAKE_C_FLAGS and CMAKE_CXX_FLAGS, and use those to pass C and C++ flags separately to libc++ build.

Jul 23 2018, 12:26 PM

Jul 16 2018

azharudd created D49397: Pass CMAKE_C_FLAGS to the custom libc++ build too.
Jul 16 2018, 12:23 PM
azharudd requested review of D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
Jul 16 2018, 12:03 PM
azharudd updated the diff for D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

I had to revert this last time as it was causing the armhf buildbot to fail. This should take care of that.

Jul 16 2018, 12:03 PM
azharudd retitled D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported from [cmake] [ARM] Check if VFP is supported before including any VFP builtins to [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
Jul 16 2018, 12:00 PM
azharudd reopened D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
Jul 16 2018, 11:57 AM

Jul 15 2018

azharudd committed rOMP337133: [cmake] Fix libomptarget/test/CMakeLists.txt.
[cmake] Fix libomptarget/test/CMakeLists.txt
Jul 15 2018, 10:38 AM
azharudd committed rL337133: [cmake] Fix libomptarget/test/CMakeLists.txt.
[cmake] Fix libomptarget/test/CMakeLists.txt
Jul 15 2018, 10:34 AM
azharudd closed D47221: [cmake] Fix libomptarget/test/CMakeLists.txt.
Jul 15 2018, 10:34 AM

May 31 2018

azharudd added a comment to D47224: [cmake] Guard another instance where symlinks are being created.

I'm not sure about this patch: These commands do not install the aliases, they are created in the build directory and may be needed for testing.

May 31 2018, 3:09 PM

May 24 2018

azharudd committed rL333232: Revert "[cmake] [ARM] Check if VFP is supported before including any VFP….
Revert "[cmake] [ARM] Check if VFP is supported before including any VFP…
May 24 2018, 2:42 PM
azharudd committed rCRT333232: Revert "[cmake] [ARM] Check if VFP is supported before including any VFP….
Revert "[cmake] [ARM] Check if VFP is supported before including any VFP…
May 24 2018, 2:42 PM
azharudd added a comment to D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

@peter.smith Thanks for the review.

May 24 2018, 11:58 AM
azharudd committed rCRT333216: [cmake] [ARM] Check if VFP is supported before including any VFP builtins.
[cmake] [ARM] Check if VFP is supported before including any VFP builtins
May 24 2018, 11:57 AM
azharudd committed rL333216: [cmake] [ARM] Check if VFP is supported before including any VFP builtins.
[cmake] [ARM] Check if VFP is supported before including any VFP builtins
May 24 2018, 11:57 AM
azharudd closed D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
May 24 2018, 11:57 AM

May 23 2018

azharudd updated the diff for D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
May 23 2018, 12:45 PM

May 22 2018

azharudd created D47224: [cmake] Guard another instance where symlinks are being created.
May 22 2018, 1:36 PM
azharudd created D47221: [cmake] Fix libomptarget/test/CMakeLists.txt.
May 22 2018, 1:14 PM
azharudd created D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
May 22 2018, 12:35 PM

Mar 13 2018

azharudd committed rL327423: Build system changes for RISCV.
Build system changes for RISCV
Mar 13 2018, 10:07 AM
azharudd closed D44153: Build system changes for RISCV.
Mar 13 2018, 10:07 AM
azharudd added a comment to D44153: Build system changes for RISCV.
In D44153#1031969, @asb wrote:

Hi Azharuddin, many thanks for the contribution. I hadn't spotted this part of LLVM's CMake build system, and it's definitely useful to be able to build just the RISCV backend. I've tried this locally, and the problem I'm seeing is that a good number of Clang and LLVM tests fail when you don't build X86 support. On my system, 351 unexpected failures across Clang+LLVM. This is a problem with the tests rather than this patch (they should really be disabled if there is no X86 support), but it does limit the usefulness of just building _only_ the RISC-V backend. Is it expected that you build an LLVM with X86 and RISCV, ensure 100% tests pass, then build with just the RISCV backend and ignore any new failures?

The problems I'm seeing aren't introduced by this patch, so LGTM. I'd be curious on how/if you work around the tests issue though.

Mar 13 2018, 9:47 AM
azharudd added a comment to D44153: Build system changes for RISCV.
In D44153#1031976, @asb wrote:

Actually, looking again I'm not having any problems building just the RISCV backend even without this patch. e.g. an invocation like the following seems fine:

cmake -G Ninja -DCMAKE_BUILD_TYPE="Debug" \
  -DBUILD_SHARED_LIBS=True -DLLVM_USE_SPLIT_DWARF=True \
  -DLLVM_OPTIMIZED_TABLEGEN=True \
  -DLLVM_BUILD_TESTS=True \
  -DLLVM_TARGETS_TO_BUILD="RISCV" \
  -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="RISCV" ../
cmake --build .

Could you please clarify exactly which build problems this fixes?

Mar 13 2018, 9:29 AM

Mar 6 2018

azharudd created D44153: Build system changes for RISCV.
Mar 6 2018, 7:56 AM

Jan 3 2018

azharudd committed rCRT321760: [cmake] Fix typo in test/asan/CMakeLists.txt.
[cmake] Fix typo in test/asan/CMakeLists.txt
Jan 3 2018, 1:31 PM
azharudd committed rL321760: [cmake] Fix typo in test/asan/CMakeLists.txt.
[cmake] Fix typo in test/asan/CMakeLists.txt
Jan 3 2018, 1:31 PM
azharudd closed D41214: [cmake] Fix typo in test/asan/CMakeLists.txt.
Jan 3 2018, 1:31 PM
azharudd added a comment to D41214: [cmake] Fix typo in test/asan/CMakeLists.txt.

Thanks for the review @smeenai .

Jan 3 2018, 1:21 PM
azharudd added a comment to D41214: [cmake] Fix typo in test/asan/CMakeLists.txt.

The two should be equivalent unless CMAKE_SYSTEM_VERSION expands out to a value that's a variable name (which is unlikely, since it should be expanding out to a number), but this is cleaner and more consistent.

Jan 3 2018, 1:19 PM

Jan 2 2018

azharudd added reviewers for D41214: [cmake] Fix typo in test/asan/CMakeLists.txt: smeenai, beanz.
Jan 2 2018, 12:00 PM

Dec 13 2017

azharudd updated the summary of D41214: [cmake] Fix typo in test/asan/CMakeLists.txt.
Dec 13 2017, 5:39 PM
azharudd created D41214: [cmake] Fix typo in test/asan/CMakeLists.txt.
Dec 13 2017, 5:37 PM

Nov 16 2017

azharudd committed rL318437: Fix RISCV build after r318352.
Fix RISCV build after r318352
Nov 16 2017, 10:40 AM
azharudd closed D40139: Fix RISCV build after r318352 by committing rL318437: Fix RISCV build after r318352.
Nov 16 2017, 10:39 AM
azharudd created D40139: Fix RISCV build after r318352.
Nov 16 2017, 10:22 AM

Mar 12 2017

azharudd committed rL297582: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.
Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg
Mar 12 2017, 7:14 AM
azharudd closed D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg by committing rL297582: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.
Mar 12 2017, 7:14 AM

Mar 7 2017

azharudd added a comment to D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.

Hi, right, so Tim has approved it on the mailing list, which didn't get transferred here.

But he also said an additional interesting point why you have to use mcpu and not another mattr: this is a code path that only triggers with A53 because of its scheduler.

LGTM, too. Can you just add the scheduler info (instead of just saying it hits with A53) on the commit line?

thanks!

Mar 7 2017, 10:30 AM
azharudd added a comment to D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.

Can you update the context around using git diff -U999?

Mar 7 2017, 10:28 AM
azharudd updated the diff for D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.

Updated the context around the change.

Mar 7 2017, 10:27 AM
azharudd updated the summary of D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.
Mar 7 2017, 10:26 AM

Mar 2 2017

azharudd updated the summary of D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.
Mar 2 2017, 3:42 PM
azharudd updated the summary of D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.
Mar 2 2017, 3:42 PM
azharudd updated the summary of D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.
Mar 2 2017, 3:41 PM

Feb 22 2017

azharudd added a reviewer for D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg: rengolin.
Feb 22 2017, 2:35 PM
azharudd created D30274: Remove CRC32 instructions from AArch64InstrInfo::hasShiftedReg.
Feb 22 2017, 2:34 PM

Nov 7 2016

azharudd added a reviewer for D26289: [CMake] Fix llvm_setup_rpath function: sgundapa.
Nov 7 2016, 1:18 PM
azharudd added a comment to D26289: [CMake] Fix llvm_setup_rpath function.

I think there is actually a more general solution to this. At the top of the function we can just have:

if(CMAKE_INSTALL_RPATH)
  return()
endif()

Then we can remove the conditionals on CMAKE_INSTALL_RPATH, and just allow the target to inherit from the global setting, which is the default.

Nov 7 2016, 12:57 PM
azharudd updated the diff for D26289: [CMake] Fix llvm_setup_rpath function.
Nov 7 2016, 12:51 PM

Nov 3 2016

azharudd updated D26289: [CMake] Fix llvm_setup_rpath function.
Nov 3 2016, 2:03 PM
azharudd retitled D26289: [CMake] Fix llvm_setup_rpath function from to [CMake] Fix llvm_setup_rpath function.
Nov 3 2016, 2:02 PM

Oct 27 2016

azharudd added reviewers for D25994: Set default values before conditionals: hfinkel, MatzeB.
Oct 27 2016, 1:07 PM
azharudd added a reviewer for D25994: Set default values before conditionals: mgrang.
Oct 27 2016, 12:57 PM
azharudd abandoned D25743: Teach llvm-config about default sysroot..
Oct 27 2016, 11:13 AM
azharudd added a reviewer for D25967: Avoid running regex on None: mgrang.
Oct 27 2016, 11:02 AM

Oct 26 2016

azharudd retitled D25994: Set default values before conditionals from to Set default values before conditionals.
Oct 26 2016, 8:48 AM

Oct 25 2016

azharudd added a comment to D25967: Avoid running regex on None.

Chris, can you please commit this change. I do not have commit rights yet. Thanks.

Oct 25 2016, 4:47 PM
azharudd added inline comments to D25967: Avoid running regex on None.
Oct 25 2016, 2:33 PM
azharudd retitled D25967: Avoid running regex on None from to Avoid running regex on None.
Oct 25 2016, 2:29 PM
azharudd added a comment to D25743: Teach llvm-config about default sysroot..

I don't understand what you're doing here, or the justification for it. The LLVM build system has no concept of a default sysroot, and I'm not sure I understand why you're creating one. Please explain what you're trying to do and why you feel that you need this.

Oct 25 2016, 11:37 AM

Oct 18 2016

azharudd added reviewers for D25743: Teach llvm-config about default sysroot.: ddunbar, chapuni.
Oct 18 2016, 1:02 PM
azharudd retitled D25743: Teach llvm-config about default sysroot. from to Teach llvm-config about default sysroot..
Oct 18 2016, 12:56 PM
azharudd updated D25574: Fix clang tests.
Oct 18 2016, 12:27 PM

Oct 13 2016

azharudd changed the visibility for D25574: Fix clang tests.
Oct 13 2016, 1:12 PM
azharudd added a reviewer for D25574: Fix clang tests: rsmith.
Oct 13 2016, 1:11 PM
azharudd updated the diff for D25574: Fix clang tests.
Oct 13 2016, 1:07 PM
azharudd retitled D25574: Fix clang tests from to Fix clang tests.
Oct 13 2016, 1:04 PM