Page MenuHomePhabricator

azharudd (Azharuddin Mohammed)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2016, 11:11 AM (317 w, 1 d)

Recent Activity

Apr 26 2022

azharudd added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

In this case I'm just trying to make it work with existing build configurations where it is being used (for example Swift). We should definitely be moving away from LLVM_BUILD_EXTERNAL_COMPILER_RT in favor of LLVM_ENABLE_RUNTIMES eventually though.

My point here is that maybe you should move away from the legacy way of building now rather than improving it... Not sure how @phosek feels about this. I would personally very much prefer if we only had one way to build compiler-rt instead of the half dozen we have today.

Apr 26 2022, 2:25 PM · Restricted Project, Restricted Project
azharudd added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

I question whether we should be extending this or killing it off... Is there a reason you're using LLVM_BUILD_EXTERNAL_COMPILER_RT instead of LLVM_ENABLE_RUNTIMES=compiler-rt?

Apr 26 2022, 2:02 PM · Restricted Project, Restricted Project
azharudd requested review of D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.
Apr 26 2022, 1:03 PM · Restricted Project, Restricted Project

Feb 2 2022

azharudd committed rZORGa262f7ea9388: jenkins: Stop using sccache (authored by azharudd).
jenkins: Stop using sccache
Feb 2 2022, 11:10 AM

Jan 14 2022

azharudd committed rZORG13db08429e3a: jenkins: Pipeline for Sanitizer testing on iOS simulators (authored by azharudd).
jenkins: Pipeline for Sanitizer testing on iOS simulators
Jan 14 2022, 9:41 AM

Aug 23 2021

azharudd added a comment to D108294: [tsan] Disable Trace.MemoryAccessSize on Mac.

Thanks Alex! It was not just the MemoryAccessSize test, but the other unit tests were failing too. I disabled those as well in b4b8e1446a2ba1a25488ec5e6e927fa9b54cb4f8.

Aug 23 2021, 4:25 PM · Restricted Project
azharudd committed rGd898693f72fc: [ExecutionEngine] Use the libunwind __register_frame on Darwin (authored by azharudd).
[ExecutionEngine] Use the libunwind __register_frame on Darwin
Aug 23 2021, 2:54 PM

Aug 18 2021

azharudd committed rGb4b8e1446a2b: [tsan] Disable all Trace unit tests on Mac (authored by azharudd).
[tsan] Disable all Trace unit tests on Mac
Aug 18 2021, 11:49 AM
azharudd added a comment to D107911: tsan: add new trace.

The newly added unit tests are failing on Darwin. Can you please look into it? Would it possible to revert this until the issue is resolved?

Aug 18 2021, 2:06 AM · Restricted Project
azharudd committed rG593275c93c5c: Mark tsan cxa_guard_acquire test as unsupported on Darwin (authored by azharudd).
Mark tsan cxa_guard_acquire test as unsupported on Darwin
Aug 18 2021, 1:52 AM
azharudd added a comment to D107359: tsan: unify __cxa_guard_acquire and pthread_once implementations.

Let me go ahead and mark this test as unsupported on Darwin for now until we get it sorted out.

Aug 18 2021, 1:36 AM · Restricted Project
azharudd added a comment to D107359: tsan: unify __cxa_guard_acquire and pthread_once implementations.

@dvyukov, this appears to be causing test failure on Darwin. Can you please look into it.

Failed Tests (1):

ThreadSanitizer-x86_64 :: cxa_guard_acquire.cpp

https://green.lab.llvm.org/green/job/clang-stage1-RA/23006/testReport/junit/ThreadSanitizer-x86_64/ThreadSanitizer-x86_64/cxa_guard_acquire_cpp/

Humm... I've looked at this, but so far don't have any concrete ideas.

First, I see that this build also includes these 2 other changes that touched this code:
https://github.com/llvm/llvm-project/commit/0bc626d516a201953ef6a45be0d059d70672d7db
https://github.com/llvm/llvm-project/commit/e3f4c63e78b1ed54f0a35aeb30730e5c74bcfeed
here is build info:
https://green.lab.llvm.org/green/job/clang-stage1-RA/23006/

Also I see this is the only test that failed:
https://green.lab.llvm.org/green/job/clang-stage1-RA/23006/testReport/junit/ThreadSanitizer-x86_64/ThreadSanitizer-x86_64/

But it seems that we don't have any tests for pthread_once, so we can't say if this issue is related to cxa_guard_acquire specifically, or to both cxa_guard_acquire and pthread_once. That may have helped to narrow the problem down.

The only semantic change for __cxa_guard_acquire that I see is that we now test "!thr->in_ignored_lib" before doing Acquire/Release. But I don't see how _not_ calling these functions can cause any crashes...

OnPotentiallyBlockingRegionBegin/End was already present in __cxa_guard_acquire.

So for now I am puzzled...

Azharuddin, can you run this test under gdb and do a "bt", "disass" and "info registers" on SIGSEGV?

And FutexWait is the same sched_yield on mac as we had before in this code.

Aug 18 2021, 1:35 AM · Restricted Project

Aug 4 2021

azharudd added a comment to D107359: tsan: unify __cxa_guard_acquire and pthread_once implementations.

@dvyukov, this appears to be causing test failure on Darwin. Can you please look into it.

Aug 4 2021, 9:46 AM · Restricted Project

Jul 25 2021

azharudd committed rZORG56cd66e2a88d: jenkins: Fix the file path pattern for the test results XML files (authored by azharudd).
jenkins: Fix the file path pattern for the test results XML files
Jul 25 2021, 9:40 AM
azharudd committed rZORG3cdd95df20ac: jenkins: Stop uploading the compiler build artifacts to cloud storage (authored by azharudd).
jenkins: Stop uploading the compiler build artifacts to cloud storage
Jul 25 2021, 9:29 AM
azharudd committed rZORG8fe2367ba5b3: jenkins: cmake_builder and clang_builder: Ignore error in the test stage (authored by azharudd).
jenkins: cmake_builder and clang_builder: Ignore error in the test stage
Jul 25 2021, 8:52 AM

Jul 23 2021

azharudd committed rG8da3b7d85729: [CMake] Don't LTO optimize targets on Darwin, but only if its not ThinLTO (authored by azharudd).
[CMake] Don't LTO optimize targets on Darwin, but only if its not ThinLTO
Jul 23 2021, 10:40 PM
azharudd added a comment to D104764: [CMake] Don't LTO optimize targets on Darwin either.

@phosek, the config where I'm seeing this is a two stage bootstrap build. Could you try building again with the just built clang and see if it still works for you? I seem to be able to reliably reproduce the error locally.

Yes, that's what we use on our bots as well. However, I just noticed that your bots are using ThinLTO, is that correct? We always use full LTO and it's possible that this issue only manifests in ThinLTO.

Jul 23 2021, 4:11 PM · Restricted Project

Jul 22 2021

azharudd added a comment to D104764: [CMake] Don't LTO optimize targets on Darwin either.

Should this apply to Darwin even when not using LLD?

I'm seeing an error which tracks down to this change. It works fine without the -mllvm,-O0 link flags.

FAILED: bin/llvm-tblgen 
[...snip...]
Remaining virtual register operands
UNREACHABLE executed at .../llvm-project/llvm/lib/CodeGen/MachineRegisterInfo.cpp:209!
clang-13: error: unable to execute command: Abort trap: 6
clang-13: error: linker command failed due to signal (use -v to see invocation)

https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/4221/consoleFull

It should, ld64 supports passing flags to libLTO via the -mllvm flag. We have been using this on our macOS bots for a few weeks and haven't run into any issues (they are using using ld64, not lld).

Jul 22 2021, 12:10 AM · Restricted Project

Jul 21 2021

azharudd added a comment to D104764: [CMake] Don't LTO optimize targets on Darwin either.

Should this apply to Darwin even when not using LLD?

Jul 21 2021, 11:38 PM · Restricted Project

Jul 19 2021

azharudd added a comment to D106155: Reland "[benchmark] Re-enable building benchmark tests".

The error comes from gtest-port.cc which does #import <Foundation/Foundation.h>. Is it possible there is some C++/Objective C mixing issue here and we need to add some a flag or build option? (though if #import works at all it must have some understanding)

Ah, I see. Can we just disable benchmark testing for iOS?

Created https://reviews.llvm.org/D106281 - I don't have a iOS build setup, though, so it'd be good if someone verified this; or we can wait for it to land?

Jul 19 2021, 11:23 AM

Jul 16 2021

azharudd added a comment to D106155: Reland "[benchmark] Re-enable building benchmark tests".

This is failing for arm64 with iPhoneOS SDK.

Jul 16 2021, 7:48 PM

Jun 9 2021

azharudd committed rZORG5e5cb8bd8a1a: llvmbisect: Add support for monorepo artifacts (authored by azharudd).
llvmbisect: Add support for monorepo artifacts
Jun 9 2021, 9:40 PM

May 17 2021

azharudd committed rZORG92122d159f72: jenkins/tasks: virtualenv: Use the Python3 interpreter (authored by azharudd).
jenkins/tasks: virtualenv: Use the Python3 interpreter
May 17 2021, 2:57 PM

May 14 2021

azharudd added a comment to D102218: [NFC][LSAN] Limit the number of concurrent threads is the test.

This won't work on Darwin.

May 14 2021, 12:43 PM · Restricted Project

Apr 9 2021

azharudd added inline comments to D97389: added section on CI system.
Apr 9 2021, 10:16 AM · Restricted Project

Mar 17 2021

azharudd committed rZORG70a8255a6f8d: Revert "[jenkins] Temporarily disable compiler-rt tests until couple of tests… (authored by azharudd).
Revert "[jenkins] Temporarily disable compiler-rt tests until couple of tests…
Mar 17 2021, 1:29 PM
azharudd added a reverting change for rZORG33a9f3c59121: [jenkins] Temporarily disable compiler-rt tests until couple of tests are fixed: rZORG70a8255a6f8d: Revert "[jenkins] Temporarily disable compiler-rt tests until couple of tests….
Mar 17 2021, 1:29 PM
azharudd committed rZORG33a9f3c59121: [jenkins] Temporarily disable compiler-rt tests until couple of tests are fixed (authored by azharudd).
[jenkins] Temporarily disable compiler-rt tests until couple of tests are fixed
Mar 17 2021, 9:59 AM

Feb 24 2021

azharudd committed rZORGc81651376396: jenkins/jobs: Add timeout to the lnt-ctmark-* jobs (authored by azharudd).
jenkins/jobs: Add timeout to the lnt-ctmark-* jobs
Feb 24 2021, 8:43 PM
azharudd committed rZORGb8d41c307ba7: More master to main updates (authored by azharudd).
More master to main updates
Feb 24 2021, 8:24 PM

Feb 19 2021

azharudd committed rZORG4cb746c769b8: jenkins: More updates for "master" to "main" branch (authored by azharudd).
jenkins: More updates for "master" to "main" branch
Feb 19 2021, 2:43 PM

Feb 8 2021

azharudd committed rZORG1d4d24022c16: jenkins: Update branch names for the repos from "master" to "main" (authored by azharudd).
jenkins: Update branch names for the repos from "master" to "main"
Feb 8 2021, 1:10 PM

Jan 21 2021

azharudd committed rZORGdaab19c5e8ff: jenkins/jobs: Checking in Clang jobs pipelines (authored by azharudd).
jenkins/jobs: Checking in Clang jobs pipelines
Jan 21 2021, 12:55 PM

Dec 14 2020

azharudd added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

Could we revert this until we have a fix for the errors showing up on Darwin?

Dec 14 2020, 8:39 AM · Restricted Project

Dec 9 2020

azharudd committed rZORGa056a54d8b11: jenkins: Do not resume the pipelines if the master restarts (authored by azharudd).
jenkins: Do not resume the pipelines if the master restarts
Dec 9 2020, 11:53 AM

Sep 21 2020

azharudd committed rZORG76a1ebd3ccf6: jenkins/jobs: Move the lnt-ctmark-* jobs to green-dragon-12 (authored by azharudd).
jenkins/jobs: Move the lnt-ctmark-* jobs to green-dragon-12
Sep 21 2020, 10:51 AM
azharudd committed rZORG1e8d9e10ded4: LNT CTMark: Update default SUBMIT_NAME and add SUBMIT_ORDER (authored by azharudd).
LNT CTMark: Update default SUBMIT_NAME and add SUBMIT_ORDER
Sep 21 2020, 10:51 AM

Sep 10 2020

azharudd added a reverting change for rG01cdab0b335e: [gcov] Delete flush_fn_list (unused since D83149): rG626209cac055: Revert "[gcov] Delete flush_fn_list (unused since D83149)".
Sep 10 2020, 9:54 AM
azharudd committed rG626209cac055: Revert "[gcov] Delete flush_fn_list (unused since D83149)" (authored by azharudd).
Revert "[gcov] Delete flush_fn_list (unused since D83149)"
Sep 10 2020, 9:54 AM

Sep 8 2020

azharudd committed rGd95ef009bd50: Update clang/test/Driver/darwin-infer-simulator-sdkroot.c (authored by azharudd).
Update clang/test/Driver/darwin-infer-simulator-sdkroot.c
Sep 8 2020, 11:27 AM

Sep 2 2020

azharudd updated the summary of D87054: Include libcxx and libcxxabi tests in check-all.
Sep 2 2020, 1:45 PM · Restricted Project, Restricted Project
azharudd updated the summary of D87054: Include libcxx and libcxxabi tests in check-all.
Sep 2 2020, 1:42 PM · Restricted Project, Restricted Project
azharudd requested review of D87054: Include libcxx and libcxxabi tests in check-all.
Sep 2 2020, 1:40 PM · Restricted Project, Restricted Project

Aug 27 2020

azharudd committed rGd22985c41087: [Driver][XRay][test] Update the macOS support check (authored by azharudd).
[Driver][XRay][test] Update the macOS support check
Aug 27 2020, 2:06 PM
azharudd closed D85773: [Driver][XRay][test] Update the macOS support check.
Aug 27 2020, 2:06 PM · Restricted Project
azharudd added a comment to D85773: [Driver][XRay][test] Update the macOS support check.

LGTM from me if XRay actually does work on non-x86_64 macOS.

Aug 27 2020, 2:04 PM · Restricted Project
azharudd committed rZORGf36909d94d45: Allow lit test timeout value to be configurable (authored by azharudd).
Allow lit test timeout value to be configurable
Aug 27 2020, 1:22 AM
azharudd closed D85173: [zorg] build.py: Allow lit test timeout value to be configurable.
Aug 27 2020, 1:21 AM
azharudd added a comment to D85173: [zorg] build.py: Allow lit test timeout value to be configurable.

Merged in f36909d9. Thanks!

Aug 27 2020, 1:21 AM
azharudd accepted D85173: [zorg] build.py: Allow lit test timeout value to be configurable.
Aug 27 2020, 1:19 AM

Aug 25 2020

azharudd added a comment to D85554: [libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator..

Reverted this in 8831e34771fec4dfbe62a6e31d9bc9419a3b93c3 to get the bots green again. Please feel free to ping if you need someone to test this on macOS.

Could you try this patch again on top of https://reviews.llvm.org/D86247 which hopefully fixes the failing test on macOS?

Aug 25 2020, 12:26 PM · Restricted Project
azharudd added a comment to D85554: [libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator..

@dokyungs, looking into this now.

Aug 25 2020, 9:50 AM · Restricted Project

Aug 21 2020

azharudd committed rG6a64079699e7: Fix llvm/test/tools/lto/hide-linkonce-odr.ll (authored by azharudd).
Fix llvm/test/tools/lto/hide-linkonce-odr.ll
Aug 21 2020, 6:33 PM
azharudd added a comment to D85554: [libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator..

Reverted this in 8831e34771fec4dfbe62a6e31d9bc9419a3b93c3 to get the bots green again. Please feel free to ping if you need someone to test this on macOS.

Aug 21 2020, 10:04 AM · Restricted Project
azharudd added a reverting change for rGbb54bcf84970: [libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator.: rG8831e34771fe: Revert "[libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver….
Aug 21 2020, 10:01 AM
azharudd committed rG8831e34771fe: Revert "[libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver… (authored by azharudd).
Revert "[libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver…
Aug 21 2020, 10:01 AM
azharudd added a reverting change for D85554: [libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator.: rG8831e34771fe: Revert "[libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver….
Aug 21 2020, 10:01 AM · Restricted Project
azharudd committed rG7ed3286a512d: [LibFuzzer] [tests] [Darwin] Use the pthread library from the SDK (authored by azharudd).
[LibFuzzer] [tests] [Darwin] Use the pthread library from the SDK
Aug 21 2020, 9:26 AM

Aug 19 2020

azharudd added a comment to D85554: [libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator..

Looks like this change is causing the value-profile-load.test test to fail. Can you please take a look?

******************** TEST 'libFuzzer :: value-profile-load.test' FAILED ********************
Script:
--
: 'RUN: at line 2';     /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/./bin/clang  --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/lib/fuzzer -arch x86_64 -stdlib=libc++ -mmacosx-version-min=10.9 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk /Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/LoadTest.cpp -fsanitize-coverage=trace-gep -o /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/value-profile-load.test.tmp-LoadTest
: 'RUN: at line 3';   not  /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/value-profile-load.test.tmp-LoadTest -seed=2 -use_cmp=0 -use_value_profile=1 -runs=20000000 2>&1 | FileCheck /Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/value-profile-load.test
--
Exit Code: 1

Command Output (stderr):
--
+ : 'RUN: at line 2'
+ /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/lib/fuzzer -arch x86_64 -stdlib=libc++ -mmacosx-version-min=10.9 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk /Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/LoadTest.cpp -fsanitize-coverage=trace-gep -o /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/value-profile-load.test.tmp-LoadTest
+ : 'RUN: at line 3'
+ not /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/value-profile-load.test.tmp-LoadTest -seed=2 -use_cmp=0 -use_value_profile=1 -runs=20000000
+ FileCheck /Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/value-profile-load.test
/Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/value-profile-load.test:1:8: error: CHECK: expected string not found in input
CHECK: AddressSanitizer: global-buffer-overflow
       ^
<stdin>:1:1: note: scanning from here
INFO: Seed: 2
^
<stdin>:5:27: note: possible intended match here
INFO: A corpus is not provided, starting from an empty corpus
                          ^

Input file: <stdin>
Check file: /Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/value-profile-load.test

-dump-input=help explains the following input dump.

Input was:
<<<<<<
           1: INFO: Seed: 2
check:1'0     X~~~~~~~~~~~~ error: no match found
           2: INFO: Loaded 1 modules (3 inline 8-bit counters): 3 [0x10af2bac8, 0x10af2bacb), 
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           3: INFO: Loaded 1 PC tables (3 PCs): 3 [0x10af2bad0,0x10af2bb00), 
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           4: INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           5: INFO: A corpus is not provided, starting from an empty corpus
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:1'1                               ?                                   possible intended match
           6: #2 INITED cov: 2 ft: 4 corp: 1/1b exec/s: 0 rss: 31Mb
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           7: #14 NEW cov: 2 ft: 5 corp: 2/4b lim: 4 exec/s: 0 rss: 31Mb L: 3/3 MS: 2 CrossOver-CopyPart-
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           8: #242 NEW cov: 2 ft: 6 corp: 3/9b lim: 6 exec/s: 0 rss: 31Mb L: 5/5 MS: 3 ShuffleBytes-ShuffleBytes-CopyPart-
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           9: #477 NEW cov: 3 ft: 11 corp: 4/17b lim: 8 exec/s: 0 rss: 31Mb L: 8/8 MS: 5 EraseBytes-ChangeByte-EraseBytes-InsertRepeatedBytes-CopyPart-
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          10: #480 NEW cov: 3 ft: 13 corp: 5/24b lim: 8 exec/s: 0 rss: 31Mb L: 7/8 MS: 3 ChangeByte-InsertByte-CopyPart-
check:1'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           .
           .
           .
>>>>>>

--

********************

Could you please apply the following patch and see if it fixes the regression?

https://reviews.llvm.org/D86247

Aug 19 2020, 2:55 PM · Restricted Project
azharudd added a comment to D85554: [libFuzzer] Fix arguments of InsertPartOf/CopyPartOf calls in CrossOver mutator..

Looks like this change is causing the value-profile-load.test test to fail. Can you please take a look?

******************** TEST 'libFuzzer :: value-profile-load.test' FAILED ********************
Script:
--
: 'RUN: at line 2';     /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/./bin/clang  --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/lib/fuzzer -arch x86_64 -stdlib=libc++ -mmacosx-version-min=10.9 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk /Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/LoadTest.cpp -fsanitize-coverage=trace-gep -o /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/value-profile-load.test.tmp-LoadTest
: 'RUN: at line 3';   not  /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/value-profile-load.test.tmp-LoadTest -seed=2 -use_cmp=0 -use_value_profile=1 -runs=20000000 2>&1 | FileCheck /Users/buildslave/jenkins/workspace/clang-stage1-RA/llvm-project/compiler-rt/test/fuzzer/value-profile-load.test
--
Exit Code: 1
Aug 19 2020, 10:36 AM · Restricted Project

Aug 11 2020

azharudd requested review of D85773: [Driver][XRay][test] Update the macOS support check.
Aug 11 2020, 12:58 PM · Restricted Project

Aug 6 2020

azharudd requested changes to D85173: [zorg] build.py: Allow lit test timeout value to be configurable.
Aug 6 2020, 10:46 AM

Aug 3 2020

azharudd added a reverting change for rZORG17e1c3a1e4ac: Temporarily disable email notification for test-suite pipeline jobs: rZORG334aee1e5a0e: Revert "Temporarily disable email notification for test-suite pipeline jobs".
Aug 3 2020, 5:19 PM
azharudd committed rZORG334aee1e5a0e: Revert "Temporarily disable email notification for test-suite pipeline jobs" (authored by azharudd).
Revert "Temporarily disable email notification for test-suite pipeline jobs"
Aug 3 2020, 5:19 PM
azharudd updated subscribers of D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary.

Hey Eli,

Aug 3 2020, 11:01 AM · Restricted Project

Jul 28 2020

azharudd added a comment to D84700: [ThinLTO] [test] cache.ll: Prevent Spotlight indexing of the output dir.

No issues from my point of view, aside from the suggested comment change.

Jul 28 2020, 9:23 PM · Restricted Project

Jul 27 2020

azharudd added a comment to D84700: [ThinLTO] [test] cache.ll: Prevent Spotlight indexing of the output dir.

Since it is just a change in the directory name, I think this would still work fine on other platforms.

Jul 27 2020, 1:56 PM · Restricted Project
azharudd added a reviewer for D84700: [ThinLTO] [test] cache.ll: Prevent Spotlight indexing of the output dir: steven_wu.
Jul 27 2020, 1:49 PM · Restricted Project
Herald added a project to D84700: [ThinLTO] [test] cache.ll: Prevent Spotlight indexing of the output dir: Restricted Project.
Jul 27 2020, 1:28 PM · Restricted Project

May 27 2020

azharudd added a comment to D80474: tsan: fix false positives in AcquireGlobal.

Looks like the test added here is failing on Darwin. Can you please look into it.

May 27 2020, 6:34 PM

Dec 12 2019

azharudd committed rGfb31b13f352a: [AST] Fix test for Swift clang (authored by lanza).
[AST] Fix test for Swift clang
Dec 12 2019, 2:05 PM

Aug 15 2019

azharudd added a comment to D66296: [BUNDLER]Improve the test, NFC..

Looks like this is failing on Darwin:

Aug 15 2019, 11:57 AM · Restricted Project, Restricted Project

Jul 17 2019

azharudd committed rL366297: Revert "[zorg] Add a new build script for use with monorepo".
Revert "[zorg] Add a new build script for use with monorepo"
Jul 17 2019, 12:51 AM

Jul 8 2019

azharudd committed rL365440: [zorg] Add a new build script for use with monorepo.
[zorg] Add a new build script for use with monorepo
Jul 8 2019, 10:23 PM
azharudd closed D64028: [zorg] Add a new build script for use with monorepo.
Jul 8 2019, 10:23 PM · Restricted Project

Jul 1 2019

azharudd removed a reviewer for D64028: [zorg] Add a new build script for use with monorepo: azhar.
Jul 1 2019, 12:27 PM · Restricted Project
azharudd commandeered D64028: [zorg] Add a new build script for use with monorepo.
Jul 1 2019, 12:27 PM · Restricted Project

Nov 1 2018

azharudd added a comment to D53912: [Headers] [MS] Add intrin0.h.
In D53912#1281584, @rnk wrote:

This sounds like it would defeat what I'm assuming is the intended purpose of intrin0.h, which is to reduce compile time. intrin.h is kind of enormous, and the compile time problems are well-documented. We should investigate what's up with intrin0.h and implement as many builtins as we need to support it.

Nov 1 2018, 4:30 PM

Oct 30 2018

azharudd created D53912: [Headers] [MS] Add intrin0.h.
Oct 30 2018, 4:50 PM

Oct 5 2018

azharudd added a comment to D51804: [CMake] Fix LTO option on Windows.

CMAKE_LINKER MATCHES "lld-link\.exe"

@aganea, can you please elaborate on the need for the backslash that you added?

Oct 5 2018, 6:17 PM

Sep 24 2018

azharudd added a reviewer for D52144: use __ARM_FP instead of __VFP_FP__: peter.smith.
Sep 24 2018, 12:01 PM

Sep 13 2018

azharudd committed rLLD342145: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Add missing REQUIRES x86 to test/COFF/icf-safe.s
Sep 13 2018, 8:43 AM
azharudd committed rL342145: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Add missing REQUIRES x86 to test/COFF/icf-safe.s
Sep 13 2018, 8:43 AM
azharudd closed D51764: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Sep 13 2018, 8:43 AM
azharudd committed rLLD342144: Fix typo in error message. NFC..
Fix typo in error message. NFC.
Sep 13 2018, 8:40 AM
azharudd added a comment to D51764: Add missing REQUIRES x86 to test/COFF/icf-safe.s.

Thanks for the review @ruiu.

Sep 13 2018, 8:39 AM
azharudd committed rL342144: Fix typo in error message. NFC..
Fix typo in error message. NFC.
Sep 13 2018, 8:38 AM
azharudd closed D51767: Fix typo in error message. NFC..
Sep 13 2018, 8:38 AM
azharudd added a comment to D51767: Fix typo in error message. NFC..

Thanks for the review @ruiu.

Sep 13 2018, 8:37 AM

Sep 6 2018

azharudd created D51767: Fix typo in error message. NFC..
Sep 6 2018, 5:51 PM
azharudd created D51764: Add missing REQUIRES x86 to test/COFF/icf-safe.s.
Sep 6 2018, 5:08 PM

Aug 8 2018

azharudd added a reviewer for D50431: generalize SKS key server in debian8 Dockerfile: ilya-biryukov.

Adding Ilya who is the original author of that file.

Aug 8 2018, 4:06 PM

Jul 30 2018

azharudd committed rCRT338284: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
[cmake] [ARM] Exclude any VFP builtins if VFP is not supported
Jul 30 2018, 11:20 AM
azharudd committed rL338284: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
[cmake] [ARM] Exclude any VFP builtins if VFP is not supported
Jul 30 2018, 11:19 AM
azharudd closed D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.
Jul 30 2018, 11:19 AM
azharudd added a comment to D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

@peter.smith Thanks for the review.

Jul 30 2018, 11:17 AM

Jul 27 2018

azharudd added a comment to D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported.

Ping for review please.

Jul 27 2018, 9:53 AM

Jul 24 2018

azharudd committed rL337842: [docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value.
[docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value
Jul 24 2018, 11:34 AM
azharudd closed D49712: [docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value.
Jul 24 2018, 11:34 AM