samsonov (Alexey Samsonov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2012, 5:59 AM (261 w, 3 d)

Recent Activity

May 2 2016

samsonov added a comment to D19818: sanitizers: call __cxa_demangle only on mangled external names.

That is, even if we want to add this check, it should be closer to the call site, where we know for sure we're demangling the variable name.

May 2 2016, 1:09 PM
samsonov added a comment to D19818: sanitizers: call __cxa_demangle only on mangled external names.

I am not sure, but IIRC somewhere we depend on the ability of __cxa_demangle to demangle the type names.

May 2 2016, 1:09 PM

Mar 28 2016

samsonov added a comment to D16737: Support for dead code stripping on Mach-O platforms.

LGTM. Feel free to submit after addressing a couple of comments below.

Mar 28 2016, 10:34 AM

Mar 24 2016

samsonov accepted D18413: [asan] Intercept all Heap* related imports from ucrtbase.dll.

LGTM

Mar 24 2016, 1:20 PM
samsonov added a reviewer for D18413: [asan] Intercept all Heap* related imports from ucrtbase.dll: kcc.
Mar 24 2016, 10:44 AM
samsonov added a reviewer for D18413: [asan] Intercept all Heap* related imports from ucrtbase.dll: vitalybuka.
Mar 24 2016, 10:44 AM

Mar 23 2016

samsonov added inline comments to D18397: [sanitizer] Add strnlen to the common interceptors.
Mar 23 2016, 1:51 PM
samsonov accepted D18397: [sanitizer] Add strnlen to the common interceptors.

LGTM with a nit below.

Mar 23 2016, 10:29 AM

Mar 21 2016

samsonov accepted D18326: [sanitizier] initializing common flags..

LGTM

Mar 21 2016, 1:30 PM
samsonov added a reviewer for D18312: [Compiler-rt] Mark getpwnam_r_invalid_user as expected failure for MIPS: vitalybuka.

Please investigate this issue in more details. "There might be some leak in getpwnam_r" is not a good enough reason to exclude this test on MIPS (note that it also runs for ASan, TSan, MSan, not just for LSan).

Mar 21 2016, 10:47 AM

Mar 18 2016

samsonov added a reviewer for D18277: [tsan] Build TSan dylibs for iOS-style simulators: beanz.
Mar 18 2016, 2:04 PM
samsonov added a comment to D18280: [tsan] Allow -fsanitize=thread for iOS-style simulator targets.

Cool, great to see this coming. I'll let Kuba sign this off.

Mar 18 2016, 2:03 PM

Mar 17 2016

samsonov committed rL263754: [Docs] Fix a typo..
[Docs] Fix a typo.
Mar 17 2016, 4:13 PM
samsonov committed rL263751: [CMake] Remove bash-ism in SanitizerLintCheck.
[CMake] Remove bash-ism in SanitizerLintCheck
Mar 17 2016, 2:46 PM

Mar 16 2016

samsonov accepted D18212: [sanitizer] On OS X, verify that interceptors work and abort if not, take 2.

LGTM

Mar 16 2016, 2:46 PM
samsonov added a comment to D18212: [sanitizer] On OS X, verify that interceptors work and abort if not, take 2.

... that is, make weak bool DisableReexec() { return false; } and override it with function returning true in unit tests.

Mar 16 2016, 1:14 PM
samsonov added a comment to D18212: [sanitizer] On OS X, verify that interceptors work and abort if not, take 2.

This is really unfortunate. I also don't like adding the runtime flag for the sake of TSan unit test. Why can we call DisableReexec() from ASan unit tests, but not from TSan ones? The former also use static runtime on OS X?

Mar 16 2016, 12:09 PM
samsonov requested changes to D18208: [UBSan] Fix test cast-overflow.cc for mips64 big-endian..

This was fixed recently, please update.

Mar 16 2016, 11:59 AM

Mar 15 2016

samsonov committed rL263575: [ASan] Make sure unittest works if sized-delete is enabled by default..
[ASan] Make sure unittest works if sized-delete is enabled by default.
Mar 15 2016, 12:13 PM
samsonov accepted D17883: [ASAN] Add support for mips/mips64 android.

LGTM after addressing one minor comment below. Thanks!

Mar 15 2016, 11:54 AM

Mar 14 2016

samsonov accepted D18121: [sanitizer] On OS X, verify that interceptors work and abort if not.

LGTM

Mar 14 2016, 10:30 AM

Mar 11 2016

samsonov added a reviewer for D18109: Prevent GlobalOpts from dropping ASANitized global variables: rgov.
Mar 11 2016, 4:52 PM

Mar 10 2016

samsonov committed rL263195: Fix ASan test cases after r263177.
Fix ASan test cases after r263177
Mar 10 2016, 9:09 PM
samsonov committed rL263177: [sanitizer] Add strlen to the common interceptors.
[sanitizer] Add strlen to the common interceptors
Mar 10 2016, 4:50 PM
samsonov closed D18020: [sanitizer] Add strlen to the common interceptors by committing rL263177: [sanitizer] Add strlen to the common interceptors.
Mar 10 2016, 4:50 PM
samsonov committed rL263176: [UBSan] Improve bufferization of UBSan error reports..
[UBSan] Improve bufferization of UBSan error reports.
Mar 10 2016, 4:42 PM
samsonov closed D18068: [UBSan] Improve bufferization of UBSan error reports. by committing rL263176: [UBSan] Improve bufferization of UBSan error reports..
Mar 10 2016, 4:42 PM
samsonov accepted D18020: [sanitizer] Add strlen to the common interceptors.

LGTM, thank you!

Mar 10 2016, 4:22 PM
samsonov retitled D18068: [UBSan] Improve bufferization of UBSan error reports. from to [UBSan] Improve bufferization of UBSan error reports..
Mar 10 2016, 3:18 PM
samsonov added a comment to D18020: [sanitizer] Add strlen to the common interceptors.

Looks mostly good, thank you for working on this.

Mar 10 2016, 2:29 PM
samsonov added a reviewer for D18020: [sanitizer] Add strlen to the common interceptors: vitalybuka.
Mar 10 2016, 2:05 PM
samsonov accepted D17883: [ASAN] Add support for mips/mips64 android.

LGTM with a nit. Thanks!

Mar 10 2016, 10:37 AM
samsonov accepted D17985: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test.

LGTM

Mar 10 2016, 10:35 AM
samsonov accepted D17928: [sanitizer_common tests] Make Darwin a Posix system and bring the stable-runtime definition from ASan tests..

LGTM with a nit. Thanks!

Mar 10 2016, 10:34 AM

Mar 9 2016

samsonov added a comment to D16737: Support for dead code stripping on Mach-O platforms.

LGTM

Mar 9 2016, 7:55 PM
samsonov added inline comments to D16841: Support for __asan_apply_to_globals in ASAN runtime library.
Mar 9 2016, 7:54 PM
samsonov committed rL263081: EmitCXXStructorCall -> EmitCXXDestructorCall. NFC..
EmitCXXStructorCall -> EmitCXXDestructorCall. NFC.
Mar 9 2016, 4:25 PM
samsonov committed rL263080: Remove unused function arguments. NFC..
Remove unused function arguments. NFC.
Mar 9 2016, 4:25 PM
samsonov added inline comments to D17883: [ASAN] Add support for mips/mips64 android.
Mar 9 2016, 3:52 PM
samsonov added inline comments to D17985: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test.
Mar 9 2016, 3:48 PM
samsonov added inline comments to D17928: [sanitizer_common tests] Make Darwin a Posix system and bring the stable-runtime definition from ASan tests..
Mar 9 2016, 3:47 PM
samsonov committed rL263077: sanitizer: Fix endianness checks for gcc.
sanitizer: Fix endianness checks for gcc
Mar 9 2016, 3:44 PM
samsonov closed D17660: sanitizer: Fix endianness checks for gcc by committing rL263077: sanitizer: Fix endianness checks for gcc.
Mar 9 2016, 3:44 PM · Restricted Project

Mar 8 2016

samsonov accepted D17881: [Compiler-rt][MIPS] Defining macros for MIPS archs.

LGTM

Mar 8 2016, 12:11 PM
samsonov added inline comments to D17928: [sanitizer_common tests] Make Darwin a Posix system and bring the stable-runtime definition from ASan tests..
Mar 8 2016, 12:10 PM
samsonov accepted D17751: [DFSan] Fix test_inet_pton for big endian archs.

LGTM

Mar 8 2016, 12:07 PM
samsonov accepted D17660: sanitizer: Fix endianness checks for gcc.

LGTM. Thank you for fixing this!

Mar 8 2016, 12:04 PM · Restricted Project

Mar 7 2016

samsonov added a comment to D17660: sanitizer: Fix endianness checks for gcc.

We use __BIG_ENDIAN__ and __LITTLE_ENDIAN__ macro in a few places in sanitizers. Let's update all these use cases to a more portable form for consistency.

Mar 7 2016, 5:37 PM · Restricted Project

Mar 4 2016

samsonov accepted D17896: [cmake] Address Samsonov's post-commit review of r262723.

LGTM

Mar 4 2016, 2:54 PM
samsonov added a comment to D17891: [sanitizer] Fix strlen assumptions in sanitizer interception code.

Yes, this would definitely be a better solution.

Mar 4 2016, 11:34 AM
samsonov added a comment to D17891: [sanitizer] Fix strlen assumptions in sanitizer interception code.

I think it's reasonable to make an assumption that we're intercepting strlen(), and the REAL() version works faster. Depending on the order of inclusion is not nice, for sure.

Mar 4 2016, 11:22 AM
samsonov added inline comments to D17883: [ASAN] Add support for mips/mips64 android.
Mar 4 2016, 11:06 AM
samsonov requested changes to D17881: [Compiler-rt][MIPS] Defining macros for MIPS archs.
Mar 4 2016, 11:05 AM
samsonov added a comment to D17881: [Compiler-rt][MIPS] Defining macros for MIPS archs.

Um, no, let's follow the strategy we use for other macros here and always define SANITIZER_MIPS, SANITIZER_MIPS64 and SANITIZER_MIPS32 to either 1, or 0.

Mar 4 2016, 11:04 AM

Mar 3 2016

samsonov requested changes to D17851: [DebugInfo] The last byte of the entity is still a part of it..

I don't think this change is correct. E.g. in dwarfdump-test.elf-x86-64 symbol "main" has address 0x400540 and size 0x24, which means that 0x400564 does *not* belong to this function.

Mar 3 2016, 5:04 PM
samsonov committed rL262680: [TSan] Fix compiler warning in Go sanity test..
[TSan] Fix compiler warning in Go sanity test.
Mar 3 2016, 5:01 PM
samsonov closed D17855: [asan] Fix odr_c_test failure with gold linker.

Submitted as r262678.

Mar 3 2016, 4:46 PM
samsonov committed rL262678: [asan] Fix odr_c_test failure with gold linker.
[asan] Fix odr_c_test failure with gold linker
Mar 3 2016, 4:46 PM
samsonov accepted D17846: [Compiler-rt][safestack] Enable for MIPS.

LGTM

Mar 3 2016, 4:21 PM
samsonov accepted D17855: [asan] Fix odr_c_test failure with gold linker.

LGTM

Mar 3 2016, 10:33 AM
samsonov added a reviewer for D17842: [ASAN] Add support for mips/mips64 android: eugenis.
Mar 3 2016, 9:58 AM
samsonov updated subscribers of D17842: [ASAN] Add support for mips/mips64 android.
Mar 3 2016, 9:47 AM

Mar 2 2016

samsonov accepted D17797: [LSan] Enable use_registers test for MIPS.

LGTM

Mar 2 2016, 11:50 AM

Feb 29 2016

samsonov added a comment to D17690: [asan] Check if the memory is readable before using the AsanChunk in free() and realloc().

I'm somewhat worried about the performance implications of this. IsAccessibleMemoryRange is a syscall after all, not sure it would be nice to call it on every malloc/free. We do run non-trivial operations on these calls though, like collecting stack traces.

Feb 29 2016, 10:45 AM
samsonov accepted D17703: [Compiler-rt][MIPS] Correct Dynamic Thread Vector offset for MIPS.

LGTM

Feb 29 2016, 10:27 AM

Feb 26 2016

samsonov committed rL262063: [CMake] Fix a typo in add_compiler_rt_library..
[CMake] Fix a typo in add_compiler_rt_library.
Feb 26 2016, 1:04 PM

Feb 25 2016

samsonov accepted D17603: [MSAN] Fix test SmallPreAllocatedStackThread for MIPS.

LGTM

Feb 25 2016, 12:17 PM
samsonov committed rL261909: [Sanitizer] Protect against compiler-inserted memcpy() in InternalMmapVector….
[Sanitizer] Protect against compiler-inserted memcpy() in InternalMmapVector…
Feb 25 2016, 10:17 AM

Feb 24 2016

samsonov accepted D17262: [Compiler-rt][MSan]Fix shmat testcase: Pass SHMLBA-alligned address to shmat.

LGTM after fixing a bug below.

Feb 24 2016, 2:42 PM

Feb 23 2016

samsonov committed rL261715: [tests] Portability fixup for r261713..
[tests] Portability fixup for r261713.
Feb 23 2016, 5:33 PM
samsonov accepted D17556: [CMake] Default CMAKE_MACOSX_RPATH to On, this is the default with CMP0042.

LGTM

Feb 23 2016, 5:32 PM
samsonov committed rL261713: [tests] Resolve old TODOs in ASan unit tests..
[tests] Resolve old TODOs in ASan unit tests.
Feb 23 2016, 4:46 PM
samsonov committed rL261708: [tests] Don't compile CFI C tests in C++ mode..
[tests] Don't compile CFI C tests in C++ mode.
Feb 23 2016, 4:21 PM
samsonov added inline comments to D17262: [Compiler-rt][MSan]Fix shmat testcase: Pass SHMLBA-alligned address to shmat.
Feb 23 2016, 9:44 AM

Feb 22 2016

samsonov committed rL261609: [tests] Run test that uses gnu asm syntax on Posix only..
[tests] Run test that uses gnu asm syntax on Posix only.
Feb 22 2016, 8:15 PM
samsonov committed rL261603: [tests] Remove "supported-target" in favor of "target-arch" lit features..
[tests] Remove "supported-target" in favor of "target-arch" lit features.
Feb 22 2016, 6:03 PM
samsonov committed rL261601: [tests] Always specify correct config.target_arch when configuring test suite..
[tests] Always specify correct config.target_arch when configuring test suite.
Feb 22 2016, 5:38 PM
samsonov accepted D17431: [Windows] Fix UnmapOrDie and MmapAlignedOrDie.

Looks reasonable (yet sad).

Feb 22 2016, 11:29 AM
samsonov accepted D17503: [MSAN] Mark dlerror.cc expected failure for MIPS .

This test checks that dlerror() unpoisons the string it returns. glibc is indeed not instrumented, so some implementations could trigger false positives by calling strcmp() on internal strings are not known to be fully initialized.

Feb 22 2016, 11:17 AM
samsonov committed rL261554: [Sanitizer] Introduce ListOfModules object and use it to replace….
[Sanitizer] Introduce ListOfModules object and use it to replace…
Feb 22 2016, 10:57 AM
samsonov closed D17470: [Sanitizer] Introduce ListOfModules object and use it to replace GetListOfModules(). by committing rL261554: [Sanitizer] Introduce ListOfModules object and use it to replace….
Feb 22 2016, 10:57 AM
samsonov added a comment to D17262: [Compiler-rt][MSan]Fix shmat testcase: Pass SHMLBA-alligned address to shmat.

Instead of writing different code for x86 and MIPS, can you just make sure that you get a SHMLBA-aligned address?

Feb 22 2016, 10:29 AM

Feb 19 2016

samsonov retitled D17470: [Sanitizer] Introduce ListOfModules object and use it to replace GetListOfModules(). from to [Sanitizer] Introduce ListOfModules object and use it to replace GetListOfModules()..
Feb 19 2016, 6:23 PM

Feb 18 2016

samsonov accepted D17361: [PGO] Add support to enable testing multiple supported targets .

LGTM

Feb 18 2016, 11:01 AM
samsonov accepted D17383: [tsan] Disable sysroot flag on FreeBSD.

LGTM

Feb 18 2016, 9:31 AM

Feb 17 2016

samsonov committed rL261157: PR26606: Make abort_on_error.cc test more portable..
PR26606: Make abort_on_error.cc test more portable.
Feb 17 2016, 1:29 PM
samsonov committed rL261150: Fix PR26608: Make sanitizer_common tests more portable..
Fix PR26608: Make sanitizer_common tests more portable.
Feb 17 2016, 1:05 PM
samsonov committed rL261148: [TSan] PR26609: Fix two test cases..
[TSan] PR26609: Fix two test cases.
Feb 17 2016, 12:44 PM
samsonov accepted D17190: [compiler-rt] Return correct size of struct pthread for glibc-2.12.2.

LGTM

Feb 17 2016, 12:25 PM
samsonov committed rL261142: [tests] Slightly improve a fix in r260669..
[tests] Slightly improve a fix in r260669.
Feb 17 2016, 11:40 AM
samsonov accepted D17243: Enable SafeStack for CloudABI..

LGTM

Feb 17 2016, 9:30 AM

Feb 16 2016

samsonov accepted D17322: sanitizers bots: fail the whole run, if building fresh Clang fails..

LGTM

Feb 16 2016, 7:10 PM
samsonov added a comment to D17243: Enable SafeStack for CloudABI..

Please add a test case for this (probably to test/Driver/fsanitize.c).

Feb 16 2016, 9:57 AM

Feb 12 2016

samsonov committed rL260779: Disable two tests that use a lot of stack under ASan..
Disable two tests that use a lot of stack under ASan.
Feb 12 2016, 5:07 PM
samsonov committed rL260775: [TSan] Adjust expectation for check_analyze.sh.
[TSan] Adjust expectation for check_analyze.sh
Feb 12 2016, 5:00 PM
samsonov committed rL260766: Fix Windows buildbot breakage..
Fix Windows buildbot breakage.
Feb 12 2016, 3:55 PM
samsonov committed rL260717: [LSan] Print more helpful error message if LSan crashes during leak detection..
[LSan] Print more helpful error message if LSan crashes during leak detection.
Feb 12 2016, 12:25 PM

Feb 11 2016

samsonov added inline comments to D16841: Support for __asan_apply_to_globals in ASAN runtime library.
Feb 11 2016, 6:24 PM
samsonov committed rL260564: [LSan] Test case fix: mode debug output, synchronization instead of sleep()..
[LSan] Test case fix: mode debug output, synchronization instead of sleep().
Feb 11 2016, 11:07 AM
samsonov accepted D17135: [Compiler-rt][MSan][MIPS] Resolve gethostbyname_r_erange for MIPS.

LGTM

Feb 11 2016, 10:34 AM