This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Enable static libcxxabi linking on Darwin
AbandonedPublic

Authored by phosek on Mar 19 2018, 8:57 PM.

Download Raw Diff

Details

Reviewers

EricWF
mclow.lists
compnerd
beanz
dexonsmith
ldionne

Summary

This seems to be working without any problems.

Diff Detail

Repository: rCXX libc++

Event Timeline

phosek created this revision.Mar 19 2018, 8:57 PM

Herald added subscribers: cfe-commits, christof, mgorny. · View Herald TranscriptMar 19 2018, 8:57 PM

I would imagine there was a reason this configuration was unsupported on macOS – perhaps something to do with libc++/libc++abi being the default system libraries on that platform?

libcxx/CMakeLists.txt
330	You should get rid of this comment.

phosek updated this revision to Diff 139163.Mar 20 2018, 11:06 AM

phosek marked an inline comment as done.

I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS.

phosek mentioned this in D45639: [Driver] Support default libc++ library location on Darwin.Apr 25 2018, 12:18 PM

jfb added a reviewer: ldionne.Aug 8 2018, 1:24 PM

Were the concerns expressed in D8017 addressed?

smeenai mentioned this in D59513: [libc++][CMake] Allow merging libc++abi.a into libc++ even on Apple platforms.Mar 18 2019, 2:22 PM

This was already implemented in D59513.

Herald added a subscriber: libcxx-commits. · View Herald TranscriptMar 29 2019, 12:30 PM

Revision Contents

Path

Size

libcxx/

CMakeLists.txt

7 lines

Diff 139163

libcxx/CMakeLists.txt

	Show First 20 Lines • Show All 321 Lines • ▼ Show 20 Lines
	if (CMAKE_SIZEOF_VOID_P EQUAL 8 AND NOT WIN32)			if (CMAKE_SIZEOF_VOID_P EQUAL 8 AND NOT WIN32)
	if (LIBCXX_BUILD_32_BITS AND NOT LLVM_BUILD_32_BITS) # Don't duplicate the output from LLVM			if (LIBCXX_BUILD_32_BITS AND NOT LLVM_BUILD_32_BITS) # Don't duplicate the output from LLVM
	message(STATUS "Building 32 bits executables and libraries.")			message(STATUS "Building 32 bits executables and libraries.")
	endif()			endif()
	elseif(LIBCXX_BUILD_32_BITS)			elseif(LIBCXX_BUILD_32_BITS)
	message(FATAL_ERROR "LIBCXX_BUILD_32_BITS=ON is not supported on this platform.")			message(FATAL_ERROR "LIBCXX_BUILD_32_BITS=ON is not supported on this platform.")
	endif()			endif()

	# Check that this option is not enabled on Apple and emit a usage warning.
	if (LIBCXX_ENABLE_STATIC_ABI_LIBRARY)			if (LIBCXX_ENABLE_STATIC_ABI_LIBRARY)
				smeenaiUnsubmitted Done Reply Inline Actions You should get rid of this comment. smeenai: You should get rid of this comment.
	if (APPLE)
	message(FATAL_ERROR "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is not supported on OS X")
	else()
	message(WARNING "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is an experimental option")			message(WARNING "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is an experimental option")
	endif()
	if (LIBCXX_ENABLE_STATIC AND NOT PYTHONINTERP_FOUND)			if (LIBCXX_ENABLE_STATIC AND NOT PYTHONINTERP_FOUND)
	message(FATAL_ERROR "LIBCXX_ENABLE_STATIC_ABI_LIBRARY requires python but it was not found.")			message(FATAL_ERROR "LIBCXX_ENABLE_STATIC_ABI_LIBRARY requires python but it was not found.")
	endif()			endif()
	endif()			endif()

	if (LIBCXX_ENABLE_ABI_LINKER_SCRIPT)			if (LIBCXX_ENABLE_ABI_LINKER_SCRIPT)
	if (APPLE)			if (APPLE)
	message(FATAL_ERROR "LIBCXX_ENABLE_ABI_LINKER_SCRIPT cannot be used on APPLE targets")			message(FATAL_ERROR "LIBCXX_ENABLE_ABI_LINKER_SCRIPT cannot be used on APPLE targets")
	▲ Show 20 Lines • Show All 377 Lines • Show Last 20 Lines