Page MenuHomePhabricator

[CMake] Install resource files into a share/ directory

Authored by phosek on Jan 2 2018, 11:44 AM.

Diff Detail

Event Timeline

phosek created this revision.Jan 2 2018, 11:44 AM
Herald added subscribers: Restricted Project, mgorny. · View Herald TranscriptJan 2 2018, 11:44 AM

Verified that this fixes my DESTDIR build of standalone compiler-rt.

I like this idea, but will anything else need to be updated if these files are installed in this new location?

Looks like the blacklist files are installed using add_compiler_rt_resource_file, so at the very least, this would require updating getDefaultBlacklist in clang to look in the new location?

I forgot about Clang driver, I've created D41706 to update the driver.

compnerd accepted this revision.Jan 8 2018, 1:46 PM
compnerd added a subscriber: compnerd.

This needs to be coordinated with D41706.

This revision is now accepted and ready to land.Jan 8 2018, 1:46 PM
This revision was automatically updated to reflect the committed changes.
hintonda added inline comments.
434 ↗(On Diff #129207)

I think you need to append "share" here too.