- User Since
- Dec 4 2015, 11:34 AM (93 w, 3 d)
Move TaskPool from Utility to Host
Fix build issues
Is ThreadLauncher unavailable in this code for some reason? The link failed on linux buildbots (building lldb on Darwin was fine locally): http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13311/steps/run%20unit%20tests/logs/stdio
Ping - I think this one may have slipped under the radar with the reviews for D37269
Fri, Sep 15
Thu, Sep 14
Wed, Sep 13
Only delete buffer if xar_extract_tobuffersz succeeds
Tue, Sep 12
Abandoning in favor of other options.
Mon, Sep 11
Remove recursion and refactor to make more understandable
Why does it omit some of the output?
Fri, Sep 8
Good call, thanks.
Thu, Sep 7
ping - I'm open to alternate ways of dealing with this, but it's pretty important for our use case (and presumably affects anyone else using faulty or other custom loaders).
Fri, Sep 1
modules_.enableFallbackInit() will only return true once (if use_fallback_init_ is already enabled, it returns false), so there shouldn't be an infinite recursion anywhere.
Wed, Aug 30
Tue, Aug 29
Mon, Aug 28
Thanks. Verified that this patch doesn't cause any files to be rebuilt when targeting macOS.
Re-use existing darwin function
Fri, Aug 25
Tue, Aug 22
I'm not familiar with this part of the codebase.
Mon, Aug 21
Aug 16 2017
Aug 15 2017
memalign -> malloc
Also add missing interceptors for delete(ptr, size)
Aug 8 2017
Please add a test for this.
Are there buildbots for NetBSD?
Aug 4 2017
Adding @dvyukov for the futex stuff.
Please update the commit message and one style comment, otherwise lgtm.
Aug 3 2017
Jul 25 2017
Jul 24 2017
Rebase and account for new opaque data pointer
Ok, I decided that option 2 seemed like the better call, and took care of it in D35799
Don't split executable segment into sections to avoid confusing libignore
I think the need for this may actually reveal a deeper issue. Only the address range for the first executable section will be added to the suppression. The two ways around that would be to 1) allow the suppression to take multiple ranges or 2) don't use sections in procmaps for executable segments (lsan doesn't care about executable segments anyway)
Jul 20 2017
This had to be reverted due to a masking error in its dependency which caused failures on 10.11 buildbots. Since it got reverted anyway, I took the opportunity to look into some false positives in swift, and found that they were caused by this patch. In order to prevent false positives, this now uses a blacklist of sections which definitely do not store pointers instead of a whitelist of sections which do (to avoid missing sections). Would appreciate a re-review.
Use blacklist instead of whitelist to avoid false positives
Dependency was reverted.
Remove accidental arcanist squash
Use blacklist instead of whitelist
Jul 19 2017
Fix 10.11 buildbots by masking dyld section addresses