fjricci (Francis Ricci)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2015, 11:34 AM (93 w, 3 d)

Recent Activity

Yesterday

fjricci requested review of D37930: Use ThreadLauncher to launch TaskPool threads.
Mon, Sep 18, 11:32 AM
fjricci updated the diff for D37930: Use ThreadLauncher to launch TaskPool threads.

Move TaskPool from Utility to Host

Mon, Sep 18, 11:30 AM
fjricci updated the diff for D37269: Add support for custom loaders to the sanitizer symbolizer.

Fix build issues

Mon, Sep 18, 10:03 AM
fjricci committed rL313539: Revert "Use ThreadLauncher to launch TaskPool threads".
Revert "Use ThreadLauncher to launch TaskPool threads"
Mon, Sep 18, 8:47 AM
fjricci reopened D37930: Use ThreadLauncher to launch TaskPool threads.

Is ThreadLauncher unavailable in this code for some reason? The link failed on linux buildbots (building lldb on Darwin was fine locally): http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13311/steps/run%20unit%20tests/logs/stdio

Mon, Sep 18, 8:47 AM
fjricci committed rL313537: Use ThreadLauncher to launch TaskPool threads.
Use ThreadLauncher to launch TaskPool threads
Mon, Sep 18, 8:20 AM
fjricci closed D37930: Use ThreadLauncher to launch TaskPool threads by committing rL313537: Use ThreadLauncher to launch TaskPool threads.
Mon, Sep 18, 8:20 AM
fjricci added a comment to D37268: Invalidate symbolizer module list from dlopen/dlclose interceptors.

Ping - I think this one may have slipped under the radar with the reviews for D37269

Mon, Sep 18, 8:02 AM
fjricci updated the diff for D37269: Add support for custom loaders to the sanitizer symbolizer.

Use NoCtor

Mon, Sep 18, 7:59 AM

Fri, Sep 15

fjricci created D37930: Use ThreadLauncher to launch TaskPool threads.
Fri, Sep 15, 1:55 PM

Thu, Sep 14

fjricci updated the diff for D37269: Add support for custom loaders to the sanitizer symbolizer.

Address comments

Thu, Sep 14, 9:39 AM

Wed, Sep 13

fjricci committed rL313179: [docs] Update LeakSanitizer documentation to reflect OS X support.
[docs] Update LeakSanitizer documentation to reflect OS X support
Wed, Sep 13, 12:41 PM
fjricci closed D37811: [docs] Update LeakSanitizer documentation to reflect OS X support by committing rL313179: [docs] Update LeakSanitizer documentation to reflect OS X support.
Wed, Sep 13, 12:41 PM
fjricci created D37811: [docs] Update LeakSanitizer documentation to reflect OS X support.
Wed, Sep 13, 7:48 AM
fjricci created D37810: [test] Enable LeakSanitizer on 64-bit Darwin ASan clang builds.
Wed, Sep 13, 7:08 AM
fjricci committed rL313146: [llvm-objdump] Fix memory leaks in macho dump.
[llvm-objdump] Fix memory leaks in macho dump
Wed, Sep 13, 6:59 AM
fjricci closed D37750: [llvm-objdump] Fix memory leaks in macho dump by committing rL313146: [llvm-objdump] Fix memory leaks in macho dump.
Wed, Sep 13, 6:59 AM
fjricci updated the diff for D37750: [llvm-objdump] Fix memory leaks in macho dump.

Only delete buffer if xar_extract_tobuffersz succeeds

Wed, Sep 13, 6:57 AM

Tue, Sep 12

fjricci added a dependency for D37781: [test] Enable LeakSanitizer on 64-bit Darwin ASan llvm builds: D37750: [llvm-objdump] Fix memory leaks in macho dump.
Tue, Sep 12, 4:52 PM
fjricci added a dependent revision for D37750: [llvm-objdump] Fix memory leaks in macho dump: D37781: [test] Enable LeakSanitizer on 64-bit Darwin ASan llvm builds.
Tue, Sep 12, 4:52 PM
fjricci created D37781: [test] Enable LeakSanitizer on 64-bit Darwin ASan llvm builds.
Tue, Sep 12, 4:52 PM
fjricci added reviewers for D37750: [llvm-objdump] Fix memory leaks in macho dump: compnerd, lhames.
Tue, Sep 12, 10:43 AM
fjricci abandoned D35443: Enable 64-bit Darwin LeakSanitizer by default on AddressSanitizer builds.

Abandoning in favor of other options.

Tue, Sep 12, 10:30 AM
fjricci created D37750: [llvm-objdump] Fix memory leaks in macho dump.
Tue, Sep 12, 10:21 AM

Mon, Sep 11

fjricci updated the diff for D37269: Add support for custom loaders to the sanitizer symbolizer.

Remove recursion and refactor to make more understandable

Mon, Sep 11, 4:59 PM
fjricci added a comment to D35443: Enable 64-bit Darwin LeakSanitizer by default on AddressSanitizer builds.

Why does it omit some of the output?

Mon, Sep 11, 9:59 AM
fjricci added a comment to D35443: Enable 64-bit Darwin LeakSanitizer by default on AddressSanitizer builds.

Hi @kubamracek - turns out that the llvm-tblgen issues were caused by DCE leading to a broken weak hook, which I fixed here: https://reviews.llvm.org/D37636.

Mon, Sep 11, 8:57 AM
fjricci committed rL312914: [TableGen] Ensure that __lsan_is_turned_off isn't removed by DCE in llvm-tblgen.
[TableGen] Ensure that __lsan_is_turned_off isn't removed by DCE in llvm-tblgen
Mon, Sep 11, 6:52 AM
fjricci closed D37636: [TableGen] Ensure that __lsan_is_turned_off isn't removed by DCE in llvm-tblgen by committing rL312914: [TableGen] Ensure that __lsan_is_turned_off isn't removed by DCE in llvm-tblgen.
Mon, Sep 11, 6:51 AM

Fri, Sep 8

fjricci added inline comments to D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading.
Fri, Sep 8, 2:59 PM · Restricted Project
fjricci committed rL312827: Revert "Prevent DCE on __lsan_is_turned_off and re-enable test case".
Revert "Prevent DCE on __lsan_is_turned_off and re-enable test case"
Fri, Sep 8, 2:13 PM
fjricci committed rL312824: Prevent DCE on __lsan_is_turned_off and re-enable test case.
Prevent DCE on __lsan_is_turned_off and re-enable test case
Fri, Sep 8, 12:47 PM
fjricci closed D37635: Prevent DCE on __lsan_is_turned_off and re-enable test case by committing rL312824: Prevent DCE on __lsan_is_turned_off and re-enable test case.
Fri, Sep 8, 12:47 PM
fjricci updated the diff for D37635: Prevent DCE on __lsan_is_turned_off and re-enable test case.

Add documentation

Fri, Sep 8, 12:39 PM
fjricci added a comment to D37635: Prevent DCE on __lsan_is_turned_off and re-enable test case.

Good call, thanks.

Fri, Sep 8, 12:38 PM
fjricci updated the diff for D37636: [TableGen] Ensure that __lsan_is_turned_off isn't removed by DCE in llvm-tblgen.

LLVM_ATTRIBUTE_USED

Fri, Sep 8, 12:16 PM
fjricci added inline comments to D37269: Add support for custom loaders to the sanitizer symbolizer.
Fri, Sep 8, 12:13 PM
fjricci created D37636: [TableGen] Ensure that __lsan_is_turned_off isn't removed by DCE in llvm-tblgen.
Fri, Sep 8, 11:59 AM
fjricci created D37635: Prevent DCE on __lsan_is_turned_off and re-enable test case.
Fri, Sep 8, 11:54 AM

Thu, Sep 7

fjricci added a comment to D37269: Add support for custom loaders to the sanitizer symbolizer.

ping - I'm open to alternate ways of dealing with this, but it's pretty important for our use case (and presumably affects anyone else using faulty or other custom loaders).

Thu, Sep 7, 8:27 AM

Fri, Sep 1

fjricci added a comment to D37269: Add support for custom loaders to the sanitizer symbolizer.

modules_.enableFallbackInit() will only return true once (if use_fallback_init_ is already enabled, it returns false), so there shouldn't be an infinite recursion anywhere.

Fri, Sep 1, 7:49 AM

Wed, Aug 30

fjricci committed rL312140: [builtins] Prevent duplicate definitions for overridden functions.
[builtins] Prevent duplicate definitions for overridden functions
Wed, Aug 30, 10:14 AM
fjricci closed D37166: [builtins] Prevent duplicate definitions for overridden functions by committing rL312140: [builtins] Prevent duplicate definitions for overridden functions.
Wed, Aug 30, 10:14 AM

Tue, Aug 29

fjricci added a dependency for D37269: Add support for custom loaders to the sanitizer symbolizer: D37268: Invalidate symbolizer module list from dlopen/dlclose interceptors.
Tue, Aug 29, 12:52 PM
fjricci created D37269: Add support for custom loaders to the sanitizer symbolizer.
Tue, Aug 29, 12:52 PM
fjricci added a dependent revision for D37268: Invalidate symbolizer module list from dlopen/dlclose interceptors: D37269: Add support for custom loaders to the sanitizer symbolizer.
Tue, Aug 29, 12:52 PM
fjricci created D37268: Invalidate symbolizer module list from dlopen/dlclose interceptors.
Tue, Aug 29, 12:48 PM

Mon, Aug 28

fjricci added a comment to D37166: [builtins] Prevent duplicate definitions for overridden functions.

Thanks. Verified that this patch doesn't cause any files to be rebuilt when targeting macOS.

Mon, Aug 28, 9:00 AM
fjricci updated the diff for D37166: [builtins] Prevent duplicate definitions for overridden functions.

Re-use existing darwin function

Mon, Aug 28, 8:52 AM

Fri, Aug 25

fjricci created D37166: [builtins] Prevent duplicate definitions for overridden functions.
Fri, Aug 25, 1:59 PM

Tue, Aug 22

fjricci resigned from D36587: Add NetBSD ASAN shadow mapping for x86-64.

I'm not familiar with this part of the codebase.

Tue, Aug 22, 8:21 AM · Restricted Project

Mon, Aug 21

fjricci resigned from D33878: Handle NetBSD specific _Unwind_Ptr.
Mon, Aug 21, 7:54 AM

Aug 16 2017

fjricci committed rL311030: Add C++17 aligned new/delete interceptors to standalone lsan.
Add C++17 aligned new/delete interceptors to standalone lsan
Aug 16 2017, 11:10 AM
fjricci closed D36757: Add C++17 aligned new/delete interceptors to standalone lsan by committing rL311030: Add C++17 aligned new/delete interceptors to standalone lsan.
Aug 16 2017, 11:10 AM

Aug 15 2017

fjricci updated the diff for D36757: Add C++17 aligned new/delete interceptors to standalone lsan.

memalign -> malloc

Aug 15 2017, 4:12 PM
fjricci added inline comments to D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Aug 15 2017, 3:37 PM
fjricci added inline comments to D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Aug 15 2017, 2:57 PM
fjricci added inline comments to D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Aug 15 2017, 2:07 PM
fjricci updated the diff for D36757: Add C++17 aligned new/delete interceptors to standalone lsan.

Also add missing interceptors for delete(ptr, size)

Aug 15 2017, 10:53 AM
fjricci created D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Aug 15 2017, 10:48 AM

Aug 8 2017

fjricci accepted D36376: Add NetBSD support in asan_malloc_linux.cc.
Aug 8 2017, 1:30 PM · Restricted Project
fjricci added a comment to D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.

Please add a test for this.

Aug 8 2017, 1:30 PM · Restricted Project
fjricci accepted D36484: Add NetBSD support in asan_symbolize.py.
Aug 8 2017, 1:30 PM · Restricted Project
fjricci accepted D36483: Enable ubsan on NetBSD.

Are there buildbots for NetBSD?

Aug 8 2017, 1:27 PM · Restricted Project
fjricci accepted D36325: Reuse sanitizer_linux for NetBSD.
Aug 8 2017, 1:26 PM · Restricted Project

Aug 4 2017

fjricci added a reviewer for D36325: Reuse sanitizer_linux for NetBSD: dvyukov.

Adding @dvyukov for the futex stuff.

Aug 4 2017, 11:40 AM · Restricted Project
fjricci added inline comments to D35551: Add NetBSD support in sanitizer_procmaps_freebsd.cc.
Aug 4 2017, 7:25 AM · Restricted Project
fjricci accepted D35551: Add NetBSD support in sanitizer_procmaps_freebsd.cc.

Please update the commit message and one style comment, otherwise lgtm.

Aug 4 2017, 6:57 AM · Restricted Project
fjricci added inline comments to D35551: Add NetBSD support in sanitizer_procmaps_freebsd.cc.
Aug 4 2017, 6:29 AM · Restricted Project

Aug 3 2017

fjricci accepted D36284: [sanitizer] Remove use of task_for_pid from sanitizer_stoptheworld_mac.cc.

lgtm

Aug 3 2017, 2:46 PM · Restricted Project

Jul 25 2017

fjricci committed rL308999: Only scan global sections containing data in LSan on darwin.
Only scan global sections containing data in LSan on darwin
Jul 25 2017, 11:18 AM
fjricci closed D35432: Only scan global sections containing data in LSan on darwin by committing rL308999: Only scan global sections containing data in LSan on darwin.
Jul 25 2017, 11:17 AM
fjricci committed rL308992: Fix unused variable warning with MemoryMappedSegment private data.
Fix unused variable warning with MemoryMappedSegment private data
Jul 25 2017, 10:29 AM
fjricci committed rL308977: Add address ranges for individual macho sections on darwin.
Add address ranges for individual macho sections on darwin
Jul 25 2017, 8:29 AM
fjricci closed D35799: Add address ranges for individual macho sections on darwin by committing rL308977: Add address ranges for individual macho sections on darwin.
Jul 25 2017, 8:29 AM

Jul 24 2017

fjricci updated the diff for D35432: Only scan global sections containing data in LSan on darwin.

Rebase and account for new opaque data pointer

Jul 24 2017, 10:59 AM
fjricci abandoned D35798: [compiler-rt] Allow libignore to handle modules with multiple executable sections.

Ok, I decided that option 2 seemed like the better call, and took care of it in D35799

Jul 24 2017, 10:27 AM
fjricci updated the diff for D35799: Add address ranges for individual macho sections on darwin.

Don't split executable segment into sections to avoid confusing libignore

Jul 24 2017, 10:26 AM
fjricci planned changes to D35798: [compiler-rt] Allow libignore to handle modules with multiple executable sections.

I think the need for this may actually reveal a deeper issue. Only the address range for the first executable section will be added to the suppression. The two ways around that would be to 1) allow the suppression to take multiple ranges or 2) don't use sections in procmaps for executable segments (lsan doesn't care about executable segments anyway)

Jul 24 2017, 9:10 AM
fjricci committed rL308881: [compiler-rt] Add missing const specifier to MemoryMappedSegment functions.
[compiler-rt] Add missing const specifier to MemoryMappedSegment functions
Jul 24 2017, 7:32 AM
fjricci added a dependency for D35799: Add address ranges for individual macho sections on darwin: D35798: [compiler-rt] Allow libignore to handle modules with multiple executable sections.
Jul 24 2017, 7:20 AM
fjricci added a dependent revision for D35798: [compiler-rt] Allow libignore to handle modules with multiple executable sections: D35799: Add address ranges for individual macho sections on darwin.
Jul 24 2017, 7:20 AM
fjricci created D35799: Add address ranges for individual macho sections on darwin.
Jul 24 2017, 7:20 AM
fjricci created D35798: [compiler-rt] Allow libignore to handle modules with multiple executable sections.
Jul 24 2017, 7:20 AM

Jul 20 2017

fjricci committed rL308676: Revert "Add MemoryMappedSection struct for two-level memory map iteration".
Revert "Add MemoryMappedSection struct for two-level memory map iteration"
Jul 20 2017, 2:24 PM
fjricci added inline comments to D35422: Add MemoryMappedSection struct for two-level memory map iteration.
Jul 20 2017, 11:57 AM
fjricci added inline comments to D35422: Add MemoryMappedSection struct for two-level memory map iteration.
Jul 20 2017, 11:15 AM
fjricci committed rL308644: Add MemoryMappedSection struct for two-level memory map iteration.
Add MemoryMappedSection struct for two-level memory map iteration
Jul 20 2017, 11:09 AM
fjricci closed D35422: Add MemoryMappedSection struct for two-level memory map iteration by committing rL308644: Add MemoryMappedSection struct for two-level memory map iteration.
Jul 20 2017, 11:09 AM
fjricci updated the diff for D35432: Only scan global sections containing data in LSan on darwin.

clang-format

Jul 20 2017, 10:51 AM
fjricci requested review of D35432: Only scan global sections containing data in LSan on darwin.

This had to be reverted due to a masking error in its dependency which caused failures on 10.11 buildbots. Since it got reverted anyway, I took the opportunity to look into some false positives in swift, and found that they were caused by this patch. In order to prevent false positives, this now uses a blacklist of sections which definitely do not store pointers instead of a whitelist of sections which do (to avoid missing sections). Would appreciate a re-review.

Jul 20 2017, 10:38 AM
fjricci updated the diff for D35432: Only scan global sections containing data in LSan on darwin.

Use blacklist instead of whitelist to avoid false positives

Jul 20 2017, 10:36 AM
fjricci reopened D35432: Only scan global sections containing data in LSan on darwin.

Dependency was reverted.

Jul 20 2017, 10:36 AM
fjricci updated the diff for D35422: Add MemoryMappedSection struct for two-level memory map iteration.

Remove accidental arcanist squash

Jul 20 2017, 10:33 AM
fjricci updated the diff for D35422: Add MemoryMappedSection struct for two-level memory map iteration.

Use blacklist instead of whitelist

Jul 20 2017, 10:32 AM

Jul 19 2017

fjricci added inline comments to D35551: Add NetBSD support in sanitizer_procmaps_freebsd.cc.
Jul 19 2017, 3:32 PM · Restricted Project
fjricci requested review of D35422: Add MemoryMappedSection struct for two-level memory map iteration.
Jul 19 2017, 10:37 AM
fjricci updated the diff for D35422: Add MemoryMappedSection struct for two-level memory map iteration.

Fix 10.11 buildbots by masking dyld section addresses

Jul 19 2017, 10:37 AM

Jul 18 2017

fjricci committed rL308395: Revert "Add MemoryMappedSection struct for two-level memory map iteration".
Revert "Add MemoryMappedSection struct for two-level memory map iteration"
Jul 18 2017, 4:54 PM
fjricci committed rL308394: Revert "Only scan global sections containing data in LSan on darwin".
Revert "Only scan global sections containing data in LSan on darwin"
Jul 18 2017, 4:54 PM