fjricci (Francis Ricci)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2015, 11:34 AM (110 w, 4 d)

Recent Activity

Sat, Jan 13

fjricci added a comment to D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.
Sat, Jan 13, 6:45 AM · Restricted Project
fjricci committed rCRT322437: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.
[Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE
Sat, Jan 13, 6:45 AM
fjricci committed rL322437: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.
[Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE
Sat, Jan 13, 6:45 AM
fjricci closed D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.
Sat, Jan 13, 6:45 AM · Restricted Project
fjricci added a comment to D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.

Will do.

Sat, Jan 13, 6:41 AM · Restricted Project

Fri, Jan 12

fjricci accepted D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.

lgtm

Fri, Jan 12, 9:04 AM · Restricted Project

Thu, Jan 11

fjricci added a comment to D41909: Fix deadlock in dwarf logging.

SymbolVendor::FindFunctions will lazily parse functions from the debug info and populate things inside the module, so the lock is required.

Thu, Jan 11, 1:55 PM
fjricci planned changes to D41909: Fix deadlock in dwarf logging.
Thu, Jan 11, 7:42 AM
fjricci added a comment to D41909: Fix deadlock in dwarf logging.

I think a better option would be to remove that lock and if it is needed then lock it just for the calls where it necessary. The fact that SymbolVendor locks a mutex inside a Module feels like a pretty bad layering violation for me what can cause many other deadlocks so it would be nice to fix that instead of hacking it around here.

Thu, Jan 11, 7:42 AM

Wed, Jan 10

fjricci added a comment to D41909: Fix deadlock in dwarf logging.

It's definitely possible to re-design the lock holding in such a way that we can keep this locked, but I don't want to go through all the work to do that if there isn't any added value to doing so.

Wed, Jan 10, 9:55 AM
fjricci added a comment to D41909: Fix deadlock in dwarf logging.

Actually I don't think even that is racy, because we just get a pointer to the const char *, which is immutable anyway.

Wed, Jan 10, 9:54 AM
fjricci added a comment to D41909: Fix deadlock in dwarf logging.

I guess the question is whether we expect that someone will do something like change the module's filepath while we're printing a log message with that filepath in it.

Wed, Jan 10, 9:53 AM
fjricci updated the summary of D41909: Fix deadlock in dwarf logging.
Wed, Jan 10, 9:31 AM
fjricci created D41909: Fix deadlock in dwarf logging.
Wed, Jan 10, 9:29 AM

Tue, Jan 9

fjricci added a comment to D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.

I think it would be preferable to define this as a separate constant (perhaps kSanitizerVmMemoryOsAllocOnce, like @kubamracek suggested), which is set to VM_MEMORY_OS_ALLOC_ONCE if defined, and some other value (that 73 perhaps?) otherwise. Makes it clear that the constant used by the code isn't necessarily the same as the one set by the system.

Tue, Jan 9, 9:25 AM · Restricted Project

Mon, Jan 8

fjricci abandoned D41402: [cmake] Fix DESTDIR support in compiler-rt build.

Abandoning in favor of D41706

Mon, Jan 8, 1:51 PM

Tue, Jan 2

fjricci added a comment to D41673: [CMake] Install resource files into a share/ directory.

Verified that this fixes my DESTDIR build of standalone compiler-rt.

Tue, Jan 2, 11:52 AM
fjricci added a comment to D41402: [cmake] Fix DESTDIR support in compiler-rt build.

That patch fixes our build for me.

Tue, Jan 2, 11:52 AM
fjricci added a comment to D41402: [cmake] Fix DESTDIR support in compiler-rt build.

Yeah, if I try to use an empty CMAKE_INSTALL_PATH for compiler-rt, I end up with:

Tue, Jan 2, 11:15 AM
fjricci added a comment to D41402: [cmake] Fix DESTDIR support in compiler-rt build.

ping (particularly looking for input from @beanz)

Tue, Jan 2, 9:54 AM

Tue, Dec 19

fjricci updated the summary of D41402: [cmake] Fix DESTDIR support in compiler-rt build.
Tue, Dec 19, 10:25 AM
fjricci created D41402: [cmake] Fix DESTDIR support in compiler-rt build.
Tue, Dec 19, 10:08 AM

Nov 30 2017

fjricci accepted D40672: [lit] Don't enable LSan on darwin for clang 900.

Thanks!

Nov 30 2017, 2:13 PM

Nov 29 2017

fjricci accepted D39991: [sanitizer] Add 'strip_env' flag to enable/disable removing sanitizer dylib from DYLD_INSERT_LIBRARIES.

Seems fine to me, and since nobody else has had any issue with it, I'll accept.

Nov 29 2017, 12:18 PM · Restricted Project
fjricci added inline comments to D40587: [lldb] Minor fixes in TaskPool.
Nov 29 2017, 5:49 AM

Nov 16 2017

fjricci accepted D40143: [sanitizer] Refactor how assembly files are handled.

Lgtm

Nov 16 2017, 11:41 AM · Restricted Project

Nov 15 2017

fjricci committed rL318336: Fix some typos in a comment..
Fix some typos in a comment.
Nov 15 2017, 1:19 PM
fjricci accepted D40052: [asan] Allow getpwnam(NULL) for binary compatibily.
Nov 15 2017, 1:14 PM · Restricted Project
fjricci accepted D40053: [asan] Don't crash on fclose(NULL).
Nov 15 2017, 1:14 PM · Restricted Project

Nov 14 2017

fjricci accepted D39987: [compiler-rt] Switch from deprecated TARGET_IPHONE_SIMULATOR to TARGET_OS_SIMULATOR.
Nov 14 2017, 7:57 AM · Restricted Project

Nov 10 2017

fjricci added a comment to D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.

An alternative could be to just disable the build of LSan on OS X < 10.9 (or even 10.11)

Nov 10 2017, 7:40 AM · Restricted Project
fjricci requested changes to D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE.

Because macOS changes quite a bit from version to version, we (or at least I) don't have strong plans to support LSan outside of 10.11+. Not sure what darwin used to store singleton kernel allocations before this page was introduced, but I assume that just not handling those allocations will lead to a ton of false positives. I'm inclined to let this fail on old versions unless there's someone willing to do the work to make sure they're properly supported. cc @kubamracek

Nov 10 2017, 7:38 AM · Restricted Project

Nov 9 2017

fjricci accepted D39861: [compiler-rt] Fix const and volatile qualifier warnings.

lgtm

Nov 9 2017, 4:03 PM · Restricted Project

Oct 23 2017

fjricci added a comment to D27607: [ubsan] Treat ObjC's BOOL as if its range is always {0, 1}.

Awesome, good to know. Thanks!

Oct 23 2017, 11:52 AM
fjricci added inline comments to D39151: [tsan] Fix warnings in tsan_interceptors.cc from expansion of variadic macros.
Oct 23 2017, 10:12 AM
fjricci added inline comments to D39151: [tsan] Fix warnings in tsan_interceptors.cc from expansion of variadic macros.
Oct 23 2017, 8:16 AM

Oct 21 2017

fjricci added reviewers for D39151: [tsan] Fix warnings in tsan_interceptors.cc from expansion of variadic macros: kubamracek, alekseyshl.
Oct 21 2017, 8:16 AM

Oct 19 2017

fjricci added a comment to D27607: [ubsan] Treat ObjC's BOOL as if its range is always {0, 1}.

On platforms where BOOL == signed char, is it actually undefined behavior (or is it just bad programming practice) to store a value other than 0 or 1 in your BOOL? I can't find any language specs suggesting that it is, and given that it's just a typedef for a signed char, I don't see why it would be.

Oct 19 2017, 5:42 PM

Oct 16 2017

fjricci added a comment to D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test.

(for posterity, the build is not failing anymore with this patch committed)

Oct 16 2017, 6:55 PM
fjricci added a comment to D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test.

Failing build: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/5341/

Oct 16 2017, 6:54 PM

Oct 10 2017

fjricci committed rL315338: [lit] Add host_cxx to lit config.
[lit] Add host_cxx to lit config
Oct 10 2017, 10:54 AM
fjricci closed D38741: [lit] Add host_cxx to lit config by committing rL315338: [lit] Add host_cxx to lit config.
Oct 10 2017, 10:54 AM
fjricci committed rL315337: [llvm-objdump] Disable leak checking on an llvm-objdump test.
[llvm-objdump] Disable leak checking on an llvm-objdump test
Oct 10 2017, 10:51 AM
fjricci closed D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test by committing rL315337: [llvm-objdump] Disable leak checking on an llvm-objdump test.
Oct 10 2017, 10:51 AM
fjricci added a comment to D38703: [lit] Only enable LSan on darwin when clang supports it.

@qcolombet - Can you keep an eye on the internal apple builders and let me know if this doesn't fix them? I'll be out of the town the rest of the week though, so I probably won't be able to do much until Monday.

Oct 10 2017, 10:30 AM
fjricci committed rL315333: [lit] Only enable LSan on darwin when clang supports it.
[lit] Only enable LSan on darwin when clang supports it
Oct 10 2017, 10:21 AM
fjricci closed D38703: [lit] Only enable LSan on darwin when clang supports it by committing rL315333: [lit] Only enable LSan on darwin when clang supports it.
Oct 10 2017, 10:21 AM
fjricci updated the diff for D38703: [lit] Only enable LSan on darwin when clang supports it.

Improve warning messages

Oct 10 2017, 10:10 AM
fjricci added a comment to D38741: [lit] Add host_cxx to lit config.

Used here: https://reviews.llvm.org/D38703

Oct 10 2017, 9:58 AM
fjricci added a reviewer for D38741: [lit] Add host_cxx to lit config: ddunbar.
Oct 10 2017, 9:20 AM
fjricci added a comment to D38703: [lit] Only enable LSan on darwin when clang supports it.

Clang change here: reviews.llvm.org/D38741

Oct 10 2017, 9:19 AM
fjricci created D38741: [lit] Add host_cxx to lit config.
Oct 10 2017, 9:19 AM
fjricci updated the diff for D38703: [lit] Only enable LSan on darwin when clang supports it.

Add warnings

Oct 10 2017, 9:16 AM
fjricci added a comment to D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test.

I'm going to be on vacation starting tomorrow (oct 11), and this seems like a pretty unoffensive change to me, so if I don't hear anything positive or negative by the end of the day, I'll commit this to fix the green bootstrapped builders.

Oct 10 2017, 9:01 AM
fjricci added a comment to D38703: [lit] Only enable LSan on darwin when clang supports it.

I'll upload the clang host_cxx patch shortly, but this shouldn't be blocked on that (since it handles the undefined case).

Oct 10 2017, 8:58 AM
fjricci updated the diff for D38703: [lit] Only enable LSan on darwin when clang supports it.

Address comments

Oct 10 2017, 8:57 AM
fjricci added a reviewer for D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test: enderby.
Oct 10 2017, 7:21 AM
fjricci added a comment to D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test.

Fairly certain that if this is 10.11-specific, it's either a leak in libxar, or a bug in LeakSanitizer. It doesn't appear to be a leak in objdump itself (particularly when looking at the stack, which has a dispatch_once call in it)

Oct 10 2017, 7:20 AM

Oct 9 2017

fjricci added inline comments to D38703: [lit] Only enable LSan on darwin when clang supports it.
Oct 9 2017, 3:40 PM
fjricci added inline comments to D38703: [lit] Only enable LSan on darwin when clang supports it.
Oct 9 2017, 3:38 PM
fjricci added inline comments to D38703: [lit] Only enable LSan on darwin when clang supports it.
Oct 9 2017, 2:59 PM
fjricci added inline comments to D38703: [lit] Only enable LSan on darwin when clang supports it.
Oct 9 2017, 2:52 PM
fjricci added inline comments to D38598: [llvm-objdump] Add RAII for xar apis.
Oct 9 2017, 1:29 PM
fjricci committed rL315243: [llvm-objdump] Use initializer list for scoped xar api constructors.
[llvm-objdump] Use initializer list for scoped xar api constructors
Oct 9 2017, 1:29 PM
fjricci updated the diff for D38703: [lit] Only enable LSan on darwin when clang supports it.

Fix a couple python issues

Oct 9 2017, 1:20 PM
fjricci planned changes to D38703: [lit] Only enable LSan on darwin when clang supports it.

Fixing a couple issues.

Oct 9 2017, 1:16 PM
fjricci created D38703: [lit] Only enable LSan on darwin when clang supports it.
Oct 9 2017, 1:07 PM
fjricci added a comment to D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test.

I got this failure to reproduce locally on my macOS 10.11 VM, but it's probably still worth disabling the leak checking on this test to fix the buildbots until I can diagnose the issue.

Oct 9 2017, 12:32 PM
fjricci created D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test.
Oct 9 2017, 11:34 AM
fjricci committed rL315218: [dsymutil] Emit valid debug locations when no symbol flags are set.
[dsymutil] Emit valid debug locations when no symbol flags are set
Oct 9 2017, 10:29 AM
fjricci closed D38587: [dsymutil] Emit valid debug locations when no symbol flags are set by committing rL315218: [dsymutil] Emit valid debug locations when no symbol flags are set.
Oct 9 2017, 10:29 AM
fjricci added a comment to D38587: [dsymutil] Emit valid debug locations when no symbol flags are set.

Oh interesting. I tried using PWD=/, but I didn't try actually cd-ing into that directory. I'll try that - thanks!

Oct 9 2017, 9:29 AM
fjricci accepted D38686: [dsymutil] Timestmap verification for __swift_ast.

Looks good to me

Oct 9 2017, 7:41 AM
fjricci added a comment to D38587: [dsymutil] Emit valid debug locations when no symbol flags are set.

I'm running into some issues with using a precompiled binary + object file here. For some reason, the debug info contains an absolute path to the object file instead of a relative path, so dsymutil will fail because it's looking for a path that doesn't exist (ie a path on my local machine). This is true even if I use -fdebug-compilation-dir (it updates the debug info in the IR, but doesn't change where dsymutil looks for the object file). I also tried -add_ast_path, which works as a hacky workaround because it will search the relative path in addition to the absolute path, but that seems like a bad solution.

Oct 9 2017, 7:29 AM

Oct 6 2017

fjricci updated the diff for D38587: [dsymutil] Emit valid debug locations when no symbol flags are set.

Use precompiled binary with IR as a comment to allow testing on linux

Oct 6 2017, 11:31 AM
fjricci reopened D38587: [dsymutil] Emit valid debug locations when no symbol flags are set.
Oct 6 2017, 11:30 AM
fjricci committed rL315088: Revert "[dsymutil] Emit valid debug locations when no symbol flags are set".
Revert "[dsymutil] Emit valid debug locations when no symbol flags are set"
Oct 6 2017, 11:21 AM
fjricci committed rL315082: [dsymutil] Emit valid debug locations when no symbol flags are set.
[dsymutil] Emit valid debug locations when no symbol flags are set
Oct 6 2017, 10:45 AM
fjricci closed D38587: [dsymutil] Emit valid debug locations when no symbol flags are set by committing rL315082: [dsymutil] Emit valid debug locations when no symbol flags are set.
Oct 6 2017, 10:45 AM
fjricci committed rL315072: Guard xar RAII behind HAVE_LIBXAR.
Guard xar RAII behind HAVE_LIBXAR
Oct 6 2017, 8:56 AM
fjricci committed rL315069: [llvm-objdump] Add RAII for xar apis.
[llvm-objdump] Add RAII for xar apis
Oct 6 2017, 8:35 AM
fjricci closed D38598: [llvm-objdump] Add RAII for xar apis by committing rL315069: [llvm-objdump] Add RAII for xar apis.
Oct 6 2017, 8:35 AM
fjricci updated the diff for D38587: [dsymutil] Emit valid debug locations when no symbol flags are set.

Move to x86 test dir

Oct 6 2017, 8:05 AM
fjricci committed rL315066: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.
[llvm-dsymutil] Add support for __swift_ast MachO DWARF section
Oct 6 2017, 7:51 AM
fjricci closed D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section by committing rL315066: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.
Oct 6 2017, 7:51 AM
fjricci updated the diff for D38598: [llvm-objdump] Add RAII for xar apis.

clang-format

Oct 6 2017, 7:41 AM
fjricci updated the diff for D38598: [llvm-objdump] Add RAII for xar apis.

Delete copy constructor (which implicitly deletes move constructor), and
assignment operator

Oct 6 2017, 7:38 AM

Oct 5 2017

fjricci added a comment to D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.

They fail with:
while processing dwarf streamer init
error: : error: unable to get target for 'x86_64-apple-darwin', see --version and --triple.

Oct 5 2017, 4:17 PM
fjricci reopened D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.

Weirdly, appending .macho.x86_64 fixed the armv7/thumbv7 buildbots, but not aarch64. Will try to diagnose.

Oct 5 2017, 4:16 PM
fjricci committed rL315034: Revert "[llvm-dsymutil] Add support for __swift_ast MachO DWARF section".
Revert "[llvm-dsymutil] Add support for __swift_ast MachO DWARF section"
Oct 5 2017, 4:11 PM
fjricci updated the diff for D38598: [llvm-objdump] Add RAII for xar apis.

Don't call deallocation routines on null xar objects

Oct 5 2017, 4:09 PM
fjricci updated the diff for D38598: [llvm-objdump] Add RAII for xar apis.

anonymous namespace

Oct 5 2017, 2:21 PM
fjricci updated the diff for D38598: [llvm-objdump] Add RAII for xar apis.

Xar -> ScopedXar

Oct 5 2017, 2:06 PM
fjricci updated the diff for D38598: [llvm-objdump] Add RAII for xar apis.

clang-format

Oct 5 2017, 1:58 PM
fjricci updated subscribers of D38598: [llvm-objdump] Add RAII for xar apis.
Oct 5 2017, 1:57 PM
fjricci created D38598: [llvm-objdump] Add RAII for xar apis.
Oct 5 2017, 1:55 PM
fjricci committed rL315017: [dsymutil] Fix typo in swift-ast.test.
[dsymutil] Fix typo in swift-ast.test
Oct 5 2017, 1:18 PM
fjricci committed rL315014: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.
[llvm-dsymutil] Add support for __swift_ast MachO DWARF section
Oct 5 2017, 1:05 PM
fjricci closed D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section by committing rL315014: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.
Oct 5 2017, 1:04 PM
fjricci added a comment to D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.

I think that postfixing the binary name with ".macho.x86_64" will work, that seems to be what the other tests do, although I can't seem to find a lit config relating to that.

Oct 5 2017, 12:58 PM