- User Since
- Jun 18 2013, 5:29 PM (309 w, 2 d)
- Fix typo.
- Removed unneeded public method from Option.
- Added cl::debug_opt_storage with specializations.
Tue, May 21
- Use CMAKE_HOST_APPLE when checking host system.
- Remove tab.
- Don't put new variable in the cache.
- Remove unneeded else branch.
- Get Ninja version and add LLVM_TOUCH_STATIC_LIBRARIES.
- Restrict to Darwin > 15.6.0. Ninja version not available, so will add code to get that and hide all of this under a new variable in the next version of this patch.
LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks!
D62174 is a better solution.
Mon, May 20
I think people have learned to overcome the OLD behavior by including CACHE and type in set commands in cache files, but this makes it easier. However, if you want to rerun cmake and change existing values, you'll still need to include CACHE, type, and FORCE, is that right? At least that's how I've been handling it locally. Any advice would be appreciated.
LGTM. If no further comments, I'll commit it for you tomorrow.
I'll give it a day for further comments, and barring any, commit it for you tomorrow.
Sun, May 19
- Remove Categories cache as well. This change reduces the size of the Option class down to 64 bytes.
- Add comments, fix auto usage, and minor refactoring.
Sat, May 18
The Option class started at 184 bytes, this change, along with D62091, gets it down to 88 types, and reduces bin/opt by over 90k.
- Reduce initial vector/set size to the expected value.
Fri, May 17
- Remove unneeded bit fields.
- Change type to multiple uint16_t's and reorder members.
Btw, options on the command line always override what's in the cache. Has nothing to do with FORCE. All FORCE does is make sure the set command actually changes an existing cache value. So it's an ordering issue. If the -D comes before the -C then using FORCE would override, but if the -C comes before the -D, the -D always overrides.
Btw, TopLevelSubCommand can't actually see every option, just those not specifically assigned to another SubCommand. Typically, that only happens in applications, so this should work okay. However, it would probably be safer to iterate over all SubCommands instead of just looking TopLevelSubCommand. Though I'm not sure that really matters.
Thu, May 16
After thinking about it, I agree with this change -- there's no way to provide an appropriate default at this level.
Wed, May 15
- Remove file erroneously included in last upload.
- Used find instead of find_if.
I've also had issues with this behavior. It's a bad default, as the PR notes, but is there a way to provide a better one and still respect the config file?
Just a couple nits, otherwise looks great.
Tue, May 14
I'll be happy to commit for you, but will give it till tomorrow just to make sure no one else has any additional comments.
Just a few nits, otherwise looks pretty good.
Mon, May 13
This is a great idea, but I'd prefer it not unilaterally change current behavior.
Sun, May 12
I pulled down you patch, compiled and ran it. Once I fixed the two problems I mentioned, it ran clean, e.g.:
Sat, May 11
Fri, May 10
- Address comments.
- Fix comment.