- User Since
- Jun 18 2013, 5:29 PM (317 w, 18 h)
Wed, Jul 10
Tue, Jul 9
Make GeneralCategory a ManagedStatic.
Patch is ready, so I'll post as soon as I complete rebase/build/test.
Reopening to track fix for buildbot failure -- need to make GeneralCategory a ManagedStatic.
Mon, Jul 8
Sat, Jul 6
@beanz, could you take a look? thanks...
Sat, Jun 22
Fri, Jun 21
Thu, Jun 20
LGTM, but you'll also want to fix llvm/test/Support/check-default-options.txt. It checks your special handling to make sure the default -h support didn't break it.
Wed, Jun 19
I just reviewed all the release notes, and while 3.9 relaxed the usage of TARGET_OBJECTS, cmake doesn't explicitly mention allowing them in target_link_libraries until release 3.15.
Otherwise, LGTM, thanks!
Jun 17 2019
Even though this patch has been accepted, I've made 2 additional changes, and would
like to have them reviewed as well.
- Make Option::addArgument virtual.
Jun 16 2019
- Reduce compile-time container sizes.
This test fails to compile on Windows 64 bit builds. Please see http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/77
Jun 15 2019
This seems to have broken gcc 5.4 builds -- for example see http://lab.llvm.org:8011/builders/clang-cmake-armv7-lnt/builds/29/steps/build%20stage%201/logs/stdio.
Jun 14 2019
Jun 13 2019
Jun 5 2019
Jun 4 2019
Jun 3 2019
This change seems to have caused the following error:
Jun 2 2019
Since a SubCommand's OptionsMap key is a string, and multiple
SubCommands can have unrelated options of the same name,
getSubCommands needs to also make sure the found Option matches the
Jun 1 2019
- Fix dependencies so required plugins get built before tests.
This patch broke some of the bots, so reopening to track the fix.
May 31 2019
May 30 2019
May 27 2019
Ah, yes. That would be great and wouldn’t require the bot maintainers to do anything.
I’m not sure printing out the entire CMakeCache.txt file is a good idea — it’s huge and much of it is of no interest.
May 25 2019
There are several more of these, so I've come up with a better solution and will submit a patch to D62172 that moves this logic into llvm_update_compile_flags instead.
May 24 2019
I'll just pass LLVM_INCLUDE_BENCHMARK=OFF until this library is fixed to configure properly on Mac.
Since this is a problem with a 3rd party project I'm not working on, I'm going to let them decide how to deal with this and just disable it in my builds by setting LLVM_INCLUDE_BENCHMARK=OFF.
May 23 2019
- Fix typo.
- Removed unneeded public method from Option.
May 22 2019
- Added cl::debug_opt_storage with specializations.
May 21 2019
- Use CMAKE_HOST_APPLE when checking host system.
- Remove tab.
- Don't put new variable in the cache.
- Remove unneeded else branch.
- Get Ninja version and add LLVM_TOUCH_STATIC_LIBRARIES.
- Restrict to Darwin > 15.6.0. Ninja version not available, so will add code to get that and hide all of this under a new variable in the next version of this patch.
LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks!