Page MenuHomePhabricator

hintonda (Don Hinton)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2013, 5:29 PM (317 w, 18 h)

Recent Activity

Wed, Jul 10

hintonda committed rG43d75f977853: Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the… (authored by hintonda).
Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the…
Wed, Jul 10, 10:58 AM

Tue, Jul 9

hintonda added a comment to D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags.

One thought, we should probably evaluate why those tools are using add_library instead of add_llvm_library. The right fix might be to move them over. This is exactly the kind of behavior that add_llvm_library and llvm_add_library were designed to handle.

Tue, Jul 9, 3:03 PM · Restricted Project
hintonda updated the diff for D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

Make GeneralCategory a ManagedStatic.

Tue, Jul 9, 10:31 AM · Restricted Project, Restricted Project
hintonda added a comment to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

Patch is ready, so I'll post as soon as I complete rebase/build/test.

Tue, Jul 9, 7:39 AM · Restricted Project, Restricted Project
hintonda reopened D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

Reopening to track fix for buildbot failure -- need to make GeneralCategory a ManagedStatic.

Tue, Jul 9, 7:26 AM · Restricted Project, Restricted Project

Mon, Jul 8

hintonda added a comment to D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags.

I don't like the idea of putting this in llvm_update_compile_flags. That function does exactly what its name says, and adding additional behavior to it seems undesirable. Where are we creating libraries with add_library that we need this?

Mon, Jul 8, 1:41 PM · Restricted Project

Sat, Jul 6

hintonda added a comment to D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags.

@beanz, could you take a look? thanks...

Sat, Jul 6, 1:21 PM · Restricted Project

Sat, Jun 22

hintonda committed rG64b0924531cc: Revert [CommandLine] Remove OptionCategory and SubCommand caches from the… (authored by hintonda).
Revert [CommandLine] Remove OptionCategory and SubCommand caches from the…
Sat, Jun 22, 4:34 PM
hintonda committed rGa5b83bc9e3b8: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class. (authored by hintonda).
[CommandLine] Remove OptionCategory and SubCommand caches from the Option class.
Sat, Jun 22, 10:25 AM

Fri, Jun 21

hintonda added a comment to D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.

LGTM, but you'll also want to fix llvm/test/Support/check-default-options.txt. It checks your special handling to make sure the default -h support didn't break it.

Thanks, I wasn't aware of that one (and hadn't yet bothered running every lit test for this). Just to be clear, are you recommending that I just delete the bits of that test relating to llvm-dwarfdump, since it will now follow the default process, or do you think there should be something else to replace it? I can replace it with llvm-opt-report, which seems to do something similar to llvm-dwarfdump.

Yes, it can be removed. If you want, you can add it to the ones above that do use the new default -h, but I don't think that's necessary. And yes, if there's another one that does something special, adding it, i.e., s/llvm-dwarfdump/llvm-opt-report/ makes sense.

Okay, I'm going to remove it and then commit, without replacing the removed test part. My initial evaluation was using an out-of-date llvm-opt-report, and I was unable to find any other suitable candidates. I reviewed the other tools, and the only tools I could find with explicit -h help handling are dsymutil and clang-offload-bundler. In both cases, I think the existing handling is a bug (in dsymutil at least, you actually have to provide a positional argument before it will process '-h'!).

Fri, Jun 21, 7:30 AM · Restricted Project

Thu, Jun 20

hintonda added a comment to D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.

LGTM, but you'll also want to fix llvm/test/Support/check-default-options.txt. It checks your special handling to make sure the default -h support didn't break it.

Thanks, I wasn't aware of that one (and hadn't yet bothered running every lit test for this). Just to be clear, are you recommending that I just delete the bits of that test relating to llvm-dwarfdump, since it will now follow the default process, or do you think there should be something else to replace it? I can replace it with llvm-opt-report, which seems to do something similar to llvm-dwarfdump.

Thu, Jun 20, 8:17 AM · Restricted Project
hintonda accepted D63544: Use object library if cmake supports it.

Finally updated versions - target_sources supports using $<TARGET_OBJECTS:...> since CMake 3.5.0.

Thu, Jun 20, 7:33 AM · Restricted Project, Restricted Project
hintonda accepted D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.

LGTM, but you'll also want to fix llvm/test/Support/check-default-options.txt. It checks your special handling to make sure the default -h support didn't break it.

Thu, Jun 20, 7:29 AM · Restricted Project

Wed, Jun 19

hintonda added inline comments to D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.
Wed, Jun 19, 10:52 AM · Restricted Project
hintonda added a comment to D63544: Use object library if cmake supports it.

I just reviewed all the release notes, and while 3.9 relaxed the usage of TARGET_OBJECTS, cmake doesn't explicitly mention allowing them in target_link_libraries until release 3.15.

Wed, Jun 19, 7:47 AM · Restricted Project, Restricted Project
hintonda accepted D63544: Use object library if cmake supports it.

Otherwise, LGTM, thanks!

Wed, Jun 19, 7:29 AM · Restricted Project, Restricted Project
hintonda added inline comments to D63544: Use object library if cmake supports it.
Wed, Jun 19, 7:27 AM · Restricted Project, Restricted Project
hintonda added a reviewer for D63544: Use object library if cmake supports it: beanz.
Wed, Jun 19, 7:12 AM · Restricted Project, Restricted Project

Jun 17 2019

hintonda added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
Jun 17 2019, 10:07 AM · Restricted Project, Restricted Project
hintonda added a comment to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

Even though this patch has been accepted, I've made 2 additional changes, and would
like to have them reviewed as well.

Jun 17 2019, 9:25 AM · Restricted Project, Restricted Project
hintonda updated the diff for D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
  • Make Option::addArgument virtual.
Jun 17 2019, 8:55 AM · Restricted Project, Restricted Project

Jun 16 2019

hintonda updated the diff for D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
  • Reduce compile-time container sizes.
Jun 16 2019, 6:45 PM · Restricted Project, Restricted Project
hintonda added inline comments to D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.
Jun 16 2019, 1:22 PM · Restricted Project
hintonda committed rG9b2d96024ae6: [docs] Fix another bot error by setting highlight language of objc code-block… (authored by hintonda).
[docs] Fix another bot error by setting highlight language of objc code-block…
Jun 16 2019, 12:13 PM
hintonda committed rG9d8c94dfd765: [docs] Fix another bot warning by adding a blank line to separate the `option… (authored by hintonda).
[docs] Fix another bot warning by adding a blank line to separate the `option…
Jun 16 2019, 11:42 AM
hintonda committed rG3a92aa299921: [docs] Fix a few problems with clang-tool docs to get the bots green again. (authored by hintonda).
[docs] Fix a few problems with clang-tool docs to get the bots green again.
Jun 16 2019, 10:56 AM
hintonda added a comment to D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls.

This test fails to compile on Windows 64 bit builds. Please see http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/77

Jun 16 2019, 10:12 AM · Restricted Project, Restricted Project

Jun 15 2019

hintonda committed rGb3fc9fde2c79: Fix gcc-05.4 bot failures caused by in r363481 "[clangd] Index API and… (authored by hintonda).
Fix gcc-05.4 bot failures caused by in r363481 "[clangd] Index API and…
Jun 15 2019, 6:09 PM
hintonda added a comment to D62839: [clangd] Index API and implementations for relations.

This seems to have broken gcc 5.4 builds -- for example see http://lab.llvm.org:8011/builders/clang-cmake-armv7-lnt/builds/29/steps/build%20stage%201/logs/stdio.

Jun 15 2019, 3:08 PM · Restricted Project, Restricted Project
hintonda committed rG0a29028072fd: Recommit r363298 "[lit] Disable test on darwin when building shared libs." (authored by hintonda).
Recommit r363298 "[lit] Disable test on darwin when building shared libs."
Jun 15 2019, 1:07 PM
hintonda added a comment to D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags.

ping...

Jun 15 2019, 11:19 AM · Restricted Project
hintonda abandoned D61554: [llvm] Add CloneModuleInto to clone a Module into another one, a la assignment.
Jun 15 2019, 11:19 AM · Restricted Project

Jun 14 2019

hintonda added a comment to D59754: [Sema] Add c++2a designated initializer warnings.

This looks like exactly what we need for my project. We're using Clang and Designated Initializers but would like to make sure that we use those in C++20 compatible manner. Is this blocked on something? Any way I can help?

Jun 14 2019, 11:21 AM · Restricted Project
hintonda added a comment to D61697: [lit] Disable test on darwin when building shared libs..

I reverted this in r363379 to unbreak check-lld on mac. I think the

if config.enable_shared:
               features.add("enable_shared")

bit belongs in clang/test/lit.cfg.py, not in llvm/utils/lit/lit/llvm/config.py.

Jun 14 2019, 9:39 AM · Restricted Project, Restricted Project

Jun 13 2019

hintonda committed rGed9c7ec73dfb: [lit] Disable test on darwin when building shared libs. (authored by hintonda).
[lit] Disable test on darwin when building shared libs.
Jun 13 2019, 12:08 PM

Jun 5 2019

hintonda added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
Jun 5 2019, 6:55 PM · Restricted Project, Restricted Project

Jun 4 2019

hintonda added a comment to D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

I seem to have missed out on previous commits that moved analyzer plugins around -- would you mind adding [analyzer] to the revision names that affect the Static Analyzer? Many of us are automatically subscribed to such patches.

In any case, LGTM!

Jun 4 2019, 6:28 PM · Restricted Project
hintonda added inline comments to D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.
Jun 4 2019, 5:10 PM · Restricted Project
hintonda accepted D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

LGTM...

Jun 4 2019, 4:01 PM · Restricted Project
hintonda added a comment to D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

Thanks for the quick fix, looks good to me!

Jun 4 2019, 3:16 PM · Restricted Project
hintonda added inline comments to D62445: [test] Fix plugin tests.
Jun 4 2019, 3:06 PM · Restricted Project, Restricted Project
hintonda committed rGa33eaad00cca: [Analysis] Only build Analysis plugins when CLANG_ENABLE_STATIC_ANALYZER is… (authored by hintonda).
[Analysis] Only build Analysis plugins when CLANG_ENABLE_STATIC_ANALYZER is…
Jun 4 2019, 3:06 PM
hintonda added inline comments to D62445: [test] Fix plugin tests.
Jun 4 2019, 12:21 PM · Restricted Project, Restricted Project

Jun 3 2019

hintonda added a comment to D59491: Fix relative thin archive path handling.

This change seems to have caused the following error:

Jun 3 2019, 8:59 AM · Restricted Project
hintonda added a comment to D62445: [test] Fix plugin tests.

This broke non-PIC builds. Fixed: r362399

Jun 3 2019, 8:34 AM · Restricted Project, Restricted Project
hintonda added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
Jun 3 2019, 8:18 AM · Restricted Project, Restricted Project

Jun 2 2019

hintonda updated the diff for D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

Since a SubCommand's OptionsMap key is a string, and multiple
SubCommands can have unrelated options of the same name,
getSubCommands needs to also make sure the found Option matches the
this pointer.

Jun 2 2019, 1:38 PM · Restricted Project, Restricted Project
hintonda committed rG232a8785c011: Fix bug in r362328 -- append to dependency list instead of overwrite it. (authored by hintonda).
Fix bug in r362328 -- append to dependency list instead of overwrite it.
Jun 2 2019, 10:56 AM
hintonda committed rGccbda6b0003b: [test] Fix plugin tests (authored by hintonda).
[test] Fix plugin tests
Jun 2 2019, 8:54 AM

Jun 1 2019

hintonda updated the diff for D62445: [test] Fix plugin tests.
  • Fix dependencies so required plugins get built before tests.
Jun 1 2019, 4:40 PM · Restricted Project, Restricted Project
hintonda reopened D62445: [test] Fix plugin tests.

This patch broke some of the bots, so reopening to track the fix.

Jun 1 2019, 4:40 PM · Restricted Project, Restricted Project

May 31 2019

hintonda added a comment to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

ping...

May 31 2019, 9:25 AM · Restricted Project, Restricted Project
hintonda added a comment to D61697: [lit] Disable test on darwin when building shared libs..

ping...

May 31 2019, 9:25 AM · Restricted Project, Restricted Project

May 30 2019

hintonda added a reviewer for D61554: [llvm] Add CloneModuleInto to clone a Module into another one, a la assignment: beanz.
May 30 2019, 6:43 PM · Restricted Project

May 27 2019

hintonda committed rG102b4b2486ca: Revert [test] Fix plugin tests (authored by hintonda).
Revert [test] Fix plugin tests
May 27 2019, 11:38 PM
hintonda committed rGfe5eaab2b5b4: [test] Fix plugin tests (authored by hintonda).
[test] Fix plugin tests
May 27 2019, 11:25 PM
hintonda added inline comments to D62445: [test] Fix plugin tests.
May 27 2019, 9:51 PM · Restricted Project, Restricted Project
hintonda added inline comments to D62445: [test] Fix plugin tests.
May 27 2019, 9:28 PM · Restricted Project, Restricted Project
hintonda added a comment to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..

Ah, yes. That would be great and wouldn’t require the bot maintainers to do anything.

May 27 2019, 7:57 AM · Restricted Project
hintonda added a comment to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..

I’m not sure printing out the entire CMakeCache.txt file is a good idea — it’s huge and much of it is of no interest.

May 27 2019, 7:41 AM · Restricted Project

May 25 2019

hintonda created D62455: [cmake] Move LLVM_TOUCH_STATIC_LIBRARIES logic to llvm_update_compile_flags.
May 25 2019, 12:17 PM · Restricted Project
hintonda abandoned D62436: [cmake] Apply static archive touch logic from D62172 to libraries not using llvm_add_library..

There are several more of these, so I've come up with a better solution and will submit a patch to D62172 that moves this logic into llvm_update_compile_flags instead.

May 25 2019, 11:50 AM · Restricted Project

May 24 2019

hintonda updated the summary of D62445: [test] Fix plugin tests.
May 24 2019, 11:15 PM · Restricted Project, Restricted Project
hintonda created D62445: [test] Fix plugin tests.
May 24 2019, 11:09 PM · Restricted Project, Restricted Project
hintonda updated the summary of D62445: [test] Fix plugin tests.
May 24 2019, 11:09 PM · Restricted Project, Restricted Project
hintonda retitled D62436: [cmake] Apply static archive touch logic from D62172 to libraries not using llvm_add_library. from [cmake] Apply static archive touching logic from D62172 to libraries not using llvm_add_library. to [cmake] Apply static archive touch logic from D62172 to libraries not using llvm_add_library..
May 24 2019, 5:18 PM · Restricted Project
hintonda abandoned D61831: [cmake] Do not generate benchmark targets by default.

I'll just pass LLVM_INCLUDE_BENCHMARK=OFF until this library is fixed to configure properly on Mac.

May 24 2019, 4:38 PM · Restricted Project
hintonda abandoned D61660: [cmake] Make google benchmark project handle libraries properly when built in-tree.

Since this is a problem with a 3rd party project I'm not working on, I'm going to let them decide how to deal with this and just disable it in my builds by setting LLVM_INCLUDE_BENCHMARK=OFF.

May 24 2019, 4:37 PM · Restricted Project
hintonda added a reviewer for D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.: MaskRay.
May 24 2019, 4:31 PM · Restricted Project, Restricted Project
hintonda created D62436: [cmake] Apply static archive touch logic from D62172 to libraries not using llvm_add_library..
May 24 2019, 4:18 PM · Restricted Project
hintonda committed rG3e8b9d4a57ca: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC] (authored by hintonda).
[cmake] Remove old unused version of FindZ3.cmake from clang [NFC]
May 24 2019, 12:22 PM
hintonda added a comment to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..

Btw, where would you want to put them?

Pre-monorepo, it would depend on what the bot is building, but with the mono-repo we could just create a new top-level directory to contain them all. Name each file to match the bot config it runs.

May 24 2019, 10:28 AM · Restricted Project
hintonda added a comment to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..

I have the same concerns as @labath, so we should certainly put it behind a flag.

I'm also not sure that this is how I would want to handle bot reproducibility. I've been advocating for years that we should migrate bots to using CMake cache files for configurations so that the bot configurations are stored in-tree. @sqlbyme liked that idea, but we never really got any progress on that front. It would be great if we made cache-based configuration a requirement for all bots on lab.llvm.org.

May 24 2019, 10:17 AM · Restricted Project
hintonda added a comment to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..

I'm somewhat worried about the fact that this only works for the very first cmake run. Reconfiguring an existing build tree is something that is normally supported by cmake. I don't know about others, but I do that relatively frequently. gui tools like ccmake cannot even work without making multiple cmake invocations (they do one run to fetch the list of cache variables, let the user change that, and then one run to reconfigure)..

May 24 2019, 8:50 AM · Restricted Project
hintonda added inline comments to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..
May 24 2019, 8:13 AM · Restricted Project

May 23 2019

hintonda updated the diff for D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..
  • Fix typo.
May 23 2019, 4:26 PM · Restricted Project
hintonda added inline comments to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..
May 23 2019, 4:22 PM · Restricted Project
hintonda created D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..
May 23 2019, 4:19 PM · Restricted Project
hintonda created D62343: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC].
May 23 2019, 1:53 PM · Restricted Project
hintonda updated the diff for D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
  • Removed unneeded public method from Option.
May 23 2019, 1:03 PM · Restricted Project, Restricted Project
hintonda added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
May 23 2019, 11:04 AM · Restricted Project, Restricted Project
hintonda committed rG0857a4ec20db: [cmake] When getting Ninja version, don't include CMakeNinjaFindMake which… (authored by hintonda).
[cmake] When getting Ninja version, don't include CMakeNinjaFindMake which…
May 23 2019, 8:04 AM

May 22 2019

hintonda added inline comments to D62264: [CommandLine] WIP: Add new debug_opt that reduces down to size of DataType in Release builds..
May 22 2019, 3:41 PM · Restricted Project
hintonda updated the diff for D62264: [CommandLine] WIP: Add new debug_opt that reduces down to size of DataType in Release builds..
  • Added cl::debug_opt_storage with specializations.
May 22 2019, 2:56 PM · Restricted Project
hintonda added inline comments to D62264: [CommandLine] WIP: Add new debug_opt that reduces down to size of DataType in Release builds..
May 22 2019, 11:20 AM · Restricted Project
hintonda created D62264: [CommandLine] WIP: Add new debug_opt that reduces down to size of DataType in Release builds..
May 22 2019, 11:17 AM · Restricted Project

May 21 2019

hintonda committed rG24d27689bc9c: [clang-tidy] remove default header-filter for run-clang-tidy (authored by hintonda).
[clang-tidy] remove default header-filter for run-clang-tidy
May 21 2019, 6:00 PM
hintonda committed rG120a6f09bb95: [Docs] Increase Doxygen cache size (authored by hintonda).
[Docs] Increase Doxygen cache size
May 21 2019, 5:55 PM
hintonda committed rGb61f2b6c8775: [cmake] Don't use VERSION_GREATER_EQUAL in cmake versions prior to 3.72. (authored by hintonda).
[cmake] Don't use VERSION_GREATER_EQUAL in cmake versions prior to 3.72.
May 21 2019, 12:27 PM
hintonda committed rG76e5a1d3c3b1: [cmake] Try to make cmake happy and fix bots. (authored by hintonda).
[cmake] Try to make cmake happy and fix bots.
May 21 2019, 11:50 AM
hintonda committed rGc1b6b9a17776: [cmake] Bug in r361281: make include optional and fix typo which might make a… (authored by hintonda).
[cmake] Bug in r361281: make include optional and fix typo which might make a…
May 21 2019, 11:13 AM
hintonda committed rGbd467cfe4bcd: [cmake] Add custom command to touch archives on Darwin so ninja won't rebuild… (authored by hintonda).
[cmake] Add custom command to touch archives on Darwin so ninja won't rebuild…
May 21 2019, 10:55 AM
hintonda updated the diff for D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them..
  • Use CMAKE_HOST_APPLE when checking host system.
May 21 2019, 10:46 AM · Restricted Project
hintonda updated the diff for D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them..
  • Remove tab.
May 21 2019, 9:52 AM · Restricted Project
hintonda added a comment to D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them..

It is silly that CMake doesn't expose the ninja version, but it is easy enough to get it. It should be something like:

if(CMAKE_GENERATOR STREQUAL "Ninja")
  execute_process(COMMAND ${RunCMake_MAKE_PROGRAM} --version
      OUTPUT_VARIABLE ninja_version OUTPUT_STRIP_TRAILING_WHITESPACE)
  if(ninja_version VERSION_GREATER 1.8.2)
    set(ninja_greater_1_8_2 On)
  endif()
endif()

I know this is a bunch of seemingly odd boiler plate, but since we're working around tools bugs in non-LLVM tools which will hopefully someday be fixed, I'd like to restrict this fix to only places where we know the bug is present.

May 21 2019, 9:45 AM · Restricted Project
hintonda updated the diff for D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them..
  • Don't put new variable in the cache.
May 21 2019, 9:45 AM · Restricted Project
hintonda updated the diff for D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them..
  • Remove unneeded else branch.
May 21 2019, 9:24 AM · Restricted Project
hintonda updated the diff for D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them..
  • Get Ninja version and add LLVM_TOUCH_STATIC_LIBRARIES.
May 21 2019, 8:55 AM · Restricted Project
hintonda updated the diff for D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them..
  • Restrict to Darwin > 15.6.0. Ninja version not available, so will add code to get that and hide all of this under a new variable in the next version of this patch.
May 21 2019, 8:17 AM · Restricted Project
hintonda accepted D62174: [Analysis] Link library dependencies to Analysis plugins.

LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks!

May 21 2019, 7:39 AM · Restricted Project, Restricted Project