This is an archive of the discontinued LLVM Phabricator instance.

[asan] Add lit feature to indicate compiler_rt's shadow scale value
ClosedPublic

Authored by waltl on Nov 7 2017, 4:25 PM.

Event Timeline

waltl created this revision.Nov 7 2017, 4:25 PM
waltl updated this revision to Diff 122459.Nov 10 2017, 9:18 AM

Change approach to only override shadow scale in compiler_rt

vitalybuka added inline comments.Nov 16 2017, 8:44 AM
compiler-rt/test/lit.common.cfg
332 ↗(On Diff #122459)

can we see a patch where it's used?

waltl added inline comments.Nov 16 2017, 8:49 AM
compiler-rt/test/lit.common.cfg
332 ↗(On Diff #122459)
vitalybuka added inline comments.Nov 16 2017, 9:04 AM
compiler-rt/test/lit.common.cfg
332 ↗(On Diff #122459)

WDYT about "config.available_features.add("shadow-scale-%s" % (config.asan_shadow_scale if not empty else 3))"?

So you can replace " UNSUPPORTED: custom-shadow-scale" with " REQUIRES: shadow-scale-3"
This allows to add some scale-5 specific tests

waltl added inline comments.Nov 16 2017, 9:13 AM
compiler-rt/test/lit.common.cfg
332 ↗(On Diff #122459)

That sounds much better. Thanks.

waltl updated this revision to Diff 123240.Nov 16 2017, 2:12 PM

Address CR comments

waltl marked an inline comment as done.Nov 16 2017, 2:25 PM
waltl retitled this revision from [asan] Add lit feature for custom shadow scale to [asan] Add lit feature to indicate compiler_rt's shadow scale value.Nov 16 2017, 2:30 PM
waltl edited the summary of this revision. (Show Details)
vitalybuka accepted this revision.Nov 16 2017, 2:41 PM
This revision is now accepted and ready to land.Nov 16 2017, 2:41 PM
This revision was automatically updated to reflect the committed changes.