alekseyshl (Aleksey Shlyapnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 4:57 PM (41 w, 5 d)

Recent Activity

Wed, Aug 16

alekseyshl accepted D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Wed, Aug 16, 10:51 AM

Tue, Aug 15

alekseyshl added inline comments to D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Tue, Aug 15, 3:50 PM
alekseyshl added inline comments to D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Tue, Aug 15, 3:09 PM
alekseyshl added inline comments to D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Tue, Aug 15, 2:39 PM
alekseyshl added inline comments to D36757: Add C++17 aligned new/delete interceptors to standalone lsan.
Tue, Aug 15, 2:02 PM
alekseyshl accepted D36754: [scudo] Application & platform compatibility changes.

What are these libraries? Can you mention some examples here?

Tue, Aug 15, 1:54 PM

Fri, Aug 11

alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

Couldn't fix/find the actual error so for now, just moving the flag patch tests to openmp-offload-gpu.c which is a disabled test.

310765

Bad news, the bot is still red: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7114

Fri, Aug 11, 4:13 PM
alekseyshl committed rL310772: Disabling openmp-offload.c on linux until it is stabilized on all local….
Disabling openmp-offload.c on linux until it is stabilized on all local…
Fri, Aug 11, 4:11 PM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.
Fri, Aug 11, 3:44 PM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 failed on r310718, please fix.

Fri, Aug 11, 1:04 PM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

I have re-enabled the previous offloading tests and moved the new GPU offloading tests to a new file which is disabled for linux (for now).

310718

Alex thanks so much for the logs, they have been very useful to understand what's going on.

Aleksey, I have since tried to install a Clang version with the address sanitizer enabled but without much success. Apart from turning on the sanitizer in the cmake using the -DLLVM_USE_SANITIZER="Address" flag is there any other flag that I need to pass to cmake?
I am trying to run this on my macbook x86_64 and OS X 10.11. I am getting the following error when building the compiler:

[2966/4254] Linking CXX shared library lib/libc++abi.1.0.dylib
FAILED: lib/libc++abi.1.0.dylib
Undefined symbols for architecture x86_64:

"___asan_after_dynamic_init", referenced from:
    __GLOBAL__sub_I_cxa_default_handlers.cpp in cxa_default_handlers.cpp.o
"___asan_before_dynamic_init", referenced from:
    __GLOBAL__sub_I_cxa_default_handlers.cpp in cxa_default_handlers.cpp.o

[...]
ld: symbol(s) not found for architecture x86_64

Fri, Aug 11, 10:02 AM
alekseyshl accepted D36399: [sanitizers] Add a blocking boolean to GetRandom prototype.
Fri, Aug 11, 7:53 AM

Thu, Aug 10

alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

The failures were very widespread, e.g. there's a linux buildbot that was red until the revert: http://bb.pgr.jp/builders/test-clang-i686-linux-RA. If you have access to a linux machine you should be able to reproduce the failures that the bot experienced by using the same cmake arguments (I don't know the exact ones, but judging from the bot you should be able to reproduce them using 32 bit release build with assertions enabled). I don't know what GPU that buildbot has.

Thanks Alex, I will try to reproduce it locally.

I'll try to get the detailed test output for my local machine today as well.

Oh that would be great! Thanks a lot! :)

First of all, I apologize if I've upset you with my previous post. I am actively working on understanding what is causing these issues. It is not my intention to write tests that work on local configurations only. I am upset to see that these tests keep failing for your and maybe other configurations. Without knowing the actual reason of the failures I can only speculate what is going wrong with them hence the flurry of changes.

Thank you, apology accepted. That was exactly my point, not to start a fight, but to emphasize that depending on local configuration is never going to work, you will never be able to see and test all of them. Please disable the test ASAP and until the better way to handle it is determined.

I have disabled all the offloading tests apart from the ones that pertain to the patch previous to the one introducing Cubin integration into host bin.
Please let me know if you see any more failures on your side. If you do feel free to revert all the patches up to and including: D29654

310625

Our bots still fai after this changel: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7085

Thu, Aug 10, 10:57 AM
alekseyshl committed rL310640: Disabling openmp-offload.c on linux until it is stabilized on all local….
Disabling openmp-offload.c on linux until it is stabilized on all local…
Thu, Aug 10, 10:55 AM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

The failures were very widespread, e.g. there's a linux buildbot that was red until the revert: http://bb.pgr.jp/builders/test-clang-i686-linux-RA. If you have access to a linux machine you should be able to reproduce the failures that the bot experienced by using the same cmake arguments (I don't know the exact ones, but judging from the bot you should be able to reproduce them using 32 bit release build with assertions enabled). I don't know what GPU that buildbot has.

Thanks Alex, I will try to reproduce it locally.

I'll try to get the detailed test output for my local machine today as well.

Oh that would be great! Thanks a lot! :)

Thu, Aug 10, 10:54 AM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

First of all, I apologize if I've upset you with my previous post. I am actively working on understanding what is causing these issues. It is not my intention to write tests that work on local configurations only. I am upset to see that these tests keep failing for your and maybe other configurations. Without knowing the actual reason of the failures I can only speculate what is going wrong with them hence the flurry of changes.

Thu, Aug 10, 8:54 AM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

Even after all the reverts in r310580, our tests are still failing (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7080). not surprising, but very disrupting. Please have a plan to fix it soon, otherwise I'll have to revert it even further.

Thu, Aug 10, 8:21 AM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

While I do get the time pressure and such, doing it at the expense of others is not cool. Many teams work process is broken for days, folks are busy looking into it, investigating and reverting, other breakages are masked by these failures etc.

Thu, Aug 10, 8:15 AM

Wed, Aug 9

alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

r310519 did not fix the problem, see http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7062. I would suggest to revert and fix it properly, our bots are broken for a few days already.

Wed, Aug 9, 4:27 PM
alekseyshl added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

Even after r310505, openmp-offload.c continues to haunt our bots, for example http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. Can you please fix this test?

Wed, Aug 9, 1:35 PM
alekseyshl added a comment to D36512: [ValueTracking] Honour recursion limit.

Test failed on http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2011, please fix.

Wed, Aug 9, 11:22 AM

Tue, Aug 8

alekseyshl added a comment to D36385: [asan] Refactor thread creation bookkeeping.

dead returned back?

Tue, Aug 8, 5:37 PM · Restricted Project
alekseyshl added a comment to D36376: Add NetBSD support in asan_malloc_linux.cc.

This bot is unhappy about your change: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/3307. Please fix.

Tue, Aug 8, 4:26 PM · Restricted Project
alekseyshl accepted D36385: [asan] Refactor thread creation bookkeeping.
Tue, Aug 8, 1:53 PM · Restricted Project
alekseyshl added a comment to D29654: [OpenMP] Integrate OpenMP target region cubin into host binary.

Driver/openmp-offload.c still fails on http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7038, please fix.

Tue, Aug 8, 1:14 PM
alekseyshl added inline comments to D36385: [asan] Refactor thread creation bookkeeping.
Tue, Aug 8, 10:28 AM · Restricted Project
alekseyshl added inline comments to D36399: [sanitizers] Add a blocking boolean to GetRandom prototype.
Tue, Aug 8, 9:38 AM
alekseyshl added a comment to D23563: [RISCV 6/10] Add basic RISCVAsmParser.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/3300 is still unhappy about RISCVAsmParser.cpp

Tue, Aug 8, 9:16 AM

Mon, Aug 7

alekseyshl accepted D36430: [asan] Restore dead-code-elimination optimization for Fuchsia.
Mon, Aug 7, 4:50 PM · Restricted Project
alekseyshl added a comment to rL310282: Non-functional change. Fix previous patch D34784..

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7015 is still failing

Mon, Aug 7, 2:02 PM
alekseyshl added a comment to D36295: Port libFuzzer tests to LIT. Do not require two-stage build for check-fuzzer..

http://lab.llvm.org:8011/builders/sanitizer-windows/builds/14939 is unhappy about this change, please fix

Mon, Aug 7, 11:03 AM
alekseyshl added a comment to D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7010 is unhappy about this change, please fix.

Mon, Aug 7, 10:58 AM · Restricted Project

Fri, Aug 4

alekseyshl accepted D36339: [asan] Fix unsupported test on Android.
Fri, Aug 4, 2:26 PM
alekseyshl accepted D36257: [asan] Check for pvalloc overlow.
Fri, Aug 4, 1:21 PM
alekseyshl committed rL310089: [compiler-rt] Check for empty buffer in Addr2LineProcess::ReadFromSymbolizer.
[compiler-rt] Check for empty buffer in Addr2LineProcess::ReadFromSymbolizer
Fri, Aug 4, 11:40 AM
alekseyshl closed D36207: [compiler-rt] Check for empty buffer in Addr2LineProcess::ReadFromSymbolizer by committing rL310089: [compiler-rt] Check for empty buffer in Addr2LineProcess::ReadFromSymbolizer.
Fri, Aug 4, 11:40 AM · Restricted Project

Thu, Aug 3

alekseyshl accepted D36207: [compiler-rt] Check for empty buffer in Addr2LineProcess::ReadFromSymbolizer.

addr2line is not necessary present on the system, I don't think you should test for it.

Thu, Aug 3, 5:13 PM · Restricted Project
alekseyshl accepted D36284: [sanitizer] Remove use of task_for_pid from sanitizer_stoptheworld_mac.cc.
Thu, Aug 3, 2:45 PM · Restricted Project
alekseyshl accepted D36257: [asan] Check for pvalloc overlow.
Thu, Aug 3, 2:44 PM

Wed, Aug 2

alekseyshl accepted D36190: [asan] Allocator support for Fuchsia.
Wed, Aug 2, 4:05 PM · Restricted Project
alekseyshl accepted D36245: [tsan] Check for pvalloc overlow.
Wed, Aug 2, 3:46 PM
alekseyshl accepted D36164: [msan] Check for pvalloc overflow.
Wed, Aug 2, 1:29 PM
alekseyshl added inline comments to D36190: [asan] Allocator support for Fuchsia.
Wed, Aug 2, 11:20 AM · Restricted Project

Mon, Jul 31

alekseyshl accepted D36120: [msan] Reverting D36093.
Mon, Jul 31, 3:45 PM
alekseyshl accepted D36093: [msan] Check for pvalloc overflow.
Mon, Jul 31, 11:39 AM
alekseyshl added inline comments to D36032: [sanitizer_common] Fuchsia-specific symbolizer.
Mon, Jul 31, 11:35 AM · Restricted Project

Tue, Jul 25

alekseyshl accepted D35818: [scudo] Check for pvalloc overflow.
Tue, Jul 25, 1:52 PM
alekseyshl added a comment to D35818: [scudo] Check for pvalloc overflow.

Let's have a cl per sanitizer.

Tue, Jul 25, 8:40 AM

Mon, Jul 24

alekseyshl accepted D35799: Add address ranges for individual macho sections on darwin.
Mon, Jul 24, 5:33 PM
alekseyshl accepted D35818: [scudo] Check for pvalloc overflow.

Yep, please do it other sanitizers too. Seems like a reasonable change.

Mon, Jul 24, 5:05 PM
alekseyshl committed rL308929: [Sanitizers] TSan allocator set errno on failure..
[Sanitizers] TSan allocator set errno on failure.
Mon, Jul 24, 2:24 PM
alekseyshl closed D35690: [Sanitizers] TSan allocator set errno on failure. by committing rL308929: [Sanitizers] TSan allocator set errno on failure..
Mon, Jul 24, 2:24 PM
alekseyshl accepted D35806: [scudo] Fix QuarantineChunksUpToSize failing test on AArch64.
Mon, Jul 24, 11:21 AM
alekseyshl accepted D35694: [scudo] Quarantine overhaul.

Looks good

Mon, Jul 24, 7:29 AM
alekseyshl accepted D35798: [compiler-rt] Allow libignore to handle modules with multiple executable sections.
Mon, Jul 24, 7:26 AM

Fri, Jul 21

alekseyshl added a comment to D35586: [ProfData] Detect if zlib is available .

nocompress.test fails on a few targets here http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6639

Fri, Jul 21, 4:26 PM
alekseyshl accepted D34501: [sanitizer] Support libc++abi in addition to libstdc++.
Fri, Jul 21, 3:41 PM
alekseyshl added a comment to D35591: [sanitizer_common] Move filesystem-related code out of sanitizer_common.cc.

I have no access to Win or Mac either but I'll ask around. Or we can just land it and revert if something goes wrong again...

Fri, Jul 21, 3:15 PM · Restricted Project
alekseyshl accepted D35694: [scudo] Quarantine overhaul.
Fri, Jul 21, 3:10 PM
alekseyshl added inline comments to D35165: [sanitizer] Support compiler-rt builtins.
Fri, Jul 21, 2:35 PM
alekseyshl added inline comments to D35690: [Sanitizers] TSan allocator set errno on failure..
Fri, Jul 21, 10:26 AM
alekseyshl updated the diff for D35690: [Sanitizers] TSan allocator set errno on failure..
  • Address comments
Fri, Jul 21, 10:25 AM
alekseyshl added inline comments to D35690: [Sanitizers] TSan allocator set errno on failure..
Fri, Jul 21, 7:57 AM

Jul 20 2017

alekseyshl added inline comments to D35690: [Sanitizers] TSan allocator set errno on failure..
Jul 20 2017, 4:21 PM
alekseyshl updated the diff for D35690: [Sanitizers] TSan allocator set errno on failure..
  • Do not use "tsan_" prefix.
Jul 20 2017, 4:18 PM
alekseyshl added inline comments to D35694: [scudo] Quarantine overhaul.
Jul 20 2017, 3:39 PM
alekseyshl accepted D35432: Only scan global sections containing data in LSan on darwin.

Makes sense!

Jul 20 2017, 10:55 AM
alekseyshl committed rL308640: [sanitizer_common] Move filesystem-related code out of sanitizer_common.cc.
[sanitizer_common] Move filesystem-related code out of sanitizer_common.cc
Jul 20 2017, 10:49 AM
alekseyshl closed D35591: [sanitizer_common] Move filesystem-related code out of sanitizer_common.cc by committing rL308640: [sanitizer_common] Move filesystem-related code out of sanitizer_common.cc.
Jul 20 2017, 10:49 AM · Restricted Project
alekseyshl created D35690: [Sanitizers] TSan allocator set errno on failure..
Jul 20 2017, 10:28 AM

Jul 19 2017

alekseyshl added a comment to D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started.

MSan detects use-of-uninitialized-value in these new tests, please fix: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1855/steps/check-llvm%20msan/logs/stdio

Jul 19 2017, 6:52 PM
alekseyshl accepted D35654: [compiler-rt] Include thread ID into sanitizers logs.
Jul 19 2017, 6:43 PM
alekseyshl accepted D35655: [compiler-rt] Replace VPrintf with VReport in sanitizer_tls_get_addr.cc.
Jul 19 2017, 6:35 PM
alekseyshl committed rL308575: [asan] Move memcpy, memmove, memset code out of asan_interceptors.cc.
[asan] Move memcpy, memmove, memset code out of asan_interceptors.cc
Jul 19 2017, 6:31 PM
alekseyshl closed D35590: [asan] Move memcpy, memmove, memset code out of asan_interceptors.cc by committing rL308575: [asan] Move memcpy, memmove, memset code out of asan_interceptors.cc.
Jul 19 2017, 6:31 PM · Restricted Project
alekseyshl added a comment to D35590: [asan] Move memcpy, memmove, memset code out of asan_interceptors.cc.

Will do!

Jul 19 2017, 12:57 PM · Restricted Project
alekseyshl accepted D35591: [sanitizer_common] Move filesystem-related code out of sanitizer_common.cc.
Jul 19 2017, 12:08 PM · Restricted Project
alekseyshl accepted D35590: [asan] Move memcpy, memmove, memset code out of asan_interceptors.cc.

Can we rename them to asan_interceptors_memintrinsics.cc/.h? Other than that, lgtm.

Jul 19 2017, 10:02 AM · Restricted Project

Jul 18 2017

alekseyshl added a comment to D35500: [Sparc] Added software multiplication/division feature.

MSan detects use of unitialized values, please fix: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1846

Jul 18 2017, 5:38 PM
alekseyshl accepted D35513: Don't call exit() from atexit handlers on Darwin.
Jul 18 2017, 12:47 PM
alekseyshl added a comment to D29892: ar: add llvm-dlltool support.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6544 is not happy about this patch.

Jul 18 2017, 12:30 PM
alekseyshl committed rL308344: [Sanitizers] ASan/MSan/LSan allocators set errno on failure..
[Sanitizers] ASan/MSan/LSan allocators set errno on failure.
Jul 18 2017, 12:11 PM
alekseyshl closed D35275: [Sanitizers] MSan allocator set errno on failure. by committing rL308344: [Sanitizers] ASan/MSan/LSan allocators set errno on failure..
Jul 18 2017, 12:11 PM
alekseyshl updated the diff for D35275: [Sanitizers] MSan allocator set errno on failure..
  • Disable errno test on Windows until we figure out the problem.
Jul 18 2017, 9:57 AM

Jul 17 2017

alekseyshl added inline comments to D35513: Don't call exit() from atexit handlers on Darwin.
Jul 17 2017, 6:13 PM
alekseyshl accepted D35512: [sanitizers] Make sure that all complex macros uses parenthesis.
Jul 17 2017, 3:35 PM
alekseyshl accepted D35432: Only scan global sections containing data in LSan on darwin.
Jul 17 2017, 3:33 PM
alekseyshl updated the diff for D35275: [Sanitizers] MSan allocator set errno on failure..
  • Move common functions to sanitizer_common.
Jul 17 2017, 3:30 PM
alekseyshl added inline comments to D35275: [Sanitizers] MSan allocator set errno on failure..
Jul 17 2017, 3:29 PM

Jul 14 2017

alekseyshl added inline comments to D35275: [Sanitizers] MSan allocator set errno on failure..
Jul 14 2017, 6:45 PM
alekseyshl updated the diff for D35275: [Sanitizers] MSan allocator set errno on failure..
  • Rename the check function and add a few UNLIKELY around.
Jul 14 2017, 6:40 PM
alekseyshl added a comment to D35432: Only scan global sections containing data in LSan on darwin.

Oh, and darin -> Darwin in the title

Jul 14 2017, 5:19 PM
alekseyshl added inline comments to D35432: Only scan global sections containing data in LSan on darwin.
Jul 14 2017, 5:17 PM
alekseyshl added inline comments to D35422: Add MemoryMappedSection struct for two-level memory map iteration.
Jul 14 2017, 4:46 PM
alekseyshl retitled D35275: [Sanitizers] MSan allocator set errno on failure. from [Sanitizers] ASan/MSan/LSan allocators set errno on failure. to [Sanitizers] MSan allocator set errno on failure..
Jul 14 2017, 4:23 PM
alekseyshl updated the diff for D35275: [Sanitizers] MSan allocator set errno on failure..

Merging with HEAD

Jul 14 2017, 4:18 PM
alekseyshl accepted D35422: Add MemoryMappedSection struct for two-level memory map iteration.

Looks good, thank you!

Jul 14 2017, 4:16 PM
alekseyshl committed rL308064: [Sanitizers] ASan and LSan allocator set errno on failure..
[Sanitizers] ASan and LSan allocator set errno on failure.
Jul 14 2017, 3:24 PM
alekseyshl closed D35440: [Sanitizers] ASan and LSan allocator set errno on failure. by committing rL308064: [Sanitizers] ASan and LSan allocator set errno on failure..
Jul 14 2017, 3:24 PM
alekseyshl committed rL308063: [Sanitizers] LSan allocator set errno on failure..
[Sanitizers] LSan allocator set errno on failure.
Jul 14 2017, 3:24 PM