- User Since
- Oct 31 2016, 4:57 PM (41 w, 5 d)
Wed, Aug 16
Tue, Aug 15
What are these libraries? Can you mention some examples here?
Fri, Aug 11
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 failed on r310718, please fix.
Thu, Aug 10
Even after all the reverts in r310580, our tests are still failing (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7080). not surprising, but very disrupting. Please have a plan to fix it soon, otherwise I'll have to revert it even further.
While I do get the time pressure and such, doing it at the expense of others is not cool. Many teams work process is broken for days, folks are busy looking into it, investigating and reverting, other breakages are masked by these failures etc.
Wed, Aug 9
r310519 did not fix the problem, see http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7062. I would suggest to revert and fix it properly, our bots are broken for a few days already.
Even after r310505, openmp-offload.c continues to haunt our bots, for example http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. Can you please fix this test?
Test failed on http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2011, please fix.
Tue, Aug 8
This bot is unhappy about your change: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/3307. Please fix.
Driver/openmp-offload.c still fails on http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7038, please fix.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/3300 is still unhappy about RISCVAsmParser.cpp
Mon, Aug 7
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/14939 is unhappy about this change, please fix
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7010 is unhappy about this change, please fix.
Fri, Aug 4
Thu, Aug 3
addr2line is not necessary present on the system, I don't think you should test for it.
Wed, Aug 2
Mon, Jul 31
Tue, Jul 25
Let's have a cl per sanitizer.
Mon, Jul 24
Yep, please do it other sanitizers too. Seems like a reasonable change.
Fri, Jul 21
nocompress.test fails on a few targets here http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6639
I have no access to Win or Mac either but I'll ask around. Or we can just land it and revert if something goes wrong again...
- Address comments
Jul 20 2017
- Do not use "tsan_" prefix.
Jul 19 2017
MSan detects use-of-uninitialized-value in these new tests, please fix: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1855/steps/check-llvm%20msan/logs/stdio
Can we rename them to asan_interceptors_memintrinsics.cc/.h? Other than that, lgtm.
Jul 18 2017
MSan detects use of unitialized values, please fix: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1846
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6544 is not happy about this patch.
- Disable errno test on Windows until we figure out the problem.
Jul 17 2017
- Move common functions to sanitizer_common.
Jul 14 2017
- Rename the check function and add a few UNLIKELY around.
Oh, and darin -> Darwin in the title
Merging with HEAD
Looks good, thank you!