alekseyshl (Aleksey Shlyapnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 4:57 PM (102 w, 5 d)

Recent Activity

Aug 23 2018

alekseyshl accepted D50940: [sanitizer] Change Mmap*NoAccess to return nullptr on error.
Aug 23 2018, 12:49 PM

Aug 20 2018

alekseyshl added a comment to D50940: [sanitizer] Change Mmap*NoAccess to return nullptr on error.

I do support the unification of the return value, and if no call site is currently care for the actual syscall return value, I'd say, let's make all of them return pointer, nullptr or die. MMAP_FAILED might be a reasonable common ground too, but seems like nullptr is used in many places already and Windows returns NULL on failure, so a bit more unification across platforms here.

Aug 20 2018, 11:12 AM

Aug 17 2018

alekseyshl added a comment to D50910: [sanitizer] Use private futex operations for BlockingMutex.

Have you noticed any difference in performance? I tried the same back in March I have not noticed any perf gain on the couple of benchmarks. I am merely curious, I think this is a right change to make anyways.

Aug 17 2018, 5:11 PM

Jul 19 2018

alekseyshl removed a reviewer for D32895: [ASAN] Insert call to __asan_init and load of dynamic shadow address in correct order: alekseyshl.
Jul 19 2018, 10:51 AM · Restricted Project
alekseyshl removed a reviewer for D40349: [LSan] New experimental flag for background leak checking before exit.: alekseyshl.
Jul 19 2018, 10:51 AM
alekseyshl accepted D49505: [scudo] Simplify internal names (NFC).
Jul 19 2018, 10:50 AM

Jul 18 2018

alekseyshl added a comment to D49505: [scudo] Simplify internal names (NFC).

Well, now it is not consistent. Why some types end with T and some not (AllocatorCacheT vs PrimaryAllocator)? Why combined allocator is called Backend and struct Allocator is not called Frontend?

Jul 18 2018, 3:26 PM
alekseyshl added inline comments to D49505: [scudo] Simplify internal names (NFC).
Jul 18 2018, 1:17 PM

Jul 16 2018

alekseyshl accepted D49367: sanitizers: consistently check result of MmapFixedNoReserve.
Jul 16 2018, 9:56 AM

Jul 9 2018

alekseyshl committed rCRT336573: [ASan] Minor ASan error reporting cleanup.
[ASan] Minor ASan error reporting cleanup
Jul 9 2018, 11:01 AM
alekseyshl committed rL336573: [ASan] Minor ASan error reporting cleanup.
[ASan] Minor ASan error reporting cleanup
Jul 9 2018, 10:59 AM
alekseyshl closed D49044: [ASan] Minor ASan error reporting cleanup.
Jul 9 2018, 10:59 AM

Jul 6 2018

alekseyshl created D49044: [ASan] Minor ASan error reporting cleanup.
Jul 6 2018, 2:12 PM

Jul 5 2018

alekseyshl accepted D48902: [scudo] Add some logs for Android.
Jul 5 2018, 4:03 PM

Jul 3 2018

alekseyshl accepted D48885: [scudo] Get rid of builtin-declaration-mismatch warnings.
Jul 3 2018, 10:09 AM

Jul 2 2018

alekseyshl accepted D48833: [Driver] Add PPC64 as supported for Scudo.
Jul 2 2018, 1:57 PM
alekseyshl accepted D48834: [scudo] Enable Scudo on PPC64.

Awesome!

Jul 2 2018, 1:57 PM

Jun 29 2018

alekseyshl committed rL336011: [HWASan] Do not retag allocas before return from the function..
[HWASan] Do not retag allocas before return from the function.
Jun 29 2018, 1:25 PM
alekseyshl closed D48664: [HWASan] Do not retag allocas before return from the function..
Jun 29 2018, 1:25 PM

Jun 28 2018

alekseyshl added a comment to D48664: [HWASan] Do not retag allocas before return from the function..

Good, but please update flag description, too.

Jun 28 2018, 4:21 PM
alekseyshl added a comment to D48664: [HWASan] Do not retag allocas before return from the function..

How about this name?

Jun 28 2018, 2:59 PM
alekseyshl updated the diff for D48664: [HWASan] Do not retag allocas before return from the function..
  • Renamed the flag
Jun 28 2018, 2:59 PM
alekseyshl updated the summary of D48664: [HWASan] Do not retag allocas before return from the function..
Jun 28 2018, 2:47 PM
alekseyshl committed rCRT335928: [TSan] More detailed error message on failed sahdow memory madvise.
[TSan] More detailed error message on failed sahdow memory madvise
Jun 28 2018, 2:43 PM
alekseyshl committed rL335928: [TSan] More detailed error message on failed sahdow memory madvise.
[TSan] More detailed error message on failed sahdow memory madvise
Jun 28 2018, 2:43 PM
alekseyshl closed D48668: [TSan] More detailed error message on failed sahdow memory madvise.
Jun 28 2018, 2:43 PM

Jun 27 2018

alekseyshl created D48668: [TSan] More detailed error message on failed sahdow memory madvise.
Jun 27 2018, 1:11 PM
alekseyshl created D48664: [HWASan] Do not retag allocas before return from the function..
Jun 27 2018, 11:13 AM

Jun 25 2018

alekseyshl committed rL335502: [HWASan] Initalize shadow earler..
[HWASan] Initalize shadow earler.
Jun 25 2018, 10:32 AM
alekseyshl committed rCRT335502: [HWASan] Initalize shadow earler..
[HWASan] Initalize shadow earler.
Jun 25 2018, 10:32 AM
alekseyshl closed D48551: [HWASan] Initalize shadow earler..
Jun 25 2018, 10:31 AM
alekseyshl added a comment to D48142: [Sanitizers] Make sanitizer allocator linker-initialize compliant..

Clang still warns:

/Users/filcab/dev/llvm/compiler-rt/lib/asan/asan_allocator.cc:793:18: warning: declaration requires a global constructor [-Wglobal-constructors]
static Allocator instance(LINKER_INITIALIZED);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Ah, that's the Asan allocator, which might be bringing something else on. It's probably not about this patch. Sorry for the noise.

Jun 25 2018, 10:25 AM
alekseyshl created D48551: [HWASan] Initalize shadow earler..
Jun 25 2018, 9:51 AM

Jun 20 2018

alekseyshl removed a reviewer for D41243: [ASan] Add interceptros for fortified strcat, strncat, strcpy, strncpy.: alekseyshl.
Jun 20 2018, 5:19 PM · Restricted Project
alekseyshl accepted D48390: ASan docs: no_sanitize("address") works on globals..
Jun 20 2018, 5:19 PM
alekseyshl committed rL335147: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
[Sanitizers] Remove OOM/BadRequest allocator error handling policies.
Jun 20 2018, 10:15 AM
alekseyshl committed rCRT335147: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
[Sanitizers] Remove OOM/BadRequest allocator error handling policies.
Jun 20 2018, 10:15 AM
alekseyshl closed D48328: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
Jun 20 2018, 10:15 AM

Jun 19 2018

alekseyshl updated the diff for D48328: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
  • Improve error messages
Jun 19 2018, 10:40 AM
alekseyshl created D48328: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
Jun 19 2018, 10:28 AM

Jun 18 2018

alekseyshl committed rL334975: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[TSan] Report proper error on allocator failures instead of CHECK(0)-ing
Jun 18 2018, 1:08 PM
alekseyshl committed rCRT334975: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[TSan] Report proper error on allocator failures instead of CHECK(0)-ing
Jun 18 2018, 1:08 PM
alekseyshl closed D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Jun 18 2018, 1:07 PM
alekseyshl added inline comments to D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Jun 18 2018, 11:18 AM
alekseyshl added a reviewer for D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing: vitalybuka.
Jun 18 2018, 10:23 AM

Jun 15 2018

alekseyshl accepted D48228: [scudo] Move noinline functions definitions out of line.
Jun 15 2018, 10:58 AM

Jun 14 2018

alekseyshl accepted D48199: [scudo] Add verbose failures in place of CHECK(0).
Jun 14 2018, 3:14 PM
alekseyshl updated subscribers of D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.

MSan found a problem here:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/19549/steps/check-llvm%20msan/logs/stdio

Jun 14 2018, 12:17 PM
alekseyshl committed rCRT334749: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
[MSan] Linker-initialize static fallback_mutex in msan_allocator.cc
Jun 14 2018, 11:35 AM
alekseyshl committed rL334749: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
[MSan] Linker-initialize static fallback_mutex in msan_allocator.cc
Jun 14 2018, 11:35 AM
alekseyshl closed D48145: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
Jun 14 2018, 11:35 AM
alekseyshl committed rCRT334748: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
[ASan] Linker-initialize static ScopedInErrorReport::current_error_.
Jun 14 2018, 11:27 AM
alekseyshl committed rL334748: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
[ASan] Linker-initialize static ScopedInErrorReport::current_error_.
Jun 14 2018, 11:26 AM
alekseyshl closed D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
Jun 14 2018, 11:26 AM
alekseyshl added a comment to D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..

Isn't this basically https://reviews.llvm.org/D44243 ?

It is! Thanks, missed that one. I'm fine with that one being committed too. Is the explanation on this patch satisfactory?

minor nit: s/on the startup/on application startup/ or s/on the startup/on startup/

I'm fine with either patch. My issue with D44243 is that the reason for the change wasn't provided. The explanation you provide was satisfactory once I read https://github.com/google/sanitizers/issues/194 .
Without reading the github issue it's not so clear what _asan_init-safe means. I'll leave it up to you to decide whether you want the commit message to be clear when read on its own or whether
referencing the GitHub issue is sufficient.

Jun 14 2018, 11:16 AM
alekseyshl updated the summary of D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
Jun 14 2018, 11:15 AM

Jun 13 2018

alekseyshl accepted D48148: [scudo] Make Secondary linker-initialized compliant.
Jun 13 2018, 2:50 PM
alekseyshl committed rCRT334660: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
[Sanitizers] Make sanitizer allocator linker-initialize compliant.
Jun 13 2018, 2:49 PM
alekseyshl committed rL334660: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
[Sanitizers] Make sanitizer allocator linker-initialize compliant.
Jun 13 2018, 2:49 PM
alekseyshl closed D48142: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
Jun 13 2018, 2:49 PM
alekseyshl added a comment to D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..

Isn't this basically https://reviews.llvm.org/D44243 ?

Jun 13 2018, 1:10 PM
alekseyshl created D48145: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
Jun 13 2018, 1:00 PM
alekseyshl created D48142: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
Jun 13 2018, 12:31 PM
alekseyshl created D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
Jun 13 2018, 12:06 PM
alekseyshl committed rCRT334624: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
[TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory
Jun 13 2018, 10:23 AM
alekseyshl committed rL334624: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
[TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory
Jun 13 2018, 10:23 AM
alekseyshl closed D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
Jun 13 2018, 10:23 AM
alekseyshl added a comment to D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.

Thanks!

Jun 13 2018, 9:05 AM
alekseyshl updated the diff for D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
  • Die on madvise-ing shadow memory failure.
Jun 13 2018, 7:59 AM

Jun 12 2018

alekseyshl created D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
Jun 12 2018, 2:26 PM
alekseyshl created D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Jun 12 2018, 11:30 AM
alekseyshl accepted D47960: [asan, myriad] Support environment variables.
Jun 12 2018, 11:24 AM

Jun 11 2018

alekseyshl accepted D48031: [scudo] Add C++17 aligned new/delete operators support.
Jun 11 2018, 4:56 PM
alekseyshl committed rCRT334438: [Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc.
[Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc
Jun 11 2018, 2:08 PM
alekseyshl committed rL334438: [Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc.
[Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc
Jun 11 2018, 2:08 PM
alekseyshl committed rCRT334433: [Sanitizers] Move allocator_returns_null.cc test to common..
[Sanitizers] Move allocator_returns_null.cc test to common.
Jun 11 2018, 12:50 PM
alekseyshl committed rL334433: [Sanitizers] Move allocator_returns_null.cc test to common..
[Sanitizers] Move allocator_returns_null.cc test to common.
Jun 11 2018, 12:50 PM
alekseyshl closed D47971: [Sanitizers] Move allocator_returns_null.cc test to common..
Jun 11 2018, 12:50 PM
alekseyshl added inline comments to D48031: [scudo] Add C++17 aligned new/delete operators support.
Jun 11 2018, 12:48 PM
alekseyshl added inline comments to D47960: [asan, myriad] Support environment variables.
Jun 11 2018, 11:31 AM
alekseyshl added inline comments to D48031: [scudo] Add C++17 aligned new/delete operators support.
Jun 11 2018, 11:12 AM
alekseyshl committed rCRT334424: [Sanitizers] Move pvalloc overflow tests to common..
[Sanitizers] Move pvalloc overflow tests to common.
Jun 11 2018, 10:38 AM
alekseyshl committed rL334424: [Sanitizers] Move pvalloc overflow tests to common..
[Sanitizers] Move pvalloc overflow tests to common.
Jun 11 2018, 10:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Jun 11 2018, 10:38 AM

Jun 8 2018

alekseyshl created D47971: [Sanitizers] Move allocator_returns_null.cc test to common..
Jun 8 2018, 6:32 PM
alekseyshl created D47970: [Sanitizers] Move pvalloc overflow tests to common..
Jun 8 2018, 5:59 PM
alekseyshl committed rCRT334340: [MSan] Switch to common aligned allocs tests..
[MSan] Switch to common aligned allocs tests.
Jun 8 2018, 5:52 PM
alekseyshl committed rL334340: [MSan] Switch to common aligned allocs tests..
[MSan] Switch to common aligned allocs tests.
Jun 8 2018, 5:52 PM
alekseyshl closed D47968: [MSan] Switch to common aligned allocs tests..
Jun 8 2018, 5:51 PM
alekseyshl created D47968: [MSan] Switch to common aligned allocs tests..
Jun 8 2018, 5:29 PM
alekseyshl committed rCRT334338: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[MSan] Report proper error on allocator failures instead of CHECK(0)-ing
Jun 8 2018, 4:37 PM
alekseyshl committed rL334338: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[MSan] Report proper error on allocator failures instead of CHECK(0)-ing
Jun 8 2018, 4:37 PM
alekseyshl closed D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Jun 8 2018, 4:36 PM
alekseyshl updated the diff for D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
  • rebasing
Jun 8 2018, 3:49 PM
alekseyshl committed rL334332: [Sanitizers] Use proper substitution in common allocator test..
[Sanitizers] Use proper substitution in common allocator test.
Jun 8 2018, 3:02 PM
alekseyshl committed rCRT334332: [Sanitizers] Use proper substitution in common allocator test..
[Sanitizers] Use proper substitution in common allocator test.
Jun 8 2018, 3:02 PM
alekseyshl accepted D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.
Jun 8 2018, 2:12 PM
alekseyshl committed rCRT334316: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
[Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign
Jun 8 2018, 1:45 PM
alekseyshl committed rL334316: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
[Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign
Jun 8 2018, 1:45 PM
alekseyshl closed D47924: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
Jun 8 2018, 1:45 PM