alekseyshl (Aleksey Shlyapnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 4:57 PM (85 w, 2 d)

Recent Activity

Yesterday

alekseyshl removed a reviewer for D41243: [ASan] Add interceptros for fortified strcat, strncat, strcpy, strncpy.: alekseyshl.
Wed, Jun 20, 5:19 PM · Restricted Project
alekseyshl accepted D48390: ASan docs: no_sanitize("address") works on globals..
Wed, Jun 20, 5:19 PM
alekseyshl committed rL335147: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
[Sanitizers] Remove OOM/BadRequest allocator error handling policies.
Wed, Jun 20, 10:15 AM
alekseyshl committed rCRT335147: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
[Sanitizers] Remove OOM/BadRequest allocator error handling policies.
Wed, Jun 20, 10:15 AM
alekseyshl closed D48328: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
Wed, Jun 20, 10:15 AM

Tue, Jun 19

alekseyshl updated the diff for D48328: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
  • Improve error messages
Tue, Jun 19, 10:40 AM
alekseyshl created D48328: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
Tue, Jun 19, 10:28 AM

Mon, Jun 18

alekseyshl committed rL334975: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[TSan] Report proper error on allocator failures instead of CHECK(0)-ing
Mon, Jun 18, 1:08 PM
alekseyshl committed rCRT334975: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[TSan] Report proper error on allocator failures instead of CHECK(0)-ing
Mon, Jun 18, 1:08 PM
alekseyshl closed D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Mon, Jun 18, 1:07 PM
alekseyshl added inline comments to D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Mon, Jun 18, 11:18 AM
alekseyshl added a reviewer for D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing: vitalybuka.
Mon, Jun 18, 10:23 AM

Fri, Jun 15

alekseyshl accepted D48228: [scudo] Move noinline functions definitions out of line.
Fri, Jun 15, 10:58 AM

Thu, Jun 14

alekseyshl accepted D48199: [scudo] Add verbose failures in place of CHECK(0).
Thu, Jun 14, 3:14 PM
alekseyshl updated subscribers of D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.

MSan found a problem here:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/19549/steps/check-llvm%20msan/logs/stdio

Thu, Jun 14, 12:17 PM
alekseyshl committed rCRT334749: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
[MSan] Linker-initialize static fallback_mutex in msan_allocator.cc
Thu, Jun 14, 11:35 AM
alekseyshl committed rL334749: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
[MSan] Linker-initialize static fallback_mutex in msan_allocator.cc
Thu, Jun 14, 11:35 AM
alekseyshl closed D48145: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
Thu, Jun 14, 11:35 AM
alekseyshl committed rCRT334748: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
[ASan] Linker-initialize static ScopedInErrorReport::current_error_.
Thu, Jun 14, 11:27 AM
alekseyshl committed rL334748: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
[ASan] Linker-initialize static ScopedInErrorReport::current_error_.
Thu, Jun 14, 11:26 AM
alekseyshl closed D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
Thu, Jun 14, 11:26 AM
alekseyshl added a comment to D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..

Isn't this basically https://reviews.llvm.org/D44243 ?

It is! Thanks, missed that one. I'm fine with that one being committed too. Is the explanation on this patch satisfactory?

minor nit: s/on the startup/on application startup/ or s/on the startup/on startup/

I'm fine with either patch. My issue with D44243 is that the reason for the change wasn't provided. The explanation you provide was satisfactory once I read https://github.com/google/sanitizers/issues/194 .
Without reading the github issue it's not so clear what _asan_init-safe means. I'll leave it up to you to decide whether you want the commit message to be clear when read on its own or whether
referencing the GitHub issue is sufficient.

Thu, Jun 14, 11:16 AM
alekseyshl updated the summary of D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
Thu, Jun 14, 11:15 AM

Wed, Jun 13

alekseyshl accepted D48148: [scudo] Make Secondary linker-initialized compliant.
Wed, Jun 13, 2:50 PM
alekseyshl committed rCRT334660: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
[Sanitizers] Make sanitizer allocator linker-initialize compliant.
Wed, Jun 13, 2:49 PM
alekseyshl committed rL334660: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
[Sanitizers] Make sanitizer allocator linker-initialize compliant.
Wed, Jun 13, 2:49 PM
alekseyshl closed D48142: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
Wed, Jun 13, 2:49 PM
alekseyshl added a comment to D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..

Isn't this basically https://reviews.llvm.org/D44243 ?

Wed, Jun 13, 1:10 PM
alekseyshl created D48145: [MSan] Linker-initialize static fallback_mutex in msan_allocator.cc.
Wed, Jun 13, 1:00 PM
alekseyshl created D48142: [Sanitizers] Make sanitizer allocator linker-initialize compliant..
Wed, Jun 13, 12:31 PM
alekseyshl created D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..
Wed, Jun 13, 12:06 PM
alekseyshl committed rCRT334624: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
[TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory
Wed, Jun 13, 10:23 AM
alekseyshl committed rL334624: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
[TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory
Wed, Jun 13, 10:23 AM
alekseyshl closed D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
Wed, Jun 13, 10:23 AM
alekseyshl added a comment to D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.

Thanks!

Wed, Jun 13, 9:05 AM
alekseyshl updated the diff for D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
  • Die on madvise-ing shadow memory failure.
Wed, Jun 13, 7:59 AM

Tue, Jun 12

alekseyshl created D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory.
Tue, Jun 12, 2:26 PM
alekseyshl created D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Tue, Jun 12, 11:30 AM
alekseyshl accepted D47960: [asan, myriad] Support environment variables.
Tue, Jun 12, 11:24 AM

Mon, Jun 11

alekseyshl accepted D48031: [scudo] Add C++17 aligned new/delete operators support.
Mon, Jun 11, 4:56 PM
alekseyshl committed rCRT334438: [Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc.
[Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc
Mon, Jun 11, 2:08 PM
alekseyshl committed rL334438: [Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc.
[Sanitizers] %tool_options -> %env_tool_opts in allocator_returns_null.cc
Mon, Jun 11, 2:08 PM
alekseyshl committed rCRT334433: [Sanitizers] Move allocator_returns_null.cc test to common..
[Sanitizers] Move allocator_returns_null.cc test to common.
Mon, Jun 11, 12:50 PM
alekseyshl committed rL334433: [Sanitizers] Move allocator_returns_null.cc test to common..
[Sanitizers] Move allocator_returns_null.cc test to common.
Mon, Jun 11, 12:50 PM
alekseyshl closed D47971: [Sanitizers] Move allocator_returns_null.cc test to common..
Mon, Jun 11, 12:50 PM
alekseyshl added inline comments to D48031: [scudo] Add C++17 aligned new/delete operators support.
Mon, Jun 11, 12:48 PM
alekseyshl added inline comments to D47960: [asan, myriad] Support environment variables.
Mon, Jun 11, 11:31 AM
alekseyshl added inline comments to D48031: [scudo] Add C++17 aligned new/delete operators support.
Mon, Jun 11, 11:12 AM
alekseyshl committed rCRT334424: [Sanitizers] Move pvalloc overflow tests to common..
[Sanitizers] Move pvalloc overflow tests to common.
Mon, Jun 11, 10:38 AM
alekseyshl committed rL334424: [Sanitizers] Move pvalloc overflow tests to common..
[Sanitizers] Move pvalloc overflow tests to common.
Mon, Jun 11, 10:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Jun 11, 10:38 AM

Fri, Jun 8

alekseyshl created D47971: [Sanitizers] Move allocator_returns_null.cc test to common..
Fri, Jun 8, 6:32 PM
alekseyshl created D47970: [Sanitizers] Move pvalloc overflow tests to common..
Fri, Jun 8, 5:59 PM
alekseyshl committed rCRT334340: [MSan] Switch to common aligned allocs tests..
[MSan] Switch to common aligned allocs tests.
Fri, Jun 8, 5:52 PM
alekseyshl committed rL334340: [MSan] Switch to common aligned allocs tests..
[MSan] Switch to common aligned allocs tests.
Fri, Jun 8, 5:52 PM
alekseyshl closed D47968: [MSan] Switch to common aligned allocs tests..
Fri, Jun 8, 5:51 PM
alekseyshl created D47968: [MSan] Switch to common aligned allocs tests..
Fri, Jun 8, 5:29 PM
alekseyshl committed rCRT334338: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[MSan] Report proper error on allocator failures instead of CHECK(0)-ing
Fri, Jun 8, 4:37 PM
alekseyshl committed rL334338: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[MSan] Report proper error on allocator failures instead of CHECK(0)-ing
Fri, Jun 8, 4:37 PM
alekseyshl closed D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Fri, Jun 8, 4:36 PM
alekseyshl updated the diff for D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
  • rebasing
Fri, Jun 8, 3:49 PM
alekseyshl committed rL334332: [Sanitizers] Use proper substitution in common allocator test..
[Sanitizers] Use proper substitution in common allocator test.
Fri, Jun 8, 3:02 PM
alekseyshl committed rCRT334332: [Sanitizers] Use proper substitution in common allocator test..
[Sanitizers] Use proper substitution in common allocator test.
Fri, Jun 8, 3:02 PM
alekseyshl accepted D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.
Fri, Jun 8, 2:12 PM
alekseyshl committed rCRT334316: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
[Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign
Fri, Jun 8, 1:45 PM
alekseyshl committed rL334316: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
[Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign
Fri, Jun 8, 1:45 PM
alekseyshl closed D47924: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
Fri, Jun 8, 1:45 PM
alekseyshl accepted D47289: [scudo] Improve the scalability of the shared TSD model.

LGTM

Fri, Jun 8, 12:23 PM
alekseyshl added inline comments to D47924: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
Fri, Jun 8, 11:37 AM
alekseyshl added inline comments to D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.
Fri, Jun 8, 9:51 AM

Thu, Jun 7

alekseyshl created D47924: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
Thu, Jun 7, 7:17 PM
alekseyshl committed rCRT334255: [HWASan] Disable allocator_returns_null.cc test on Android..
[HWASan] Disable allocator_returns_null.cc test on Android.
Thu, Jun 7, 6:01 PM
alekseyshl committed rL334255: [HWASan] Disable allocator_returns_null.cc test on Android..
[HWASan] Disable allocator_returns_null.cc test on Android.
Thu, Jun 7, 6:01 PM
alekseyshl added a comment to D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.

Done

Thu, Jun 7, 5:18 PM
alekseyshl updated the diff for D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
  • Add stack trace check to pvalloc test
  • Do not create Posix specific tests just yet
Thu, Jun 7, 5:17 PM
alekseyshl added a comment to D47915: [asan] Handle 0 alignment in PosixMemalignFromLocalPool.

Are you aware of the legal use case of 0 alignment?

Thu, Jun 7, 4:52 PM
alekseyshl added inline comments to D47915: [asan] Handle 0 alignment in PosixMemalignFromLocalPool.
Thu, Jun 7, 4:51 PM
alekseyshl committed rL334248: [HWASan] Report proper error on allocator failures instead of CHECK(0)-ing.
[HWASan] Report proper error on allocator failures instead of CHECK(0)-ing
Thu, Jun 7, 4:38 PM
alekseyshl committed rCRT334248: [HWASan] Report proper error on allocator failures instead of CHECK(0)-ing.
[HWASan] Report proper error on allocator failures instead of CHECK(0)-ing
Thu, Jun 7, 4:37 PM
alekseyshl closed D47798: [HWASan] Report proper error on allocator failures instead of CHECK(0)-ing.
Thu, Jun 7, 4:37 PM
alekseyshl added inline comments to D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Thu, Jun 7, 3:16 PM
alekseyshl added a comment to D47798: [HWASan] Report proper error on allocator failures instead of CHECK(0)-ing.

LGTM

Thu, Jun 7, 11:03 AM
alekseyshl added a reviewer for D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing: vitalybuka.
Thu, Jun 7, 10:54 AM

Wed, Jun 6

alekseyshl added a comment to D47798: [HWASan] Report proper error on allocator failures instead of CHECK(0)-ing.
In D47798#1123142, @kcc wrote:

are tests possible here?

Wed, Jun 6, 11:36 AM
alekseyshl updated the diff for D47798: [HWASan] Report proper error on allocator failures instead of CHECK(0)-ing.
  • Add allocator tests
Wed, Jun 6, 11:35 AM

Tue, Jun 5

alekseyshl created D47798: [HWASan] Report proper error on allocator failures instead of CHECK(0)-ing.
Tue, Jun 5, 2:21 PM
alekseyshl updated the diff for D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
  • Add stack trace check to pvalloc test
Tue, Jun 5, 11:44 AM
alekseyshl created D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Tue, Jun 5, 11:30 AM
alekseyshl committed rCRT334034: [LSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[LSan] Report proper error on allocator failures instead of CHECK(0)-ing
Tue, Jun 5, 11:08 AM
alekseyshl committed rL334034: [LSan] Report proper error on allocator failures instead of CHECK(0)-ing.
[LSan] Report proper error on allocator failures instead of CHECK(0)-ing
Tue, Jun 5, 11:08 AM
alekseyshl closed D47645: [LSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Tue, Jun 5, 11:08 AM
alekseyshl closed D47645: [LSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Tue, Jun 5, 11:08 AM
alekseyshl abandoned D47600: [UBSan] DO NOT COMMIT: precise UBSan checks experiment.

Experimental.

Tue, Jun 5, 10:31 AM
alekseyshl abandoned D47599: [UBSan] DO NOT COMMIT: precise UBSan checks experiment.

Experimental.

Tue, Jun 5, 10:31 AM
alekseyshl accepted D47751: [lsan] Do not check for leaks in the forked process.
Tue, Jun 5, 10:26 AM

Mon, Jun 4

alekseyshl updated the diff for D47645: [LSan] Report proper error on allocator failures instead of CHECK(0)-ing.
  • Move allocator errors reporting to common to share with other sanitizers.
Mon, Jun 4, 6:04 PM

Fri, Jun 1

alekseyshl accepted D47642: [asan, myriad] Implement aligned local pool allocation.
Fri, Jun 1, 2:26 PM
alekseyshl added a comment to D47642: [asan, myriad] Implement aligned local pool allocation.

Are you solving a particular problem or you're just anticipating one?

Fri, Jun 1, 1:39 PM
alekseyshl accepted D47641: [asan, myriad] Configure platform interceptors.
Fri, Jun 1, 12:48 PM
alekseyshl created D47645: [LSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Fri, Jun 1, 11:18 AM