- User Since
- Oct 31 2016, 4:57 PM (50 w, 4 d)
Mon, Oct 16
Fri, Oct 13
Thu, Oct 12
- Always build libFuzzer with frame pointers
Wed, Oct 11
Mon, Oct 9
Other than those couple comments, lgtm.
Thu, Oct 5
Wed, Oct 4
Tue, Oct 3
Code pointers to the future changes would be nice, actually.
Fri, Sep 29
Reverted as r314560, it crashes sanitizer bots.
Our bots are not happy about this change: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2355 and http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/14195 for example, please fix
http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/4004 is broken by this change
Thu, Sep 28
Wed, Sep 27
I wonder what's the error message?
UBsan is not happy about TarWriter.cpp: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8197, can you check it out?
Our bot is broken by this change: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/17178.
vectorLoadStore.cl is failing on our bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187, please check it out
Tue, Sep 26
ASan is not happy about this patch: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8167/steps/check-llvm%20asan/logs/stdio
- Add a couple TODOs
- Switched temporary counter buffer from fixed to random mapping and address minor style comments.
Mon, Sep 25
Sep 15 2017
Sep 14 2017
Ah, right, makes sense.
Would moving SetAllocatorMayReturnNull call earler in the init() function help to resolve the problem?
Sep 13 2017
Sep 12 2017
Sep 11 2017
Sep 8 2017
What's the point of this change? It used to be generic, now it is more limiting. Even if we go this way, wouldn't it be more logical to drop End() altogether and use Default() directly? The code will make more sense.
Sep 5 2017
Aug 25 2017
Aug 24 2017
Have no better ideas either.
Ok, overall, I have no better idea how to implement it, so let's iron out minor details and get it in.
Aug 16 2017
Aug 15 2017
What are these libraries? Can you mention some examples here?
Aug 11 2017
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 failed on r310718, please fix.
Aug 10 2017
Even after all the reverts in r310580, our tests are still failing (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7080). not surprising, but very disrupting. Please have a plan to fix it soon, otherwise I'll have to revert it even further.
While I do get the time pressure and such, doing it at the expense of others is not cool. Many teams work process is broken for days, folks are busy looking into it, investigating and reverting, other breakages are masked by these failures etc.