alekseyshl (Aleksey Shlyapnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 4:57 PM (68 w, 3 d)

Recent Activity

Fri, Feb 16

alekseyshl accepted D43393: [scudo] Make some tests less Linux-y.
Fri, Feb 16, 3:24 PM

Thu, Feb 15

alekseyshl committed rL325276: [TSan] Fix static TLS boundaries calculations in __tls_get_addr interceptor..
[TSan] Fix static TLS boundaries calculations in __tls_get_addr interceptor.
Thu, Feb 15, 11:00 AM
alekseyshl committed rCRT325276: [TSan] Fix static TLS boundaries calculations in __tls_get_addr interceptor..
[TSan] Fix static TLS boundaries calculations in __tls_get_addr interceptor.
Thu, Feb 15, 11:00 AM
alekseyshl closed D43325: [TSan] Fix static TLS boundaries calculations in __tls_get_addr interceptor..
Thu, Feb 15, 11:00 AM

Wed, Feb 14

alekseyshl created D43325: [TSan] Fix static TLS boundaries calculations in __tls_get_addr interceptor..
Wed, Feb 14, 4:30 PM

Fri, Feb 9

alekseyshl added inline comments to D43088: [sanitizer] Size class map & local cache improvements.
Fri, Feb 9, 3:02 PM
alekseyshl accepted D43088: [sanitizer] Size class map & local cache improvements.
Fri, Feb 9, 2:21 PM
alekseyshl added inline comments to D43088: [sanitizer] Size class map & local cache improvements.
Fri, Feb 9, 11:24 AM

Wed, Feb 7

alekseyshl accepted D42980: [scudo] Allow options to be defined at compile time.
Wed, Feb 7, 3:25 PM
alekseyshl added a comment to D42980: [scudo] Allow options to be defined at compile time.

What about TSan setjmp?

Wed, Feb 7, 2:33 PM

Tue, Feb 6

alekseyshl accepted D42980: [scudo] Allow options to be defined at compile time.
Tue, Feb 6, 3:31 PM

Mon, Feb 5

alekseyshl added a comment to D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274).

Rainer, check rC324302 out, you probably want to add test cases for Solaris to test/Driver/sanitizer-ld.c too.

Mon, Feb 5, 4:58 PM · Restricted Project
alekseyshl committed rL324302: Fix test/Driver/sanitizer-ld.c broken by D40903.
Fix test/Driver/sanitizer-ld.c broken by D40903
Mon, Feb 5, 4:54 PM
alekseyshl committed rC324302: Fix test/Driver/sanitizer-ld.c broken by D40903.
Fix test/Driver/sanitizer-ld.c broken by D40903
Mon, Feb 5, 4:54 PM
alekseyshl committed rL324296: [Sanitizers] Basic Solaris sanitizer support (PR 33274).
[Sanitizers] Basic Solaris sanitizer support (PR 33274)
Mon, Feb 5, 4:03 PM
alekseyshl committed rC324296: [Sanitizers] Basic Solaris sanitizer support (PR 33274).
[Sanitizers] Basic Solaris sanitizer support (PR 33274)
Mon, Feb 5, 4:03 PM
alekseyshl closed D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274).
Mon, Feb 5, 4:03 PM · Restricted Project
alekseyshl accepted D42916: [sanitizer] SizeClassMap minor improvement/correctness changes.
Mon, Feb 5, 11:23 AM
alekseyshl accepted D42851: [sanitizer] Allocator local cache improvements.
Mon, Feb 5, 10:05 AM

Thu, Feb 1

alekseyshl accepted D42579: [sanitizer] Implement NanoTime & MonotonicNanoTime for Windows.
Thu, Feb 1, 1:37 PM
alekseyshl committed rCRT323995: Make detect_invalid_pointer_pairs option to be tristate..
Make detect_invalid_pointer_pairs option to be tristate.
Thu, Feb 1, 11:54 AM
alekseyshl committed rL323995: Make detect_invalid_pointer_pairs option to be tristate..
Make detect_invalid_pointer_pairs option to be tristate.
Thu, Feb 1, 11:54 AM
alekseyshl closed D41479: Make detect_invalid_pointer_pairs option to be tristate..
Thu, Feb 1, 11:54 AM
alekseyshl accepted D42696: [scudo] Minor Secondary changes.
Thu, Feb 1, 11:51 AM
alekseyshl accepted D42579: [sanitizer] Implement NanoTime & MonotonicNanoTime for Windows.

What about my top level comment? Should we turn return-to-os off by default on Windows to donot waste time walking free lists?

I didn't see it, my apologies.
Yeah I think it's worth turning it off by default for now.
And on Fuchsia as well (cc: @flowerhack) as they don't have a return-to-os function either yet.
Want me to do it in a separate one 1st?

Thu, Feb 1, 11:51 AM
alekseyshl added a comment to D42579: [sanitizer] Implement NanoTime & MonotonicNanoTime for Windows.

What about my top level comment? Should we turn return-to-os off by default on Windows to donot waste time walking free lists?

Thu, Feb 1, 11:08 AM

Tue, Jan 30

alekseyshl added a comment to D42579: [sanitizer] Implement NanoTime & MonotonicNanoTime for Windows.

Should we turn return-to-os off by default on Windows then? So that we won't waste time walking free lists.

Tue, Jan 30, 10:28 AM
alekseyshl accepted D42557: [scudo] Add default implementations for weak functions.
Tue, Jan 30, 9:58 AM

Thu, Jan 25

alekseyshl accepted D42546: [scudo] Overhaul malloc related interceptors.
Thu, Jan 25, 11:29 AM
alekseyshl added inline comments to D41479: Make detect_invalid_pointer_pairs option to be tristate..
Thu, Jan 25, 11:19 AM

Wed, Jan 24

alekseyshl accepted D41479: Make detect_invalid_pointer_pairs option to be tristate..
Wed, Jan 24, 7:06 PM

Jan 23 2018

alekseyshl accepted D42430: [scudo] Allow for weak hooks, gated by a define.
Jan 23 2018, 1:27 PM

Jan 22 2018

alekseyshl committed rCRT323162: Small fixes for detect_invalid_pointer_pairs..
Small fixes for detect_invalid_pointer_pairs.
Jan 22 2018, 3:30 PM
alekseyshl committed rL323162: Small fixes for detect_invalid_pointer_pairs..
Small fixes for detect_invalid_pointer_pairs.
Jan 22 2018, 3:30 PM
alekseyshl closed D41481: Small fixes for detect_invalid_pointer_pairs..
Jan 22 2018, 3:30 PM

Jan 18 2018

alekseyshl accepted D42243: [scudo] Use -fsanitize=scudo rather than --whole-archive in tests.
Jan 18 2018, 11:30 AM

Jan 17 2018

alekseyshl committed rL322793: [Sanitizers] Changes in Hwasan allocator missed in D42198..
[Sanitizers] Changes in Hwasan allocator missed in D42198.
Jan 17 2018, 4:26 PM
alekseyshl committed rCRT322793: [Sanitizers] Changes in Hwasan allocator missed in D42198..
[Sanitizers] Changes in Hwasan allocator missed in D42198.
Jan 17 2018, 4:26 PM
alekseyshl committed rL322784: [Sanitizers] Make common allocator agnostic to failure handling modes..
[Sanitizers] Make common allocator agnostic to failure handling modes.
Jan 17 2018, 3:23 PM
alekseyshl committed rCRT322784: [Sanitizers] Make common allocator agnostic to failure handling modes..
[Sanitizers] Make common allocator agnostic to failure handling modes.
Jan 17 2018, 3:23 PM
alekseyshl closed D42198: [Sanitizers] Make common allocator agnostic to failure handling modes..
Jan 17 2018, 3:23 PM
alekseyshl closed D42198: [Sanitizers] Make common allocator agnostic to failure handling modes..
Jan 17 2018, 3:23 PM
alekseyshl accepted D42194: [scudo] Limit by default the TSD pool to 2 on Android.

Looks reasonable

Jan 17 2018, 1:30 PM
alekseyshl created D42198: [Sanitizers] Make common allocator agnostic to failure handling modes..
Jan 17 2018, 1:23 PM

Jan 16 2018

alekseyshl accepted D40900: [Sanitizers, test] Fix sanitizer tests on Solaris (PR 33274).
Jan 16 2018, 10:42 AM · Restricted Project

Jan 12 2018

alekseyshl accepted D42023: [hwasan] An LLVM flag to disable stack tag randomization..
Jan 12 2018, 5:29 PM

Jan 3 2018

alekseyshl accepted D41707: [scudo] Attempt to re-enable the valloc test on armhf.
Jan 3 2018, 8:33 PM
alekseyshl accepted D41670: [docs] Update Scudo documentation.
Jan 3 2018, 8:32 PM
alekseyshl accepted D41704: [scudo] s/unsigned long/size_t/ for __scudo_set_rss_limit.
Jan 3 2018, 8:27 PM
alekseyshl accepted D41602: [hwasan] Stack instrumentation..
Jan 3 2018, 8:25 PM

Dec 31 2017

alekseyshl accepted D41616: [hwasan] Add heap tag randomization..
Dec 31 2017, 1:11 PM

Dec 22 2017

alekseyshl committed rCRT321394: [Sanitizers] Export aligned new/delete from runtimes..
[Sanitizers] Export aligned new/delete from runtimes.
Dec 22 2017, 4:32 PM
alekseyshl committed rL321394: [Sanitizers] Export aligned new/delete from runtimes..
[Sanitizers] Export aligned new/delete from runtimes.
Dec 22 2017, 4:31 PM
alekseyshl closed D41548: [Sanitizers] Export aligned new/delete from runtimes..
Dec 22 2017, 4:31 PM
alekseyshl created D41548: [Sanitizers] Export aligned new/delete from runtimes..
Dec 22 2017, 2:56 PM
alekseyshl added a comment to D41479: Make detect_invalid_pointer_pairs option to be tristate..

Is !nullptr expected to be special cased forever or it's transitional?

Dec 22 2017, 11:09 AM
alekseyshl accepted D40900: [Sanitizers, test] Fix sanitizer tests on Solaris (PR 33274).
Dec 22 2017, 10:40 AM · Restricted Project
alekseyshl committed rL321374: [Sanitizers] Disable new_delete_test.cc on Android until it's supported..
[Sanitizers] Disable new_delete_test.cc on Android until it's supported.
Dec 22 2017, 10:20 AM
alekseyshl committed rCRT321374: [Sanitizers] Disable new_delete_test.cc on Android until it's supported..
[Sanitizers] Disable new_delete_test.cc on Android until it's supported.
Dec 22 2017, 10:20 AM
alekseyshl committed rCRT321373: [Sanitizers, CMake] Basic sanitizer Solaris support (PR 33274).
[Sanitizers, CMake] Basic sanitizer Solaris support (PR 33274)
Dec 22 2017, 10:05 AM
alekseyshl committed rL321373: [Sanitizers, CMake] Basic sanitizer Solaris support (PR 33274).
[Sanitizers, CMake] Basic sanitizer Solaris support (PR 33274)
Dec 22 2017, 10:05 AM
alekseyshl closed D40899: [Sanitizers, CMake] Basic sanitizer Solaris support (PR 33274).
Dec 22 2017, 10:05 AM · Restricted Project
alekseyshl committed rCRT321365: [MSan,TSan] Add aligned new/delete interceptors..
[MSan,TSan] Add aligned new/delete interceptors.
Dec 22 2017, 9:03 AM
alekseyshl committed rL321365: [MSan,TSan] Add aligned new/delete interceptors..
[MSan,TSan] Add aligned new/delete interceptors.
Dec 22 2017, 9:03 AM
alekseyshl closed D41532: [MSan,TSan] Add aligned new/delete interceptors..
Dec 22 2017, 9:03 AM
alekseyshl updated the diff for D41532: [MSan,TSan] Add aligned new/delete interceptors..
  • Fix typo
Dec 22 2017, 8:42 AM

Dec 21 2017

alekseyshl added inline comments to D41532: [MSan,TSan] Add aligned new/delete interceptors..
Dec 21 2017, 5:10 PM
alekseyshl created D41532: [MSan,TSan] Add aligned new/delete interceptors..
Dec 21 2017, 4:49 PM
alekseyshl accepted D41481: Small fixes for detect_invalid_pointer_pairs..
Dec 21 2017, 10:20 AM

Dec 19 2017

alekseyshl added a comment to D40899: [Sanitizers, CMake] Basic sanitizer Solaris support (PR 33274).

Just to double check, this patch does not depend on any other and can be committed, right?

Dec 19 2017, 3:37 PM · Restricted Project

Dec 18 2017

alekseyshl accepted D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274).
Dec 18 2017, 7:47 AM · Restricted Project

Dec 14 2017

alekseyshl accepted D41200: [scudo] Refactor ScudoChunk.
Dec 14 2017, 11:44 AM

Dec 13 2017

alekseyshl added a comment to D41218: [scudo] Disabling the interface test on armhf.

LGTM

Dec 13 2017, 6:55 PM
alekseyshl accepted D41128: [scudo] Adding a public Scudo interface.

Maybe add a test case for !SCUDO_CAN_USE_PUBLIC_INTERFACE?

Dec 13 2017, 10:15 AM
alekseyshl added inline comments to D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274).
Dec 13 2017, 10:05 AM · Restricted Project

Dec 12 2017

alekseyshl accepted D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 12 2017, 2:06 PM
alekseyshl added a comment to D41128: [scudo] Adding a public Scudo interface.

To address your security concern, maybe have a define to compile Scudo without public API?

Dec 12 2017, 2:02 PM
alekseyshl added inline comments to D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274).
Dec 12 2017, 1:55 PM · Restricted Project
alekseyshl accepted D40899: [Sanitizers, CMake] Basic sanitizer Solaris support (PR 33274).
Dec 12 2017, 1:39 PM · Restricted Project
alekseyshl accepted D40898: [Sanitizers] Basic sanitizer Solaris support (PR 33274).
Dec 12 2017, 11:45 AM · Restricted Project
alekseyshl added inline comments to D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 12 2017, 11:32 AM

Dec 11 2017

alekseyshl added a comment to D40898: [Sanitizers] Basic sanitizer Solaris support (PR 33274).

Mostly looks good, just a few minor changes.

Dec 11 2017, 6:11 PM · Restricted Project
alekseyshl accepted D41088: [sanitizer] Revert rL320409.
Dec 11 2017, 1:01 PM

Dec 8 2017

alekseyshl accepted D40935: Hardware-assisted AddressSanitizer (compiler-rt).
Dec 8 2017, 3:45 PM

Dec 7 2017

alekseyshl accepted D40932: Hardware-assisted AddressSanitizer (llvm part)..
Dec 7 2017, 4:22 PM
alekseyshl added inline comments to D40951: [ASan] Add interceptor for printf_chk.
Dec 7 2017, 12:59 PM · Restricted Project
alekseyshl accepted D40936: Hardware-assisted AddressSanitizer (clang part)..
Dec 7 2017, 11:16 AM

Dec 6 2017

alekseyshl committed rCRT319929: [TSan] Make more TSan interceptors symbolizer-aware..
[TSan] Make more TSan interceptors symbolizer-aware.
Dec 6 2017, 11:13 AM
alekseyshl committed rL319929: [TSan] Make more TSan interceptors symbolizer-aware..
[TSan] Make more TSan interceptors symbolizer-aware.
Dec 6 2017, 11:13 AM
alekseyshl closed D40877: [TSan] Make more TSan interceptors symbolizer-aware. by committing rL319929: [TSan] Make more TSan interceptors symbolizer-aware..
Dec 6 2017, 11:13 AM

Dec 5 2017

alekseyshl created D40877: [TSan] Make more TSan interceptors symbolizer-aware..
Dec 5 2017, 7:12 PM
alekseyshl accepted D40862: [scudo] Correct performance regression in Secondary.
Dec 5 2017, 3:26 PM
alekseyshl removed a reviewer for D38971: Enhance libsanitizer support for invalid-pointer-pair.: alekseyshl.
Dec 5 2017, 12:00 PM
alekseyshl accepted D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].
Dec 5 2017, 11:59 AM

Dec 4 2017

alekseyshl accepted D40796: [scudo] Get rid of the thread local PRNG & header salt.
Dec 4 2017, 6:08 PM
alekseyshl committed rL319681: [ASan] Disable invalid-pointer-pairs-threads.cc on Darwin..
[ASan] Disable invalid-pointer-pairs-threads.cc on Darwin.
Dec 4 2017, 11:41 AM
alekseyshl committed rCRT319681: [ASan] Disable invalid-pointer-pairs-threads.cc on Darwin..
[ASan] Disable invalid-pointer-pairs-threads.cc on Darwin.
Dec 4 2017, 11:41 AM
alekseyshl accepted D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.

Great, thanks!

Dec 4 2017, 10:45 AM
alekseyshl committed rCRT319671: [ASan] Fix test/asan/TestCases/Posix/invalid-pointer-pairs-threads.cc.
[ASan] Fix test/asan/TestCases/Posix/invalid-pointer-pairs-threads.cc
Dec 4 2017, 10:36 AM
alekseyshl committed rL319671: [ASan] Fix test/asan/TestCases/Posix/invalid-pointer-pairs-threads.cc.
[ASan] Fix test/asan/TestCases/Posix/invalid-pointer-pairs-threads.cc
Dec 4 2017, 10:35 AM