Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People waltl

waltl (Walter Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2017, 2:20 PM (333 w, 5 d)

Recent Activity
View All

Aug 23 2023

waltl accepted D158706: [Driver] Remove Myriad.cpp.
Aug 23 2023, 11:15 PM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2021

waltl committed rG66c6bbe7ff56: Put code that avoids heapifying local blocks behind a flag (authored by waltl).
Put code that avoids heapifying local blocks behind a flag
Sep 14 2021, 11:06 AM
waltl closed D108243: Put code that avoids heapifying local blocks behind a flag.
Sep 14 2021, 11:06 AM · Restricted Project

Sep 13 2021

waltl updated the diff for D108243: Put code that avoids heapifying local blocks behind a flag.

Mark new option as NoDriverOption

Sep 13 2021, 7:07 PM · Restricted Project
waltl added a comment to D108243: Put code that avoids heapifying local blocks behind a flag.
In D108243#2998077, @ahatanak wrote:

I was just asking for test cases as I thought it was already a driver option, but it turns out it wasn't. I agree that this shouldn't be a driver option.

Sorry @waltl, please revert the changes that made it a driver option in the last patch.

Sep 13 2021, 11:46 AM · Restricted Project
waltl updated the diff for D108243: Put code that avoids heapifying local blocks behind a flag.

Remove driver flags and corresponding tests

Sep 13 2021, 11:46 AM · Restricted Project

Sep 10 2021

waltl updated the diff for D108243: Put code that avoids heapifying local blocks behind a flag.

Added driver flags, and tests for them

Sep 10 2021, 10:27 PM · Restricted Project
waltl updated the diff for D108243: Put code that avoids heapifying local blocks behind a flag.

Trivial cleanup.

Sep 10 2021, 4:41 PM · Restricted Project
waltl updated the diff for D108243: Put code that avoids heapifying local blocks behind a flag.

Merge arc-blocks-avoid-heapify.m into arc-blocks.m

Sep 10 2021, 4:35 PM · Restricted Project
waltl retitled D108243: Put code that avoids heapifying local blocks behind a flag from Revert "Avoid needlessly copying a block to the heap when a block literal" to Put code that avoids heapifying local blocks behind a flag.
Sep 10 2021, 2:54 PM · Restricted Project
waltl added a comment to D108243: Put code that avoids heapifying local blocks behind a flag.
In D108243#2995476, @ahatanak wrote:

Do you need arc-blocks-avoid-heapify.m? It seems like the other tests already cover all the cases we care about.

Sep 10 2021, 2:52 PM · Restricted Project
waltl updated the diff for D108243: Put code that avoids heapifying local blocks behind a flag.

Delete redundant tests in arc-blocks-avoid-heapify.m.

Sep 10 2021, 2:51 PM · Restricted Project

Sep 8 2021

waltl updated the diff for D108243: Put code that avoids heapifying local blocks behind a flag.

As suggested, I put the optimization behind an off-by-default flag.

Sep 8 2021, 3:59 PM · Restricted Project

Sep 7 2021

waltl commandeered D108243: Put code that avoids heapifying local blocks behind a flag.
Sep 7 2021, 6:53 PM · Restricted Project

Jun 15 2021

waltl added inline comments to D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad.
Jun 15 2021, 10:22 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2019

waltl accepted D61871: [asan] Fix debug asan build link error.
May 21 2019, 5:09 PM · Restricted Project, Restricted Project

May 15 2019

waltl added a comment to D61871: [asan] Fix debug asan build link error.

There is still a problem building for Linux. See comment below.

May 15 2019, 5:08 PM · Restricted Project, Restricted Project
waltl added a comment to D61871: [asan] Fix debug asan build link error.

Here are the changes I needed to make to get this to compile for linux and Myriad.

May 15 2019, 2:14 PM · Restricted Project, Restricted Project
waltl added a comment to D61871: [asan] Fix debug asan build link error.

I have problems getting this to compile. Let me work on it and either suggest in-line changes or make a new revision.

May 15 2019, 1:48 PM · Restricted Project, Restricted Project

Dec 19 2018

waltl added a comment to D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date..
In D55740#1335964, @delcypher wrote:

@waltl Does this have any impact for RTEMS ?

Dec 19 2018, 9:09 AM

Oct 11 2018

waltl accepted D53147: [DAG] Fix Big Endian in Load-Store forwarding.
Oct 11 2018, 11:10 AM

Sep 20 2018

waltl committed rL342682: [RegAllocGreedy] Fix crash in tryLocalSplit.
[RegAllocGreedy] Fix crash in tryLocalSplit
Sep 20 2018, 1:09 PM
waltl closed D52277: [RegAllocGreedy] Fix crash in tryLocalSplit.
Sep 20 2018, 1:09 PM
waltl updated the diff for D52277: [RegAllocGreedy] Fix crash in tryLocalSplit.

Typo.

Sep 20 2018, 12:50 PM
waltl updated subscribers of D52277: [RegAllocGreedy] Fix crash in tryLocalSplit.
Sep 20 2018, 12:50 PM
waltl updated the diff for D52277: [RegAllocGreedy] Fix crash in tryLocalSplit.

Simplify fix; bugpoint test case.

Sep 20 2018, 12:37 PM
waltl retitled D52277: [RegAllocGreedy] Fix crash in tryLocalSplit from [RegAlloc] Fix check for local splitting. to [RegAllocGreedy] Fix crash in tryLocalSplit.
Sep 20 2018, 12:37 PM
waltl commandeered D52277: [RegAllocGreedy] Fix crash in tryLocalSplit.
Sep 20 2018, 11:20 AM

Aug 23 2018

waltl committed rL340570: [llvm-mca] Fix parameter name. NFC..
[llvm-mca] Fix parameter name. NFC.
Aug 23 2018, 1:18 PM
waltl committed rLLDB340562: Fix format string issue introduced in r340548.
Fix format string issue introduced in r340548
Aug 23 2018, 11:27 AM
waltl committed rL340562: Fix format string issue introduced in r340548.
Fix format string issue introduced in r340548
Aug 23 2018, 11:27 AM
waltl added inline comments to rL340536: [llvm-mca] Allow the definition of custom strategies for selecting processor….
Aug 23 2018, 9:26 AM

Jun 12 2018

waltl committed rCRT334522: [asan, myriad] Support environment variables.
[asan, myriad] Support environment variables
Jun 12 2018, 11:38 AM
waltl committed rL334522: [asan, myriad] Support environment variables.
[asan, myriad] Support environment variables
Jun 12 2018, 11:38 AM
waltl closed D47960: [asan, myriad] Support environment variables.
Jun 12 2018, 11:38 AM
waltl updated the summary of D47960: [asan, myriad] Support environment variables.
Jun 12 2018, 9:10 AM

Jun 11 2018

waltl updated the diff for D47960: [asan, myriad] Support environment variables.

Sorry for the overly complicated initial patch. We've decided to get
setenv() to work in our test enviroment (using similar approach to the
initial patch here), so now the sanitizer run-time can just call that.

Jun 11 2018, 10:15 PM
waltl added a reviewer for D47960: [asan, myriad] Support environment variables: jyknight.
Jun 11 2018, 7:04 AM

Jun 8 2018

waltl created D47960: [asan, myriad] Support environment variables.
Jun 8 2018, 2:55 PM
waltl committed rCRT334329: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.
[asan, myriad] Use local pool for new/delete when ASan run-time is not up
Jun 8 2018, 2:54 PM
waltl committed rL334329: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.
[asan, myriad] Use local pool for new/delete when ASan run-time is not up
Jun 8 2018, 2:54 PM
waltl closed D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.
Jun 8 2018, 2:54 PM · Restricted Project
waltl updated the diff for D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.

Address CR comments

Jun 8 2018, 2:33 PM · Restricted Project
waltl added a comment to D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.

Thanks for the quick review (for this and other patches).

Jun 8 2018, 12:21 PM · Restricted Project
waltl updated the diff for D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.

Address CR comments.

Jun 8 2018, 12:20 PM · Restricted Project

Jun 7 2018

waltl updated the diff for D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.

Fix an issue after dropping a patch this depends on. This patch
should now stand on its own.

Jun 7 2018, 8:28 PM · Restricted Project
waltl reclaimed D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.

Reopening as the updated version only requires a minor tweak.

Jun 7 2018, 8:26 PM · Restricted Project
waltl abandoned D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.

Let me redo this and resubmit.

Jun 7 2018, 5:15 PM · Restricted Project
waltl abandoned D47915: [asan] Handle 0 alignment in PosixMemalignFromLocalPool.
Jun 7 2018, 5:13 PM
waltl created D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.
Jun 7 2018, 3:47 PM · Restricted Project
waltl created D47915: [asan] Handle 0 alignment in PosixMemalignFromLocalPool.
Jun 7 2018, 3:46 PM

Jun 6 2018

waltl closed D47830: [asan] Fix Myraid RTEMS port broken by r333985.

Submitted as r334102.

Jun 6 2018, 8:48 AM
waltl committed rCRT334102: [asan] Fix Myraid RTEMS port broken by r333985.
[asan] Fix Myraid RTEMS port broken by r333985
Jun 6 2018, 8:44 AM
waltl committed rL334102: [asan] Fix Myraid RTEMS port broken by r333985.
[asan] Fix Myraid RTEMS port broken by r333985
Jun 6 2018, 8:44 AM
waltl created D47830: [asan] Fix Myraid RTEMS port broken by r333985.
Jun 6 2018, 8:38 AM

Jun 1 2018

waltl committed rCRT333788: [asan, myriad] Implement aligned local pool allocation.
[asan, myriad] Implement aligned local pool allocation
Jun 1 2018, 2:33 PM
waltl committed rL333788: [asan, myriad] Implement aligned local pool allocation.
[asan, myriad] Implement aligned local pool allocation
Jun 1 2018, 2:33 PM
waltl closed D47642: [asan, myriad] Implement aligned local pool allocation.
Jun 1 2018, 2:33 PM
waltl updated the diff for D47642: [asan, myriad] Implement aligned local pool allocation.

Remove printf.

Jun 1 2018, 2:31 PM
waltl updated the diff for D47642: [asan, myriad] Implement aligned local pool allocation.

Do it for all platforms.

Jun 1 2018, 2:17 PM
waltl added a comment to D47642: [asan, myriad] Implement aligned local pool allocation.
In D47642#1119518, @alekseyshl wrote:

Are you solving a particular problem or you're just anticipating one?

Jun 1 2018, 1:46 PM
waltl committed rCRT333784: [asan, myriad] Configure platform interceptors.
[asan, myriad] Configure platform interceptors
Jun 1 2018, 12:52 PM
waltl committed rL333784: [asan, myriad] Configure platform interceptors.
[asan, myriad] Configure platform interceptors
Jun 1 2018, 12:52 PM
waltl closed D47641: [asan, myriad] Configure platform interceptors.
Jun 1 2018, 12:51 PM
waltl created D47642: [asan, myriad] Implement aligned local pool allocation.
Jun 1 2018, 8:56 AM
waltl created D47641: [asan, myriad] Configure platform interceptors.
Jun 1 2018, 8:56 AM

May 29 2018

waltl committed rCRT333504: [asan, myriad] Simplify main thread handling.
[asan, myriad] Simplify main thread handling
May 29 2018, 10:22 PM
waltl committed rCRT333503: [asan, myriad] Reset shadow memory during exit.
[asan, myriad] Reset shadow memory during exit
May 29 2018, 10:22 PM
waltl committed rL333504: [asan, myriad] Simplify main thread handling.
[asan, myriad] Simplify main thread handling
May 29 2018, 10:01 PM
waltl closed D47502: [asan, myriad] Simplify main thread handling.
May 29 2018, 10:01 PM
waltl committed rL333503: [asan, myriad] Reset shadow memory during exit.
[asan, myriad] Reset shadow memory during exit
May 29 2018, 10:01 PM
waltl closed D47501: [asan, myriad] Reset shadow memory during exit.
May 29 2018, 10:01 PM
waltl updated the diff for D47501: [asan, myriad] Reset shadow memory during exit.

Only reset if needed.

May 29 2018, 7:31 PM
waltl created D47502: [asan, myriad] Simplify main thread handling.
May 29 2018, 3:08 PM
waltl created D47501: [asan, myriad] Reset shadow memory during exit.
May 29 2018, 3:07 PM

May 21 2018

waltl committed rCRT332888: [asan] Make GetCurrentThread RTEMS-friendly.
[asan] Make GetCurrentThread RTEMS-friendly
May 21 2018, 1:48 PM
waltl committed rL332888: [asan] Make GetCurrentThread RTEMS-friendly.
[asan] Make GetCurrentThread RTEMS-friendly
May 21 2018, 1:48 PM
waltl closed D46459: [asan] Make GetCurrentThread RTEMS-friendly.
May 21 2018, 1:48 PM
waltl closed D46459: [asan] Make GetCurrentThread RTEMS-friendly.
May 21 2018, 1:48 PM

May 18 2018

waltl added inline comments to D46459: [asan] Make GetCurrentThread RTEMS-friendly.
May 18 2018, 11:24 AM
waltl added inline comments to D46459: [asan] Make GetCurrentThread RTEMS-friendly.
May 18 2018, 11:20 AM
waltl committed rCRT332746: [asan] Explicitly declare memintrinsics interceptors to have C linkage.
[asan] Explicitly declare memintrinsics interceptors to have C linkage
May 18 2018, 11:05 AM
waltl committed rL332746: [asan] Explicitly declare memintrinsics interceptors to have C linkage.
[asan] Explicitly declare memintrinsics interceptors to have C linkage
May 18 2018, 11:05 AM
waltl closed D47079: [asan] Explicitly declare memintrinsics interceptors to have C linkage.
May 18 2018, 11:05 AM
waltl committed rCRT332744: [asan] Remove an unsigned compare >= 0.
[asan] Remove an unsigned compare >= 0
May 18 2018, 10:56 AM
waltl committed rL332744: [asan] Remove an unsigned compare >= 0.
[asan] Remove an unsigned compare >= 0
May 18 2018, 10:56 AM
waltl closed D47054: [asan] Remove an unsigned compare >= 0.
May 18 2018, 10:56 AM
waltl created D47079: [asan] Explicitly declare memintrinsics interceptors to have C linkage.
May 18 2018, 10:51 AM

May 17 2018

waltl created D47054: [asan] Remove an unsigned compare >= 0.
May 17 2018, 11:59 PM
waltl added inline comments to D46459: [asan] Make GetCurrentThread RTEMS-friendly.
May 17 2018, 9:47 PM
waltl retitled D46459: [asan] Make GetCurrentThread RTEMS-friendly from [asan] On RTEMS, checks for asan_inited before entering ASan run-time to [asan] Make GetCurrentThread RTEMS-friendly.
May 17 2018, 9:45 PM
waltl updated the diff for D46459: [asan] Make GetCurrentThread RTEMS-friendly.

Make GetCurrentThread RTEMS-friendly.

May 17 2018, 9:39 PM
waltl committed rL332692: [asan] Add instrumentation support for Myriad.
[asan] Add instrumentation support for Myriad
May 17 2018, 9:14 PM
waltl closed D46451: [asan] Add instrumentation support for Myriad.
May 17 2018, 9:14 PM
waltl committed rCRT332691: [asan] Add target-specific files for Myriad RTEMS port.
[asan] Add target-specific files for Myriad RTEMS port
May 17 2018, 9:14 PM
waltl committed rL332691: [asan] Add target-specific files for Myriad RTEMS port.
[asan] Add target-specific files for Myriad RTEMS port
May 17 2018, 9:14 PM
waltl closed D46468: [asan] Add target-specific files for Myriad RTEMS port.
May 17 2018, 9:14 PM
waltl committed rCRT332690: [asan] Add support for Myriad RTEMS memory map.
[asan] Add support for Myriad RTEMS memory map
May 17 2018, 9:13 PM
waltl committed rL332690: [asan] Add support for Myriad RTEMS memory map.
[asan] Add support for Myriad RTEMS memory map
May 17 2018, 9:13 PM
waltl closed D46456: [asan] Add support for Myriad RTEMS memory map.
May 17 2018, 9:13 PM