Page MenuHomePhabricator
Differential D39475

[asan] Add full redzone after every stack variable
ClosedPublic
Actions

Authored by waltl on Oct 31 2017, 1:59 PM.

Details

Reviewers
vitalybuka
eugenis
alekseyshl
Commits
rG9abeecc07cfa: [asan] Add a full redzone after every stack variable
rL318581: [asan] Add a full redzone after every stack variable
Summary

We were not doing that for large shadow granularity.

Diff Detail

Event Timeline

waltl created this revision.Oct 31 2017, 1:59 PM
Herald added subscribers: hiraditya, kubamracek. · View Herald TranscriptOct 31 2017, 1:59 PM
kosarev added a subscriber: kosarev.Nov 1 2017, 1:39 AM
waltl updated this revision to Diff 122009.Nov 7 2017, 4:14 PM

Add full redzone after every stack variable

Harbormaster completed remote builds in B11935: Diff 122009.Nov 7 2017, 4:14 PM
waltl retitled this revision from [asan] Improve stack error reports for large shadow granularity to [asan] Add full redzone after every stack variable.Nov 7 2017, 4:15 PM
waltl edited the summary of this revision. (Show Details)
waltl added reviewers: vitalybuka, eugenis, alekseyshl.Nov 7 2017, 5:04 PM
waltl added subscribers: kcc, llvm-commits.
vitalybuka accepted this revision.Nov 15 2017, 2:47 PM
vitalybuka added inline comments.
llvm/unittests/Transforms/Utils/ASanStackFrameLayoutTest.cpp
74–76

maybe more cases with unusual granularity?

This revision is now accepted and ready to land.Nov 15 2017, 2:47 PM
waltl updated this revision to Diff 123334.Nov 17 2017, 7:07 AM

Add more stack frame layout tests for large shadow granularity

Harbormaster completed remote builds in B12275: Diff 123334.Nov 17 2017, 7:07 AM
waltl marked an inline comment as done.Nov 17 2017, 7:08 AM
waltl updated this revision to Diff 123337.Nov 17 2017, 7:10 AM

Trivial format fixes

Harbormaster completed remote builds in B12276: Diff 123337.Nov 17 2017, 7:10 AM
vitalybuka accepted this revision.Nov 17 2017, 1:50 PM
Closed by commit rL318581: [asan] Add a full redzone after every stack variable (authored by waltl). · Explain WhyNov 17 2017, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Utils/
9 lines
unittests/
Transforms/
Utils/
29 lines

Diff 123337

View Options

llvm/lib/Transforms/Utils/ASanStackFrameLayout.cpp

Loading...
View Options

llvm/unittests/Transforms/Utils/ASanStackFrameLayoutTest.cpp

Loading...