Page MenuHomePhabricator
Differential D39474

[asan] Avoid assert failure for non-default shadow scale
ClosedPublic
Actions

Authored by waltl on Oct 31 2017, 1:59 PM.

Details

Reviewers
vitalybuka
eugenis
alekseyshl
Commits
rGed8b52c8bc58: [asan] Avoid assert failure for non-default shadow scale
rCRT318460: [asan] Avoid assert failure for non-default shadow scale
rL318460: [asan] Avoid assert failure for non-default shadow scale
Summary

Rather than assertion failing, we can fall back to the
non-optimized version which works for any shadow scale.

Diff Detail

Event Timeline

waltl created this revision.Oct 31 2017, 1:59 PM
Harbormaster completed remote builds in B11687: Diff 121053.Oct 31 2017, 1:59 PM
Herald added a subscriber: kubamracek. · View Herald TranscriptOct 31 2017, 1:59 PM
kosarev added a subscriber: kosarev.Nov 1 2017, 1:38 AM
waltl added reviewers: vitalybuka, eugenis, alekseyshl.Nov 7 2017, 5:03 PM
waltl added subscribers: kcc, llvm-commits.
vitalybuka accepted this revision.Nov 16 2017, 8:40 AM
This revision is now accepted and ready to land.Nov 16 2017, 8:40 AM
Closed by commit rL318460: [asan] Avoid assert failure for non-default shadow scale (authored by waltl). · Explain WhyNov 16 2017, 2:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
compiler-rt/
lib/
asan/
4 lines

Diff 121053

View Options

compiler-rt/lib/asan/asan_fake_stack.cc

Loading...