Page MenuHomePhabricator

[clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.
ClosedPublic

Authored by yawanng on Jul 13 2017, 10:44 AM.

Diff Detail

Event Timeline

yawanng created this revision.Jul 13 2017, 10:44 AM
yawanng retitled this revision from Add a close-on-exec check on inotify_init1() in Android module. to [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module..Jul 13 2017, 10:53 AM
yawanng edited the summary of this revision. (Show Details)
yawanng added a subscriber: cfe-commits.
yawanng edited the summary of this revision. (Show Details)Jul 13 2017, 11:01 AM
Eugene.Zelenko edited reviewers, added: alexfh, aaron.ballman, hokein; removed: chh.Jul 13 2017, 11:20 AM
Eugene.Zelenko set the repository for this revision to rL LLVM.
chh added a subscriber: chh.Jul 13 2017, 11:59 AM
Eugene.Zelenko added inline comments.
docs/ReleaseNotes.rst
60

Please sort checks in alphabetical order.

yawanng updated this revision to Diff 106520.Jul 13 2017, 1:51 PM
yawanng marked an inline comment as done.
alexfh requested changes to this revision.Jul 15 2017, 1:26 AM

See the comment on D35372.

This revision now requires changes to proceed.Jul 15 2017, 1:26 AM
yawanng updated this revision to Diff 110649.Aug 10 2017, 4:25 PM
yawanng edited edge metadata.
hokein added inline comments.Aug 11 2017, 7:11 AM
clang-tidy/android/CloexecInotifyInit1Check.cpp
29

nit: /*MarcoFlag=*/

test/clang-tidy/android-cloexec-inotify-init1.cpp
20

The same, trailing ;.

yawanng updated this revision to Diff 110750.Aug 11 2017, 10:00 AM
yawanng marked 2 inline comments as done.
hokein accepted this revision.Aug 14 2017, 1:23 AM

LGTM

This revision was automatically updated to reflect the committed changes.