Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
I think the comments are minor enough that they can be addressed on the commit. LGTM.
lib/Target/PowerPC/PPCInstrAltivec.td | ||
---|---|---|
1489 ↗ | (On Diff #104150) | I don't see a compelling reason to remove these patterns from the instruction defs just to add them as anonymous patterns. The instruction definitions should remain unchanged. |
1497 ↗ | (On Diff #104150) | Formatting nit: please add a space between the type and the left paren: |
test/CodeGen/PowerPC/ppc64-P9-vabsd.ll | ||
9 ↗ | (On Diff #104150) | Please add a test case where the sub(0, a) is the first operand to the max intrinsic for symmetry. |
Comment Actions
Why is this patch sitting here in approved state for a week? Can you rebase, retest and commit this?