This is an archive of the discontinued LLVM Phabricator instance.

[Power 9] Exploit vector absolute difference instructions on Power 9
ClosedPublic

Authored by stefanp on Jun 27 2017, 6:47 AM.

Diff Detail

Event Timeline

stefanp created this revision.Jun 27 2017, 6:47 AM
nemanjai accepted this revision.Jul 25 2017, 4:07 AM

I think the comments are minor enough that they can be addressed on the commit. LGTM.

lib/Target/PowerPC/PPCInstrAltivec.td
1489

I don't see a compelling reason to remove these patterns from the instruction defs just to add them as anonymous patterns. The instruction definitions should remain unchanged.

1497

Formatting nit: please add a space between the type and the left paren:
(v16i8 (VABSDUB...
of course, this applies for all of these output patterns suffering from the same issue.

test/CodeGen/PowerPC/ppc64-P9-vabsd.ll
9

Please add a test case where the sub(0, a) is the first operand to the max intrinsic for symmetry.

This revision is now accepted and ready to land.Jul 25 2017, 4:07 AM

Why is this patch sitting here in approved state for a week? Can you rebase, retest and commit this?

This revision was automatically updated to reflect the committed changes.