Patch by Martell Malone.
This patch adds MinGW-w64 SEH on Win64 support on the clang side.
See http://reviews.llvm.org/differential/revision/edit/3418/ for the LLVM part of the patch.
Differential D3419
MinGW-w64 SEH on Win64 support (clang part) Alexpux on Apr 18 2014, 1:31 AM. Authored by
Details Patch by Martell Malone. This patch adds MinGW-w64 SEH on Win64 support on the clang side. See http://reviews.llvm.org/differential/revision/edit/3418/ for the LLVM part of the patch.
Diff Detail Event TimelineComment Actions Is this useful without the LLVM change (http://reviews.llvm.org/D3418)? It seems like a reasonable step forward for MinGW64 compatibility, but I think the commit message is off. I think most people will assume "SEH exceptions" means try { ... } except (...) { ... }, which is not what this commit covers. I'd rephrase it to talk about MinGW64 SEH support. Comment Actions This change seems fine. If someone can rebase it and commit it that would be great.
Comment Actions Hi Alex, In the "Action" box above select "Commandeer Revision" and then you will become the Author. To upload a new diff there are some options. If you want to upload the patch file, select "Create Diff" in the top-right corner and upload the updated patch. Then, attach it to this revision and it will appear here. This patch requires lib/Driver/MinGWToolChain.cpp but you can move the three lines required in this file to the mingw toolchain patch so it won't block this one.
Comment Actions I thought this was in the code base already? How do I accept it as a reviewer? Comment Actions martell, I'm get remove mingw toolchain part from here to http://reviews.llvm.org/D5268. |
This should start with a lowercase 'u' to adhere to the coding standards in our wonderfully consistent codebase.