Page MenuHomePhabricator

nrieck (Nico Rieck)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2013, 2:57 PM (345 w, 6 d)

Recent Activity

Nov 23 2015

nrieck retitled D14927: clang-format: Add SpaceBeforeTemplateParameterList option from to clang-format: Add SpaceBeforeTemplateParameterList option.
Nov 23 2015, 7:25 AM

Aug 6 2015

nrieck closed D11806: Rename inst_range() to instructions() for consistency. NFC.
Aug 6 2015, 12:30 PM
nrieck committed rL244248: Rename inst_range() to instructions() for consistency. NFC.
Rename inst_range() to instructions() for consistency. NFC
Aug 6 2015, 12:11 PM
nrieck retitled D11806: Rename inst_range() to instructions() for consistency. NFC from to Rename inst_range() to instructions() for consistency. NFC.
Aug 6 2015, 10:25 AM

Dec 17 2014

nrieck added a comment to D6549: ASTImporter: Propagate implicit flag to imported record and field decls.

Ping.

Dec 17 2014, 6:49 AM
nrieck added a comment to D6550: ASTImporter: Fix missing SourceLoc imports.

Ping.

Dec 17 2014, 6:48 AM

Dec 5 2014

nrieck retitled D6550: ASTImporter: Fix missing SourceLoc imports from to ASTImporter: Fix missing SourceLoc imports.
Dec 5 2014, 6:16 AM
nrieck retitled D6549: ASTImporter: Propagate implicit flag to imported record and field decls from to ASTImporter: Propagate implicit flag to imported record and field decls.
Dec 5 2014, 6:06 AM

Nov 13 2014

nrieck added a comment to D6163: implement MachODumper::printFileHeaders.

Since llvm-readobj is a low-level inspection tool, the Reserved field should also be printed (even more so than unused fields).

Nov 13 2014, 4:35 AM

Oct 17 2014

nrieck added a comment to D5755: First step towards PR21189 -- Teach llvm-readobj to dump bits of COFF symbol subsections required to debug using VS2012+.

As a rule of thumb: Use DictScope for key-value pairs. Usually there's only a fixed amount of these per scope, like a single symbol info. Use ListScope if you want to delimit a list of things. Usually there's a loop printing the contents, and the amount is not fixed, like a list of symbols or sections. HTH!

Oct 17 2014, 1:17 PM
nrieck added inline comments to D5755: First step towards PR21189 -- Teach llvm-readobj to dump bits of COFF symbol subsections required to debug using VS2012+.
Oct 17 2014, 10:43 AM

Jun 18 2014

nrieck added a comment to D4136: Inherit dll attributes to static locals.
In D4136#10, @hans wrote:

Nico: does the new version of the patch look ok to you?

Jun 18 2014, 8:08 AM

Jun 13 2014

nrieck added inline comments to D4136: Inherit dll attributes to static locals.
Jun 13 2014, 11:27 AM

May 30 2014

nrieck added a comment to D3973: Error on using dll attribute on members of class that already has a dll attribute.

LGTM except that this check should not be done for MinGW (and on a related note, I wish MSVC would behave the same since I can't see the benefit of this diagnostic).

May 30 2014, 4:25 PM
nrieck abandoned D1108: Add full semantic support for dllimport/export attributes.

This revision has been superseded by incremental patches which have made it into ToT.

May 30 2014, 10:23 AM

May 29 2014

nrieck added inline comments to D3877: Start adding support for dllimport/dllexport on classes (PR11170).
May 29 2014, 5:42 PM

May 27 2014

nrieck added inline comments to D3877: Start adding support for dllimport/dllexport on classes (PR11170).

I also have a few more tests you should use. For example currently sema diagnoses dllimport redeclarations and drops this attribute, but class template member functions would still be imported.

May 27 2014, 9:16 PM