Page MenuHomePhabricator

martell (Martell Malone)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2013, 6:49 PM (337 w, 6 d)

Recent Activity

Jan 24 2019

martell abandoned D56060: ELF: BLOCK Keyword linker script support.

Sorry for the delay.
The change from BLOCK to ALIGN is now accepted upstream.
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=a652758ac1475f69d28d11b3528c4f48
Closing this and thanks @grimar

Jan 24 2019, 2:43 PM

Dec 23 2018

martell updated subscribers of D56060: ELF: BLOCK Keyword linker script support.
Dec 23 2018, 8:51 AM
martell added a comment to D56060: ELF: BLOCK Keyword linker script support.

I'm not sure if we should change the linker script or add BLOCK

Dec 23 2018, 8:50 AM
martell created D56060: ELF: BLOCK Keyword linker script support.
Dec 23 2018, 8:50 AM

Dec 21 2018

martell abandoned D55498: [PPC64] Support R_PPC64_GOT16 Relocations.

This was already implemented in rL349511 and rL349772.
Thanks @sfertile and sorry for the noise.
I don't know if there are any notes here that are useful. --got-optimize ?

Dec 21 2018, 11:31 AM

Dec 10 2018

martell added reviewers for D55501: [PPC64][PPC] add tests for R_PPC64_REL14 R_PPC_REL14: nemanjai, rnk.
Dec 10 2018, 7:19 PM · Restricted Project
martell committed rL348826: [PPC][NFC] store operands are dst not src.
[PPC][NFC] store operands are dst not src
Dec 10 2018, 7:18 PM
martell closed D55502: [NFC] [PPC] Store Instructions have a destination not a source.
Dec 10 2018, 7:18 PM

Dec 9 2018

martell updated the diff for D55501: [PPC64][PPC] add tests for R_PPC64_REL14 R_PPC_REL14.

add context

Dec 9 2018, 6:35 PM · Restricted Project
martell added a reviewer for D55502: [NFC] [PPC] Store Instructions have a destination not a source: rnk.
Dec 9 2018, 6:33 PM
martell created D55502: [NFC] [PPC] Store Instructions have a destination not a source.
Dec 9 2018, 6:30 PM
martell created D55501: [PPC64][PPC] add tests for R_PPC64_REL14 R_PPC_REL14.
Dec 9 2018, 6:26 PM · Restricted Project
martell added a comment to D55498: [PPC64] Support R_PPC64_GOT16 Relocations.

I'm probably going to learn something valuable about the global offsets table or the table of contents sections from the response to this :)

Dec 9 2018, 12:51 PM
martell added a comment to D55498: [PPC64] Support R_PPC64_GOT16 Relocations.

I implemented this for ppc32 as well but there are a few things that need to be changed as a result of this so I will put that in a separate patch
I'm going to add a bunch of inline comments about things that could change.

Dec 9 2018, 12:23 PM
martell updated subscribers of D55498: [PPC64] Support R_PPC64_GOT16 Relocations.

Tracking issue for clang built linux for @nickdesaulniers
https://github.com/ClangBuiltLinux/linux/issues/285

Dec 9 2018, 12:20 PM
martell created D55498: [PPC64] Support R_PPC64_GOT16 Relocations.
Dec 9 2018, 12:20 PM

Dec 4 2018

martell added a comment to D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}.

Also, Sorry for the long time to reply, I don't LLVM often enough :)

Dec 4 2018, 5:12 AM · Restricted Project
martell added a comment to D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}.

Seems like a better solution than what I had in D37726.
I'm not sully sure on the naming so I think someone else should also sign off on this.

Dec 4 2018, 5:11 AM · Restricted Project
martell abandoned D37726: clang: alias -static-{libstdc++,libgcc} for LLVM variants.

Dropping in favour of D53238

Dec 4 2018, 5:08 AM
martell committed rL348259: [GN][NFC] Update readme example to functional command.
[GN][NFC] Update readme example to functional command
Dec 4 2018, 5:02 AM
martell closed D54840: [GN][NFC] Update readme example to functional command.
Dec 4 2018, 5:02 AM
martell committed rL348258: [ELF] Allow discarding of .rela.plt.
[ELF] Allow discarding of .rela.plt
Dec 4 2018, 4:40 AM
martell committed rLLD348258: [ELF] Allow discarding of .rela.plt.
[ELF] Allow discarding of .rela.plt
Dec 4 2018, 4:40 AM
martell closed D54871: [ELF] Allow discarding of .rela.plt.
Dec 4 2018, 4:40 AM · lld
martell added a comment to D54871: [ELF] Allow discarding of .rela.plt.

Sorry only getting around to this comment now. I think this is probably what you are looking for
https://github.com/torvalds/linux/blob/master/arch/powerpc/kernel/vmlinux.lds.S#L387

Dec 4 2018, 4:36 AM · lld
martell committed rLLD348255: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.
[PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations
Dec 4 2018, 4:30 AM
martell committed rL348255: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.
[PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations
Dec 4 2018, 4:30 AM
martell closed D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.
Dec 4 2018, 4:30 AM · lld

Dec 2 2018

martell added a comment to D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.

This probably needs another approval based on the small changes I made to address the warning

Dec 2 2018, 3:54 PM · lld
martell updated the diff for D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.

update to address comments

Dec 2 2018, 3:53 PM · lld
martell updated the diff for D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.
Dec 2 2018, 3:52 PM · lld

Nov 24 2018

martell updated the diff for D54871: [ELF] Allow discarding of .rela.plt.

update tests

Nov 24 2018, 4:42 PM · lld
martell updated the summary of D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.
Nov 24 2018, 2:48 PM · lld
martell created D54871: [ELF] Allow discarding of .rela.plt.
Nov 24 2018, 2:46 PM · lld
martell updated the diff for D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.
Nov 24 2018, 6:59 AM · lld
martell created D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.
Nov 24 2018, 6:48 AM · lld

Nov 22 2018

martell retitled D54840: [GN][NFC] Update readme example to functional command from [GN] : Update readme example to functional command to [GN][NFC] Update readme example to functional command.
Nov 22 2018, 4:38 PM
martell added a comment to D54840: [GN][NFC] Update readme example to functional command.

Though I really hope gn will work with the tools layout ( i.e. llvm/tools/lld ) soon so I can make use of ninja -C out/gn check-lld. :)

Nov 22 2018, 4:37 PM
martell created D54840: [GN][NFC] Update readme example to functional command.
Nov 22 2018, 4:32 PM

Apr 22 2018

martell accepted D45505: [GCC] Match a GCC version with a patch suffix without a third version component.

LGTM

Apr 22 2018, 2:02 PM

Apr 4 2018

martell added a comment to D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH.

@mstorsjo I would much prefer to detect the clang sysroot first and if that exists just ignore the gcc one.
Most of the time clang and gcc will be in the same bin folder and in the case where the clang sysroot with mingw prefix folders is not found we can just default back to the default gcc behavior.
This should cover the use case for existing gcc users while not blocking us to move forward with clang only toolchains.
If someone really wants to ignore the clang sysroot with mingw folders we could add a flag for that and not the other way around.
What are your thoughts here?

Apr 4 2018, 3:27 PM

Mar 23 2018

martell added inline comments to D41580: CMAKE: Add flags to skip building NATIVE tools.
Mar 23 2018, 7:57 PM · Restricted Project
martell abandoned D41580: CMAKE: Add flags to skip building NATIVE tools.
Mar 23 2018, 7:57 PM · Restricted Project

Mar 11 2018

martell added a comment to D44357: [COFF] Adjust how we flag weak externals.

@alexcrichton can you confirm this works as a replacement for your partial revert here https://github.com/rust-lang/llvm/commit/9eb9267 ?

Mar 11 2018, 2:48 PM
martell updated the summary of D44357: [COFF] Adjust how we flag weak externals.
Mar 11 2018, 2:48 PM

Mar 10 2018

martell created D44357: [COFF] Adjust how we flag weak externals.
Mar 10 2018, 4:26 PM

Mar 8 2018

martell added a comment to D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64..

ping @marsupial

Mar 8 2018, 6:59 PM

Feb 21 2018

martell added inline comments to D29892: ar: add llvm-dlltool support.
Feb 21 2018, 4:53 PM

Feb 20 2018

martell committed rL325667: RISCV: Add COFF address space.
RISCV: Add COFF address space
Feb 20 2018, 10:44 PM
martell closed D41571: RISCV: Add IMAGE_FILE_MACHINE COFF address spaces.
Feb 20 2018, 10:44 PM
martell added a comment to D41571: RISCV: Add IMAGE_FILE_MACHINE COFF address spaces.

Sorry for the delay,
I looked back on this a few times and I don't have the relocations to support doing a full round trip.
It does seem however that tests are only done for the 4 fully supported arch's.
IMAGE_FILE_MACHINE_I386
IMAGE_FILE_MACHINE_AMD64
IMAGE_FILE_MACHINE_ARMNT
IMAGE_FILE_MACHINE_ARM64
see obj2yaml.test for reference.

Feb 20 2018, 10:40 PM
martell added a comment to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.

Glad to see this finally get approved :)
@marsupial do you have commit access?

Feb 20 2018, 10:37 PM

Feb 7 2018

martell retitled D41597: Driver: ignore -mbig-obj like /bigobj from CMAKE: disable -mbig-obj for mingw clang asm to Driver: ignore -mbig-obj like /bigobj.
Feb 7 2018, 11:39 PM
martell updated the diff for D41597: Driver: ignore -mbig-obj like /bigobj.
Feb 7 2018, 11:33 PM
martell added a comment to D41597: Driver: ignore -mbig-obj like /bigobj.

Updated to just ignore the flag just like how clang-cl does for /bigobj

Feb 7 2018, 11:33 PM
martell committed rL324570: CMAKE: apply -O3 for mingw clang.
CMAKE: apply -O3 for mingw clang
Feb 7 2018, 11:16 PM
martell closed D41596: CMAKE: apply -O3 for mingw-w64 clang.
Feb 7 2018, 11:16 PM

Jan 20 2018

martell accepted D41806: [cmake] Don't build Native llvm-config when cross compiling if passed by user..

This seems to work better then what I have in D41580 for llvm_config.
LGTM.

Jan 20 2018, 1:29 PM

Jan 17 2018

martell added a comment to D33753: [libcxxabi] Add back HandleLLVMOptions for out of tree builds.

Err, I mean Sam, Sorry.

Jan 17 2018, 9:34 PM · Restricted Project
martell added a comment to D33753: [libcxxabi] Add back HandleLLVMOptions for out of tree builds.

My problem is that HandleLLVMOptions seems to add a lot of compiler and system check.... seemingly more than are required to build libcxxabi. It seems like by including this line we are maybe needlessly restricting the set of compilers/environments on which it can be built.

Jan 17 2018, 12:23 PM · Restricted Project

Jan 13 2018

martell accepted D41809: Clang counterpart change for fuzzer FreeBSD support.

Given that https://reviews.llvm.org/rL322380 has been merged this seems good to me.

Jan 13 2018, 5:47 PM

Jan 2 2018

martell added a comment to D41597: Driver: ignore -mbig-obj like /bigobj.
In D41597#964538, @rnk wrote:

Looks good. Maybe we should also fix clang to accept this flag, though?

We should be able to add it as an ignored flag much like the /bigobj flag for clang-cl
Since rL217812 clang implicitly creates bigobj files when needed.
Will update to reflect when I get the chance.

Jan 2 2018, 2:58 AM

Dec 27 2017

martell created D41597: Driver: ignore -mbig-obj like /bigobj.
Dec 27 2017, 6:16 AM
martell created D41596: CMAKE: apply -O3 for mingw-w64 clang.
Dec 27 2017, 6:13 AM

Dec 26 2017

martell added a comment to D41580: CMAKE: Add flags to skip building NATIVE tools.

I like your idea, but can't you do this without adding new flags?

You already have to pass -D(CLANG|LLVM)_TABLEGEN which prevents them from getting built. llvm-config is a little different in that you need to pass -D_LLVM_CONFIG_EXE since project is undefined in tools/llvm-config, but adding a test for ${project}_LLVM_CONFIG_EXE is consistent and should work as well. Perhaps this needs to be refactored as well, so you can pass -DLLVM_CONFIG_EXE instead of -D_LLVM_CONFIG_EXE.

Dec 26 2017, 10:35 PM · Restricted Project
martell updated the summary of D41580: CMAKE: Add flags to skip building NATIVE tools.
Dec 26 2017, 3:20 AM · Restricted Project
martell updated the summary of D41580: CMAKE: Add flags to skip building NATIVE tools.
Dec 26 2017, 3:19 AM · Restricted Project
martell created D41580: CMAKE: Add flags to skip building NATIVE tools.
Dec 26 2017, 3:09 AM · Restricted Project

Dec 25 2017

martell closed D41570: COFF: fix IMAGE_FILE_MACHINE_AM33.

Landed in rL321447

Dec 25 2017, 12:12 PM
martell committed rL321447: COFF: fix IMAGE_FILE_MACHINE_AM33.
COFF: fix IMAGE_FILE_MACHINE_AM33
Dec 25 2017, 12:12 PM
martell added a reviewer for D41571: RISCV: Add IMAGE_FILE_MACHINE COFF address spaces: compnerd.
Dec 25 2017, 11:57 AM

Dec 24 2017

martell retitled D41571: RISCV: Add IMAGE_FILE_MACHINE COFF address spaces from RISCV: Add COFF address space to RISCV: Add IMAGE_FILE_MACHINE COFF address spaces.
Dec 24 2017, 10:33 PM
martell updated the summary of D41571: RISCV: Add IMAGE_FILE_MACHINE COFF address spaces.
Dec 24 2017, 10:33 PM
martell created D41571: RISCV: Add IMAGE_FILE_MACHINE COFF address spaces.
Dec 24 2017, 10:32 PM
martell created D41570: COFF: fix IMAGE_FILE_MACHINE_AM33.
Dec 24 2017, 10:29 PM
martell updated subscribers of D41567: Add NO_EXEC_STACK_DIRECTIVE to chkstk and chkstk2 sources.

hmm, looking at the #define for NO_EXEC_STACK_DIRECTIVE
once the two files have been removed from non windows targets they won't do anything anymore.

Dec 24 2017, 12:50 PM
martell accepted D41567: Add NO_EXEC_STACK_DIRECTIVE to chkstk and chkstk2 sources.

Also noting my comment on 35739

Dec 24 2017, 12:30 PM

Dec 1 2017

martell committed rL319610: CMAKE: help CheckAtomic find check_library_exists.
CMAKE: help CheckAtomic find check_library_exists
Dec 1 2017, 11:17 PM
martell closed D40220: CMAKE: help CheckAtomic find check_library_exists by committing rL319610: CMAKE: help CheckAtomic find check_library_exists.
Dec 1 2017, 11:17 PM

Nov 28 2017

martell abandoned D33384: [libcxx] [libcxxabi] fix building with libc++ win32 threads for mingw-w64.

The default is now configurable in mingw-w64

Nov 28 2017, 11:51 PM
martell committed rL319297: Toolchain: Normalize dwarf, sjlj and seh eh.
Toolchain: Normalize dwarf, sjlj and seh eh
Nov 28 2017, 11:25 PM
martell added a comment to D40220: CMAKE: help CheckAtomic find check_library_exists.

ping

Nov 28 2017, 11:12 PM
martell abandoned D23541: COFF: Support __image_base__.
Nov 28 2017, 11:10 PM
martell abandoned D13933: [COFF] Add some ld Aliases for gnu mode.
Nov 28 2017, 11:10 PM
martell abandoned D12323: lld: make pe targets use the coff linker.

we have come a long way since then @ruiu :) , abandoning a really old revision

Nov 28 2017, 11:10 PM · lld
martell added a comment to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.

I also want to note a small addition armeb and thumbeb for NetBSD.
They were missed in the previous version.
Just waiting for tests to pass now.

Nov 28 2017, 11:07 PM
martell added a comment to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.

@mstorsjo yup, I added a comment on the commit about the failure here rL319294
I have already fixed both issues.
Will re apply shortly.

Nov 28 2017, 11:03 PM
martell committed rL319295: Revert "Toolchain: Normalize dwarf, sjlj and seh eh".
Revert "Toolchain: Normalize dwarf, sjlj and seh eh"
Nov 28 2017, 10:52 PM
martell added a reverting change for rL319294: Toolchain: Normalize dwarf, sjlj and seh eh: rL319295: Revert "Toolchain: Normalize dwarf, sjlj and seh eh".
Nov 28 2017, 10:52 PM
martell added a comment to rL319294: Toolchain: Normalize dwarf, sjlj and seh eh.

seems the windows sanitizer bot does not like seh on i686
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/20371/steps/run%20check-asan/logs/stdio
going to revert and re apply with None for x86

Nov 28 2017, 10:47 PM
martell committed rL319294: Toolchain: Normalize dwarf, sjlj and seh eh.
Toolchain: Normalize dwarf, sjlj and seh eh
Nov 28 2017, 10:25 PM
martell closed D39673: Toolchain: Normalize dwarf, sjlj and seh eh by committing rL319294: Toolchain: Normalize dwarf, sjlj and seh eh.
Nov 28 2017, 10:25 PM
martell added a comment to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.

landing this as it was previous approved by reid in this state and again re checked by martin.

Nov 28 2017, 10:24 PM
martell updated the diff for D39673: Toolchain: Normalize dwarf, sjlj and seh eh.
  • disregard my last comment, lets go with seh on all windows targets.
Nov 28 2017, 10:11 PM
martell added inline comments to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.
Nov 28 2017, 9:53 PM
martell updated the diff for D39673: Toolchain: Normalize dwarf, sjlj and seh eh.

address reid's comment
update to HEAD

Nov 28 2017, 9:11 PM

Nov 22 2017

martell added a comment to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.
In D39673#931861, @rnk wrote:

We have to know the EH model before pre-processing, and that shouldn't rely on LLVM TargetOptions. We can probably reuse the llvm::ExceptionHandling enum instead of these various overlapping booleans, if that's the direction you want to go. However, I don't see how we can get away from the clang toolchain knowing the default EH model for each target.

Nov 22 2017, 1:24 AM
martell updated the diff for D39673: Toolchain: Normalize dwarf, sjlj and seh eh.

fold USESjLjExceptions into GetExceptionModel.
do a best effort to check the llvm default exception model for the triple if the toolchain does not specify.
(mostly based on the cc1_as code)

Nov 22 2017, 1:04 AM

Nov 21 2017

martell added a comment to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.

Just as a note there is still a lot to be desired here. I do not particularly like the UseSEHExceptions function default and the actual macro definition guards should be based on the current ExceptionModel because we set that in lib/CodeGen/BackendUtil.cpp. This way we do not need to have some silly default of x64 && windows for UseSEHExceptions and can rely on the llvm backend defaults but override within the driver we want like the apple targets do for sjlj. This does for now keep the current functionality while giving us a flag to override which is the goal of this patch.

Nov 21 2017, 4:28 AM
martell added a comment to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.

I'm not sure if this is the right thing to do. Since the exception handling model more or less also defines what ABI the code conforms to, I can see it being useful to know what exception handling mode is intended to be used, even if compiling plain C code without exceptions enabled. E.g. when building libunwind, some of the C sources there have ifdefs that check for __USING_SJLJ_EXCEPTIONS__ and/or __ARM_DWARF_EH__. With this change, one has to manually start specifying it when building libunwind, to match whatever the default and/or manually chosen exception handling model is.

Nov 21 2017, 3:53 AM