Page MenuHomePhabricator

logan (Logan Chien)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 9 2012, 3:27 PM (502 w, 1 d)

Recent Activity

May 25 2022

logan committed rG0c8fdd72309e: [mlir] Fix Tensor_InsertSliceOp description (authored by logan).
[mlir] Fix Tensor_InsertSliceOp description
May 25 2022, 9:39 AM · Restricted Project, Restricted Project
logan closed D126264: [mlir] Fix Tensor_InsertSliceOp description.
May 25 2022, 9:39 AM · Restricted Project, Restricted Project

May 24 2022

logan added a comment to D125938: [mlir] Breakdown diagnostic string literals.

Thanks. Landed as rG57d239e4ad110c052fe0c05fb25a588ec5a8de14.

May 24 2022, 8:01 AM · Restricted Project, Restricted Project
logan committed rG57d239e4ad11: [mlir] Breakdown diagnostic string literals (authored by logan).
[mlir] Breakdown diagnostic string literals
May 24 2022, 7:59 AM · Restricted Project, Restricted Project
logan closed D125938: [mlir] Breakdown diagnostic string literals.
May 24 2022, 7:58 AM · Restricted Project, Restricted Project

May 23 2022

logan updated the summary of D126264: [mlir] Fix Tensor_InsertSliceOp description.
May 23 2022, 6:13 PM · Restricted Project, Restricted Project
logan requested review of D126264: [mlir] Fix Tensor_InsertSliceOp description.
May 23 2022, 6:12 PM · Restricted Project, Restricted Project

May 18 2022

logan requested review of D125938: [mlir] Breakdown diagnostic string literals.
May 18 2022, 4:51 PM · Restricted Project, Restricted Project

May 13 2022

logan requested review of D125599: Introduce TypeNameTraits for llvm::getTypeName().
May 13 2022, 10:26 PM · Restricted Project, Restricted Project

Mar 10 2022

logan accepted D121432: [ARM] __cxa_end_cleanup: avoid clobbering r4.
Mar 10 2022, 10:35 PM · Restricted Project, Restricted Project

Dec 14 2021

logan committed rG9eb71608ee0f: Print the sign of negative infinity (authored by logan).
Print the sign of negative infinity
Dec 14 2021, 10:40 PM
logan closed D111917: Print the sign of negative infinity.
Dec 14 2021, 10:40 PM · Restricted Project

Oct 28 2021

logan added a comment to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..

Independent of the test failure: We (chromium) update clang and libcxxabi independently of each other. That works fine with this change, yes?

Oct 28 2021, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
logan added inline comments to rGb6420e575f3b: Reland "[ARM] __cxa_end_cleanup should be called instead of _UnwindResume.".
Oct 28 2021, 9:21 AM

Oct 26 2021

logan accepted D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..

Looks good to me.

Oct 26 2021, 9:57 AM · Restricted Project, Restricted Project, Restricted Project
logan requested changes to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 26 2021, 8:12 AM · Restricted Project, Restricted Project, Restricted Project
logan accepted D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 26 2021, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
logan added a comment to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..

Looks good to me. Please also fix the pre-merge lint checks.

Oct 26 2021, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Oct 25 2021

logan added a comment to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..

We are quite close now. Here are my final comments.

Oct 25 2021, 9:06 AM · Restricted Project, Restricted Project, Restricted Project

Oct 24 2021

logan added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 24 2021, 9:49 AM · Restricted Project, Restricted Project, Restricted Project

Oct 16 2021

logan added a reviewer for D111917: Print the sign of negative infinity: chandlerc.
Oct 16 2021, 12:08 PM · Restricted Project

Oct 15 2021

logan added a reviewer for D111917: Print the sign of negative infinity: zturner.
Oct 15 2021, 5:51 PM · Restricted Project
logan requested review of D111917: Print the sign of negative infinity.
Oct 15 2021, 5:51 PM · Restricted Project

Oct 13 2021

logan added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 13 2021, 7:39 PM · Restricted Project, Restricted Project, Restricted Project
logan added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 13 2021, 7:34 PM · Restricted Project, Restricted Project, Restricted Project
logan added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 13 2021, 3:00 PM · Restricted Project, Restricted Project, Restricted Project
logan accepted D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 13 2021, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
logan added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 13 2021, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
logan added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Oct 13 2021, 7:36 AM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2021

logan committed rG88125e8af1d2: [mlir] Fix attachInterface typo (authored by logan).
[mlir] Fix attachInterface typo
Aug 24 2021, 3:19 PM
logan closed D108666: Fix attachInterface documentation typo.
Aug 24 2021, 3:18 PM · Restricted Project
logan requested review of D108666: Fix attachInterface documentation typo.
Aug 24 2021, 2:46 PM · Restricted Project

Jun 29 2021

logan accepted D102894: [MCStreamer] Move emission of attributes section into MCELFStreamer.
Jun 29 2021, 1:25 PM · Restricted Project

Jun 28 2021

logan added a comment to D102894: [MCStreamer] Move emission of attributes section into MCELFStreamer.

It has been a while since I wrote the ARM attribute emitter, but anyway this commit makes sense to me and I think this is the right direction. Other than the Lint problems, I don't see other problems in this commit.

Jun 28 2021, 8:05 PM · Restricted Project

Apr 15 2020

logan added a comment to D70800: Fix AArch64 AAPCS frame record chain.

Rebase to latest LLVM master branch

Did you make any other changes other than the rebase?

Apr 15 2020, 10:56 AM · Restricted Project

Apr 14 2020

logan updated the diff for D70800: Fix AArch64 AAPCS frame record chain.

Rebase to latest LLVM master branch

Apr 14 2020, 9:45 PM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG9110af5bec63: Add dialect-attribute-entry requirement to docs (authored by logan).
Add dialect-attribute-entry requirement to docs
Dec 23 2019, 9:15 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG0fbac09473fb: Fix attribute dict syntax in the docs (authored by logan).
Fix attribute dict syntax in the docs
Dec 23 2019, 9:15 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG6b1d7f51ef03: Add TensorRankOf for ranked tensor types with specific ranks (authored by logan).
Add TensorRankOf for ranked tensor types with specific ranks
Dec 23 2019, 8:50 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGb1ce4df505d7: Add Positive{I32,I64}Attr and HasAnyRankOfPred (authored by logan).
Add Positive{I32,I64}Attr and HasAnyRankOfPred
Dec 23 2019, 8:49 PM

Dec 16 2019

logan reopened D70800: Fix AArch64 AAPCS frame record chain.

I reverted the CL because I encountered the following assertion:

Dec 16 2019, 10:18 PM · Restricted Project

Dec 14 2019

logan committed rG061a94e4e285: Revert "AArch64: Fix frame record chain" (authored by logan).
Revert "AArch64: Fix frame record chain"
Dec 14 2019, 2:08 PM
logan added a reverting change for rGd4e10e6adb1b: AArch64: Fix frame record chain: rG061a94e4e285: Revert "AArch64: Fix frame record chain".
Dec 14 2019, 2:07 PM
logan committed rGd4e10e6adb1b: AArch64: Fix frame record chain (authored by logan).
AArch64: Fix frame record chain
Dec 14 2019, 10:41 AM
logan closed D70800: Fix AArch64 AAPCS frame record chain.
Dec 14 2019, 10:40 AM · Restricted Project

Dec 10 2019

logan updated the diff for D70800: Fix AArch64 AAPCS frame record chain.

Run git clang-format and resolve rebase conflicts.

Dec 10 2019, 11:19 PM · Restricted Project

Dec 3 2019

logan added inline comments to D70800: Fix AArch64 AAPCS frame record chain.
Dec 3 2019, 11:39 PM · Restricted Project
logan updated the diff for D70800: Fix AArch64 AAPCS frame record chain.
Dec 3 2019, 11:30 PM · Restricted Project

Dec 2 2019

logan updated the diff for D70800: Fix AArch64 AAPCS frame record chain.
Dec 2 2019, 11:03 PM · Restricted Project
logan added inline comments to D70800: Fix AArch64 AAPCS frame record chain.
Dec 2 2019, 9:54 PM · Restricted Project
logan updated the diff for D70800: Fix AArch64 AAPCS frame record chain.
Dec 2 2019, 9:54 PM · Restricted Project

Dec 1 2019

logan added inline comments to D70800: Fix AArch64 AAPCS frame record chain.
Dec 1 2019, 11:30 PM · Restricted Project
logan updated the diff for D70800: Fix AArch64 AAPCS frame record chain.
Dec 1 2019, 11:21 PM · Restricted Project

Nov 29 2019

logan added inline comments to D70800: Fix AArch64 AAPCS frame record chain.
Nov 29 2019, 11:10 PM · Restricted Project

Nov 28 2019

logan added inline comments to D70800: Fix AArch64 AAPCS frame record chain.
Nov 28 2019, 10:25 PM · Restricted Project

Nov 27 2019

logan created D70800: Fix AArch64 AAPCS frame record chain.
Nov 27 2019, 11:58 PM · Restricted Project

Jun 29 2018

logan abandoned D24083: [CMake] Fix libc++abi __aeabi_idiv() link error..
Jun 29 2018, 8:24 PM
logan abandoned D24084: [CMake] Cleanup libunwind lookup code..
Jun 29 2018, 8:24 PM

Feb 23 2018

logan committed rL326027: Cleanup __config indention NFC.
Cleanup __config indention NFC
Feb 23 2018, 11:59 PM
logan committed rCXX326027: Cleanup __config indention NFC.
Cleanup __config indention NFC
Feb 23 2018, 11:59 PM

Jan 5 2017

logan committed rL291193: Code cleanup: Remove tab indents..
Code cleanup: Remove tab indents.
Jan 5 2017, 3:52 PM

Dec 15 2016

logan added a comment to D24083: [CMake] Fix libc++abi __aeabi_idiv() link error..

Sorry, I don't have time to work on this recently. Here's the plan:

Dec 15 2016, 8:59 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

Yeah. It is a kind of similar. Another route is to move the code from <libunwind>/include/unwind.h to <clang>/lib/Headers and then ship a shim layer with libc++abi and/or libunwind for old clang.

Dec 15 2016, 8:54 AM

Nov 13 2016

logan closed D24085: arm: Fix ttype encoding assertion failure..

Thanks for reviewing. Committed as rL286760.

Nov 13 2016, 6:54 AM
logan committed rL286760: arm: Fix ttype encoding assertion failure..
arm: Fix ttype encoding assertion failure.
Nov 13 2016, 6:54 AM
logan closed D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Thanks. Committed as rL286759.

Nov 13 2016, 6:52 AM
logan committed rL286759: [CMake] Fix libc++abi arm build w/o libunwind..
[CMake] Fix libc++abi arm build w/o libunwind.
Nov 13 2016, 6:52 AM

Nov 11 2016

logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Would you mind if I commit this patch as-is? I believe OFF will is the better default value for ARM as well. Thanks.

Nov 11 2016, 8:22 PM

Nov 1 2016

logan updated subscribers of D24760: Failure to hoist constant out of loop.

For atomic-cmpxchg.ll, I found that your output is the same as the version I originally committed. The test was updated by @danielcdh in D24818 / rL284757. You may wish to add him as reviewer.

Nov 1 2016, 9:04 AM
logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Thanks for your comment.

Nov 1 2016, 8:56 AM

Oct 31 2016

logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Hi @EricWF and @mclow.lists:

Oct 31 2016, 6:59 AM
logan updated the diff for D24085: arm: Fix ttype encoding assertion failure..

Refine assertions to address the comments from mclow.lists.

Oct 31 2016, 6:57 AM

Oct 27 2016

logan added inline comments to D24085: arm: Fix ttype encoding assertion failure..
Oct 27 2016, 6:17 AM

Oct 6 2016

logan added inline comments to D24085: arm: Fix ttype encoding assertion failure..
Oct 6 2016, 8:03 AM

Oct 4 2016

logan committed rL283118: [lit] Allow more file extensions for test cases..
[lit] Allow more file extensions for test cases.
Oct 4 2016, 1:05 AM
logan committed rL283100: [CMake] Fix libc++abi standalone cmake build..
[CMake] Fix libc++abi standalone cmake build.
Oct 4 2016, 1:05 AM

Oct 3 2016

logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Ping? Any other comments?

Oct 3 2016, 9:14 AM
logan closed D24087: [lit] Allow more file extensions for test cases..

Thanks for reviewing. Committed as rL283118 with the suggested change regarding to is_sh_test assertion.

Oct 3 2016, 9:11 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

Ping. Any further comments? Or, should we duplicate <unwind.h> in multiple repositories?

Oct 3 2016, 5:04 AM
logan closed D24081: [CMake] Fix libc++abi standalone cmake build..

Thanks for reviewing. Committed as rL283100.

Oct 3 2016, 4:17 AM

Sep 6 2016

logan added a comment to D24083: [CMake] Fix libc++abi __aeabi_idiv() link error..

Hi @rengolin and @EricWF,

Sep 6 2016, 4:05 AM
logan added inline comments to D24087: [lit] Allow more file extensions for test cases..
Sep 6 2016, 3:43 AM

Sep 2 2016

logan closed D24080: [lit] Replace print with lit_config.note()..
Sep 2 2016, 7:05 AM
logan added a comment to D24080: [lit] Replace print with lit_config.note()..

Thanks. Committed as rL280484.

Sep 2 2016, 7:05 AM
logan committed rL280484: [lit] Replace print with lit_config.note()..
[lit] Replace print with lit_config.note().
Sep 2 2016, 7:04 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..
In D24084#532724, @asl wrote:

I totally agree with Renato. What part of libc++abi requires exactly libunwind's unwind.h, what is the dependency?

Sep 2 2016, 6:59 AM

Aug 31 2016

logan retitled D24087: [lit] Allow more file extensions for test cases. from to [lit] Allow more file extensions for test cases..
Aug 31 2016, 9:16 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

That is a horrible dependency... I never hit it because I always test libc++ with libunwind.

Aug 31 2016, 9:03 AM
logan accepted D19910: [unwinder] Get rid of unused code.

Sorry for the late reply. Thanks for your work. Yes, this is correct.

Aug 31 2016, 8:54 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

Yes. This is what we have today.

Aug 31 2016, 8:50 AM
logan retitled D24085: arm: Fix ttype encoding assertion failure. from to arm: Fix ttype encoding assertion failure..
Aug 31 2016, 8:43 AM
logan added a reviewer for D24084: [CMake] Cleanup libunwind lookup code.: asl.
Aug 31 2016, 8:42 AM
logan retitled D24084: [CMake] Cleanup libunwind lookup code. from to [CMake] Cleanup libunwind lookup code..
Aug 31 2016, 8:41 AM
logan retitled D24083: [CMake] Fix libc++abi __aeabi_idiv() link error. from to [CMake] Fix libc++abi __aeabi_idiv() link error..
Aug 31 2016, 8:40 AM
logan retitled D24082: [CMake] Fix libc++abi arm build w/o libunwind. from to [CMake] Fix libc++abi arm build w/o libunwind..
Aug 31 2016, 8:39 AM
logan retitled D24081: [CMake] Fix libc++abi standalone cmake build. from to [CMake] Fix libc++abi standalone cmake build..
Aug 31 2016, 8:38 AM
logan retitled D24080: [lit] Replace print with lit_config.note(). from to [lit] Replace print with lit_config.note()..
Aug 31 2016, 8:37 AM
logan committed rL280251: Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined()..
Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined().
Aug 31 2016, 8:25 AM

Mar 19 2016

logan added a comment to D18217: [libcxx] Fix -Wdeprecated warnings.

The simple replacement from throw() to _NOEXCEPT looks fine.

Mar 19 2016, 8:17 AM
logan removed a reviewer for D18217: [libcxx] Fix -Wdeprecated warnings: logan.
Mar 19 2016, 8:05 AM