Page MenuHomePhabricator

logan (Logan Chien)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 9 2012, 3:27 PM (357 w, 3 d)

Recent Activity

Jun 29 2018

logan abandoned D24083: [CMake] Fix libc++abi __aeabi_idiv() link error..
Jun 29 2018, 8:24 PM
logan abandoned D24084: [CMake] Cleanup libunwind lookup code..
Jun 29 2018, 8:24 PM

Feb 23 2018

logan committed rL326027: Cleanup __config indention NFC.
Cleanup __config indention NFC
Feb 23 2018, 11:59 PM
logan committed rCXX326027: Cleanup __config indention NFC.
Cleanup __config indention NFC
Feb 23 2018, 11:59 PM

Jan 5 2017

logan committed rL291193: Code cleanup: Remove tab indents..
Code cleanup: Remove tab indents.
Jan 5 2017, 3:52 PM

Dec 15 2016

logan added a comment to D24083: [CMake] Fix libc++abi __aeabi_idiv() link error..

Sorry, I don't have time to work on this recently. Here's the plan:

Dec 15 2016, 8:59 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

Yeah. It is a kind of similar. Another route is to move the code from <libunwind>/include/unwind.h to <clang>/lib/Headers and then ship a shim layer with libc++abi and/or libunwind for old clang.

Dec 15 2016, 8:54 AM

Nov 13 2016

logan closed D24085: arm: Fix ttype encoding assertion failure..

Thanks for reviewing. Committed as rL286760.

Nov 13 2016, 6:54 AM
logan committed rL286760: arm: Fix ttype encoding assertion failure..
arm: Fix ttype encoding assertion failure.
Nov 13 2016, 6:54 AM
logan closed D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Thanks. Committed as rL286759.

Nov 13 2016, 6:52 AM
logan committed rL286759: [CMake] Fix libc++abi arm build w/o libunwind..
[CMake] Fix libc++abi arm build w/o libunwind.
Nov 13 2016, 6:52 AM

Nov 11 2016

logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Would you mind if I commit this patch as-is? I believe OFF will is the better default value for ARM as well. Thanks.

Nov 11 2016, 8:22 PM

Nov 1 2016

logan updated subscribers of D24760: Failure to hoist constant out of loop.

For atomic-cmpxchg.ll, I found that your output is the same as the version I originally committed. The test was updated by @danielcdh in D24818 / rL284757. You may wish to add him as reviewer.

Nov 1 2016, 9:04 AM
logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Thanks for your comment.

Nov 1 2016, 8:56 AM

Oct 31 2016

logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Hi @EricWF and @mclow.lists:

Oct 31 2016, 6:59 AM
logan updated the diff for D24085: arm: Fix ttype encoding assertion failure..

Refine assertions to address the comments from mclow.lists.

Oct 31 2016, 6:57 AM

Oct 27 2016

logan added inline comments to D24085: arm: Fix ttype encoding assertion failure..
Oct 27 2016, 6:17 AM

Oct 6 2016

logan added inline comments to D24085: arm: Fix ttype encoding assertion failure..
Oct 6 2016, 8:03 AM

Oct 4 2016

logan committed rL283118: [lit] Allow more file extensions for test cases..
[lit] Allow more file extensions for test cases.
Oct 4 2016, 1:05 AM
logan committed rL283100: [CMake] Fix libc++abi standalone cmake build..
[CMake] Fix libc++abi standalone cmake build.
Oct 4 2016, 1:05 AM

Oct 3 2016

logan added a comment to D24082: [CMake] Fix libc++abi arm build w/o libunwind..

Ping? Any other comments?

Oct 3 2016, 9:14 AM
logan closed D24087: [lit] Allow more file extensions for test cases..

Thanks for reviewing. Committed as rL283118 with the suggested change regarding to is_sh_test assertion.

Oct 3 2016, 9:11 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

Ping. Any further comments? Or, should we duplicate <unwind.h> in multiple repositories?

Oct 3 2016, 5:04 AM
logan closed D24081: [CMake] Fix libc++abi standalone cmake build..

Thanks for reviewing. Committed as rL283100.

Oct 3 2016, 4:17 AM

Sep 6 2016

logan added a comment to D24083: [CMake] Fix libc++abi __aeabi_idiv() link error..

Hi @rengolin and @EricWF,

Sep 6 2016, 4:05 AM
logan added inline comments to D24087: [lit] Allow more file extensions for test cases..
Sep 6 2016, 3:43 AM

Sep 2 2016

logan closed D24080: [lit] Replace print with lit_config.note()..
Sep 2 2016, 7:05 AM
logan added a comment to D24080: [lit] Replace print with lit_config.note()..

Thanks. Committed as rL280484.

Sep 2 2016, 7:05 AM
logan committed rL280484: [lit] Replace print with lit_config.note()..
[lit] Replace print with lit_config.note().
Sep 2 2016, 7:04 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..
In D24084#532724, @asl wrote:

I totally agree with Renato. What part of libc++abi requires exactly libunwind's unwind.h, what is the dependency?

Sep 2 2016, 6:59 AM

Aug 31 2016

logan added parent revisions for D24085: arm: Fix ttype encoding assertion failure.: D24087: [lit] Allow more file extensions for test cases., D24081: [CMake] Fix libc++abi standalone cmake build..
Aug 31 2016, 9:17 AM
logan added a child revision for D24081: [CMake] Fix libc++abi standalone cmake build.: D24085: arm: Fix ttype encoding assertion failure..
Aug 31 2016, 9:17 AM
logan added a child revision for D24087: [lit] Allow more file extensions for test cases.: D24085: arm: Fix ttype encoding assertion failure..
Aug 31 2016, 9:17 AM
logan retitled D24087: [lit] Allow more file extensions for test cases. from to [lit] Allow more file extensions for test cases..
Aug 31 2016, 9:16 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

That is a horrible dependency... I never hit it because I always test libc++ with libunwind.

Aug 31 2016, 9:03 AM
logan accepted D19910: [unwinder] Get rid of unused code.

Sorry for the late reply. Thanks for your work. Yes, this is correct.

Aug 31 2016, 8:54 AM
logan added a comment to D24084: [CMake] Cleanup libunwind lookup code..

Yes. This is what we have today.

Aug 31 2016, 8:50 AM
logan retitled D24085: arm: Fix ttype encoding assertion failure. from to arm: Fix ttype encoding assertion failure..
Aug 31 2016, 8:43 AM
logan added a reviewer for D24084: [CMake] Cleanup libunwind lookup code.: asl.
Aug 31 2016, 8:42 AM
logan retitled D24084: [CMake] Cleanup libunwind lookup code. from to [CMake] Cleanup libunwind lookup code..
Aug 31 2016, 8:41 AM
logan retitled D24083: [CMake] Fix libc++abi __aeabi_idiv() link error. from to [CMake] Fix libc++abi __aeabi_idiv() link error..
Aug 31 2016, 8:40 AM
logan retitled D24082: [CMake] Fix libc++abi arm build w/o libunwind. from to [CMake] Fix libc++abi arm build w/o libunwind..
Aug 31 2016, 8:39 AM
logan retitled D24081: [CMake] Fix libc++abi standalone cmake build. from to [CMake] Fix libc++abi standalone cmake build..
Aug 31 2016, 8:38 AM
logan retitled D24080: [lit] Replace print with lit_config.note(). from to [lit] Replace print with lit_config.note()..
Aug 31 2016, 8:37 AM
logan committed rL280251: Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined()..
Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined().
Aug 31 2016, 8:25 AM

Mar 19 2016

logan added a comment to D18217: [libcxx] Fix -Wdeprecated warnings.

The simple replacement from throw() to _NOEXCEPT looks fine.

Mar 19 2016, 8:17 AM
logan removed a reviewer for D18217: [libcxx] Fix -Wdeprecated warnings: logan.
Mar 19 2016, 8:05 AM

Mar 14 2016

logan accepted D15883: Add ARM EHABI-related constants to unwind.h..
Mar 14 2016, 6:05 AM
logan closed D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..
Mar 14 2016, 6:01 AM

Mar 9 2016

logan added a comment to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..

Committed as rL263010.

Mar 9 2016, 5:29 AM
logan committed rL263010: Add ARM EHABI support to gcc_personality_v0..
Add ARM EHABI support to gcc_personality_v0.
Mar 9 2016, 5:25 AM

Mar 6 2016

logan added a comment to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..

Note: I have tested this change on Debian Jessie (armhf). It works without problems.

Mar 6 2016, 3:06 PM
logan accepted D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..

Look good to me.

Mar 6 2016, 3:05 PM

Feb 28 2016

logan added inline comments to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..
Feb 28 2016, 7:34 AM
logan added a comment to D15883: Add ARM EHABI-related constants to unwind.h..

I have committed this change as rL262178. Thanks for your work.

Feb 28 2016, 7:08 AM
logan committed rL262178: Add ARM EHABI-related constants to unwind.h..
Add ARM EHABI-related constants to unwind.h.
Feb 28 2016, 7:06 AM

Feb 26 2016

logan accepted D15883: Add ARM EHABI-related constants to unwind.h..

LGTM. It is good to go now.

Feb 26 2016, 8:49 PM

Feb 25 2016

logan added inline comments to D15883: Add ARM EHABI-related constants to unwind.h..
Feb 25 2016, 7:00 AM

Feb 24 2016

logan added inline comments to D15883: Add ARM EHABI-related constants to unwind.h..
Feb 24 2016, 7:30 AM

Feb 18 2016

logan added inline comments to D15883: Add ARM EHABI-related constants to unwind.h..
Feb 18 2016, 8:09 AM

Feb 17 2016

logan added inline comments to D15883: Add ARM EHABI-related constants to unwind.h..
Feb 17 2016, 4:54 PM

Feb 16 2016

logan added a comment to D15883: Add ARM EHABI-related constants to unwind.h..

In general, it looks good to me if the comments are addressed.

Feb 16 2016, 2:39 PM

Jan 4 2016

logan added a comment to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..

I have tested your patch. It can't be compiled with clang because several types and defines are missing from <clang>/lib/Headers/unwind.h. Thus, submitting this patch will break all self-bootstrapping build.

Jan 4 2016, 7:18 AM
logan added a comment to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..

Sorry for the late reply. I spent sometime to setup the testing environment.

Jan 4 2016, 7:12 AM

Dec 29 2015

logan added a comment to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..

I didn't mean to imply the C++ personality. The reconfiguration of the C personality makes things harder IMO. Now you need to rebuild the library if something changes and control that. If you absolutely must use this approach, why not introduce a new routine that dispatches as you want (just to be clear this would be different from the language specific personality)? The entire thing with the personalities is that they handle things one way only and you switch the one that is used.

Dec 29 2015, 8:11 AM

Dec 28 2015

logan added a comment to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..

Also, neighter LLVM nor GCC would produce references to this personality routine, so it seems odd to support this.

Dec 28 2015, 4:31 PM

Dec 26 2015

logan added inline comments to D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0..
Dec 26 2015, 9:38 PM

Dec 22 2015

logan closed D15613: Fix ARM __cxa_end_cleanup() and gc-sections..

Thanks! Committed as rL256241.

Dec 22 2015, 6:42 AM
logan committed rL256241: Fix ARM __cxa_end_cleanup() and gc-sections..
Fix ARM __cxa_end_cleanup() and gc-sections.
Dec 22 2015, 6:42 AM

Dec 20 2015

logan added a comment to D15613: Fix ARM __cxa_end_cleanup() and gc-sections..

@echristo: IMO, I prefer not to add such comment for two reasons:

Dec 20 2015, 7:28 AM

Dec 17 2015

logan retitled D15613: Fix ARM __cxa_end_cleanup() and gc-sections. from to Fix ARM __cxa_end_cleanup() and gc-sections..
Dec 17 2015, 7:42 AM

Sep 27 2015

logan added a comment to D13104: Mips - Mark the section .eh_frame as writeable for pic.

I was only testing clang+ld.bfd and clang+ld.gold at the time.

Sep 27 2015, 9:31 AM · Restricted Project

Sep 23 2015

logan added a comment to D13104: Mips - Mark the section .eh_frame as writeable for pic.

It was Android that asked us to get read-only .eh_frame working properly for Mips so I might have two opposing requests from the same project.

Sep 23 2015, 6:16 PM · Restricted Project

Aug 19 2015

logan accepted D11894: [libunwind] Remove unused includes.

LGTM. Tested on x86_64 and arm-linux-gnueabihf.

Aug 19 2015, 5:17 PM

Jul 28 2015

logan added a comment to D9744: Install libunwind headers.

My long-term plan is to make <clang>/lib/Headers/unwind.h have all
essential structs and defines to build libunwind and libc++abi. It will
look similar to the one in <libunwind>/include/unwind.h currently, i.e.
guarding different structs and defines with ifdefs.

Jul 28 2015, 5:30 PM

Jul 23 2015

logan closed D11190: unwind: Fix libc++abi and libgcc build..

Thanks for reviewing. Committed as rL243073.

Jul 23 2015, 5:17 PM
logan committed rL243073: unwind: Fix libc++abi and libgcc build..
unwind: Fix libc++abi and libgcc build.
Jul 23 2015, 5:17 PM

Jul 21 2015

logan added a comment to D11153: [Compiler-RT] If unwind/c++abi is set, don't include libgcc.

Since there's no way to remove libraries from the list (because the compiler adds them), there is no way a warning would be effective. Ie. the user would get a warning and would be able to do nothing.

Jul 21 2015, 5:23 PM
logan added a comment to D11190: unwind: Fix libc++abi and libgcc build..

Please have a look on the revised version. This should address all of the comments at the moment. I really wish to commit this change before 3.7 release. Thanks.

Jul 21 2015, 4:59 PM
logan updated the diff for D11190: unwind: Fix libc++abi and libgcc build..

Stash the changes from D11191.

Jul 21 2015, 4:56 PM
logan abandoned D11191: unwind: Export _Unwind_{Get,Set}{GR,IP}() for ARM EHABI..

Stashing the change with D11190.

Jul 21 2015, 4:54 PM

Jul 19 2015

logan closed D11230: libunwind: Introduce __libunwind_config.h..

Thanks for reviewing!

Jul 19 2015, 8:23 AM
logan committed rL242642: libunwind: Introduce __libunwind_config.h..
libunwind: Introduce __libunwind_config.h.
Jul 19 2015, 8:23 AM

Jul 18 2015

logan added inline comments to D11191: unwind: Export _Unwind_{Get,Set}{GR,IP}() for ARM EHABI..
Jul 18 2015, 8:53 AM

Jul 15 2015

logan added a comment to D11230: libunwind: Introduce __libunwind_config.h..

May you further elaborate your idea? I don't quite understand why should we install the headers of libunwind for libcxx?

Jul 15 2015, 11:47 AM
logan added a comment to D11190: unwind: Fix libc++abi and libgcc build..

For your use case, please have a look at the upcoming D11191. I believe it should work for you. Although I am really hesitating, I have just confirmed that Savannah libunwind[1] is working on ARM. So I am not strongly oppose to the idea now.

Jul 15 2015, 11:24 AM
logan added a parent revision for D11190: unwind: Fix libc++abi and libgcc build.: D11230: libunwind: Introduce __libunwind_config.h..
Jul 15 2015, 11:16 AM
logan added a child revision for D11230: libunwind: Introduce __libunwind_config.h.: D11190: unwind: Fix libc++abi and libgcc build..
Jul 15 2015, 11:16 AM
logan updated the diff for D11190: unwind: Fix libc++abi and libgcc build..

Address asl's comment.

Jul 15 2015, 11:16 AM
logan retitled D11230: libunwind: Introduce __libunwind_config.h. from to libunwind: Introduce __libunwind_config.h..
Jul 15 2015, 11:14 AM
logan added inline comments to D11190: unwind: Fix libc++abi and libgcc build..
Jul 15 2015, 9:42 AM

Jul 14 2015

logan added inline comments to D11190: unwind: Fix libc++abi and libgcc build..
Jul 14 2015, 5:40 PM
logan retitled D11191: unwind: Export _Unwind_{Get,Set}{GR,IP}() for ARM EHABI. from to unwind: Export _Unwind_{Get,Set}{GR,IP}() for ARM EHABI..
Jul 14 2015, 12:14 PM
logan added a child revision for D11190: unwind: Fix libc++abi and libgcc build.: D11191: unwind: Export _Unwind_{Get,Set}{GR,IP}() for ARM EHABI..
Jul 14 2015, 12:14 PM
logan retitled D11190: unwind: Fix libc++abi and libgcc build. from to unwind: Fix libc++abi and libgcc build..
Jul 14 2015, 12:06 PM
logan added a comment to D11153: [Compiler-RT] If unwind/c++abi is set, don't include libgcc.

I have some concern on the design of this change. IMO, it is unintuitive that one -l option will affect the other -l options. Can't we simply rely on --rtlib=compiler-rt? Or, alternatively, can we simply emit a warning instead of changing the behavior quietly? Thanks.

Jul 14 2015, 10:16 AM

Jul 13 2015

logan closed D11123: ARM: Fix cttz expansion on vector types..

Hi Renato,

Jul 13 2015, 8:40 AM
logan committed rL242037: ARM: Fix cttz expansion on vector types..
ARM: Fix cttz expansion on vector types.
Jul 13 2015, 8:37 AM
logan added a comment to D11123: ARM: Fix cttz expansion on vector types..

Hi Renato,

Jul 13 2015, 8:23 AM
logan updated the diff for D11123: ARM: Fix cttz expansion on vector types..

Add test cases for 64/128-bit vector types.

Jul 13 2015, 8:16 AM