User Details
- User Since
- Nov 9 2012, 3:27 PM (502 w, 1 d)
May 25 2022
May 24 2022
Thanks. Landed as rG57d239e4ad110c052fe0c05fb25a588ec5a8de14.
May 23 2022
May 18 2022
May 13 2022
Mar 10 2022
Dec 14 2021
Oct 28 2021
Independent of the test failure: We (chromium) update clang and libcxxabi independently of each other. That works fine with this change, yes?
Oct 26 2021
Looks good to me.
Looks good to me. Please also fix the pre-merge lint checks.
Oct 25 2021
We are quite close now. Here are my final comments.
Oct 24 2021
Oct 16 2021
Oct 15 2021
Oct 13 2021
Aug 24 2021
Jun 29 2021
Jun 28 2021
It has been a while since I wrote the ARM attribute emitter, but anyway this commit makes sense to me and I think this is the right direction. Other than the Lint problems, I don't see other problems in this commit.
Apr 15 2020
Apr 14 2020
Rebase to latest LLVM master branch
Dec 23 2019
Dec 16 2019
I reverted the CL because I encountered the following assertion:
Dec 14 2019
Dec 10 2019
Run git clang-format and resolve rebase conflicts.
Dec 3 2019
Dec 2 2019
Dec 1 2019
Nov 29 2019
Nov 28 2019
Nov 27 2019
Jun 29 2018
Feb 23 2018
Jan 5 2017
Dec 15 2016
Sorry, I don't have time to work on this recently. Here's the plan:
Yeah. It is a kind of similar. Another route is to move the code from <libunwind>/include/unwind.h to <clang>/lib/Headers and then ship a shim layer with libc++abi and/or libunwind for old clang.
Nov 13 2016
Thanks for reviewing. Committed as rL286760.
Thanks. Committed as rL286759.
Nov 11 2016
Would you mind if I commit this patch as-is? I believe OFF will is the better default value for ARM as well. Thanks.
Nov 1 2016
For atomic-cmpxchg.ll, I found that your output is the same as the version I originally committed. The test was updated by @danielcdh in D24818 / rL284757. You may wish to add him as reviewer.
Thanks for your comment.
Oct 31 2016
Hi @EricWF and @mclow.lists:
Refine assertions to address the comments from mclow.lists.
Oct 27 2016
Oct 6 2016
Oct 4 2016
Oct 3 2016
Ping? Any other comments?
Thanks for reviewing. Committed as rL283118 with the suggested change regarding to is_sh_test assertion.
Ping. Any further comments? Or, should we duplicate <unwind.h> in multiple repositories?
Thanks for reviewing. Committed as rL283100.
Sep 6 2016
Sep 2 2016
Thanks. Committed as rL280484.
Aug 31 2016
Sorry for the late reply. Thanks for your work. Yes, this is correct.
Yes. This is what we have today.
Mar 19 2016
The simple replacement from throw() to _NOEXCEPT looks fine.