- User Since
- Nov 9 2012, 3:27 PM (357 w, 3 d)
Jun 29 2018
Feb 23 2018
Jan 5 2017
Dec 15 2016
Sorry, I don't have time to work on this recently. Here's the plan:
Yeah. It is a kind of similar. Another route is to move the code from <libunwind>/include/unwind.h to <clang>/lib/Headers and then ship a shim layer with libc++abi and/or libunwind for old clang.
Nov 13 2016
Thanks for reviewing. Committed as rL286760.
Thanks. Committed as rL286759.
Nov 11 2016
Would you mind if I commit this patch as-is? I believe OFF will is the better default value for ARM as well. Thanks.
Nov 1 2016
Thanks for your comment.
Oct 31 2016
Refine assertions to address the comments from mclow.lists.
Oct 27 2016
Oct 6 2016
Oct 4 2016
Oct 3 2016
Ping? Any other comments?
Thanks for reviewing. Committed as rL283118 with the suggested change regarding to is_sh_test assertion.
Ping. Any further comments? Or, should we duplicate <unwind.h> in multiple repositories?
Thanks for reviewing. Committed as rL283100.
Sep 6 2016
Sep 2 2016
Thanks. Committed as rL280484.
Aug 31 2016
Sorry for the late reply. Thanks for your work. Yes, this is correct.
Yes. This is what we have today.
Mar 19 2016
The simple replacement from throw() to _NOEXCEPT looks fine.
Mar 14 2016
Mar 9 2016
Committed as rL263010.
Mar 6 2016
Note: I have tested this change on Debian Jessie (armhf). It works without problems.
Look good to me.
Feb 28 2016
I have committed this change as rL262178. Thanks for your work.
Feb 26 2016
LGTM. It is good to go now.
Feb 25 2016
Feb 24 2016
Feb 18 2016
Feb 17 2016
Feb 16 2016
In general, it looks good to me if the comments are addressed.
Jan 4 2016
I have tested your patch. It can't be compiled with clang because several types and defines are missing from <clang>/lib/Headers/unwind.h. Thus, submitting this patch will break all self-bootstrapping build.
Sorry for the late reply. I spent sometime to setup the testing environment.
Dec 29 2015
Dec 28 2015
Dec 26 2015
Dec 22 2015
Thanks! Committed as rL256241.
Dec 20 2015
@echristo: IMO, I prefer not to add such comment for two reasons:
Dec 17 2015
Sep 27 2015
Sep 23 2015
Aug 19 2015
LGTM. Tested on x86_64 and arm-linux-gnueabihf.
Jul 28 2015
My long-term plan is to make <clang>/lib/Headers/unwind.h have all
essential structs and defines to build libunwind and libc++abi. It will
look similar to the one in <libunwind>/include/unwind.h currently, i.e.
guarding different structs and defines with ifdefs.
Jul 23 2015
Thanks for reviewing. Committed as rL243073.
Jul 21 2015
Since there's no way to remove libraries from the list (because the compiler adds them), there is no way a warning would be effective. Ie. the user would get a warning and would be able to do nothing.
Please have a look on the revised version. This should address all of the comments at the moment. I really wish to commit this change before 3.7 release. Thanks.
Stash the changes from D11191.
Stashing the change with D11190.
Jul 19 2015
Thanks for reviewing!
Jul 18 2015
Jul 15 2015
May you further elaborate your idea? I don't quite understand why should we install the headers of libunwind for libcxx?
For your use case, please have a look at the upcoming D11191. I believe it should work for you. Although I am really hesitating, I have just confirmed that Savannah libunwind is working on ARM. So I am not strongly oppose to the idea now.
Address asl's comment.
Jul 14 2015
I have some concern on the design of this change. IMO, it is unintuitive that one -l option will affect the other -l options. Can't we simply rely on --rtlib=compiler-rt? Or, alternatively, can we simply emit a warning instead of changing the behavior quietly? Thanks.
Jul 13 2015