♟ logan

[mlir] Fix Tensor_InsertSliceOp description

[mlir] Breakdown diagnostic string literals

Print the sign of negative infinity

Independent of the test failure: We (chromium) update clang and libcxxabi independently of each other. That works fine with this change, yes?

Looks good to me. Please also fix the pre-merge lint checks.

We are quite close now. Here are my final comments.

[mlir] Fix attachInterface typo

It has been a while since I wrote the ARM attribute emitter, but anyway this commit makes sense to me and I think this is the right direction. Other than the Lint problems, I don't see other problems in this commit.

In D70800#1982889, @sdesmalen wrote:

In D70800#1982722, @logan wrote:

Rebase to latest LLVM master branch

Did you make any other changes other than the rebase?

Rebase to latest LLVM master branch

Add dialect-attribute-entry requirement to docs

Fix attribute dict syntax in the docs

Add TensorRankOf for ranked tensor types with specific ranks

Add Positive{I32,I64}Attr and HasAnyRankOfPred

I reverted the CL because I encountered the following assertion:

Revert "AArch64: Fix frame record chain"

AArch64: Fix frame record chain

Run git clang-format and resolve rebase conflicts.

Cleanup __config indention NFC

Code cleanup: Remove tab indents.

Sorry, I don't have time to work on this recently. Here's the plan:

Yeah. It is a kind of similar. Another route is to move the code from <libunwind>/include/unwind.h to <clang>/lib/Headers and then ship a shim layer with libc++abi and/or libunwind for old clang.

Thanks for reviewing. Committed as rL286760.

arm: Fix ttype encoding assertion failure.

Thanks. Committed as rL286759.

[CMake] Fix libc++abi arm build w/o libunwind.

Would you mind if I commit this patch as-is? I believe OFF will is the better default value for ARM as well. Thanks.

For atomic-cmpxchg.ll, I found that your output is the same as the version I originally committed. The test was updated by @danielcdh in D24818 / rL284757. You may wish to add him as reviewer.

Thanks for your comment.

Refine assertions to address the comments from mclow.lists.

[lit] Allow more file extensions for test cases.

[CMake] Fix libc++abi standalone cmake build.

Ping? Any other comments?

Thanks for reviewing. Committed as rL283118 with the suggested change regarding to is_sh_test assertion.

Ping. Any further comments? Or, should we duplicate <unwind.h> in multiple repositories?

Thanks for reviewing. Committed as rL283100.

Thanks. Committed as rL280484.

[lit] Replace print with lit_config.note().

In D24084#532724, @asl wrote:

I totally agree with Renato. What part of libc++abi requires exactly libunwind's unwind.h, what is the dependency?

In D24084#530433, @rengolin wrote:

That is a horrible dependency... I never hit it because I always test libc++ with libunwind.

Sorry for the late reply. Thanks for your work. Yes, this is correct.

Yes. This is what we have today.

Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined().

The simple replacement from throw() to _NOEXCEPT looks fine.

logan (Logan Chien)User

Projects

User Details

Recent ActivityView All

May 25 2022

May 24 2022

May 23 2022

May 18 2022

May 13 2022

Mar 10 2022

Dec 14 2021

Oct 28 2021

Oct 26 2021

Oct 25 2021

Oct 24 2021

Oct 16 2021

Oct 15 2021

Oct 13 2021

Aug 24 2021

Jun 29 2021

Jun 28 2021

Apr 15 2020

Apr 14 2020

Dec 23 2019

Dec 16 2019

Dec 14 2019

Dec 10 2019

Dec 3 2019

Dec 2 2019

Dec 1 2019

Nov 29 2019

Nov 28 2019

Nov 27 2019

Jun 29 2018

Feb 23 2018

Jan 5 2017

Dec 15 2016

Nov 13 2016

Nov 11 2016

Nov 1 2016

Oct 31 2016

Oct 27 2016

Oct 6 2016

Oct 4 2016

Oct 3 2016

Sep 6 2016

Sep 2 2016

Aug 31 2016

Mar 19 2016

logan (Logan Chien)
User

Recent Activity
View All