Page MenuHomePhabricator

yaron.keren (Yaron Keren)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 9 2013, 1:30 PM (485 w, 1 d)

Recent Activity

Feb 17 2022

yaron.keren added a comment to D108513: [docs] Update Getting Started with Visual Studio guide.

Git for Windows comes with its own installation of a bunch of them, and llvm's lit does pick them up automatically if they aren't available in PATH: https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/lit/llvm/config.py#L31-L35

Feb 17 2022, 12:29 PM · Restricted Project

Sep 6 2021

yaron.keren added a comment to D108390: [flang] Refine output file generation.

Yes the test had passed since then, so all OK.

Sep 6 2021, 2:57 AM · Restricted Project, Restricted Project

Aug 31 2021

yaron.keren committed rG10d78a06baa2: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir (authored by yaron.keren).
[llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir
Aug 31 2021, 8:58 AM
yaron.keren closed D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir.
Aug 31 2021, 8:58 AM · Restricted Project
yaron.keren added a comment to D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir.

Addressing comment in https://reviews.llvm.org/D108085

Aug 31 2021, 8:04 AM · Restricted Project
yaron.keren added inline comments to D108085: Use installed llvm-lit.py instead of lit.py PR-51072.
Aug 31 2021, 8:04 AM · Restricted Project
yaron.keren requested review of D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir.
Aug 31 2021, 8:03 AM · Restricted Project

Aug 27 2021

yaron.keren committed rG692ebe539537: [docs] Add DIA register instructions to Getting Started with Visual Studio page (authored by yaron.keren).
[docs] Add DIA register instructions to Getting Started with Visual Studio page
Aug 27 2021, 3:10 AM
yaron.keren closed D108811: [docs] Add DIA register instructions to Getting Started with Visual Studio page.
Aug 27 2021, 3:10 AM · Restricted Project
yaron.keren added a comment to D108811: [docs] Add DIA register instructions to Getting Started with Visual Studio page.

Address https://bugs.llvm.org/show_bug.cgi?id=51643

Aug 27 2021, 2:24 AM · Restricted Project
yaron.keren requested review of D108811: [docs] Add DIA register instructions to Getting Started with Visual Studio page.
Aug 27 2021, 2:17 AM · Restricted Project

Aug 26 2021

yaron.keren added a comment to D108513: [docs] Update Getting Started with Visual Studio guide.

Thanks for all the comments!

Aug 26 2021, 11:23 AM · Restricted Project
yaron.keren committed rG195857585908: [docs] Update Getting Started with Visual Studio guide (authored by yaron.keren).
[docs] Update Getting Started with Visual Studio guide
Aug 26 2021, 11:22 AM
yaron.keren closed D108513: [docs] Update Getting Started with Visual Studio guide.
Aug 26 2021, 11:21 AM · Restricted Project
yaron.keren added a comment to D108390: [flang] Refine output file generation.

The x64 windows pre-check bot is failing on this test, see:

Aug 26 2021, 11:19 AM · Restricted Project, Restricted Project
yaron.keren updated the diff for D108513: [docs] Update Getting Started with Visual Studio guide.

Upload lal local commits to include all local changes

Aug 26 2021, 7:25 AM · Restricted Project

Aug 24 2021

yaron.keren updated the diff for D108513: [docs] Update Getting Started with Visual Studio guide.

Address comments

Aug 24 2021, 11:25 AM · Restricted Project
yaron.keren added inline comments to D108513: [docs] Update Getting Started with Visual Studio guide.
Aug 24 2021, 11:25 AM · Restricted Project

Aug 21 2021

yaron.keren updated the diff for D108513: [docs] Update Getting Started with Visual Studio guide.

Trying yet again to fix the diff

Aug 21 2021, 11:43 AM · Restricted Project
yaron.keren updated the diff for D108513: [docs] Update Getting Started with Visual Studio guide.

Trying to fix the diff

Aug 21 2021, 11:42 AM · Restricted Project
yaron.keren updated the diff for D108513: [docs] Update Getting Started with Visual Studio guide.

Fix typo

Aug 21 2021, 11:31 AM · Restricted Project
yaron.keren updated the summary of D108513: [docs] Update Getting Started with Visual Studio guide.
Aug 21 2021, 11:17 AM · Restricted Project
yaron.keren retitled D108513: [docs] Update Getting Started with Visual Studio guide from changes to [docs] Update Getting Started with Visual Studio guide.
Aug 21 2021, 11:05 AM · Restricted Project
yaron.keren updated the diff for D108513: [docs] Update Getting Started with Visual Studio guide.

add all commits

Aug 21 2021, 11:04 AM · Restricted Project
yaron.keren requested review of D108513: [docs] Update Getting Started with Visual Studio guide.
Aug 21 2021, 11:00 AM · Restricted Project

Aug 20 2021

yaron.keren added a comment to D108444: [docs] Clarify how to run cmake and llvm-lit with Visual Studio addressing PR45978.

I completely agree, the Getting Started document should be modernized considering a current Visual Studio 2019 installation bundles tools and that GnuWin32 is antique. I will create revision for your review.

Aug 20 2021, 11:36 AM · Restricted Project
yaron.keren committed rG25c8ffa223ec: [docs] Clarify how to run cmake and llvm-lit with Visual Studio addressing… (authored by yaron.keren).
[docs] Clarify how to run cmake and llvm-lit with Visual Studio addressing…
Aug 20 2021, 12:55 AM
yaron.keren closed D108444: [docs] Clarify how to run cmake and llvm-lit with Visual Studio addressing PR45978.
Aug 20 2021, 12:54 AM · Restricted Project

Aug 19 2021

yaron.keren added a comment to D108444: [docs] Clarify how to run cmake and llvm-lit with Visual Studio addressing PR45978.

https://bugs.llvm.org/show_bug.cgi?id=45978

Aug 19 2021, 10:30 PM · Restricted Project
yaron.keren requested review of D108444: [docs] Clarify how to run cmake and llvm-lit with Visual Studio addressing PR45978.
Aug 19 2021, 10:29 PM · Restricted Project
yaron.keren added inline comments to D107690: [Modules] Do not remove failed modules after the control block phase.
Aug 19 2021, 10:31 AM · Restricted Project
yaron.keren added inline comments to D107690: [Modules] Do not remove failed modules after the control block phase.
Aug 19 2021, 9:50 AM · Restricted Project
yaron.keren committed rG1987eb9e9cc1: [docs] Document how to install sphinx and recommonmark on Ubuntu (authored by yaron.keren).
[docs] Document how to install sphinx and recommonmark on Ubuntu
Aug 19 2021, 8:25 AM
yaron.keren closed D108374: [docs] Document how to install sphinx and recommonmark on Ubuntu.
Aug 19 2021, 8:24 AM · Restricted Project
yaron.keren requested review of D108374: [docs] Document how to install sphinx and recommonmark on Ubuntu.
Aug 19 2021, 6:58 AM · Restricted Project
yaron.keren committed rG23b16d245382: [docs] Document that psutil should be installed in non-user location (authored by yaron.keren).
[docs] Document that psutil should be installed in non-user location
Aug 19 2021, 3:43 AM
yaron.keren closed D108356: [docs] Document that psutil should be installed in non-user location.
Aug 19 2021, 3:43 AM · Restricted Project
yaron.keren requested review of D108356: [docs] Document that psutil should be installed in non-user location.
Aug 19 2021, 2:28 AM · Restricted Project

Aug 18 2021

yaron.keren abandoned D108300: [AMX] replace dyn_cast<> with isa<>, https://reviews.llvm.org/D107544 comment.

already fixed in https://github.com/llvm/llvm-project/commit/ffe58de39319b42b46319473263b59bd68ceee67

Aug 18 2021, 8:13 AM · Restricted Project
yaron.keren accepted D108300: [AMX] replace dyn_cast<> with isa<>, https://reviews.llvm.org/D107544 comment.

passes tests

Aug 18 2021, 8:04 AM · Restricted Project
yaron.keren added a comment to D108300: [AMX] replace dyn_cast<> with isa<>, https://reviews.llvm.org/D107544 comment.

https://reviews.llvm.org/D107544

Aug 18 2021, 7:23 AM · Restricted Project
yaron.keren requested review of D108300: [AMX] replace dyn_cast<> with isa<>, https://reviews.llvm.org/D107544 comment.
Aug 18 2021, 7:22 AM · Restricted Project

Aug 17 2021

yaron.keren committed rG5aa0f9cc9ab2: Use installed llvm-lit.py instead of lit.py PR-51072 (authored by yaron.keren).
Use installed llvm-lit.py instead of lit.py PR-51072
Aug 17 2021, 11:06 PM
yaron.keren closed D108085: Use installed llvm-lit.py instead of lit.py PR-51072.
Aug 17 2021, 11:06 PM · Restricted Project
yaron.keren updated the diff for D108085: Use installed llvm-lit.py instead of lit.py PR-51072.

Switched to Linux repo

Aug 17 2021, 10:21 AM · Restricted Project
yaron.keren abandoned D108218: Use installed llvm-lit.py instead of lit.py PR-51072.

opened by mistake

Aug 17 2021, 10:20 AM · Restricted Project
yaron.keren requested review of D108218: Use installed llvm-lit.py instead of lit.py PR-51072.
Aug 17 2021, 10:20 AM · Restricted Project

Aug 15 2021

yaron.keren updated the diff for D108085: Use installed llvm-lit.py instead of lit.py PR-51072.

Support both Windows llvm-lit.py and Linux llvm-lit command name

Aug 15 2021, 11:51 AM · Restricted Project
yaron.keren added a comment to D108085: Use installed llvm-lit.py instead of lit.py PR-51072.

looking into Linux failures

Aug 15 2021, 7:57 AM · Restricted Project
yaron.keren requested review of D108085: Use installed llvm-lit.py instead of lit.py PR-51072.
Aug 15 2021, 6:37 AM · Restricted Project

Oct 7 2019

yaron.keren closed D31540: Prefer non-friend to friend in in redeclaration chain.
Oct 7 2019, 6:15 AM · Restricted Project

Feb 28 2018

yaron.keren resigned from D30170: Function definition may have uninstantiated body.
Feb 28 2018, 10:55 AM

Jun 12 2017

yaron.keren added a comment to D34086: Fix -print-after-all banner.

Added test in r305213.

Jun 12 2017, 11:07 AM

Jun 11 2017

yaron.keren created D34086: Fix -print-after-all banner.
Jun 11 2017, 1:30 AM

Apr 27 2017

yaron.keren added a comment to D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

OK

Apr 27 2017, 4:40 AM
yaron.keren added a comment to D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

Raphael , do you have commit access? should I commit this?

Apr 27 2017, 3:36 AM

Apr 25 2017

yaron.keren accepted D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

LGTM

Apr 25 2017, 7:59 AM
yaron.keren added a comment to D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.

Please move the =new out of the PP.AddPragmaHandler calls.
While at it, this code still (as the original) leaks the PragmaHandlers. These should be deleted after RemovePragmaHandler or instead, simply use std::unique_ptr.

Apr 25 2017, 7:19 AM

Apr 17 2017

yaron.keren added a reviewer for D31540: Prefer non-friend to friend in in redeclaration chain: bkramer.
Apr 17 2017, 11:43 PM · Restricted Project
yaron.keren reopened D31540: Prefer non-friend to friend in in redeclaration chain.

reverted in r300497

Apr 17 2017, 11:42 PM · Restricted Project

Apr 14 2017

yaron.keren added reviewers for D15006: Driver: Better detection of mingw-gcc: mati865, rnk.

Adding Mateusz and Reid.

Apr 14 2017, 8:06 AM

Apr 12 2017

yaron.keren updated the diff for D31540: Prefer non-friend to friend in in redeclaration chain.

Added attribute test.

Apr 12 2017, 6:21 AM · Restricted Project

Apr 5 2017

yaron.keren added a comment to D31540: Prefer non-friend to friend in in redeclaration chain.

Thanks, I'll make a test.

Apr 5 2017, 12:23 PM · Restricted Project
yaron.keren added inline comments to D31702: Append -w when LLVM_ENABLE_WARNINGS is Off..
Apr 5 2017, 2:45 AM

Mar 31 2017

yaron.keren created D31540: Prefer non-friend to friend in in redeclaration chain.
Mar 31 2017, 9:12 AM · Restricted Project
yaron.keren added a comment to D31505: Do not close STD* descriptors.

r299207

Mar 31 2017, 5:22 AM

Mar 30 2017

yaron.keren created D31505: Do not close STD* descriptors.
Mar 30 2017, 12:27 PM
yaron.keren resigned from D14446: Fallback to getpwuid() in path::home_directory() on Unix..
Mar 30 2017, 12:09 PM
yaron.keren resigned from D9880: Fix Bug 23189 in C++14 type inference for lambdas with undeclared identifiers.
Mar 30 2017, 12:08 PM
yaron.keren abandoned D6336: make SmallString::str() return std::string.
Mar 30 2017, 12:07 PM
yaron.keren resigned from D15006: Driver: Better detection of mingw-gcc.
Mar 30 2017, 12:07 PM

Mar 29 2017

yaron.keren added a comment to D27051: [X86] Add NumRegisterParameters Module Flag.

No intention of any major work intended... just moved the code (locally) to Release and regression tests were still passing.

Mar 29 2017, 12:54 PM
yaron.keren added a comment to D27051: [X86] Add NumRegisterParameters Module Flag.

Most other module flags are added at CodeGenModule::Release(). For consistency, could this code be in CodeGenModule::Release() as well?

Mar 29 2017, 12:13 PM

Mar 21 2017

yaron.keren added a comment to D31187: Fix removal of out-of-line definitions..

Could use dumpDeclContext() to test?

Mar 21 2017, 8:11 AM

Feb 14 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

OK.

Feb 14 2017, 11:14 AM · Restricted Project
yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

If something is broken now we don't break it even more.
__float128 remain be fixed to be compatible, not only some poor developer would have to fix the missing headers bug one day, he will have to re-fix limits.h the right way and undo this "fix".
There is a problems with limits.h, fix limits.h. Don't make all headers that happens to be in the same directory as limits.h disappear.

Feb 14 2017, 5:37 AM · Restricted Project

Feb 13 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

These directories are "mostly" equivalent, with some headers existing is mings gcc dir but missing in clang resource dir and thus will break compilation.
For example, the most popular (37089 download this week) https://sourceforge.net/projects/mingw-w64 distribuion for Windows had elected to place the includes

omp.h, quadmath.h, openacc.h

at

c:\mingw32\lib\gcc\i686-w64-mingw32\5.4.0\include\

with the corresponding libraries at

c:\mingw32\lib\gcc\i686-w64-mingw32\5.4.0\

I had verified this still holds true for the latest i686-6.3.0-release-posix-dwarf-rt_v5-rev1.7z package.
Removing the include dir will make clang less useful for mingw users using these includes, since they will not be found anymore.
Furthermore, It makes no sense to make such intrusive wide-ranging change where the original problem was with limits.h is actually due to:

/* The system's limits.h may, in turn, try to #include_next GCC's limits.h.
 Avert this #include_next madness. */
#if defined __GNUC__ && !defined _GCC_LIMITS_H_
#define _GCC_LIMITS_H_
#endif

so the solution may be as simple as

#if defined __GNUC__ && !defined _GCC_LIMITS_H_ && !defined __MINGW32__
#define _GCC_LIMITS_H_
#endif
Feb 13 2017, 10:03 PM · Restricted Project

Feb 9 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

What about omp.h and openacc.h ? many programs are using OpenMP.

Feb 9 2017, 11:57 AM · Restricted Project
yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

The gcc include dirs in mingw contains headers not available esewhere and thus can't be removed.
Notable examples,

Feb 9 2017, 11:24 AM · Restricted Project

Feb 3 2017

yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

Hiding these two include dirs removes many headers. Most has clang equivalents but not all of them.
For example quadmath.h is only there, and without the include path programs using it will fail to compile.

Feb 3 2017, 8:10 AM · Restricted Project
yaron.keren added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

This code is actually used with Windows as well as Linux (with the exception of line 218), see the comment blocks above for detailed include dirs from all platforms from which it was derived.

Feb 3 2017, 4:34 AM · Restricted Project

Jan 21 2017

yaron.keren accepted D28620: Guard __gnuc_va_list typedef.

LGTM, matches the code in libstdc++ stdarg,h.
You can remove the 'hack' comment in line 46, __GNUC_VA_LIST is just a standard include guard for the typedef.

Jan 21 2017, 7:22 PM

Jan 12 2017

yaron.keren added a comment to D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts..

@yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function declarations. My current patch focuses on friend class templates. Perhaps we should open another review item for a fix of http://llvm.org/pr30994.

Jan 12 2017, 12:57 AM

Jan 6 2017

yaron.keren added a comment to D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts..

While at it, http://llvm.org/pr30994

Jan 6 2017, 9:49 AM

Dec 29 2016

yaron.keren added inline comments to D27810: FileManager: mark virtual file entries as valid entries.
Dec 29 2016, 6:55 AM

Dec 12 2016

yaron.keren added inline comments to D27686: Add llvm::StringLiteral.
Dec 12 2016, 3:39 PM

Nov 29 2016

yaron.keren accepted D27049: [OpenCL] Refactor out ReadPipe/WritePipe.

LGTM after fixing the inline comment

Nov 29 2016, 12:35 PM

Nov 26 2016

yaron.keren added inline comments to D27049: [OpenCL] Refactor out ReadPipe/WritePipe.
Nov 26 2016, 12:31 PM

Jul 28 2016

yaron.keren added a comment to D22858: Fix DbgValue handling in SelectionDAG..

PR28749 was created with trunk clang on Ubuntu x64.
It reproduced reliably but is very fragile, changing just about anything in the code makes the problem disappear.

Jul 28 2016, 1:36 PM

Jul 27 2016

yaron.keren added a comment to D22858: Fix DbgValue handling in SelectionDAG..

I added a small reproducer for what is probably the same problem in

Jul 27 2016, 10:46 PM

Jun 8 2016

yaron.keren accepted D21117: Specify target in lifetime-asan test..

You mean
Some target platforms do not support -fsanitize=address.

Jun 8 2016, 3:14 AM

May 13 2016

yaron.keren accepted D20240: [clang-rename] Fix broken dependency on shared build..

result of r269402, LGTM

May 13 2016, 8:32 AM

Apr 20 2016

yaron.keren accepted D19285: Tweaks to get_started.html, especially for Windows developers.

Ah, OK, I am using regular svn and thus did not counter this problem.
Could you detail this exactly, the problem happens when using git-svn with core.autocrlf config=true but not with svn?
LGTM with this addition.

Apr 20 2016, 9:41 AM
yaron.keren added a comment to D19285: Tweaks to get_started.html, especially for Windows developers.

AFAIK the eol type is decided by svn based the svn:eol-style property, so as long the files were checked in correctly and you do not override it specifically while svn checkout, it just works.
Did you encounter problems with eol ?

Apr 20 2016, 9:01 AM

Feb 17 2016

yaron.keren accepted D15450: Avoid double deletion in Clang driver..

Would be nice to have CodeGenAction::TheModule redirect to CodeGeneratorImpl::M if possible, but that's for another patch. LGTM.

Feb 17 2016, 8:23 AM
yaron.keren added a comment to D15450: Avoid double deletion in Clang driver..

It certainly makes sense to redirect the module request to its owner instead of duplicating it in a local copy.

Feb 17 2016, 6:16 AM

Feb 11 2016

yaron.keren added a comment to D17183: Make TargetInfo store an actual DataLayout instead of a string..

We have tried to keep one copy of DataLayout around
http://reviews.llvm.org/D11103
Can it share the Module->getDataLayout() ?

Feb 11 2016, 7:41 PM

Jan 28 2016

yaron.keren added a comment to D16478: Always build a new TypeSourceInfo for function templates with parameters.

The instantiated does get a new collection of ParmVarDecls while getting
the pattern Type which points to the pattern ParmVarDecls. So the
ParmVarDecls pointed in the instantiated are not the same as those pointed
by its Type.

Jan 28 2016, 2:07 PM

Dec 18 2015

yaron.keren added a comment to D15553: PR25717: fatal IO error writing large outputs to console on Windows.

#define NOGDI
is also useful.

Dec 18 2015, 2:41 PM
yaron.keren added a comment to D15553: PR25717: fatal IO error writing large outputs to console on Windows.

+1 all general-purpose Windows stuff should move to WindowsSupport.h. I'm surprised we got away without so far.
We have NOMINMAX at lib/Driver/MSVCToolChain.cpp before Windows.h which should probably switched to use WindowsSupport.h.

Dec 18 2015, 2:40 PM