- User Since
- Apr 5 2014, 8:26 PM (504 w, 3 d)
Oct 15 2021
Oct 10 2021
Is it possible to get your IDE to record the module & the address?
Oct 8 2021
@JDevlieghere: ping. Or are you saying you wouldn't consider landing such a change at all?
Sep 15 2021
I think there's a bit of confusion going on here:
The original bug was opened by Ted Woodward, and I think his scenario was
motivated by embedded debugging. He also provided that example with a
breakpoint being set in main.
Sep 14 2021
Added patch context.
In the future, can you generate patches with context (i.e. pass -U9999 to
"git diff" or "git show"), it's a lot easier to read patches with context.
Sure thing, will do.
Sep 13 2021
Sep 6 2021
Jul 21 2021
@mgorny Do your changes allow debugging both the parent and child processes after a fork?
Jan 10 2020
Oct 14 2018
Oct 7 2018
What changed in SWIG 3.0.11?
Oct 6 2018
Changing title as it looks like this is not a Windows-only problem: https://github.com/rust-lang/rust/issues/54126.
Sep 18 2017
Maybe LLDB should use qAttached to determine if there's an active process? OpenOCD seems to implement that one correctly.
Sorry, for not catching this regression! I've checked that attaching to a standard gdbserver still worked, but was not aware of the other scenarios.
Sep 17 2017
FYI - this broke at least Windows, because the default behavior of Process::WillResume() changed from success to an error and WindowsProcess does not override WillResume(). Not sure what other platforms are in the same boat.
Sep 15 2017
This is what I see in the log:
< 16> send packet: $qfThreadInfo#bb < 5> read packet: $l#6c
And here's code that generates it: https://github.com/gnu-mcu-eclipse/openocd/blob/b21ab1d683aaee501d45fe8a509a2043123f16fd/src/rtos/rtos.c#L370
Jul 5 2017
Jul 1 2017
Eli, I can commit this if you are busy. Just give a nod.
Jun 30 2017
Tested Eli's version and was able to build all of rustc's standard library for the wasm32-... target.
Jun 22 2017
Jun 16 2017
Jun 15 2017
I'm definitely not an expert on this part of LLVM, but to me this change seems very fragile, as it assumes things about the types of certain DAG nodes, which may be true now, but may change in the future.
Jun 6 2017
Rust and Go are not the only missing languages. Looks like all of the newly-added DWARF5 language codes are not covered here.
Jun 2 2017
Though... wouldn't "category_lang == valobj_lang" be a sane default behavior for any languages not mentioned specifically below?
Jan 27 2017
Jan 26 2017
Could we make CMAKE_INSTALL_UCRT_LIBRARIES the default when building for Windows? Would there be any downside to that?
Jan 25 2017
Dec 21 2016
Ping! Should I ask somebody else to review?
Dec 6 2016
Nov 2 2015
@rnk Can you please commit it? Thanks!
Nov 1 2015
@rnk, Sounds like compiler-rt *is* a drop-in replacement for libgcc, so let's add 64-bit versions of chkstk/alloca for gcc objects.
Oct 26 2015
Oct 25 2015
Sorry, one more revision. Apparently chkstk needs triple underscore... <sigh>
On second thought, elimination of probe for the last page is not correct - that final push of the return address could land on the next page...
Also, I've figured out a better way to preserve eax.
Oct 24 2015
After playing with this some more - it's no fun linking with gcc-generated libraries, because they actually do use __checkstk_ms, so you have to pull in libgcc as well, and end up with duplicate symbols. Let's add _chkstk as an extra, not as replacement.
Oct 22 2015
So apparently LLVM lowers alloca's of large buffers into a call to _alloca (makes sense I guess - if the buffer is larger than a page).
Why wasn't it added along with _chkstk? Is _alloca available from some other mingw library?
Dec 9 2014
Dropped "-fPIC" part of the change, dropped #ifdef WIN32_ check.
Dec 6 2014
You guys seem to be the most active in compiler-rt repo. Can you please review and commit? (or suggest somebody more appropriate). Thanks!
Dec 4 2014
This was committed by @rnk in r212081.
Aug 1 2014
Implemented 'SEH_Epilogue' approach.
Jun 30 2014
Jun 27 2014
Jun 23 2014
@chapuni, Which tests broke? Is there a PR?
I saw that MultiJitTest.JitPool fails, but it was failing before my change too, so I ignored it.
Hmm, something must be wrong at the MC layer. When I assemble the output of llc with gnu assembler (after replacing register numbers with names in seh directives), it seems to produce a correct .obj.
Jun 22 2014
Jun 20 2014
FYI - this commit broke LLVM build using win32 threads flavor of the mingw toolchain. I am getting error: 'recursive_mutex' in namespace 'std' does not name a type.
Not sure if this would be considered a problem for LLVM...
Jun 19 2014
Fixed x86-64-static-relo-movl.ll and rebased.
Is 'x86_64-pc-win32-macho' a valid target? Windows 64 ABI in OSX object file seems like a weird combination.
Jun 18 2014
Yes, please commit, if you don't mind running format yourself.
Jun 13 2014
Addressed review comments.
Jun 12 2014
Jun 10 2014
Whoops, looks like I got .cfi_offset and .cfi_rel_offset mixed up. The original offsets in bigstructret2.ll test were actually correct.
Also, rebased on top of master.
Jun 9 2014
I ended up with an almost complete rewrite, so positing it as a new review: D4081
I've updated my patch. It should now solve your problem too.
Jun 8 2014
@sanjoy, I wonder what happens with your patch in case of stack re-alignment.
Sorry, I can't figure out how to get git to apply your diff. Could you please try it on the following IR:
Jun 7 2014
Looking at the llc output you provided in the bug, I notice that it spilled and emitted CFI info for XMM registers. What target was that compiled for? AFAIK, only Windows 64 ABI specifies XMMs as callee-saved. So if it was for Win64, my patch would directly address your problem.
Jun 6 2014
With more context
Please take a look at my preliminary patch to support Win64 SEH I've put here: http://reviews.llvm.org/D4053 (specifically stuff in X86FrameLowering.cpp). Not directly related to 19905, however, it touches the same code, and could benefit from the same refactoring.
May 2 2014
This patch doesn't work right. I am seeing stuff like this in the emitted code:
pushq %rbp .seh_pushreg %rdi
Which, I guess, makes sense, because MCAsmStreamer::EmitRegisterName performs DWARF->LLVM register index mapping before emitting the name.
Apr 28 2014
@nrieck, you've said above "I believe it's not necessary to change the prologue emission for Win64". However I don't see how would one express 'and ..., %rsp' with SEH unwind instructions, because the effective RSP offset here is not a compile-time constant.
Apr 25 2014
There's been much back-and-forth on the mailing list thread, so I am no longer sure which problems absolutely need to be fixed, and which were mentioned just in passing. It would be helpful to restate them in one place (here probably).