This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Add Kryo to available targets
ClosedPublic

Authored by kongyi on Apr 6 2017, 11:05 AM.

Details

Summary

Host CPU detection now supports Kryo, so we need to recognize it in ARM
target.

Diff Detail

Repository
rL LLVM

Event Timeline

kongyi created this revision.Apr 6 2017, 11:05 AM
t.p.northover accepted this revision.Apr 6 2017, 11:11 AM

Looks reasonable to me.

This revision is now accepted and ready to land.Apr 6 2017, 11:11 AM
echristo accepted this revision.Apr 6 2017, 11:14 AM
This revision was automatically updated to reflect the committed changes.
krasin added a subscriber: krasin.Apr 6 2017, 12:21 PM

I see the following failure in the bootstrap Clang build:

/usr/local/google/home/krasin/src/llvm.org/llvm/lib/Target/ARM/ARMSubtarget.cpp:244:11: error: enumeration value 'Kryo' not handled in switch [-Werror,-Wswitch]
  switch (ARMProcFamily) {

Looks like a bug to me.

kongyi added a comment.Apr 6 2017, 1:54 PM

I see the following failure in the bootstrap Clang build:

/usr/local/google/home/krasin/src/llvm.org/llvm/lib/Target/ARM/ARMSubtarget.cpp:244:11: error: enumeration value 'Kryo' not handled in switch [-Werror,-Wswitch]
  switch (ARMProcFamily) {

Looks like a bug to me.

Yes, this is something I overlooked. Since it's breaking Werror builds, I've reverted the change.