Page MenuHomePhabricator

krasin (Ivan Krasin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 6 2015, 3:56 PM (219 w, 9 h)

Recent Activity

Apr 17 2017

krasin edited reviewers for D32043: [Driver] Load all necessary default sanitizer blacklists, added: eugenis, pcc; removed: krasin.
Apr 17 2017, 10:10 AM

Apr 6 2017

krasin abandoned D31780: Add a virtual destructor to a class with virtual methods..
Apr 6 2017, 1:00 PM
krasin added a comment to D31780: Add a virtual destructor to a class with virtual methods..

So, this does not work as it introduces an undefined reference to the operator delete. And after a second thought, it might be that it's the warning that got enabled by default is to blame.

Apr 6 2017, 1:00 PM
krasin added a comment to D31775: [ARM] Add Kryo to available targets.

I see the following failure in the bootstrap Clang build:

Apr 6 2017, 12:21 PM
krasin created D31780: Add a virtual destructor to a class with virtual methods..
Apr 6 2017, 11:41 AM
krasin committed rL299679: Revert r299672: Add a virtual destructor to a class with virtual methods..
Revert r299672: Add a virtual destructor to a class with virtual methods.
Apr 6 2017, 11:35 AM
krasin committed rL299672: Add a virtual destructor to a class with virtual methods..
Add a virtual destructor to a class with virtual methods.
Apr 6 2017, 11:11 AM
krasin closed D31776: Add a virtual destructor to a class with virtual methods..
Apr 6 2017, 11:11 AM
krasin updated the summary of D31776: Add a virtual destructor to a class with virtual methods..
Apr 6 2017, 11:09 AM
krasin created D31776: Add a virtual destructor to a class with virtual methods..
Apr 6 2017, 11:07 AM
krasin committed rL299671: Fix unused lambda capture. Follow up to r299653..
Fix unused lambda capture. Follow up to r299653.
Apr 6 2017, 10:54 AM
krasin committed rL299666: Fix unused typedef. Follow up to r299575..
Fix unused typedef. Follow up to r299575.
Apr 6 2017, 10:48 AM
krasin added a comment to rL299575: Fix invalid memory access on android x86.

I am preparing a fix that only makes this typedef under Android.

Apr 6 2017, 10:39 AM
krasin added a comment to rL299575: Fix invalid memory access on android x86.

FYI: this breaks some bots, like http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/1239

Apr 6 2017, 10:34 AM

Apr 5 2017

krasin committed rL299584: Remove accidental debug printf. Follow up to r299583..
Remove accidental debug printf. Follow up to r299583.
Apr 5 2017, 1:20 PM
krasin added a comment to D31671: [AMDGPU] SDWA peephole: enable by default.

Sorry, I had to revert this revision as asan/msan detected issues with the change:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3988
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1173

Apr 5 2017, 1:11 PM
krasin committed rL299583: Revert r299536. [AMDGPU] SDWA peephole: enable by default..
Revert r299536. [AMDGPU] SDWA peephole: enable by default.
Apr 5 2017, 1:11 PM

Mar 24 2017

krasin committed rL298735: Revert r298620: [LV] Vectorize GEPs.
Revert r298620: [LV] Vectorize GEPs
Mar 24 2017, 2:02 PM
krasin added a comment to rL298620: [LV] Vectorize GEPs.

For the record, this makes LLD to crash while linking Chromium with ThinLTO: https://bugs.llvm.org//show_bug.cgi?id=32413

Mar 24 2017, 1:49 PM

Mar 20 2017

krasin accepted D31109: Support, LTO: When pruning a directory, ignore files not matching a prefix..

Thank you, Peter!

Mar 20 2017, 9:00 AM

Mar 17 2017

krasin added a comment to D31109: Support, LTO: When pruning a directory, ignore files not matching a prefix..

Generally, looks good, modulo the comment.

Mar 17 2017, 4:48 PM
krasin added a comment to D31096: LTO, Support: Add a safeguard against pruning a directory that is not a cache directory..

I believe this approach is too fragile, in particular because if llvmcache.timestamp is deleted, the cache no longer works, but the directory exists. That creates a broken state and user will have to learn about how the cache works. That breaks the principle of least surprise.

Mar 17 2017, 1:15 PM

Feb 28 2017

krasin added a comment to D30365: ELF ICF: Merge only functions..

Do we wait for anything or anybody? If not, let's submit the CL. That should fix ThinLTO bot in Chrome.

Feb 28 2017, 2:51 PM

Feb 27 2017

krasin accepted D30365: ELF ICF: Merge only functions..

Thank you, Rui!

Feb 27 2017, 8:33 AM

Feb 7 2017

krasin accepted D29686: [CMake] Fix USE_LLVM_SANITIZER configuration for out-of-tree builds..
Feb 7 2017, 2:57 PM
krasin added a comment to D29686: [CMake] Fix USE_LLVM_SANITIZER configuration for out-of-tree builds..

Hi Eric,

Feb 7 2017, 2:56 PM
krasin added a comment to D29686: [CMake] Fix USE_LLVM_SANITIZER configuration for out-of-tree builds..

Hi Eric,

Feb 7 2017, 2:40 PM

Jan 30 2017

krasin added a comment to D29240: IR: Consider two DISubprograms to be odr-equal if they have the same template parameters..

I have manually verified that this change gets rid of an assert during linking Chromium. Can you please also include a test case similar to the one mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c14?

Jan 30 2017, 8:14 AM

Jan 27 2017

krasin added inline comments to D28913: ThinLTOBitcodeWriter: Strip debug info from merged module..
Jan 27 2017, 2:50 PM
krasin added a comment to D28913: ThinLTOBitcodeWriter: Strip debug info from merged module..

I have just confirmed that this CL fixes the issue with Chromium + ThinLTO + debug info described here: https://crbug.com/682773#c9

Jan 27 2017, 1:53 PM
krasin committed rL293291: Avoid using unspecified ordering in MetadataLoader::MetadataLoaderImpl….
Avoid using unspecified ordering in MetadataLoader::MetadataLoaderImpl…
Jan 27 2017, 8:06 AM
krasin closed D29204: Avoid using unspecified ordering in MetadataLoader::MetadataLoaderImpl::parseOneMetadata..
Jan 27 2017, 8:05 AM

Jan 26 2017

krasin updated the summary of D29204: Avoid using unspecified ordering in MetadataLoader::MetadataLoaderImpl::parseOneMetadata..
Jan 26 2017, 4:08 PM
krasin created D29204: Avoid using unspecified ordering in MetadataLoader::MetadataLoaderImpl::parseOneMetadata..
Jan 26 2017, 4:07 PM

Jan 24 2017

krasin committed rL292974: Revert [AMDGPU][mc][tests][NFC] Add coverage/smoke tests for Gfx7 and Gfx8..
Revert [AMDGPU][mc][tests][NFC] Add coverage/smoke tests for Gfx7 and Gfx8.
Jan 24 2017, 12:10 PM

Jan 18 2017

krasin added a comment to D28467: [Sema] Add warning for unused lambda captures.

This change makes Clang hardly incompatible with MSVC++. Consider the following program:

Jan 18 2017, 2:03 PM

Jan 17 2017

krasin abandoned D28824: Revert r292204 as it introduces a stack-use-after-scope issue..

A proper fix had been submitted.

Jan 17 2017, 1:33 PM
krasin updated the summary of D28824: Revert r292204 as it introduces a stack-use-after-scope issue..
Jan 17 2017, 1:25 PM
krasin created D28824: Revert r292204 as it introduces a stack-use-after-scope issue..
Jan 17 2017, 1:07 PM

Jan 13 2017

krasin committed rL291918: Fix UBSan bots by blacklisting bits/stl_tree.h..
Fix UBSan bots by blacklisting bits/stl_tree.h.
Jan 13 2017, 9:41 AM
krasin closed D28686: Fix UBSan bots by blacklisting bits/stl_tree.h. by committing rL291918: Fix UBSan bots by blacklisting bits/stl_tree.h..
Jan 13 2017, 9:41 AM
krasin updated the diff for D28686: Fix UBSan bots by blacklisting bits/stl_tree.h..

Add a comment to the suppression.

Jan 13 2017, 9:37 AM
krasin updated the diff for D28686: Fix UBSan bots by blacklisting bits/stl_tree.h..

Remove leading space.

Jan 13 2017, 9:33 AM
krasin retitled D28686: Fix UBSan bots by blacklisting bits/stl_tree.h. from to Fix UBSan bots by blacklisting bits/stl_tree.h..
Jan 13 2017, 9:32 AM
krasin committed rL291911: Revert r291903 and r291898. Reason: they break check-lld on the bots..
Revert r291903 and r291898. Reason: they break check-lld on the bots.
Jan 13 2017, 8:56 AM
krasin closed D28683: Revert r291903 and r291898. Reason: they break check-lld on the bots. by committing rL291911: Revert r291903 and r291898. Reason: they break check-lld on the bots..
Jan 13 2017, 8:56 AM
krasin added a comment to D28683: Revert r291903 and r291898. Reason: they break check-lld on the bots..

For the record, check-lld failures can be observed here:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/2078

Jan 13 2017, 8:46 AM
krasin updated subscribers of D28683: Revert r291903 and r291898. Reason: they break check-lld on the bots..
Jan 13 2017, 8:41 AM
krasin retitled D28683: Revert r291903 and r291898. Reason: they break check-lld on the bots. from to Revert r291903 and r291898. Reason: they break check-lld on the bots..
Jan 13 2017, 8:39 AM

Jan 11 2017

krasin accepted D28579: [CMake][compiler-rt] Mark libcxx build for tsan as standalone.

LGTM

Jan 11 2017, 3:16 PM
krasin accepted D28580: [CMake][libcxx] Check that we have libcxxabi before using it.
Jan 11 2017, 3:15 PM
krasin added a comment to D28580: [CMake][libcxx] Check that we have libcxxabi before using it.

LGTM

Jan 11 2017, 3:15 PM
krasin added inline comments to D28580: [CMake][libcxx] Check that we have libcxxabi before using it.
Jan 11 2017, 2:59 PM
krasin committed rL291684: Revert rL291205 because it breaks Chrome tests under CFI..
Revert rL291205 because it breaks Chrome tests under CFI.
Jan 11 2017, 9:05 AM
krasin added a reverting change for rL291205: LowerTypeTests: Split the pass in two: a resolution phase and a lowering phase.: rL291684: Revert rL291205 because it breaks Chrome tests under CFI..
Jan 11 2017, 9:05 AM
krasin closed D28532: Revert rL291205 because it breaks Chrome tests under CFI. by committing rL291684: Revert rL291205 because it breaks Chrome tests under CFI..
Jan 11 2017, 9:04 AM
krasin added a comment to D28532: Revert rL291205 because it breaks Chrome tests under CFI..

To reproduce the issue on the Chromium side:

Jan 11 2017, 8:04 AM

Jan 10 2017

krasin retitled D28532: Revert rL291205 because it breaks Chrome tests under CFI. from to Revert rL291205 because it breaks Chrome tests under CFI..
Jan 10 2017, 2:03 PM

Dec 2 2016

krasin committed rL288553: Support escaping in TrigramIndex..
Support escaping in TrigramIndex.
Dec 2 2016, 3:40 PM
krasin closed D27318: Support escaping in TrigramIndex..
Dec 2 2016, 3:40 PM
krasin updated the diff for D27318: Support escaping in TrigramIndex..

NULL -> nullptr; fix the backreferences test cases.

Dec 2 2016, 3:28 PM
krasin updated the diff for D27318: Support escaping in TrigramIndex..

switch -> if

Dec 2 2016, 2:44 PM
krasin added inline comments to D27318: Support escaping in TrigramIndex..
Dec 2 2016, 12:23 PM
krasin updated the diff for D27318: Support escaping in TrigramIndex..

Add backreferences back (except \0).

Dec 2 2016, 12:21 PM
krasin added inline comments to D27318: Support escaping in TrigramIndex..
Dec 2 2016, 11:01 AM
krasin updated the diff for D27318: Support escaping in TrigramIndex..

Fix handling escaped symbols: they are all self-escaped in LLVM.

Dec 2 2016, 11:00 AM

Dec 1 2016

krasin retitled D27318: Support escaping in TrigramIndex. from to Support escaping in TrigramIndex..
Dec 1 2016, 12:50 PM

Nov 30 2016

krasin committed rL288303: Use trigrams to speed up SpecialCaseList..
Use trigrams to speed up SpecialCaseList.
Nov 30 2016, 7:05 PM
krasin closed D27188: Use trigrams to speed up SpecialCaseList..
Nov 30 2016, 7:04 PM
krasin added inline comments to D27188: Use trigrams to speed up SpecialCaseList..
Nov 30 2016, 6:50 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Format nits.

Nov 30 2016, 6:49 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Shorter in-class initialization (thx Peter!)

Nov 30 2016, 6:47 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Address final nits. Also sync.

Nov 30 2016, 6:31 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Add a test case proposed by Peter.

Nov 30 2016, 5:10 PM
krasin added a comment to D27188: Use trigrams to speed up SpecialCaseList..
In D27188#610048, @pcc wrote:

Maybe I'm not making myself clear. This test doesn't pass on my machine.

TEST_F(TrigramIndexTest, foo) {
  std::unique_ptr<TrigramIndex> TI = makeTrigramIndex(
      {"class1.h", "class2.h", "class3.h", "class4.h", "class.h"});
  EXPECT_FALSE(TI->isDefeated());
}
Nov 30 2016, 5:08 PM
krasin added inline comments to D27188: Use trigrams to speed up SpecialCaseList..
Nov 30 2016, 5:07 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Add one more test case.

Nov 30 2016, 5:04 PM
krasin added inline comments to D27188: Use trigrams to speed up SpecialCaseList..
Nov 30 2016, 4:59 PM
krasin added inline comments to D27188: Use trigrams to speed up SpecialCaseList..
Nov 30 2016, 4:57 PM
krasin added inline comments to D27188: Use trigrams to speed up SpecialCaseList..
Nov 30 2016, 4:51 PM
krasin added a comment to D27188: Use trigrams to speed up SpecialCaseList..

Please, take another look.

Nov 30 2016, 4:49 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

nits.

Nov 30 2016, 4:43 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Extract TrigramIndex{.h,.cpp,Test.cpp}.

Nov 30 2016, 4:39 PM
krasin added a comment to D27188: Use trigrams to speed up SpecialCaseList..

Please, take another look.

Nov 30 2016, 12:17 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Address the comments.

Nov 30 2016, 12:17 PM
krasin updated D27188: Use trigrams to speed up SpecialCaseList..
Nov 30 2016, 11:33 AM

Nov 29 2016

krasin added a comment to D27188: Use trigrams to speed up SpecialCaseList..

Peter, thank you for your comments. I have added some benchmarks to the description and will address the rest of your points tomorrow.

Nov 29 2016, 11:22 PM
krasin updated D27188: Use trigrams to speed up SpecialCaseList..
Nov 29 2016, 11:21 PM
krasin updated subscribers of D27188: Use trigrams to speed up SpecialCaseList..
Nov 29 2016, 9:19 PM
krasin updated D27188: Use trigrams to speed up SpecialCaseList..
Nov 29 2016, 8:51 PM
krasin added a reviewer for D27188: Use trigrams to speed up SpecialCaseList.: pcc.
Nov 29 2016, 8:47 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Speed improvements.

Nov 29 2016, 8:46 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Get rid of build()

Nov 29 2016, 6:20 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Remove debug leftovers.

Nov 29 2016, 5:03 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Simplify code; ensure build() is called.

Nov 29 2016, 2:00 PM
krasin updated the diff for D27188: Use trigrams to speed up SpecialCaseList..

Add test cases for trigrams into SpecialCaseList unit test.

Nov 29 2016, 1:10 PM

Nov 28 2016

krasin retitled D27188: Use trigrams to speed up SpecialCaseList. from to Use trigrams to speed up SpecialCaseList..
Nov 28 2016, 8:08 PM

Nov 21 2016

krasin added a comment to D26866: [ThinLTO] Handle values exported via indirect reference from global.

Oh, I have just learned about the existence of https://reviews.llvm.org/D26880
Probably, my request to review the CL is outdated (I have not yet looked into the other CL to make a real guess)

Nov 21 2016, 11:17 PM
krasin added a comment to D26866: [ThinLTO] Handle values exported via indirect reference from global.

can you please take a look at this CL, if you have cycles? The CL does not look terribly complicated and it's the only known reason for the Chromium ThinLTO bot being broken:
https://build.chromium.org/p/chromium.fyi/builders/ThinLTO%20Linux%20ToT/builds/551

Nov 21 2016, 11:15 PM
krasin added a reviewer for D26866: [ThinLTO] Handle values exported via indirect reference from global: pcc.
Nov 21 2016, 11:14 PM