- User Since
- Jul 6 2015, 3:56 PM (211 w, 1 d)
Apr 17 2017
Apr 6 2017
So, this does not work as it introduces an undefined reference to the operator delete. And after a second thought, it might be that it's the warning that got enabled by default is to blame.
I see the following failure in the bootstrap Clang build:
I am preparing a fix that only makes this typedef under Android.
FYI: this breaks some bots, like http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/1239
Apr 5 2017
Sorry, I had to revert this revision as asan/msan detected issues with the change:
Mar 24 2017
For the record, this makes LLD to crash while linking Chromium with ThinLTO: https://bugs.llvm.org//show_bug.cgi?id=32413
Mar 20 2017
Thank you, Peter!
Mar 17 2017
Generally, looks good, modulo the comment.
I believe this approach is too fragile, in particular because if llvmcache.timestamp is deleted, the cache no longer works, but the directory exists. That creates a broken state and user will have to learn about how the cache works. That breaks the principle of least surprise.
Feb 28 2017
Do we wait for anything or anybody? If not, let's submit the CL. That should fix ThinLTO bot in Chrome.
Feb 27 2017
Feb 7 2017
Jan 30 2017
I have manually verified that this change gets rid of an assert during linking Chromium. Can you please also include a test case similar to the one mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c14?
Jan 27 2017
I have just confirmed that this CL fixes the issue with Chromium + ThinLTO + debug info described here: https://crbug.com/682773#c9
Jan 26 2017
Jan 24 2017
Jan 18 2017
This change makes Clang hardly incompatible with MSVC++. Consider the following program:
Jan 17 2017
A proper fix had been submitted.
Jan 13 2017
Add a comment to the suppression.
Remove leading space.
For the record, check-lld failures can be observed here:
Jan 11 2017
To reproduce the issue on the Chromium side:
Jan 10 2017
Dec 2 2016
NULL -> nullptr; fix the backreferences test cases.
switch -> if
Add backreferences back (except \0).
Fix handling escaped symbols: they are all self-escaped in LLVM.
Dec 1 2016
Nov 30 2016
Shorter in-class initialization (thx Peter!)
Address final nits. Also sync.
Add a test case proposed by Peter.
Add one more test case.
Please, take another look.
Please, take another look.
Address the comments.
Nov 29 2016
Peter, thank you for your comments. I have added some benchmarks to the description and will address the rest of your points tomorrow.
Get rid of build()
Remove debug leftovers.
Simplify code; ensure build() is called.
Add test cases for trigrams into SpecialCaseList unit test.
Nov 28 2016
Nov 21 2016
Oh, I have just learned about the existence of https://reviews.llvm.org/D26880
Probably, my request to review the CL is outdated (I have not yet looked into the other CL to make a real guess)
can you please take a look at this CL, if you have cycles? The CL does not look terribly complicated and it's the only known reason for the Chromium ThinLTO bot being broken: