Page MenuHomePhabricator

sanwou01 (Sanne Wouda)
Graduate Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jan 12 2017, 6:15 AM (144 w, 4 d)

Recent Activity

Mon, Oct 14

sanwou01 committed rL374764: Request commit access for sanwou01.
Request commit access for sanwou01
Mon, Oct 14, 3:27 AM

Apr 26 2017

sanwou01 added a comment to D32534: [ARM] Add support for ORR and ORN instruction substitutions.

Thanks for completing the set, John. Looks good to me, but I'll let someone else provide the seal of approval. :-)
Thanks,
Sanne

Apr 26 2017, 5:23 AM
sanwou01 edited reviewers for D32534: [ARM] Add support for ORR and ORN instruction substitutions, added: sanwou01; removed: sanne.wouda.
Apr 26 2017, 5:19 AM

Apr 21 2017

sanwou01 added a comment to D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.

Thanks for your comments Reid. Please find my responses inline. I'll spin a new patch addressing your comments soonish.

Apr 21 2017, 5:52 AM

Apr 20 2017

sanwou01 added a comment to D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.

Hi Diana,

Apr 20 2017, 7:22 AM

Apr 18 2017

sanwou01 updated the diff for D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.

Don't include the changes from D31709 and D32159 in this patch (oops).

Apr 18 2017, 3:47 AM
sanwou01 retitled D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine from [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine to [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.
Apr 18 2017, 3:40 AM
sanwou01 updated the diff for D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.

Rebase on top of D31709 and D32159

Apr 18 2017, 3:34 AM
sanwou01 created D32159: [NFC] Move ParseDiagnosticArgs into Frontend.
Apr 18 2017, 3:04 AM
sanwou01 updated the summary of D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.
Apr 18 2017, 2:44 AM
sanwou01 updated the diff for D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.

Rebased and clang-formatted.

Apr 18 2017, 2:43 AM

Apr 7 2017

sanwou01 added reviewers for D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc: olista01, jmolloy, richard.barton.arm, kristof.beyls.
Apr 7 2017, 4:11 AM
sanwou01 committed rL299754: Skip Unicode character expansion in assembly files.
Skip Unicode character expansion in assembly files
Apr 7 2017, 3:25 AM
sanwou01 closed D31765: Skip Unicode character expansion in assembly files by committing rL299754: Skip Unicode character expansion in assembly files.
Apr 7 2017, 3:25 AM

Apr 5 2017

sanwou01 added reviewers for D31496: Make -defsym a driver option: rnk, rsmith.

Hi Salman,

Apr 5 2017, 7:33 AM
sanwou01 created D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.
Apr 5 2017, 7:29 AM
sanwou01 added reviewers for D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine: rnk, rsmith.
Apr 5 2017, 7:18 AM

Apr 3 2017

sanwou01 added a comment to D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.

Hi Oli,

Apr 3 2017, 6:22 AM

Mar 31 2017

sanwou01 edited reviewers for D31537: [ARM, Asm] Use correct source location for register tokens, added: sanwou01; removed: sanne.wouda.
Mar 31 2017, 11:07 AM
sanwou01 edited reviewers for D31530: [ARM] Use new assembler diags for ARM, added: sanwou01; removed: sanne.wouda.
Mar 31 2017, 5:57 AM

Mar 30 2017

sanwou01 updated the summary of D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.
Mar 30 2017, 9:33 AM
sanwou01 created D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.
Mar 30 2017, 9:27 AM

Mar 28 2017

sanwou01 committed rL298908: [AArch64] [Assembler] option to disable negative immediate conversions.
[AArch64] [Assembler] option to disable negative immediate conversions
Mar 28 2017, 3:15 AM
sanwou01 closed D31243: [AArch64] [Assembler] option to disable negative immediate conversions by committing rL298908: [AArch64] [Assembler] option to disable negative immediate conversions.
Mar 28 2017, 3:15 AM

Mar 27 2017

sanwou01 added a comment to D31243: [AArch64] [Assembler] option to disable negative immediate conversions.

Hi Sam,

Mar 27 2017, 10:00 AM
sanwou01 updated the diff for D31243: [AArch64] [Assembler] option to disable negative immediate conversions.

Also mark cmn<->cmp as substitions and add a RUN: line to a test.

Mar 27 2017, 9:57 AM
sanwou01 committed rL298850: [ARM] Add a driver option for +no-neg-immediates.
[ARM] Add a driver option for +no-neg-immediates
Mar 27 2017, 8:47 AM
sanwou01 closed D31197: [ARM] Add a driver option for +no-neg-immediates by committing rL298850: [ARM] Add a driver option for +no-neg-immediates.
Mar 27 2017, 8:47 AM

Mar 22 2017

sanwou01 added a comment to D31197: [ARM] Add a driver option for +no-neg-immediates.

Hi Renato,

Mar 22 2017, 9:32 AM
sanwou01 updated the diff for D31197: [ARM] Add a driver option for +no-neg-immediates.

Fix a typo in the test; add the option for the Aarch64 target as well.

Mar 22 2017, 8:53 AM
sanwou01 created D31243: [AArch64] [Assembler] option to disable negative immediate conversions.
Mar 22 2017, 8:23 AM
sanwou01 added a comment to D31197: [ARM] Add a driver option for +no-neg-immediates.

Hi Renato,

Mar 22 2017, 5:02 AM

Mar 21 2017

sanwou01 created D31197: [ARM] Add a driver option for +no-neg-immediates.
Mar 21 2017, 11:08 AM
sanwou01 committed rL298380: [ARM] [Assembler] Support negative immediates for A32, T32 and T16.
[ARM] [Assembler] Support negative immediates for A32, T32 and T16
Mar 21 2017, 8:11 AM
sanwou01 closed D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16 by committing rL298380: [ARM] [Assembler] Support negative immediates for A32, T32 and T16.
Mar 21 2017, 8:11 AM

Mar 10 2017

sanwou01 committed rL297454: [Assembler] Add location info to unary expressions..
[Assembler] Add location info to unary expressions.
Mar 10 2017, 5:20 AM
sanwou01 closed D30581: [Assembler] Add location info to unary expressions. by committing rL297454: [Assembler] Add location info to unary expressions..
Mar 10 2017, 5:20 AM
sanwou01 added a reviewer for D30581: [Assembler] Add location info to unary expressions.: olista01.

ping

Mar 10 2017, 3:23 AM

Mar 8 2017

sanwou01 added a comment to D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.

Hi Renato,

Mar 8 2017, 7:35 AM
sanwou01 added a comment to D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.

Hi Javed,

Mar 8 2017, 4:29 AM
sanwou01 retitled D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16 from [ARM] [Assembler] Extend implicit substitutions to [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.
Mar 8 2017, 4:15 AM
sanwou01 updated the diff for D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.

Update in response to reviewer comments.

Mar 8 2017, 4:12 AM

Mar 3 2017

sanwou01 created D30581: [Assembler] Add location info to unary expressions..
Mar 3 2017, 8:42 AM
sanwou01 created D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.
Mar 3 2017, 5:47 AM

Feb 28 2017

sanwou01 committed rL296465: [Assembler] Add test for !srcloc references in assembler diags.
[Assembler] Add test for !srcloc references in assembler diags
Feb 28 2017, 2:46 AM
sanwou01 closed D30167: [Assembler] Add test for !srcloc references in assembler diags by committing rL296465: [Assembler] Add test for !srcloc references in assembler diags.
Feb 28 2017, 2:46 AM

Feb 27 2017

sanwou01 added a comment to D30167: [Assembler] Add test for !srcloc references in assembler diags.

Could I please ask someone to have a look if they have a moment?

Feb 27 2017, 3:23 AM

Feb 21 2017

sanwou01 added inline comments to D30167: [Assembler] Add test for !srcloc references in assembler diags.
Feb 21 2017, 3:30 AM

Feb 20 2017

sanwou01 abandoned D29415: [Assembler] Inline assembly diagnostics test..
Feb 20 2017, 7:18 AM
sanwou01 abandoned D29770: [Assembler] Inline assembly diagnostics test..

Please see D30167 for an attempt to test this from llc.

Feb 20 2017, 7:17 AM
sanwou01 created D30167: [Assembler] Add test for !srcloc references in assembler diags.
Feb 20 2017, 7:14 AM
sanwou01 committed rL295655: [ARM] Add a div regression test for Cortex-M23.
[ARM] Add a div regression test for Cortex-M23
Feb 20 2017, 4:16 AM
sanwou01 closed D30162: [ARM] Add a div regression test for Cortex-M23 by committing rL295655: [ARM] Add a div regression test for Cortex-M23.
Feb 20 2017, 4:16 AM
sanwou01 created D30162: [ARM] Add a div regression test for Cortex-M23.
Feb 20 2017, 3:24 AM
sanwou01 committed rL295647: [ARM] Add regression tests for Cortex-M23 and Cortex-M33.
[ARM] Add regression tests for Cortex-M23 and Cortex-M33
Feb 20 2017, 2:48 AM
sanwou01 closed D30100: [ARM] Add regression tests for Cortex-M23 and Cortex-M33 by committing rL295647: [ARM] Add regression tests for Cortex-M23 and Cortex-M33.
Feb 20 2017, 2:48 AM

Feb 17 2017

sanwou01 created D30100: [ARM] Add regression tests for Cortex-M23 and Cortex-M33.
Feb 17 2017, 9:20 AM

Feb 13 2017

sanwou01 committed rL294950: [CodeGen] fix alignment of JUMPTABLE_INSTS on v8M.base.
[CodeGen] fix alignment of JUMPTABLE_INSTS on v8M.base
Feb 13 2017, 6:19 AM
sanwou01 closed D29650: [CodeGen] fix alignment of JUMPTABLE_INSTS on v8M.base by committing rL294950: [CodeGen] fix alignment of JUMPTABLE_INSTS on v8M.base.
Feb 13 2017, 6:19 AM
sanwou01 committed rL294947: [Assembler] Improve diagnostics for inline assembly..
[Assembler] Improve diagnostics for inline assembly.
Feb 13 2017, 6:09 AM
sanwou01 closed D29769: [Assembler] Improve diagnostics for inline assembly. by committing rL294947: [Assembler] Improve diagnostics for inline assembly..
Feb 13 2017, 6:09 AM
sanwou01 updated the diff for D29770: [Assembler] Inline assembly diagnostics test..

Use clang_cc1 -verify for testing as suggested by @rnk.

Feb 13 2017, 5:54 AM

Feb 9 2017

sanwou01 updated the diff for D29769: [Assembler] Improve diagnostics for inline assembly..

Missed an off-by-one error...

Feb 9 2017, 9:48 AM
sanwou01 added a comment to D29770: [Assembler] Inline assembly diagnostics test..

This tests the improved inline asm diagnostics from D29769.

Feb 9 2017, 9:46 AM
sanwou01 created D29770: [Assembler] Inline assembly diagnostics test..
Feb 9 2017, 9:45 AM
sanwou01 added a comment to D29769: [Assembler] Improve diagnostics for inline assembly..

Unfortunately, there is no consumer of LocInfos or LocCookies in besides clang, which is why a test is missing. I'll upload a patch (test only) for clang separately.

Feb 9 2017, 9:09 AM
sanwou01 created D29769: [Assembler] Improve diagnostics for inline assembly..
Feb 9 2017, 9:07 AM
sanwou01 updated the summary of D29650: [CodeGen] fix alignment of JUMPTABLE_INSTS on v8M.base.
Feb 9 2017, 8:33 AM
sanwou01 updated the diff for D29650: [CodeGen] fix alignment of JUMPTABLE_INSTS on v8M.base.

Good suggestion, @samparker. I've updated the test to include a check for the
presence of an alignment directive if generating an asm file.

Feb 9 2017, 8:32 AM

Feb 8 2017

sanwou01 committed rL294475: Move inline asm diags tests to an ARM directory..
Move inline asm diags tests to an ARM directory.
Feb 8 2017, 9:00 AM
sanwou01 committed rL294468: Fix inline asm diagnostics test..
Fix inline asm diagnostics test.
Feb 8 2017, 8:25 AM
sanwou01 committed rL294458: [Assembler] Enable nicer diagnostics for inline assembly..
[Assembler] Enable nicer diagnostics for inline assembly.
Feb 8 2017, 6:59 AM
sanwou01 committed rL294433: [Assembler] Enable nicer diagnostics for inline assembly..
[Assembler] Enable nicer diagnostics for inline assembly.
Feb 8 2017, 2:31 AM
sanwou01 closed D29441: [Assembler] Enable nicer diagnostics for inline assembly. by committing rL294433: [Assembler] Enable nicer diagnostics for inline assembly..
Feb 8 2017, 2:31 AM
sanwou01 abandoned D29410: [Assembler] Restore diagnostics handler after parsing..

Ready to land as part of D29441.

Feb 8 2017, 2:08 AM
sanwou01 abandoned D29411: [Assembler] Move SourceMgr and DiagInfo into AsmPrinter..

Ready to land as part of D29441.

Feb 8 2017, 2:07 AM
sanwou01 added a child revision for D29441: [Assembler] Enable nicer diagnostics for inline assembly.: D29415: [Assembler] Inline assembly diagnostics test..
Feb 8 2017, 1:50 AM
sanwou01 removed a child revision for D29414: [Assembler] Enable nicer diagnostics for inline assembly.: D29415: [Assembler] Inline assembly diagnostics test..
Feb 8 2017, 1:50 AM
sanwou01 edited parent revisions for D29415: [Assembler] Inline assembly diagnostics test., added: 1; removed: 1.
Feb 8 2017, 1:50 AM
sanwou01 abandoned D29412: [Assembler] Always copy temp inline assembly string..

Ready to land as D29441.

Feb 8 2017, 1:49 AM
sanwou01 abandoned D29413: [Assembler] Add a pointer to the inline assembly SourceMgr in MCContext..

Ready to land as D29441.

Feb 8 2017, 1:49 AM
sanwou01 abandoned D29414: [Assembler] Enable nicer diagnostics for inline assembly..

Ready to land as D29441.

Feb 8 2017, 1:48 AM
sanwou01 abandoned D29409: [Assembler] Allow buffer id to be passed to MCAsmParser.

@compnerd, this is part of a larger set of patches that changes the inline asm SourceMgr to be used multiple times. It will land as part of D29441.

Feb 8 2017, 1:43 AM

Feb 7 2017

sanwou01 updated the diff for D29415: [Assembler] Inline assembly diagnostics test..

Update the tests. Note that the diagnostics for backend errors are missing the
"instantiated into assembly here" messages. This is unfortunate but expected:
the origin information is no longer available at this stage.

Feb 7 2017, 8:43 AM
sanwou01 created D29650: [CodeGen] fix alignment of JUMPTABLE_INSTS on v8M.base.
Feb 7 2017, 8:20 AM
sanwou01 updated the diff for D29441: [Assembler] Enable nicer diagnostics for inline assembly..

Address reviewers' comments.

Feb 7 2017, 7:11 AM

Feb 3 2017

sanwou01 committed rL294000: [ARM] Change TCReturn to tBL if tailcall optimization fails..
[ARM] Change TCReturn to tBL if tailcall optimization fails.
Feb 3 2017, 3:27 AM
sanwou01 closed D29020: [ARM] Change TCReturn to tBL if tailcall optimization fails..
Feb 3 2017, 3:27 AM
sanwou01 committed rL293999: [LLC] Add an inline assembly diagnostics handler..
[LLC] Add an inline assembly diagnostics handler.
Feb 3 2017, 3:26 AM
sanwou01 closed D29408: [LLC] Add an inline assembly diagnostics handler..
Feb 3 2017, 3:25 AM
sanwou01 added a comment to D29441: [Assembler] Enable nicer diagnostics for inline assembly..

Probably a completely silly question but why don't we use LLVMContext::InlineAsmDiagHandler for this?

Feb 3 2017, 3:17 AM
sanwou01 committed rL293998: Test commit: remove a blank line..
Test commit: remove a blank line.
Feb 3 2017, 3:08 AM

Feb 2 2017

sanwou01 added a comment to D29414: [Assembler] Enable nicer diagnostics for inline assembly..

Hi Renato,

Feb 2 2017, 1:42 AM
sanwou01 added a comment to D29441: [Assembler] Enable nicer diagnostics for inline assembly..

These are patched from D29409, D29410, D29411, D29412, D29413, D29414 combined.

Feb 2 2017, 1:42 AM
sanwou01 created D29441: [Assembler] Enable nicer diagnostics for inline assembly..
Feb 2 2017, 1:30 AM

Feb 1 2017

sanwou01 added a parent revision for D29415: [Assembler] Inline assembly diagnostics test.: D29414: [Assembler] Enable nicer diagnostics for inline assembly..
Feb 1 2017, 12:03 PM
sanwou01 added a child revision for D29414: [Assembler] Enable nicer diagnostics for inline assembly.: D29415: [Assembler] Inline assembly diagnostics test..
Feb 1 2017, 12:03 PM
sanwou01 created D29415: [Assembler] Inline assembly diagnostics test..
Feb 1 2017, 12:03 PM
sanwou01 removed a child revision for D29411: [Assembler] Move SourceMgr and DiagInfo into AsmPrinter.: D29414: [Assembler] Enable nicer diagnostics for inline assembly..
Feb 1 2017, 11:54 AM
sanwou01 removed a parent revision for D29414: [Assembler] Enable nicer diagnostics for inline assembly.: D29411: [Assembler] Move SourceMgr and DiagInfo into AsmPrinter..
Feb 1 2017, 11:54 AM