Page MenuHomePhabricator

sanwou01 (Sanne Wouda)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jan 12 2017, 6:15 AM (158 w, 3 d)

Recent Activity

Fri, Jan 17

sanwou01 committed rGecfd6d3e8418: [clang] Set function attributes on SEH filter functions correctly. (authored by sanwou01).
[clang] Set function attributes on SEH filter functions correctly.
Fri, Jan 17, 10:13 AM
sanwou01 closed D72786: [clang] Set function attributes on SEH filter functions correctly..
Fri, Jan 17, 10:13 AM · Restricted Project

Thu, Jan 16

sanwou01 added a comment to D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics.

ping?

Thu, Jan 16, 2:35 AM · Restricted Project, Restricted Project
sanwou01 added reviewers for D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics: rovka, rengolin, efriedma.
Thu, Jan 16, 2:35 AM · Restricted Project, Restricted Project
sanwou01 updated the diff for D72786: [clang] Set function attributes on SEH filter functions correctly..

Fix tests, thanks rnk

Thu, Jan 16, 1:58 AM · Restricted Project

Wed, Jan 15

sanwou01 created D72786: [clang] Set function attributes on SEH filter functions correctly..
Wed, Jan 15, 10:03 AM · Restricted Project

Tue, Jan 14

sanwou01 committed rG1cc8fff420a7: [AArch64] Fix save register pairing for Windows AAPCS (authored by sanwou01).
[AArch64] Fix save register pairing for Windows AAPCS
Tue, Jan 14, 7:15 AM
sanwou01 closed D71754: [AArch64] Fix save register pairing for Windows AAPCS.
Tue, Jan 14, 7:15 AM · Restricted Project

Dec 23 2019

sanwou01 added inline comments to D71754: [AArch64] Fix save register pairing for Windows AAPCS.
Dec 23 2019, 9:25 AM · Restricted Project

Dec 20 2019

sanwou01 created D71754: [AArch64] Fix save register pairing for Windows AAPCS.
Dec 20 2019, 5:38 AM · Restricted Project

Dec 13 2019

sanwou01 added reviewers for D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics: SjoerdMeijer, dmgreen, t.p.northover.
Dec 13 2019, 8:06 AM · Restricted Project, Restricted Project
sanwou01 created D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics.
Dec 13 2019, 8:06 AM · Restricted Project, Restricted Project

Dec 5 2019

sanwou01 committed rGe503fee904d8: [AArch64] Fix MUL/SUB fusing (authored by sanwou01).
[AArch64] Fix MUL/SUB fusing
Dec 5 2019, 10:15 AM
sanwou01 closed D71067: [AArch64] Fix MUL/SUB fusing.
Dec 5 2019, 10:15 AM · Restricted Project
sanwou01 added a comment to D71067: [AArch64] Fix MUL/SUB fusing.

Great, thanks for confirming.

Dec 5 2019, 10:15 AM · Restricted Project
sanwou01 created D71067: [AArch64] Fix MUL/SUB fusing.
Dec 5 2019, 7:33 AM · Restricted Project
sanwou01 added a comment to D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.

This broke vectorized code in one case. To repro, fetch https://martin.st/temp/g723.c and compile with clang -target aarch64-w64-mingw32 -c -O3 g723.c. The diff in generated code is available at https://martin.st/temp/g723.s.diff.

The key change is this:

-       mul     v4.2s, v3.2s, v4.2s
-       mls     v4.2s, v5.2s, v2.2s
+       mul     v5.2s, v5.2s, v2.2s
+       mls     v5.2s, v3.2s, v4.2s

Thus it seems the sign is flipped; it used to calculate v3*v4-v5*v2, now it calculates v5*v2-v3*v4.

Dec 5 2019, 5:53 AM · Restricted Project

Dec 3 2019

sanwou01 committed rGf2e7de81c625: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD (authored by sanwou01).
[AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD
Dec 3 2019, 7:55 AM
sanwou01 closed D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.
Dec 3 2019, 7:55 AM · Restricted Project
sanwou01 committed rG970d9719ea0d: Precommit tests for D70673 (authored by sanwou01).
Precommit tests for D70673
Dec 3 2019, 6:59 AM

Nov 29 2019

sanwou01 added a comment to D68530: [AArch64] Don't combine callee-save and local stack adjustment when optimizing for size.

This change appears to cause an assertion failure in clang during a Chromium for Windows on Arm (AArch64). We suspect that it is also the cause of a mis-compilation when clang does not have assertions enabled, and causes a crash in some test cases. See https://crbug.com/1029385 for details.

Nov 29 2019, 11:29 AM · Restricted Project
sanwou01 updated the diff for D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.

Remove redundant TODO

Nov 29 2019, 1:44 AM · Restricted Project
sanwou01 added inline comments to D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.
Nov 29 2019, 1:44 AM · Restricted Project

Nov 28 2019

sanwou01 added a comment to D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.

Is the plan to add the indexed variants too? To treat them in the same way.

Nov 28 2019, 9:28 AM · Restricted Project
sanwou01 updated the diff for D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.

Addressed @dmgreen's comments.

Nov 28 2019, 9:28 AM · Restricted Project

Nov 26 2019

sanwou01 updated the diff for D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.

Clarified commit message; fixed long lines.

Nov 26 2019, 1:47 AM · Restricted Project

Nov 25 2019

sanwou01 updated the diff for D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.

Added performance evaluation results

Nov 25 2019, 8:52 AM · Restricted Project
sanwou01 created D70674: [AArch64] Precommit tests for over-eager MUL/ADD fusing fix.
Nov 25 2019, 8:42 AM · Restricted Project
sanwou01 created D70673: [AArch64] Fix over-eager fusing of NEON SIMD MUL/ADD.
Nov 25 2019, 8:37 AM · Restricted Project

Nov 8 2019

sanwou01 committed rGf649f24d388c: [RAGreedy] Enable -consider-local-interval-cost for AArch64 (authored by sanwou01).
[RAGreedy] Enable -consider-local-interval-cost for AArch64
Nov 8 2019, 2:25 AM
sanwou01 closed D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.
Nov 8 2019, 2:25 AM · Restricted Project

Nov 7 2019

sanwou01 updated the diff for D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.

Enable -consider-local-interval-cost for AArch64 only instead of all targets.

Nov 7 2019, 7:14 AM · Restricted Project
sanwou01 updated subscribers of D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.
Nov 7 2019, 7:14 AM · Restricted Project
sanwou01 updated subscribers of D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.
Nov 7 2019, 7:14 AM · Restricted Project
sanwou01 abandoned D32159: [NFC] Move ParseDiagnosticArgs into Frontend.
Nov 7 2019, 7:14 AM
sanwou01 abandoned D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.
Nov 7 2019, 7:14 AM

Oct 31 2019

sanwou01 committed rGf2cb9c0eabc1: Fix missing memcpy, memmove and memset tail calls (authored by sanwou01).
Fix missing memcpy, memmove and memset tail calls
Oct 31 2019, 9:14 AM
sanwou01 closed D59078: Fix missing memcpy, memmove and memset tail calls.
Oct 31 2019, 9:14 AM · Restricted Project

Oct 30 2019

sanwou01 added a reviewer for D59078: Fix missing memcpy, memmove and memset tail calls: dmgreen.
Oct 30 2019, 7:10 AM · Restricted Project
sanwou01 updated the diff for D59078: Fix missing memcpy, memmove and memset tail calls.

Fix crash and refactor for readability

Oct 30 2019, 5:18 AM · Restricted Project
sanwou01 commandeered D59078: Fix missing memcpy, memmove and memset tail calls.

Hi, I'd like to take over this change to get it committed. There is a crash lurking when llvm::returnTypeIsEligibleForTailCall is called with a function that takes no arguments, so I'd like to make some changes before committing. Thanks.

Oct 30 2019, 5:18 AM · Restricted Project

Oct 28 2019

sanwou01 added a comment to D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.

@jsji I have now committed the test case with -consider-local-interval-cost disabled, so the impact should be a bit more obvious now.

Oct 28 2019, 9:21 AM · Restricted Project
sanwou01 added a reviewer for D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64: qcolombet.
Oct 28 2019, 8:30 AM · Restricted Project
sanwou01 committed rG265ddc57579b: Precommit AArch64 test for -consider-local-interval-cost (authored by sanwou01).
Precommit AArch64 test for -consider-local-interval-cost
Oct 28 2019, 8:09 AM
sanwou01 closed D69512: Precommit AArch64 test for -consider-local-interval-cost.
Oct 28 2019, 8:09 AM · Restricted Project
sanwou01 updated the diff for D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.

Try again

Oct 28 2019, 6:44 AM · Restricted Project
sanwou01 created D69512: Precommit AArch64 test for -consider-local-interval-cost.
Oct 28 2019, 6:41 AM · Restricted Project
sanwou01 updated the diff for D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.

Rebased on top of test case precommit.

Oct 28 2019, 6:35 AM · Restricted Project

Oct 25 2019

sanwou01 updated the diff for D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.

Commit message formatting fixes

Oct 25 2019, 11:02 AM · Restricted Project
sanwou01 updated the summary of D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.
Oct 25 2019, 11:02 AM · Restricted Project
sanwou01 added reviewers for D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64: SjoerdMeijer, samparker, dmgreen.
Oct 25 2019, 10:53 AM · Restricted Project
sanwou01 created D69437: [RAGreedy] Enable -consider-local-interval-cost for AArch64.
Oct 25 2019, 10:53 AM · Restricted Project

Oct 14 2019

sanwou01 committed rL374764: Request commit access for sanwou01.
Request commit access for sanwou01
Oct 14 2019, 3:27 AM

Apr 26 2017

sanwou01 added a comment to D32534: [ARM] Add support for ORR and ORN instruction substitutions.

Thanks for completing the set, John. Looks good to me, but I'll let someone else provide the seal of approval. :-)
Thanks,
Sanne

Apr 26 2017, 5:23 AM
sanwou01 edited reviewers for D32534: [ARM] Add support for ORR and ORN instruction substitutions, added: sanwou01; removed: sanne.wouda.
Apr 26 2017, 5:19 AM

Apr 21 2017

sanwou01 added a comment to D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.

Thanks for your comments Reid. Please find my responses inline. I'll spin a new patch addressing your comments soonish.

Apr 21 2017, 5:52 AM

Apr 20 2017

sanwou01 added a comment to D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.

Hi Diana,

Apr 20 2017, 7:22 AM

Apr 18 2017

sanwou01 updated the diff for D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.

Don't include the changes from D31709 and D32159 in this patch (oops).

Apr 18 2017, 3:47 AM
sanwou01 retitled D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine from [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine to [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.
Apr 18 2017, 3:40 AM
sanwou01 updated the diff for D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.

Rebase on top of D31709 and D32159

Apr 18 2017, 3:34 AM
sanwou01 created D32159: [NFC] Move ParseDiagnosticArgs into Frontend.
Apr 18 2017, 3:04 AM
sanwou01 updated the summary of D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.
Apr 18 2017, 2:44 AM
sanwou01 updated the diff for D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.

Rebased and clang-formatted.

Apr 18 2017, 2:43 AM

Apr 7 2017

sanwou01 added reviewers for D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc: olista01, jmolloy, richard.barton.arm, kristof.beyls.
Apr 7 2017, 4:11 AM
sanwou01 committed rL299754: Skip Unicode character expansion in assembly files.
Skip Unicode character expansion in assembly files
Apr 7 2017, 3:25 AM
sanwou01 closed D31765: Skip Unicode character expansion in assembly files by committing rL299754: Skip Unicode character expansion in assembly files.
Apr 7 2017, 3:25 AM

Apr 5 2017

sanwou01 added reviewers for D31496: Make -defsym a driver option: rnk, rsmith.

Hi Salman,

Apr 5 2017, 7:33 AM
sanwou01 created D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.
Apr 5 2017, 7:29 AM
sanwou01 added reviewers for D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine: rnk, rsmith.
Apr 5 2017, 7:18 AM

Apr 3 2017

sanwou01 added a comment to D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.

Hi Oli,

Apr 3 2017, 6:22 AM

Mar 31 2017

sanwou01 edited reviewers for D31537: [ARM, Asm] Use correct source location for register tokens, added: sanwou01; removed: sanne.wouda.
Mar 31 2017, 11:07 AM
sanwou01 edited reviewers for D31530: [ARM] Use new assembler diags for ARM, added: sanwou01; removed: sanne.wouda.
Mar 31 2017, 5:57 AM

Mar 30 2017

sanwou01 updated the summary of D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.
Mar 30 2017, 9:33 AM
sanwou01 created D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine.
Mar 30 2017, 9:27 AM

Mar 28 2017

sanwou01 committed rL298908: [AArch64] [Assembler] option to disable negative immediate conversions.
[AArch64] [Assembler] option to disable negative immediate conversions
Mar 28 2017, 3:15 AM
sanwou01 closed D31243: [AArch64] [Assembler] option to disable negative immediate conversions by committing rL298908: [AArch64] [Assembler] option to disable negative immediate conversions.
Mar 28 2017, 3:15 AM

Mar 27 2017

sanwou01 added a comment to D31243: [AArch64] [Assembler] option to disable negative immediate conversions.

Hi Sam,

Mar 27 2017, 10:00 AM
sanwou01 updated the diff for D31243: [AArch64] [Assembler] option to disable negative immediate conversions.

Also mark cmn<->cmp as substitions and add a RUN: line to a test.

Mar 27 2017, 9:57 AM
sanwou01 committed rL298850: [ARM] Add a driver option for +no-neg-immediates.
[ARM] Add a driver option for +no-neg-immediates
Mar 27 2017, 8:47 AM
sanwou01 closed D31197: [ARM] Add a driver option for +no-neg-immediates by committing rL298850: [ARM] Add a driver option for +no-neg-immediates.
Mar 27 2017, 8:47 AM

Mar 22 2017

sanwou01 added a comment to D31197: [ARM] Add a driver option for +no-neg-immediates.

Hi Renato,

Mar 22 2017, 9:32 AM
sanwou01 updated the diff for D31197: [ARM] Add a driver option for +no-neg-immediates.

Fix a typo in the test; add the option for the Aarch64 target as well.

Mar 22 2017, 8:53 AM
sanwou01 created D31243: [AArch64] [Assembler] option to disable negative immediate conversions.
Mar 22 2017, 8:23 AM
sanwou01 added a comment to D31197: [ARM] Add a driver option for +no-neg-immediates.

Hi Renato,

Mar 22 2017, 5:02 AM

Mar 21 2017

sanwou01 created D31197: [ARM] Add a driver option for +no-neg-immediates.
Mar 21 2017, 11:08 AM
sanwou01 committed rL298380: [ARM] [Assembler] Support negative immediates for A32, T32 and T16.
[ARM] [Assembler] Support negative immediates for A32, T32 and T16
Mar 21 2017, 8:11 AM
sanwou01 closed D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16 by committing rL298380: [ARM] [Assembler] Support negative immediates for A32, T32 and T16.
Mar 21 2017, 8:11 AM

Mar 10 2017

sanwou01 committed rL297454: [Assembler] Add location info to unary expressions..
[Assembler] Add location info to unary expressions.
Mar 10 2017, 5:20 AM
sanwou01 closed D30581: [Assembler] Add location info to unary expressions. by committing rL297454: [Assembler] Add location info to unary expressions..
Mar 10 2017, 5:20 AM
sanwou01 added a reviewer for D30581: [Assembler] Add location info to unary expressions.: olista01.

ping

Mar 10 2017, 3:23 AM

Mar 8 2017

sanwou01 added a comment to D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.

Hi Renato,

Mar 8 2017, 7:35 AM
sanwou01 added a comment to D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.

Hi Javed,

Mar 8 2017, 4:29 AM
sanwou01 retitled D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16 from [ARM] [Assembler] Extend implicit substitutions to [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.
Mar 8 2017, 4:15 AM
sanwou01 updated the diff for D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.

Update in response to reviewer comments.

Mar 8 2017, 4:12 AM

Mar 3 2017

sanwou01 created D30581: [Assembler] Add location info to unary expressions..
Mar 3 2017, 8:42 AM
sanwou01 created D30571: [ARM] [Assembler] Extend immediate conversions for A32, T32 and T16.
Mar 3 2017, 5:47 AM

Feb 28 2017

sanwou01 committed rL296465: [Assembler] Add test for !srcloc references in assembler diags.
[Assembler] Add test for !srcloc references in assembler diags
Feb 28 2017, 2:46 AM
sanwou01 closed D30167: [Assembler] Add test for !srcloc references in assembler diags by committing rL296465: [Assembler] Add test for !srcloc references in assembler diags.
Feb 28 2017, 2:46 AM

Feb 27 2017

sanwou01 added a comment to D30167: [Assembler] Add test for !srcloc references in assembler diags.

Could I please ask someone to have a look if they have a moment?

Feb 27 2017, 3:23 AM

Feb 21 2017

sanwou01 added inline comments to D30167: [Assembler] Add test for !srcloc references in assembler diags.
Feb 21 2017, 3:30 AM