Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Can you explain why you want to do this? There seems to be some precedent for this as I see ARM and AARCH64 headers in include/Support.
Tools want to use installed version of llvm. With this patch they can easily access it from, for example, /usr/include/llvm/Support/, instead of copying and maintaining it in their source trees manually.
The dump format here randomly breaks because
include/llvm/IR/ModuleSummaryIndexYAML.h says:
LLVM_YAML_IS_SEQUENCE_VECTOR(std::string)
contradicting lib/Support/AMDGPUCodeObjectMetadata.cpp:
LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR(std::string)
this violates the C++ ODR rule. In practice the linker seems to pick the "wrong" specialization for me sometimes producing non-flow output for the Printf: part. Could you fix this? (I tried to do so, but for some reason I don't understand it moves the sizes or offset in some ELF data around in a testcase which I don't fully understand).