Details
- Reviewers
rampitec echristo mehdi_amini arsenm
Diff Detail
Event Timeline
In general, I'd prefer not to use the TargetMachine for this. This is already the only point where we use the DataLayout in the TargetMachine and I'd much rather use the values in the module for getting pointer sizes.
Thoughts?
Note that the existing code was unsigned AsmPrinter::getPointerSize() const { return TM.getPointerSize(); }, so it is not introducing necessarily new uses of the TM here.
include/llvm/CodeGen/AsmPrinter.h | ||
---|---|---|
202 ↗ | (On Diff #91516) | I think if you leave out this change, the patch will be *a lot* smaller and easier to review. I'm not against considering this change as a separate patch. |
test/DebugInfo/AMDGPU/variable-locations.ll | ||
---|---|---|
31 | This patch also fixes AMDGPU's code pointer size (see AMDGPUMCAsmInfo.cpp), resulting in this test change. Should AMDGPU's fix remain in this patch or be moved to a separate patch? |
Are all these parameters useful?
why are you using -verify-machineinstrs?