Page MenuHomePhabricator

xiangzhai (Leslie Zhai)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2016, 7:35 PM (196 w, 5 d)

We are hiring OpenJDK and CoreCLR porting

Recent Activity

Aug 18 2020

xiangzhai updated xiangzhai.
Aug 18 2020, 12:09 AM
xiangzhai abandoned D37615: [ELF] Implement the relocations of AVR for LLD.
Aug 18 2020, 12:08 AM

Jun 19 2020

xiangzhai added a comment to D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Do you have commit access?

Jun 19 2020, 9:39 PM · Restricted Project
xiangzhai abandoned D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.
Jun 19 2020, 7:32 PM · Restricted Project

Jun 17 2020

xiangzhai added a comment to D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.

Why not for O32?

Jun 17 2020, 3:12 AM · Restricted Project
xiangzhai abandoned D41653: [RISCV] Initial porting GlobalISel.
Jun 17 2020, 2:40 AM · Restricted Project

Jun 16 2020

xiangzhai added a comment to D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

powerpc's behavior is definitely correct. AArch64 and MIPS's permissive behaviors are not good. A symbolic value (which can be 32-bit/64-bit) requires more bits than the immediate bits. I think flagging the instruction in the case of a symbolic value is fine.

FWIW: I filed a feature request for GNU as: https://sourceware.org/bugzilla/show_bug.cgi?id=26126

Jun 16 2020, 11:57 PM · Restricted Project
xiangzhai updated the diff for D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.

Just workaround as GNU toolchain:

Jun 16 2020, 11:57 PM · Restricted Project
xiangzhai updated the diff for D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.

How about?

    .text
main:
    nop
    daddiu $t9, $ra, main
Jun 16 2020, 6:05 PM · Restricted Project
xiangzhai updated the diff for D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.

Behaviour the same as GNU toolchain:

Jun 16 2020, 6:04 AM · Restricted Project
xiangzhai added a comment to D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Does this patch depend on D81919?

Jun 16 2020, 4:58 AM · Restricted Project
xiangzhai added a comment to D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.
Jun 16 2020, 4:24 AM · Restricted Project
xiangzhai added a comment to D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.
0000000120000a70 <main>:                   
   120000a70:   00000000    nop            
   120000a74:   64840000    daddiu  a0,a0,0 # NOTE: still zero :(
    ...
Jun 16 2020, 3:50 AM · Restricted Project
xiangzhai created D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.
Jun 16 2020, 3:17 AM · Restricted Project

Jun 15 2020

xiangzhai added a reviewer for D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected: MaskRay.
Jun 15 2020, 11:25 PM · Restricted Project

Jun 26 2019

Herald added a project to D31287: [mips] Fix atomic operations at O0, v3: Restricted Project.
Jun 26 2019, 8:19 PM · Restricted Project
xiangzhai awarded D31287: [mips] Fix atomic operations at O0, v3 a Like token.
Jun 26 2019, 8:19 PM · Restricted Project

Apr 13 2019

Herald added a project to D38190: Partial Inlining with multi-region outlining based on PGO information: Restricted Project.
Apr 13 2019, 11:15 PM · Restricted Project
xiangzhai awarded D38190: Partial Inlining with multi-region outlining based on PGO information a Like token.
Apr 13 2019, 11:11 PM · Restricted Project

Sep 27 2018

xiangzhai abandoned D41774: [GlobalISel] Refactory CallLowering handleAssignments for custom <Target>CCState.
Sep 27 2018, 10:47 PM

Sep 3 2018

xiangzhai awarded D49660: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per Value a Like token.
Sep 3 2018, 8:49 PM
xiangzhai awarded D51489: [MIPS GlobalISel] Select icmp a Like token.
Sep 3 2018, 8:42 PM
xiangzhai awarded D43583: [MIPS GlobalISel] Adding GlobalISel a Like token.
Sep 3 2018, 8:39 PM
xiangzhai awarded D51031: [MIPS GlobalISel] Lower i8 and i16 arguments a Like token.
Sep 3 2018, 8:35 PM
xiangzhai awarded D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions a Like token.
Sep 3 2018, 7:34 PM

Aug 12 2018

xiangzhai awarded D50608: [Support][JSON][NFC] Silence GCC warning about broken strict aliasing rules a Like token.
Aug 12 2018, 6:56 PM

May 14 2018

xiangzhai added a comment to D35667: [DragonEgg] Initial migration to GCC v8.x and LLVM v6.x.

Hi Dan'l,

May 14 2018, 6:52 PM

Jan 18 2018

xiangzhai added a comment to D42033: [RISCV] Initial Machine Scheduler.

Hi Alex,

Jan 18 2018, 5:29 AM
xiangzhai added a comment to D41700: [RISCV] Refactory the existing CC_RISCV32 function to conform to the CCAssignFn type.

Hi Alex,

Jan 18 2018, 5:04 AM
xiangzhai added a comment to D41653: [RISCV] Initial porting GlobalISel.

Hi Alex,

Jan 18 2018, 4:30 AM · Restricted Project
xiangzhai added inline comments to D42033: [RISCV] Initial Machine Scheduler.
Jan 18 2018, 3:09 AM
xiangzhai added inline comments to D42033: [RISCV] Initial Machine Scheduler.
Jan 18 2018, 3:06 AM

Jan 16 2018

xiangzhai updated the summary of D41774: [GlobalISel] Refactory CallLowering handleAssignments for custom <Target>CCState.
Jan 16 2018, 9:44 PM

Jan 13 2018

xiangzhai abandoned D33348: Add AVR to LLVM_ALL_TARGETS.
Jan 13 2018, 11:28 PM
xiangzhai created D42033: [RISCV] Initial Machine Scheduler.
Jan 13 2018, 11:25 PM

Jan 11 2018

xiangzhai updated the diff for D41700: [RISCV] Refactory the existing CC_RISCV32 function to conform to the CCAssignFn type.

Hi LLVM developers,

Jan 11 2018, 1:34 AM

Jan 10 2018

xiangzhai updated the diff for D41774: [GlobalISel] Refactory CallLowering handleAssignments for custom <Target>CCState.

Hi LLVM developers,

Jan 10 2018, 7:09 AM

Jan 8 2018

xiangzhai added inline comments to D40805: [RISCV] Support for varargs.
Jan 8 2018, 7:02 PM
xiangzhai added inline comments to D40805: [RISCV] Support for varargs.
Jan 8 2018, 6:01 PM

Jan 5 2018

xiangzhai added inline comments to D41774: [GlobalISel] Refactory CallLowering handleAssignments for custom <Target>CCState.
Jan 5 2018, 5:26 PM
xiangzhai created D41774: [GlobalISel] Refactory CallLowering handleAssignments for custom <Target>CCState.
Jan 5 2018, 9:36 AM

Jan 4 2018

xiangzhai added inline comments to D40805: [RISCV] Support for varargs.
Jan 4 2018, 7:22 PM

Jan 3 2018

xiangzhai added inline comments to D40805: [RISCV] Support for varargs.
Jan 3 2018, 7:35 PM
xiangzhai added a comment to D41700: [RISCV] Refactory the existing CC_RISCV32 function to conform to the CCAssignFn type.

Hi Alex,

Jan 3 2018, 8:29 AM
xiangzhai created D41700: [RISCV] Refactory the existing CC_RISCV32 function to conform to the CCAssignFn type.
Jan 3 2018, 5:03 AM

Dec 31 2017

xiangzhai created D41653: [RISCV] Initial porting GlobalISel.
Dec 31 2017, 9:07 PM · Restricted Project
xiangzhai abandoned D38304: [MCParser] Refactory ParseDirective to add parameter OperandVector &Operands.
Dec 31 2017, 8:22 PM

Dec 21 2017

xiangzhai awarded D39322: [lld] Support RISC-V a Like token.
Dec 21 2017, 4:08 AM · lld

Dec 19 2017

xiangzhai added a comment to D39322: [lld] Support RISC-V.

Hi Chen,

Dec 19 2017, 6:56 PM · lld

Dec 6 2017

xiangzhai committed rL320009: [AVR] Override ParseDirective.
[AVR] Override ParseDirective
Dec 6 2017, 10:56 PM
xiangzhai closed D38029: [AVR] Override ParseDirective by committing rL320009: [AVR] Override ParseDirective.
Dec 6 2017, 10:56 PM

Dec 1 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Dear Dylan,

Dec 1 2017, 10:44 PM

Nov 26 2017

xiangzhai added inline comments to D38029: [AVR] Override ParseDirective.
Nov 26 2017, 7:07 PM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Dear Dylan,

Nov 26 2017, 7:05 PM

Nov 22 2017

xiangzhai committed rL318895: Add backend name to AVR Target to enable runtime info to be fed back into….
Add backend name to AVR Target to enable runtime info to be fed back into…
Nov 22 2017, 8:11 PM

Nov 21 2017

xiangzhai added a comment to D38029: [AVR] Override ParseDirective.

Ping

Nov 21 2017, 3:29 AM

Nov 13 2017

xiangzhai awarded D39977: [llvm-objcopy] Support the rest of the ELF formats a Like token.
Nov 13 2017, 7:27 PM

Nov 12 2017

xiangzhai added a comment to D38029: [AVR] Override ParseDirective.

Nicely ping Dylan :)

Nov 12 2017, 9:43 PM

Nov 11 2017

xiangzhai abandoned D39712: [ARM] Add an alias for psr and psr_nzcvq.
Nov 11 2017, 12:33 AM

Nov 10 2017

xiangzhai updated the diff for D39712: [ARM] Add an alias for psr and psr_nzcvq.

Provided a diagnostic indicating that "xpsr" should be used instead of "psr":

Nov 10 2017, 10:34 PM

Nov 9 2017

xiangzhai added inline comments to D39712: [ARM] Add an alias for psr and psr_nzcvq.
Nov 9 2017, 6:11 PM

Nov 7 2017

xiangzhai updated the diff for D39712: [ARM] Add an alias for psr and psr_nzcvq.

Also add an alias for psr_nzcvq about this usecase.

Nov 7 2017, 7:18 PM
xiangzhai updated the diff for D39712: [ARM] Add an alias for psr and psr_nzcvq.

The same encoding as GNU Arm Embedded Toolchain:

Nov 7 2017, 6:25 PM

Nov 6 2017

xiangzhai created D39712: [ARM] Add an alias for psr and psr_nzcvq.
Nov 6 2017, 7:34 PM

Oct 27 2017

xiangzhai added a comment to D38029: [AVR] Override ParseDirective.

Dear Dylan,

Oct 27 2017, 1:10 AM

Oct 24 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Rebase for rL316076 and nicely Ping Dylan and Matt :)

Oct 24 2017, 8:04 PM
xiangzhai added a comment to D31868: [analyzer] Check NULL pointer dereference issue for memset function.

Dear Henry,

Oct 24 2017, 2:16 AM

Oct 16 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Rebase for rL315531

Oct 16 2017, 10:14 PM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Remove hardcoded macro REFACTORY_PARSEDIRECTIVE.

Oct 16 2017, 7:58 PM

Oct 10 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

$ llvm-mc -filetype=obj -triple=avr-unknown-linux -mcpu=atmega328p relax.s -o avr-relax-llvm.o

Oct 10 2017, 9:49 PM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Refactory EmitValue for AVRMCELFStreamer.

Oct 10 2017, 2:09 AM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Supported .byte lo8(foo) now :)

Oct 10 2017, 12:28 AM

Oct 9 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Dear Dylan,

Oct 9 2017, 9:29 PM
xiangzhai abandoned D35667: [DragonEgg] Initial migration to GCC v8.x and LLVM v6.x.
Oct 9 2017, 7:18 PM

Sep 27 2017

xiangzhai added a comment to D38304: [MCParser] Refactory ParseDirective to add parameter OperandVector &Operands.

Dear Deid,

Sep 27 2017, 10:34 PM
xiangzhai added a comment to D38029: [AVR] Override ParseDirective.

Dear Dylan,

Sep 27 2017, 10:33 PM
xiangzhai abandoned D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple.
Sep 27 2017, 12:22 AM

Sep 26 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Waiting for D38304 about Refactoring ParseDirective.

Sep 26 2017, 8:43 PM
xiangzhai created D38304: [MCParser] Refactory ParseDirective to add parameter OperandVector &Operands.
Sep 26 2017, 8:19 PM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Does it need to Refactory ParseDirective for adding parameter OperandVector Operands to support Modifier?

Sep 26 2017, 3:30 PM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

relocations.s testcase:

...
.short foo
.short gs(foo)
...
Sep 26 2017, 3:29 PM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Change RELOC_NUMBER for AVR Relocation DIFF Types.

Sep 26 2017, 3:29 PM

Sep 25 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.
$ llvm/build/bin/llvm-mc -filetype=obj -triple=avr-unknown-linux -mcpu=atmega328p relocations.s -o avr-llvm-relocations.o
$ avr-readelf -r avr-llvm-relocations.o
Sep 25 2017, 5:03 AM
xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.

Implement Parse R_AVR_LO8_LDI_NEG and other R_AVR_XXX_NEG Expression for GCC compatible.

Sep 25 2017, 5:03 AM

Sep 19 2017

xiangzhai updated the diff for D38029: [AVR] Override ParseDirective.
$ avr-readelf -r avr-relax.o 
Sep 19 2017, 9:13 PM
xiangzhai added a comment to D38029: [AVR] Override ParseDirective.

Dear Dylan,

Sep 19 2017, 2:02 AM
xiangzhai created D38029: [AVR] Override ParseDirective.
Sep 19 2017, 1:52 AM

Sep 13 2017

xiangzhai updated the diff for D37615: [ELF] Implement the relocations of AVR for LLD.

Dear Rui,

Sep 13 2017, 6:56 PM

Sep 12 2017

xiangzhai updated the diff for D37615: [ELF] Implement the relocations of AVR for LLD.

Add testcase for tinyAVR about R_AVR_LDS_STS_16:

Sep 12 2017, 10:42 PM
xiangzhai updated the diff for D37615: [ELF] Implement the relocations of AVR for LLD.

Dear Rui,

Sep 12 2017, 10:12 PM
xiangzhai committed rL313109: [ARC] Prepare the implementation of relocation for LLD.
[ARC] Prepare the implementation of relocation for LLD
Sep 12 2017, 6:51 PM
xiangzhai closed D37556: [ARC] Prepare the implementation of relocation for lld by committing rL313109: [ARC] Prepare the implementation of relocation for LLD.
Sep 12 2017, 6:51 PM
xiangzhai updated the diff for D37615: [ELF] Implement the relocations of AVR for LLD.

Add testcase for R_AVR_LDS_STS_16.

Sep 12 2017, 2:03 AM
xiangzhai updated the diff for D37615: [ELF] Implement the relocations of AVR for LLD.
$ avr-readelf -r basic-avr.o 
Sep 12 2017, 1:46 AM
xiangzhai added inline comments to D37615: [ELF] Implement the relocations of AVR for LLD.
Sep 12 2017, 12:01 AM

Sep 11 2017

xiangzhai updated the diff for D37615: [ELF] Implement the relocations of AVR for LLD.

Dear Dylan,

Sep 11 2017, 11:57 PM
xiangzhai updated the diff for D37556: [ARC] Prepare the implementation of relocation for lld.

Add ARC Specific e_flags.

Sep 11 2017, 7:57 PM
xiangzhai updated the diff for D37615: [ELF] Implement the relocations of AVR for LLD.

Dear Rui,

Sep 11 2017, 2:13 AM

Sep 10 2017

xiangzhai updated the diff for D37556: [ARC] Prepare the implementation of relocation for lld.

Hi Krzysztof,

Sep 10 2017, 7:18 PM

Sep 9 2017

xiangzhai added a comment to D37615: [ELF] Implement the relocations of AVR for LLD.

Dear Rui,

Sep 9 2017, 7:54 PM