This is an archive of the discontinued LLVM Phabricator instance.

[AVR] Migrate to new MCAsmInfo CodePointerSize
ClosedPublic

Authored by xiangzhai on Apr 17 2017, 11:38 PM.

Details

Summary

Hi LLVM developers,

Since Konstantin changed protected member PointerSize of class MCAsmInfo to CodePointerSize in D30879, it broke to build the AVR Target, so I simply migrate to new MCAsmInfo CodePointerSize, please review my patch, thanks a lot!

Regards,
Leslie Zhai

Diff Detail

Repository
rL LLVM

Event Timeline

xiangzhai created this revision.Apr 17 2017, 11:38 PM

Hi Jonathan,

If it looks good to you, I will try to commit by myself for testing commit, thanks!

Regards,
Leslie Zhai

This revision is now accepted and ready to land.Apr 18 2017, 7:20 AM
jroelofs edited edge metadata.Apr 18 2017, 8:00 AM

LGTM, too.

@xiangzhai FWIW, you shouldn't feel bad making commits that fix the build without getting them reviewed first:

  1. You are allowed to commit patches without approval which you think are obvious. This is clearly a subjective decision — we simply expect you to use good judgement. Examples include: fixing build breakage, reverting obviously broken patches, documentation/comment changes, any other minor changes.

http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Hi All,

Still thanks for your review! I will commit tomorrow :)

Regards,
Leslie Zhai

This revision was automatically updated to reflect the committed changes.