Page MenuHomePhabricator

Add LC_BUILD_VERSION load command
ClosedPublic

Authored by steven_wu on Jan 23 2017, 11:38 AM.

Details

Summary

Add a new load command LC_BUILD_VERSION. It is a generic version of
LC_*_VERSION_MIN load_command used on Apple platforms. Instead of having
a seperate load command for each platform, LC_BUILD_VERSION is recording
platform info as an enum. It also records SDK version, min_os, and tools
that used to build the binary.

rdar://problem/29781291

Diff Detail

Repository
rL LLVM

Event Timeline

steven_wu created this revision.Jan 23 2017, 11:38 AM
enderby edited edge metadata.Jan 23 2017, 11:51 AM

Looks good to me.

This revision was automatically updated to reflect the committed changes.

You need to add a llvm/test/tools/llvm-objdump/lit.local.cfg that contains config.suffixes = ['.yaml'], else the .yaml files added in this change won't be run by lit.

You need to add a llvm/test/tools/llvm-objdump/lit.local.cfg that contains config.suffixes = ['.yaml'], else the .yaml files added in this change won't be run by lit.

Good call and this test is actually broken already. There are 2 other tests in the category. Fix in r365519.