enderby (Kevin Enderby)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2015, 11:43 AM (134 w, 6 d)

Recent Activity

Mar 29 2018

enderby committed rL328824: Try to fix sanitizer-x86_64-linux-fast bot due to change in r328820..
Try to fix sanitizer-x86_64-linux-fast bot due to change in r328820.
Mar 29 2018, 1:52 PM
enderby committed rL328820: For llvm-nm and Mach-O files that are fully stripped, special case a redacted….
For llvm-nm and Mach-O files that are fully stripped, special case a redacted…
Mar 29 2018, 1:07 PM

Mar 22 2018

enderby committed rL328274: For llvm-nm and Mach-O files also use function starts info in some.
For llvm-nm and Mach-O files also use function starts info in some
Mar 22 2018, 5:02 PM

Mar 20 2018

enderby committed rL328037: For llvm-objdump and Mach-O files, fix the printing of module init and.
For llvm-objdump and Mach-O files, fix the printing of module init and
Mar 20 2018, 1:34 PM

Mar 8 2018

enderby committed rL327077: For llvm-objdump and Mach-O files, update the printing of some thread states.
For llvm-objdump and Mach-O files, update the printing of some thread states
Mar 8 2018, 3:13 PM

Feb 13 2018

enderby accepted D43003: Refactor DisassembleInfo in MachODump.cpp.

Sure, fine rearrangement of the deck chairs. Looks more C++ like.

Feb 13 2018, 10:48 AM

Feb 9 2018

enderby committed rL324767: llvm-objdump when printing the Objective-C meta data also prints the Swift ABI.
llvm-objdump when printing the Objective-C meta data also prints the Swift ABI
Feb 9 2018, 11:35 AM

Jan 30 2018

enderby committed rL323836: llvm-nm should show a symbol type of T for symbols in the (__TEXT_EXEC,__text)….
llvm-nm should show a symbol type of T for symbols in the (__TEXT_EXEC,__text)…
Jan 30 2018, 4:04 PM

Jan 3 2018

enderby accepted D41657: Do not look up symbol names when n_strx == 0.

Looks good to me with the update of the one comment.

Jan 3 2018, 2:34 PM

Dec 13 2017

enderby accepted D41199: Updated llvm-objdump to display local relocations in Mach-O binaries.

Once again looks good to me. Thanks for working through the build bot issues.

Dec 13 2017, 1:58 PM

Dec 12 2017

enderby added a comment to D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.

Looks good to me Mike!

Dec 12 2017, 10:38 AM

Dec 11 2017

enderby added inline comments to D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.
Dec 11 2017, 10:28 AM

Dec 7 2017

enderby accepted D40867: Updated llvm-objdump to display local relocations in Mach-O binaries.

Looks good to me. Thanks for the changes Mike!

Dec 7 2017, 10:02 AM

Nov 3 2017

enderby committed rL317373: Fix a crash in llvm-objdump when printing a bad x86_64 relocation in a Mach-O.
Fix a crash in llvm-objdump when printing a bad x86_64 relocation in a Mach-O
Nov 3 2017, 2:33 PM

Sep 21 2017

enderby committed rL313921: Fix a bug in llvm-objdump when disassembling using the wrong default CPU.
Fix a bug in llvm-objdump when disassembling using the wrong default CPU
Sep 21 2017, 2:46 PM

Sep 13 2017

enderby committed rL313193: Fix a crash in llvm-nm for a bad Mach-O file that has an N_SECT type symbol and….
Fix a crash in llvm-nm for a bad Mach-O file that has an N_SECT type symbol and…
Sep 13 2017, 2:03 PM

Jul 24 2017

enderby committed rL308924: Small tweak to one check in error handling to the dyld compact export.
Small tweak to one check in error handling to the dyld compact export
Jul 24 2017, 1:34 PM

Jul 20 2017

enderby committed rL308691: lld matching change for llvm change r308690 to add error handling to.
lld matching change for llvm change r308690 to add error handling to
Jul 20 2017, 4:12 PM
enderby committed rL308690: Add error handling to the dyld compact export entries in libObject..
Add error handling to the dyld compact export entries in libObject.
Jul 20 2017, 4:09 PM

Jun 22 2017

enderby committed rL306046: Updated llvm-objdump for arm64 Mach-O MH_KEXT_BUNDLE file types so.
Updated llvm-objdump for arm64 Mach-O MH_KEXT_BUNDLE file types so
Jun 22 2017, 12:51 PM
enderby committed rL306037: Updated llvm-objdump symbolic disassembly with x86_64 Mach-O MH_KEXT_BUNDLE.
Updated llvm-objdump symbolic disassembly with x86_64 Mach-O MH_KEXT_BUNDLE
Jun 22 2017, 10:42 AM

Jun 20 2017

enderby committed rL305866: Updated llvm-objdump with Mach-O files and the -objc-meta-data option so.
Updated llvm-objdump with Mach-O files and the -objc-meta-data option so
Jun 20 2017, 3:56 PM
enderby committed rL305849: Change llvm-objdump with Mach-O files and the -info-plist option with the.
Change llvm-objdump with Mach-O files and the -info-plist option with the
Jun 20 2017, 2:01 PM

Jun 19 2017

enderby committed rL305762: The change to llvm-nm in r305733 added fields to the struct NMSymbol .
The change to llvm-nm in r305733 added fields to the struct NMSymbol
Jun 19 2017, 5:41 PM
enderby committed rL305747: Fix lld test that was causing llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast.
Fix lld test that was causing llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
Jun 19 2017, 2:49 PM
enderby committed rL305744: Fix a FIXME in llvm-objdump for the -exports-trie option that was not adding.
Fix a FIXME in llvm-objdump for the -exports-trie option that was not adding
Jun 19 2017, 2:23 PM
enderby committed rL305733: Change llvm-nm for Mach-O files to use dyld info in some cases when printing….
Change llvm-nm for Mach-O files to use dyld info in some cases when printing…
Jun 19 2017, 12:39 PM

Mar 27 2017

enderby committed rL298883: Add the error handling for Mach-O dyld compact lazy bind, weak bind and.
Add the error handling for Mach-O dyld compact lazy bind, weak bind and
Mar 27 2017, 1:21 PM

Mar 20 2017

enderby committed rL298292: Add the rest of the error checking for Mach-O dyld compact bind entry errors.
Add the rest of the error checking for Mach-O dyld compact bind entry errors
Mar 20 2017, 12:59 PM

Feb 28 2017

enderby committed rL296527: Actually add error handling to unpacking the dyld compact bind and.
Actually add error handling to unpacking the dyld compact bind and
Feb 28 2017, 1:59 PM

Feb 10 2017

enderby committed rL294771: Yet another fix llvm-objdump so it picks a good CPU based for Mach-O files,.
Yet another fix llvm-objdump so it picks a good CPU based for Mach-O files,
Feb 10 2017, 11:38 AM

Feb 9 2017

enderby committed rL294599: Tweak the implementation of llvm-objdump’s -objc-meta-data option so.
Tweak the implementation of llvm-objdump’s -objc-meta-data option so
Feb 9 2017, 10:08 AM

Feb 7 2017

enderby committed rL294354: Fix a typo in an error message for a check of invalid Mach-O files where.
Fix a typo in an error message for a check of invalid Mach-O files where
Feb 7 2017, 1:32 PM

Feb 6 2017

enderby committed rL294236: Fix a bug in llvm-obdump(1) with the -macho and -info-plist options.
Fix a bug in llvm-obdump(1) with the -macho and -info-plist options
Feb 6 2017, 1:12 PM
enderby committed rL294212: Fix a bug in llvm-obdump(1) with the -macho and -disassemble options.
Fix a bug in llvm-obdump(1) with the -macho and -disassemble options
Feb 6 2017, 10:54 AM

Feb 3 2017

enderby committed rL294021: Fix a bug in llvm-obdump(1) with the -objc-meta-data flag with -macho.
Fix a bug in llvm-obdump(1) with the -objc-meta-data flag with -macho
Feb 3 2017, 10:33 AM

Jan 31 2017

enderby committed rL293662: Fix a bug in llvm-obdump(1) with the -macho flag disassembling an object.
Fix a bug in llvm-obdump(1) with the -macho flag disassembling an object
Jan 31 2017, 10:20 AM

Jan 30 2017

enderby committed rL293547: Change the llvm-obdump(1) behavior with the -macho flag and inappropriate file….
Change the llvm-obdump(1) behavior with the -macho flag and inappropriate file…
Jan 30 2017, 1:04 PM

Jan 25 2017

enderby committed rL293114: Change the test added in r293099 so it does not have the string "llvm-nm" to fix.
Change the test added in r293099 so it does not have the string "llvm-nm" to fix
Jan 25 2017, 4:08 PM
enderby committed rL293099: Add a warning when the llvm-nm -print-size flag is used on a Mach-O file as.
Add a warning when the llvm-nm -print-size flag is used on a Mach-O file as
Jan 25 2017, 1:44 PM

Jan 24 2017

enderby committed rL292993: Fix llvm-objdump so it picks a good CPU based for Mach-O files.
Fix llvm-objdump so it picks a good CPU based for Mach-O files
Jan 24 2017, 3:52 PM

Jan 23 2017

enderby committed rL292829: Add support for the x86_thread_state32_t and.
Add support for the x86_thread_state32_t and
Jan 23 2017, 1:24 PM
enderby added a comment to D29044: Add LC_BUILD_VERSION load command.

Looks good to me.

Jan 23 2017, 11:51 AM

Jan 19 2017

enderby committed rL292501: Remove this test from the r292500 commit till Chris and I figure out.
Remove this test from the r292500 commit till Chris and I figure out
Jan 19 2017, 10:18 AM
enderby committed rL292500: Add support for the new LC_NOTE load command..
Add support for the new LC_NOTE load command.
Jan 19 2017, 9:47 AM

Dec 16 2016

enderby committed rL290001: Fix a bugs with using some Mach-O command line flags like "-arch armv7m"..
Fix a bugs with using some Mach-O command line flags like "-arch armv7m".
Dec 16 2016, 3:04 PM

Dec 15 2016

enderby added a comment to D26079: Do not use CppHashInfo if reporting an error after asm file parsed.

Seem like a step forward. The initial implementation for the search backwards in SourceMgr::FindCppHashLoc() is not great but I suspect it will work well enough.

Dec 15 2016, 10:06 AM

Dec 1 2016

enderby committed rL288402: Fix a bug with llvm-size and the -m option with multiple files not printing the….
Fix a bug with llvm-size and the -m option with multiple files not printing the…
Dec 1 2016, 11:23 AM

Nov 29 2016

enderby committed rL288199: Add to llvm-objdump the -no-leading-headers option with the use of the -macho….
Add to llvm-objdump the -no-leading-headers option with the use of the -macho…
Nov 29 2016, 1:53 PM
enderby added a comment to D27182: [MachO] Add UnknownValueErrors and ability to ignore them..

Do you plan to add any test cases at this time where IgnoreValueErrs is true? Or is that to be left to be done later in a future step?

Nov 29 2016, 10:53 AM

Nov 28 2016

enderby added inline comments to D27182: [MachO] Add UnknownValueErrors and ability to ignore them..
Nov 28 2016, 6:38 PM
enderby committed rL288084: Add error checking for Mach-O universal files..
Add error checking for Mach-O universal files.
Nov 28 2016, 2:51 PM

Nov 16 2016

enderby committed rL287163: General clean up of error handling in llvm-objdump to remove its use of….
General clean up of error handling in llvm-objdump to remove its use of…
Nov 16 2016, 2:27 PM

Nov 15 2016

enderby committed rL287050: General clean up of Mach-O error handling in llvm-objdump..
General clean up of Mach-O error handling in llvm-objdump.
Nov 15 2016, 3:17 PM

Nov 14 2016

enderby committed rL286887: Add a checkSymbolTable() method to the MachOObjectFile class..
Add a checkSymbolTable() method to the MachOObjectFile class.
Nov 14 2016, 1:06 PM

Nov 3 2016

enderby committed rL285967: Add support for the ARM_THREAD_STATE64 and.
Add support for the ARM_THREAD_STATE64 and
Nov 3 2016, 2:01 PM

Nov 2 2016

enderby committed rL285860: Add the rest of the additional error checks for invalid Mach-O files when.
Add the rest of the additional error checks for invalid Mach-O files when
Nov 2 2016, 2:18 PM

Oct 31 2016

enderby committed rL285632: More additional error checks for invalid Mach-O files when.
More additional error checks for invalid Mach-O files when
Oct 31 2016, 1:39 PM

Oct 27 2016

enderby committed rL285342: Another additional error check for invalid Mach-O files for the.
Another additional error check for invalid Mach-O files for the
Oct 27 2016, 2:08 PM

Oct 24 2016

enderby committed rL285026: nother additional error check for an invalid Mach-O file.
nother additional error check for an invalid Mach-O file
Oct 24 2016, 2:24 PM

Oct 21 2016

enderby committed rL284867: Fix a bug in the code of llvm-cxxdump in dumpArchive() when.
Fix a bug in the code of llvm-cxxdump in dumpArchive() when
Oct 21 2016, 1:12 PM
enderby committed rL284852: For llvm-objdump for Mach-O files add printing of.
For llvm-objdump for Mach-O files add printing of
Oct 21 2016, 11:31 AM

Oct 20 2016

enderby committed rL284769: Another additional error check for invalid Mach-O files for the.
Another additional error check for invalid Mach-O files for the
Oct 20 2016, 1:19 PM

Oct 19 2016

enderby committed rL284668: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Oct 19 2016, 4:53 PM

Oct 18 2016

enderby committed rL284529: One more additional error check for invalid Mach-O files for a.
One more additional error check for invalid Mach-O files for a
Oct 18 2016, 1:33 PM
enderby committed rL284504: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Oct 18 2016, 11:03 AM

Oct 17 2016

enderby committed rL284431: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Oct 17 2016, 3:18 PM

Oct 11 2016

enderby committed rL283939: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Oct 11 2016, 2:13 PM

Oct 4 2016

enderby committed rL283250: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Oct 4 2016, 1:46 PM

Sep 29 2016

enderby committed rL282766: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Sep 29 2016, 9:12 PM
enderby committed rL282736: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Sep 29 2016, 9:10 PM

Sep 28 2016

enderby committed rL282649: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Sep 28 2016, 4:24 PM
enderby committed rL282635: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Sep 28 2016, 2:29 PM

Sep 27 2016

enderby committed rL282553: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Sep 27 2016, 4:33 PM

Sep 26 2016

enderby committed rL282441: Next set of additional error checks for invalid Mach-O files for the.
Next set of additional error checks for invalid Mach-O files for the
Sep 26 2016, 2:20 PM

Sep 21 2016

enderby committed rL282104: Next set of additional error checks for invalid Mach-O files for bad LC_UUID.
Next set of additional error checks for invalid Mach-O files for bad LC_UUID
Sep 21 2016, 1:12 PM

Sep 20 2016

enderby committed rL282008: Next set of additional error checks for invalid Mach-O files for bad load….
Next set of additional error checks for invalid Mach-O files for bad load…
Sep 20 2016, 1:23 PM

Sep 13 2016

enderby committed rL281400: Next set of additional error checks for invalid Mach-O files for bad load….
Next set of additional error checks for invalid Mach-O files for bad load…
Sep 13 2016, 2:51 PM

Aug 31 2016

enderby committed rL280267: Next set of additional error checks for invalid Mach-O files for bad load….
Next set of additional error checks for invalid Mach-O files for bad load…
Aug 31 2016, 11:06 AM

Aug 30 2016

enderby committed rL280167: Add a test file, macho-invalid-dysymtab-extreloff-nextrel,.
Add a test file, macho-invalid-dysymtab-extreloff-nextrel,
Aug 30 2016, 2:56 PM
enderby committed rL280161: Next set of additional error checks for invalid Mach-O files for bad….
Next set of additional error checks for invalid Mach-O files for bad…
Aug 30 2016, 2:37 PM

Aug 26 2016

enderby committed rL279854: Next set of additional error checks for invalid Mach-O files for bad….
Next set of additional error checks for invalid Mach-O files for bad…
Aug 26 2016, 12:42 PM

Aug 12 2016

enderby committed rL278557: Next set of additional error checks for invalid Mach-O files..
Next set of additional error checks for invalid Mach-O files.
Aug 12 2016, 1:18 PM

Aug 5 2016

enderby committed rL277845: Add the first of what will be a long line of additional error checks for….
Add the first of what will be a long line of additional error checks for…
Aug 5 2016, 11:27 AM

Aug 4 2016

enderby committed rL277776: Clean up the logic of the Archive::Child::Child() with an assert to know Err….
Clean up the logic of the Archive::Child::Child() with an assert to know Err…
Aug 4 2016, 3:02 PM

Aug 3 2016

enderby committed rL277657: Needed change to lld for the changes to libObject/Archive interfaces now….
Needed change to lld for the changes to libObject/Archive interfaces now…
Aug 3 2016, 3:06 PM
enderby committed rL277656: Clean up of libObject/Archive interfaces and change the last three uses of….
Clean up of libObject/Archive interfaces and change the last three uses of…
Aug 3 2016, 3:05 PM

Aug 2 2016

enderby committed rL277540: More fixes to get good error messages for bad archives..
More fixes to get good error messages for bad archives.
Aug 2 2016, 4:06 PM

Jul 29 2016

enderby committed rL277223: Think this will fix issues with the error messages generated for malformed….
Think this will fix issues with the error messages generated for malformed…
Jul 29 2016, 3:39 PM
enderby committed rL277196: Remove the test/tools/llvm-objdump/malformed-archives.test for.
Remove the test/tools/llvm-objdump/malformed-archives.test for
Jul 29 2016, 11:54 AM
enderby committed rL277183: Matching change needed to lld for llvm trunk change r277177..
Matching change needed to lld for llvm trunk change r277177.
Jul 29 2016, 11:03 AM
enderby committed rL277177: The next step along the way to getting good error messages for bad archives..
The next step along the way to getting good error messages for bad archives.
Jul 29 2016, 10:52 AM

Jul 25 2016

enderby committed rL276686: Next step along the way to getting good error messages for bad archives..
Next step along the way to getting good error messages for bad archives.
Jul 25 2016, 1:44 PM

Jul 19 2016

enderby committed rL276025: Next step along the way to getting good error messages for bad archives..
Next step along the way to getting good error messages for bad archives.
Jul 19 2016, 1:54 PM

Jul 7 2016

enderby committed rL274798: Add checks to the MachOObjectFile() constructor to make sure load commands sizes.
Add checks to the MachOObjectFile() constructor to make sure load commands sizes
Jul 7 2016, 3:18 PM

Jun 29 2016

enderby committed rL274161: Matching change for lld for the llvm change of Archive::create() from….
Matching change for lld for the llvm change of Archive::create() from…
Jun 29 2016, 1:43 PM
enderby committed rL274160: Change Archive::create() from ErrorOr<...> to Expected<...> and update.
Change Archive::create() from ErrorOr<...> to Expected<...> and update
Jun 29 2016, 1:42 PM

Jun 28 2016

enderby committed rL274079: Finish cleaning up most of the error handling in libObject’s….
Finish cleaning up most of the error handling in libObject’s…
Jun 28 2016, 4:23 PM

Jun 27 2016

enderby committed rL273946: Change all but the last ErrorOr<...> use for MachOUniversalBinary to….
Change all but the last ErrorOr<...> use for MachOUniversalBinary to…
Jun 27 2016, 2:46 PM

Jun 24 2016

enderby committed rL273740: Fix lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp for r273701.
Fix lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp for r273701
Jun 24 2016, 3:45 PM