ki.stfu (Ilia K)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2015, 12:33 AM (140 w, 5 d)

Recent Activity

Thu, Sep 7

ki.stfu accepted D37533: Fix lldb-mi test data_read_memory_bytes_global.

👍

Thu, Sep 7, 6:20 AM

Apr 27 2017

ki.stfu added inline comments to D32340: [LLDB][MIPS] Fix TestMiExec.py failure.
Apr 27 2017, 4:34 AM

Apr 21 2017

ki.stfu requested changes to D32340: [LLDB][MIPS] Fix TestMiExec.py failure.

Thanks for catching this! Could you update this CL to let me commit it?

Apr 21 2017, 3:14 AM

Apr 4 2017

ki.stfu committed rL299417: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var….
Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var…
Apr 4 2017, 1:13 AM
ki.stfu closed D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope.
Apr 4 2017, 12:50 AM · Restricted Project
ki.stfu updated the summary of D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope.
Apr 4 2017, 12:47 AM · Restricted Project

Mar 29 2017

ki.stfu accepted D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope.

Would you like me to commit it?

Mar 29 2017, 8:10 AM · Restricted Project

Mar 28 2017

ki.stfu requested changes to D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope.

LGTM. Just fix a few minor issues before committing.

Mar 28 2017, 11:28 PM · Restricted Project

Feb 3 2017

ki.stfu accepted D29513: Add -gdb-set and -gdb-show support for non-stop to lldb-mi.

lgtm

Feb 3 2017, 10:54 PM

Jan 31 2017

ki.stfu added a comment to D29256: Do not pass non-POD type variables through variadic function.

@ki.stfu do you still agree with this patch?

Jan 31 2017, 11:13 PM · Restricted Project

Jan 30 2017

ki.stfu added a comment to D29256: Do not pass non-POD type variables through variadic function.

It's undefined (implementation defined) behavior.

C++11 5.2.2/7:
Passing a potentially-evaluated argument of class type having a non-trivial copy constructor, a non-trivial move contructor, or a non-trivial destructor, with no corresponding parameter, is conditionally-supported with implementation-defined semantics.
Jan 30 2017, 3:06 AM · Restricted Project

Jan 29 2017

ki.stfu accepted D29256: Do not pass non-POD type variables through variadic function.

I don't know the point of this patch (probably it's something special for NetBSD? @emaste) but I'm okay with that.

Jan 29 2017, 9:39 PM · Restricted Project

Jan 6 2017

ki.stfu added a comment to D24711: [lldb-mi] Fix implementation for a few mi commands.

lgtm

Jan 6 2017, 4:24 AM · Restricted Project

Nov 27 2016

ki.stfu requested changes to D26124: [LLDB-MI] Escape MI output in a more consistent manner.

@enlight , thanks for giving a chance to review it, and sorry that it took to long from my side.

Nov 27 2016, 5:58 AM

Oct 14 2016

ki.stfu accepted D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 14 2016, 2:19 AM
ki.stfu requested changes to D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 14 2016, 1:53 AM
ki.stfu accepted D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 14 2016, 1:47 AM

Oct 13 2016

ki.stfu requested changes to D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 13 2016, 10:54 PM

Oct 11 2016

ki.stfu added inline comments to D25486: Fix lookup path for lldb-mi.
Oct 11 2016, 11:51 PM

Sep 21 2016

ki.stfu committed rL282135: Fix parsing expressions to evaluate with spaces and optional args (MI).
Fix parsing expressions to evaluate with spaces and optional args (MI)
Sep 21 2016, 10:17 PM
ki.stfu closed D24202: Fix parsing expressions to evaluate with spaces and optional args (MI) by committing rL282135: Fix parsing expressions to evaluate with spaces and optional args (MI).
Sep 21 2016, 10:17 PM · Restricted Project
ki.stfu added a reviewer for D24202: Fix parsing expressions to evaluate with spaces and optional args (MI): ki.stfu.
Sep 21 2016, 10:16 PM · Restricted Project
ki.stfu added inline comments to D24202: Fix parsing expressions to evaluate with spaces and optional args (MI).
Sep 21 2016, 10:13 PM · Restricted Project
ki.stfu updated the diff for D24202: Fix parsing expressions to evaluate with spaces and optional args (MI).

Rebase againt ToT; Apply clang-format & autopep; Minor fix in condition

Sep 21 2016, 10:12 PM · Restricted Project
ki.stfu retitled D24202: Fix parsing expressions to evaluate with spaces and optional args (MI) from [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args to Fix parsing expressions to evaluate with spaces and optional args (MI).
Sep 21 2016, 10:08 PM · Restricted Project
ki.stfu commandeered D24202: Fix parsing expressions to evaluate with spaces and optional args (MI).
Sep 21 2016, 10:07 PM · Restricted Project
ki.stfu added a reviewer for D24711: [lldb-mi] Fix implementation for a few mi commands: abidh.
Sep 21 2016, 9:55 PM · Restricted Project

Sep 20 2016

ki.stfu added a comment to D24711: [lldb-mi] Fix implementation for a few mi commands.

yes

Sep 20 2016, 1:17 AM · Restricted Project

Sep 18 2016

ki.stfu requested changes to D24711: [lldb-mi] Fix implementation for a few mi commands.

Hi! Please add tests for commands that you fixed. I'll take a look later this week.

Sep 18 2016, 8:57 PM · Restricted Project

Sep 12 2016

ki.stfu accepted D23883: Remove MIUtilParse (no longer used).

lgtm

Sep 12 2016, 11:50 AM
ki.stfu committed rL281199: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI).
Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)
Sep 12 2016, 12:23 AM
ki.stfu closed D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI) by committing rL281199: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI).
Sep 12 2016, 12:23 AM
ki.stfu updated the diff for D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI).

Rebase against ToT; Apply autopep8

Sep 12 2016, 12:12 AM

Sep 11 2016

ki.stfu updated the diff for D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI).

Rebase against ToT

Sep 11 2016, 11:53 PM
ki.stfu accepted D24202: Fix parsing expressions to evaluate with spaces and optional args (MI).

@edmunoz, good job. Thank you! Would you like me to commit?

Sep 11 2016, 11:35 PM · Restricted Project
ki.stfu added a comment to D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag.

PS: I think it will look like:

Index: tools/lldb-mi/MICmdCmdBreak.cpp
===================================================================
--- tools/lldb-mi/MICmdCmdBreak.cpp	(revision 281191)
+++ tools/lldb-mi/MICmdCmdBreak.cpp	(working copy)
@@ -84,8 +84,7 @@
   // Not implemented m_setCmdArgs.Add(new CMICmdArgValOptionShort(
   // m_constStrArgNamedHWBrkPt, false, false));
   m_setCmdArgs.Add(new CMICmdArgValOptionShort(
-      m_constStrArgNamedPendinfBrkPt, false, true,
-      CMICmdArgValListBase::eArgValType_StringQuotedNumberPath, 1));
+      m_constStrArgNamedPendinfBrkPt, false, true));
   m_setCmdArgs.Add(new CMICmdArgValOptionShort(m_constStrArgNamedDisableBrkPt,
                                                false, false));
   // Not implemented m_setCmdArgs.Add(new CMICmdArgValOptionShort(
@@ -99,7 +98,7 @@
   m_setCmdArgs.Add(new CMICmdArgValOptionShort(
       m_constStrArgNamedRestrictBrkPtToThreadId, false, true,
       CMICmdArgValListBase::eArgValType_Number, 1));
-  m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgNamedLocation, false,
+  m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgNamedLocation, true,
                                           true, false, false, true));
   return ParseValidateCmdOptions();
 }
@@ -158,12 +157,7 @@
     m_strArgOptionThreadGrp = CMIUtilString::Format("i%d", nThreadGrp);
   }
   m_bBrkPtIsPending = pArgPendingBrkPt->GetFound();
-  if (pArgLocation->GetFound())
-    m_brkName = pArgLocation->GetValue();
-  else if (m_bBrkPtIsPending) {
-    pArgPendingBrkPt->GetExpectedOption<CMICmdArgValString, CMIUtilString>(
-        m_brkName);
-  }
+  m_brkName = pArgLocation->GetValue();
   if (pArgIgnoreCnt->GetFound()) {
     pArgIgnoreCnt->GetExpectedOption<CMICmdArgValNumber, MIuint>(
         m_nBrkPtIgnoreCount);
Sep 11 2016, 11:17 PM · Restricted Project
ki.stfu requested changes to D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag.

I'm sorry for the delay, have a lot of work. Please folllow my inline comments, rebase against ToT and update CL's summary.

Sep 11 2016, 11:16 PM · Restricted Project
ki.stfu requested changes to D23883: Remove MIUtilParse (no longer used).

You forgot to remove its header file

Sep 11 2016, 10:37 PM
ki.stfu committed rL281191: Fix about a dozen compile warnings.
Fix about a dozen compile warnings
Sep 11 2016, 10:34 PM
ki.stfu closed D24331: Fix about a dozen compile warnings.
Sep 11 2016, 10:34 PM
ki.stfu updated the diff for D24331: Fix about a dozen compile warnings.

Apply clang-format

Sep 11 2016, 10:32 PM
ki.stfu updated the diff for D24331: Fix about a dozen compile warnings.

Rebase against ToT

Sep 11 2016, 10:29 PM

Sep 8 2016

ki.stfu added a reviewer for D24331: Fix about a dozen compile warnings: emaste.
Sep 8 2016, 12:06 PM
ki.stfu added inline comments to D24331: Fix about a dozen compile warnings.
Sep 8 2016, 1:05 AM
ki.stfu updated the diff for D24331: Fix about a dozen compile warnings.

Fixes per Zachary's comments

Sep 8 2016, 1:04 AM
ki.stfu updated the diff for D24331: Fix about a dozen compile warnings.

Apply clang-format

Sep 8 2016, 12:05 AM
ki.stfu updated the diff for D24331: Fix about a dozen compile warnings.

Remove obvious comment

Sep 8 2016, 12:04 AM

Sep 7 2016

ki.stfu added a comment to D24331: Fix about a dozen compile warnings.

BTW, the following warnings remain:

Sep 7 2016, 11:59 PM
ki.stfu retitled D24331: Fix about a dozen compile warnings from to Fix about a dozen compile warnings.
Sep 7 2016, 11:47 PM

Aug 29 2016

ki.stfu accepted D23882: Replace uses of MIUtilParse::CRegexParser with llvm::Regex.

lgtm if tests are passed

Aug 29 2016, 4:05 AM

Aug 2 2016

ki.stfu added a comment to D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag.

Yes, that's what I said. We have to throw an error if location is not passed (even if -f is specified).

Aug 2 2016, 11:44 PM · Restricted Project

Aug 1 2016

ki.stfu requested changes to D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag.
Aug 1 2016, 10:03 PM · Restricted Project
ki.stfu added a comment to D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag.

So, what you want is to create pending breakpoints without locations?

Aug 1 2016, 10:03 PM · Restricted Project

Jul 28 2016

ki.stfu committed rL277117: Fix -break-insert not working when using absolute paths (MI).
Fix -break-insert not working when using absolute paths (MI)
Jul 28 2016, 11:09 PM
ki.stfu closed D22902: Fix -break-insert not working when using absolute paths by committing rL277117: Fix -break-insert not working when using absolute paths (MI).
Jul 28 2016, 11:09 PM
ki.stfu accepted D22902: Fix -break-insert not working when using absolute paths.

No. I'm going to land it right now! Thanks!

Jul 28 2016, 11:06 PM

Jul 27 2016

ki.stfu added a comment to D22902: Fix -break-insert not working when using absolute paths.

Could you add a test case for this in packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py?

Jul 27 2016, 11:05 PM

Jul 14 2016

ki.stfu committed rL275381: Fix -break-enable/-break-disable commands (MI).
Fix -break-enable/-break-disable commands (MI)
Jul 14 2016, 12:50 AM
ki.stfu closed D21757: Fix lldb-mi disable/enable breakpoints commands by committing rL275381: Fix -break-enable/-break-disable commands (MI).
Jul 14 2016, 12:50 AM
ki.stfu updated the diff for D21757: Fix lldb-mi disable/enable breakpoints commands.

add checks for =breakpoint-modified

Jul 14 2016, 12:28 AM
ki.stfu accepted D21757: Fix lldb-mi disable/enable breakpoints commands.

@faxue, thank you for your patch! The fixes look good, but if you don't mind I gonna improve your tests. After that I'll commit this patch.

Jul 14 2016, 12:24 AM

Jul 13 2016

ki.stfu added a comment to D21757: Fix lldb-mi disable/enable breakpoints commands.

Hi Chuck! Sorry for delay, didn't see this CL. I'll check it tomorrow, so pls wait one more day.

Jul 13 2016, 6:37 AM

Feb 3 2016

ki.stfu accepted D16728: [lldb-mi] print real error message in "-data-evaluate-expression".
Feb 3 2016, 9:37 PM

Dec 17 2015

ki.stfu added inline comments to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..
Dec 17 2015, 1:01 PM
ki.stfu added inline comments to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..
Dec 17 2015, 12:28 PM
ki.stfu added inline comments to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..
Dec 17 2015, 5:11 AM
ki.stfu requested changes to D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines..

clang-format your changes please (there are many deviations from the coding style)

Dec 17 2015, 5:04 AM

Dec 2 2015

ki.stfu accepted D15168: Allow variable names to be quoted with -var-list-children.

lgtm

Dec 2 2015, 10:18 PM

Nov 2 2015

ki.stfu added inline comments to D14197: Handle the options and parameters separator in every MI command.
Nov 2 2015, 5:23 AM
ki.stfu accepted D14197: Handle the options and parameters separator in every MI command.

lgtm

Nov 2 2015, 3:02 AM

Nov 1 2015

ki.stfu requested changes to D14197: Handle the options and parameters separator in every MI command.
Nov 1 2015, 11:11 PM

Oct 29 2015

ki.stfu accepted D14177: Better handle the arguments common to all MI commands..

LGTM

Oct 29 2015, 9:07 AM
ki.stfu added inline comments to D14177: Better handle the arguments common to all MI commands..
Oct 29 2015, 8:16 AM

Oct 26 2015

ki.stfu accepted D14060: Deprecate -m/+m dotest options in favor of test categories.

lgtm

Oct 26 2015, 4:09 AM

Oct 2 2015

ki.stfu added a comment to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.
In D13058#258903, @dawn wrote:

This patch is good to commit now right? It's not marked "accepted" for some reason.

It's not "accepted" because @clayborg rejected this CL and hasn't changed his decision. But I think he will not mind if you go ahead.

Oct 2 2015, 1:25 PM

Sep 30 2015

ki.stfu accepted D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.

lgtm

Sep 30 2015, 10:02 PM

Sep 29 2015

ki.stfu requested changes to D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.
Sep 29 2015, 8:34 AM
ki.stfu added a comment to D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.

Could you make one additional cleanup here please?

Sep 29 2015, 1:21 AM
ki.stfu requested changes to D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.
Sep 29 2015, 1:15 AM
ki.stfu accepted D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.

lgtm apart a lack of description about the changes in tools/lldb-mi/MICmdCmdSupportList.cpp

Sep 29 2015, 12:57 AM

Sep 26 2015

ki.stfu requested changes to D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.

Update the summary + a few inline comments below.

Sep 26 2015, 3:32 AM

Sep 25 2015

ki.stfu added a comment to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

But you still should get lgtm from @clayborg and @granata.enrico before landing.

Sep 25 2015, 11:32 PM
ki.stfu accepted D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

lgtm

Sep 25 2015, 11:25 PM
ki.stfu added inline comments to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.
Sep 25 2015, 1:38 AM
ki.stfu committed rL248566: Allow to construct CMIUtilString using std::string directly + cleanup….
Allow to construct CMIUtilString using std::string directly + cleanup…
Sep 25 2015, 1:30 AM
ki.stfu closed D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI).
Sep 25 2015, 1:30 AM
ki.stfu closed D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI) by committing rL248566: Allow to construct CMIUtilString using std::string directly + cleanup….
Sep 25 2015, 1:30 AM
ki.stfu requested changes to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.
Sep 25 2015, 12:40 AM
ki.stfu added a comment to D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI).

I perceive it as a simple patch, so I am going to go ahead.

Sep 25 2015, 12:32 AM
ki.stfu accepted D13094: LLDB-MI: Fix assignment operator in CMIUtilString.
Sep 25 2015, 12:04 AM

Sep 24 2015

ki.stfu retitled D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI) from Allow to construct CMIUtilString using std::string directly (MI) to Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI).
Sep 24 2015, 11:40 PM
ki.stfu updated the diff for D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI).

A little fix as @brucem requested; Remove CMIUtilString(const char *const *vpData) and CMIUtilString(const char *vpData, size_t nLen) ctors; Cleanup CMIUtilString::operator=(const std::string &vrRhs)

Sep 24 2015, 11:36 PM
ki.stfu added inline comments to D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI).
Sep 24 2015, 11:30 PM
ki.stfu updated D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI).
Sep 24 2015, 11:21 PM
ki.stfu retitled D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI) from to Allow to construct CMIUtilString using std::string directly (MI).
Sep 24 2015, 11:19 PM
ki.stfu accepted D13125: Improve error reporting for failing to find argdumper..
Sep 24 2015, 12:02 AM

Sep 23 2015

ki.stfu requested changes to D13094: LLDB-MI: Fix assignment operator in CMIUtilString.

Your fix in assign operator looks good. Others go out of scope of this CL, so please revert them.

Sep 23 2015, 11:19 PM
ki.stfu requested changes to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

Please, next time make a patch with full context:

svn diff --diff-cmd diff -x "-U9999" > mypatch.txt

This will help us to reduce the review time.

Sep 23 2015, 12:48 AM

Sep 22 2015

ki.stfu added a reviewer for D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped: jingham.

+@jingham for changes in Target.

Sep 22 2015, 10:19 PM
ki.stfu updated subscribers of D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

Please always add lldb-commits to subscribers

Sep 22 2015, 10:34 AM