This required re-working the streaming support and lit's support for
'--gtest_list_tests' but otherwise seems to be a clean upgrade.
Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 2453 Build 2453: arc lint + arc unit
Event Timeline
utils/lit/lit/formats/googletest.py | ||
---|---|---|
46–47 | I realize that this may be somewhat obvious, but please add a comment here explaining that this is stripping comments (i.e. everything starting with the first '#') and, more importantly, noting why we don't need to worry about any escaping mechanism here, '#' inside quotes, etc. | |
utils/unittest/googletest/include/gtest/gtest-message.h | ||
160 | Shouldn't this be: #if GTEST_NO_LLVM_RAW_OSTREAM | |
187–191 | Same here. |
I realize that this may be somewhat obvious, but please add a comment here explaining that this is stripping comments (i.e. everything starting with the first '#') and, more importantly, noting why we don't need to worry about any escaping mechanism here, '#' inside quotes, etc.