This is an archive of the discontinued LLVM Phabricator instance.

[gtest] Upgrade googletest to version 1.8.0, minimizing local changes.
ClosedPublic

Authored by chandlerc on Dec 29 2016, 3:41 AM.

Details

Summary

This required re-working the streaming support and lit's support for
'--gtest_list_tests' but otherwise seems to be a clean upgrade.

Diff Detail

Repository
rL LLVM

Event Timeline

chandlerc updated this revision to Diff 82658.Dec 29 2016, 3:41 AM
chandlerc retitled this revision from to [gtest] Upgrade googletest to version 1.8.0, minimizing local changes..
chandlerc updated this object.
chandlerc added a subscriber: llvm-commits.
chandlerc updated this revision to Diff 82661.Dec 29 2016, 4:13 AM
chandlerc edited edge metadata.

Now with appropriate warning suppression CMake changes.

chandlerc updated this revision to Diff 83033.Jan 4 2017, 5:07 AM
chandlerc edited edge metadata.

Rebase and ping.

Note that this is useful regardless of whether we ever touch gmock.

hfinkel added a subscriber: hfinkel.Jan 4 2017, 5:48 AM
hfinkel added inline comments.
utils/lit/lit/formats/googletest.py
46 ↗(On Diff #83033)

I realize that this may be somewhat obvious, but please add a comment here explaining that this is stripping comments (i.e. everything starting with the first '#') and, more importantly, noting why we don't need to worry about any escaping mechanism here, '#' inside quotes, etc.

utils/unittest/googletest/include/gtest/gtest-message.h
160 ↗(On Diff #83033)

Shouldn't this be:

#if GTEST_NO_LLVM_RAW_OSTREAM
187 ↗(On Diff #83033)

Same here.

chandlerc updated this revision to Diff 83045.Jan 4 2017, 6:21 AM
chandlerc edited edge metadata.

Fix left over hacking code pointed out by Hal.

chandlerc updated this revision to Diff 83046.Jan 4 2017, 6:24 AM
chandlerc edited edge metadata.

Add a comment about what we're doing when processing the test listing.

chandlerc marked 3 inline comments as done.Jan 4 2017, 6:25 AM

All done, thanks!

hfinkel accepted this revision.Jan 4 2017, 6:27 AM
hfinkel added a reviewer: hfinkel.

LGTM

This revision is now accepted and ready to land.Jan 4 2017, 6:27 AM
This revision was automatically updated to reflect the committed changes.