This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add ppc support to update_llc_test_checks.py, and ppc tests. NFC.
ClosedPublic

Authored by timshen on Dec 21 2016, 3:57 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

timshen updated this revision to Diff 82284.Dec 21 2016, 3:57 PM
timshen retitled this revision from to [PowerPC] Add ppc support to update_llc_test_checks.py, and ppc tests. NFC..
timshen added a subscriber: llvm-commits.
chandlerc edited edge metadata.Dec 21 2016, 4:59 PM

This seems fine, but I'd love for Eli to make sure he's happy with how this supports ARM as well. Thanks!

Once Eli is happy, feel free to commit.

llvm/utils/update_llc_test_checks.py
66 ↗(On Diff #82284)

Put the comment on its own line so it doesn't go over 80 columns?

timshen updated this revision to Diff 82294.Dec 21 2016, 5:23 PM
timshen edited edge metadata.

Move a comment to its own line.

timshen marked an inline comment as done.Dec 22 2016, 11:46 AM

(actually add Eli as a reviewer so he has a chance of seeing this)

timshen edited reviewers, added: efriedma; removed: eli.friedman.Dec 22 2016, 11:48 AM
efriedma accepted this revision.Dec 22 2016, 12:15 PM
efriedma edited edge metadata.

I'll probably want to tweak the target_handlers list at some point (we use armv7-* rather than arm-eabi for some tests), but I can fix that up after this is committed.

This revision is now accepted and ready to land.Dec 22 2016, 12:15 PM
This revision was automatically updated to reflect the committed changes.