This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Add plumbing for GlobalISel
ClosedPublic

Authored by rovka on Nov 10 2016, 1:23 AM.

Details

Summary

Add GlobalISel skeleton, up to the point where we can select a ret void.

Diff Detail

Event Timeline

rovka updated this revision to Diff 77455.Nov 10 2016, 1:23 AM
rovka retitled this revision from to [ARM] Add plumbing for GlobalISel.
rovka updated this object.
rovka added subscribers: llvm-commits, rengolin.
rovka updated this revision to Diff 77459.Nov 10 2016, 2:06 AM

Forgot to git add LIT config file...

qcolombet accepted this revision.Nov 10 2016, 3:41 PM
qcolombet edited edge metadata.

Hi,

LGTM.
One comment: Given you've hooked up the full pipeline, you could add a test case for each pass and or a test case from LLVM IR to -stop-after instruction-select (or even down to assembly).
Right now, the testing only covers the IRTranslator.

Cheers,
-Quentin

This revision is now accepted and ready to land.Nov 10 2016, 3:41 PM

Thanks, Quentin. I was planning to add tests for the other parts of the pipeline in the next patch, which will be handling something more interesting than just ret void.

rovka closed this revision.Nov 11 2016, 12:37 AM

r286573