[analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.

[NoQ]

Summary

ASTMatchers are sometimes handy in the Analyzer, and there are more patches to make use of them.

However, it turns out that not only the Analyzer, but also the whole clang binary was never linked to libASTMatchers. So there's a binary size concern.

On my machine (mac) binary size increases by:

• 0.5% (73 731 296 bytes => 74 118 172 bytes) in release mode,
• 2% (243 942 672 bytes => 249 748 052 bytes) in debug mode.

Is such increase bearable? Would anybody approve that?

[xazax.hun]

I might be confused, but as far as I remember, when you do static linking, symbols tend to be linked in lazily. So as long as you do not use the matchers, those numbers might be misleading.

[NoQ]

In D25429#565939, @xazax.hun wrote:

I might be confused, but as far as I remember, when you do static linking, symbols tend to be linked in lazily. So as long as you do not use the matchers, those numbers might be misleading.

Yep, i did actually obtain these numbers by using matchers in one of the checkers.

[xazax.hun]

In D25429#565940, @NoQ wrote:

In D25429#565939, @xazax.hun wrote:

I might be confused, but as far as I remember, when you do static linking, symbols tend to be linked in lazily. So as long as you do not use the matchers, those numbers might be misleading.

Yep, i did actually obtain these numbers by using matchers in one of the checkers.

Great! I am in favour of this change. I wonder, however, if it is worth to ask this on the mailing list as well.

[alexfh]

The change seems to be reasonable, and the size increase is not huge. However, I'm not sure who should make the call.

[zaks.anna]

I am in support of this as well.

lib/StaticAnalyzer/Checkers/CMakeLists.txt

add_clang_library(clangStaticAnalyzerCheckers
   ValistChecker.cpp
   VirtualCallChecker.cpp
 
   DEPENDS
   ClangSACheckers
 
   LINK_LIBS
   clangAST
+  clangASTMatchers
   clangAnalysis
   clangBasic
   clangLex
   clangStaticAnalyzerCore
   )